142162 2015-03-02 05:23:19 -0800 [WinCairo] Crash in DefaultPolicyDelegate::decidePolicyForNavigationAction. 2015-03-02 13:12:30 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham ossy oldest_to_newest 1073283 0 peavo 2015-03-02 05:23:19 -0800 I have had some crashes lately, where the IWebView parameter was NULL, causing an access violoation. 1073284 1 247660 peavo 2015-03-02 05:28:42 -0800 Created attachment 247660 Patch 1073313 2 247660 andersca 2015-03-02 08:11:56 -0800 Comment on attachment 247660 Patch Delegate callbacks should never be called with a null web view. I think you should try to figure out why it is null instead of adding a null-check. 1073358 3 peavo 2015-03-02 10:02:10 -0800 (In reply to comment #2) > Comment on attachment 247660 [details] > Patch > > Delegate callbacks should never be called with a null web view. I think you > should try to figure out why it is null instead of adding a null-check. Ok, thanks for reviewing :) I will investigate why it happens. 1073364 4 247660 bfulgham 2015-03-02 10:18:33 -0800 Comment on attachment 247660 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247660&action=review > Source/WebKit/win/DefaultPolicyDelegate.cpp:106 > + Even though Anders doesn't like this check and return, it definitely seems like we should ASSERT here (or maybe even RELEASE_ASSERT?) so we can catch when this happens. 1073427 5 peavo 2015-03-02 13:12:30 -0800 (In reply to comment #4) > Comment on attachment 247660 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247660&action=review > > > Source/WebKit/win/DefaultPolicyDelegate.cpp:106 > > + > > Even though Anders doesn't like this check and return, it definitely seems > like we should ASSERT here (or maybe even RELEASE_ASSERT?) so we can catch > when this happens. Thanks :) I will add the ASSERT, and see if I can find the cause. 247660 2015-03-02 05:28:42 -0800 2015-03-02 08:11:56 -0800 Patch bug-142162-20150302142819.patch text/plain 1414 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDg4MikKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTAy ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5D YWlyb10gQ3Jhc2ggaW4gRGVmYXVsdFBvbGljeURlbGVnYXRlOjpkZWNpZGVQb2xpY3lGb3JOYXZp Z2F0aW9uQWN0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQyMTYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgbnVsbCBwb2ludGVyIGNoZWNrLgorCisgICAgICAgICogRGVmYXVsdFBvbGlj eURlbGVnYXRlLmNwcDoKKyAgICAgICAgKERlZmF1bHRQb2xpY3lEZWxlZ2F0ZTo6ZGVjaWRlUG9s aWN5Rm9yTmF2aWdhdGlvbkFjdGlvbik6CisKIDIwMTUtMDMtMDEgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIE5vdGlmaWNhdGlvbkNlbnRlciAvIE5vdGlm aWNhdGlvbiBzdXNwZW5kYWJsZQpJbmRleDogU291cmNlL1dlYktpdC93aW4vRGVmYXVsdFBvbGlj eURlbGVnYXRlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9EZWZhdWx0UG9s aWN5RGVsZWdhdGUuY3BwCShyZXZpc2lvbiAxODA4ODIpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9E ZWZhdWx0UG9saWN5RGVsZWdhdGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDEsNiArMTAxLDkg QEAgVUxPTkcgU1RETUVUSE9EQ0FMTFRZUEUgRGVmYXVsdFBvbGljeURlbAogSFJFU1VMVCBEZWZh dWx0UG9saWN5RGVsZWdhdGU6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oSVdlYlZp ZXcqIHdlYlZpZXcsIElQcm9wZXJ0eUJhZyogYWN0aW9uSW5mb3JtYXRpb24sIAogICAgIElXZWJV UkxSZXF1ZXN0KiByZXF1ZXN0LCBJV2ViRnJhbWUqIC8qZnJhbWUqLywgSVdlYlBvbGljeURlY2lz aW9uTGlzdGVuZXIqIGxpc3RlbmVyKQogeworICAgIGlmICghd2ViVmlldykKKyAgICAgICAgcmV0 dXJuIEVfRkFJTDsKKwogICAgIGludCBuYXZUeXBlID0gMDsKICAgICBfdmFyaWFudF90IHZhcjsK ICAgICBpZiAoU1VDQ0VFREVEKGFjdGlvbkluZm9ybWF0aW9uLT5SZWFkKFdlYkFjdGlvbk5hdmln YXRpb25UeXBlS2V5LCAmdmFyLkdldFZBUklBTlQoKSwgbnVsbHB0cikpKSB7Cg==