142145 2015-03-01 07:43:51 -0800 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks 2015-03-01 12:10:08 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer ap commit-queue darin dbates ddkilzer jake.nielsen.webkit mrowe msaboff simon.fraser oldest_to_newest 1073151 0 ddkilzer 2015-03-01 07:43:51 -0800 When running iOS Simulator tests with --guard-malloc or --leaks, LayoutTestRelay is not passing through the appropriate environment variables, so DumpRenderTree.app and WebKitTestRunner.app are not running with these environment variables set. 1073152 1 247630 ddkilzer 2015-03-01 07:48:14 -0800 Created attachment 247630 Patch v1 1073168 2 247630 ap 2015-03-01 10:56:57 -0800 Comment on attachment 247630 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=247630&action=review > Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:211 > + @"__XPC_DYLD_FRAMEWORK_PATH": productDirectory, Adding __XPC_ variants of DYLD_FRAMEWORK_PATH and DYLD_LIBRARY_PATH doesn't seem like part of this fix. What does it fix? 1073169 3 247630 commit-queue 2015-03-01 10:57:22 -0800 Comment on attachment 247630 Patch v1 Clearing flags on attachment: 247630 Committed r180864: <http://trac.webkit.org/changeset/180864> 1073170 4 commit-queue 2015-03-01 10:57:25 -0800 All reviewed patches have been landed. Closing bug. 1073174 5 247630 darin 2015-03-01 11:07:28 -0800 Comment on attachment 247630 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=247630&action=review > Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:225 > + environmentVariables = [dictionary copy]; Is this tool compiled with ARC? If not, we need a [dictionary release]. 1073176 6 ddkilzer 2015-03-01 11:39:34 -0800 (In reply to comment #2) > Comment on attachment 247630 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247630&action=review > > > Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:211 > > + @"__XPC_DYLD_FRAMEWORK_PATH": productDirectory, > > Adding __XPC_ variants of DYLD_FRAMEWORK_PATH and DYLD_LIBRARY_PATH doesn't > seem like part of this fix. What does it fix? It doesn't fix any known issue. It makes the environment for any XPC-launched process consistent with its parent. Is that bad? 1073177 7 ddkilzer 2015-03-01 11:41:40 -0800 (In reply to comment #5) > Comment on attachment 247630 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247630&action=review > > > Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:225 > > + environmentVariables = [dictionary copy]; > > Is this tool compiled with ARC? If not, we need a [dictionary release]. Yes, it's compiled with ARC. 1073178 8 ddkilzer 2015-03-01 11:49:56 -0800 (In reply to comment #3) > Comment on attachment 247630 [details] > Patch v1 > > Clearing flags on attachment: 247630 > > Committed r180864: <http://trac.webkit.org/changeset/180864> Fix think-o: Committed r180866: <http://trac.webkit.org/changeset/180866> 1073181 9 ap 2015-03-01 12:10:08 -0800 > It doesn't fix any known issue. It makes the environment for any XPC-launched process consistent with its parent. Is that bad? To me, it seems wrong to have code that does strange things with weird underscores and doesn't actually achieve anything. The functionality of __XPC environment variables is deeply suspect in general, and I expect that people will be looking at these lines in the future, trying to figure out if they can be removed or reimplemented. 247630 2015-03-01 07:48:14 -0800 2015-03-01 10:57:22 -0800 Patch v1 bug-142145-20150301074758.patch text/plain 2684 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWNjMGZjMzc3NDZkZDllY2RjZWEzMDlkNmQwZDY4YjI5 YTgwYThhMy4uODIyMDRjZjkwNjhkMjE0ZjhhNzNhMTc2YzE2OWU0ZTQ3NWViZGYzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTAzLTAxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgTGF5b3V0VGVzdFJlbGF5OiBBcHAgZW52aXJvbm1lbnQgdmFyaWFibGVzIG5vdCBzZXQg Zm9yIC0tZ3VhcmQtbWFsbG9jIG9yIC0tbGVha3MKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3Jn L2IvMTQyMTQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogTGF5b3V0VGVzdFJlbGF5L0xheW91dFRlc3RSZWxheS9MVFJlbGF5Q29udHJvbGxlci5t OgorICAgICAgICAoLVtMVFJlbGF5Q29udHJvbGxlciBfZW52aXJvbm1lbnRWYXJpYWJsZXNdKTog QWRkLgorICAgICAgICAoLVtMVFJlbGF5Q29udHJvbGxlciBsYXVuY2hBcHBdKTogVXNlIC1fZW52 aXJvbm1lbnRWYXJpYWJsZXMuCisKIDIwMTUtMDItMjggIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBTdG9wIHJ1bm5pbmcgd2Via2l0LWJ1aWxkLWRp cmVjdG9yeSBvbiBldmVyeSBsYXlvdXQgdGVzdApkaWZmIC0tZ2l0IGEvVG9vbHMvTGF5b3V0VGVz dFJlbGF5L0xheW91dFRlc3RSZWxheS9MVFJlbGF5Q29udHJvbGxlci5tIGIvVG9vbHMvTGF5b3V0 VGVzdFJlbGF5L0xheW91dFRlc3RSZWxheS9MVFJlbGF5Q29udHJvbGxlci5tCmluZGV4IGRjMGFk ZDVmMmZiNzhkMmE4MzZjZmVlYTM5YTQ1NGEwYTE3YjZiZGIuLjRkOGE5MzIwZmUyY2VhMGQ2ZWIx Y2FiOWVjODUyYWQ0OTUxOTU3MDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0xheW91dFRlc3RSZWxheS9M YXlvdXRUZXN0UmVsYXkvTFRSZWxheUNvbnRyb2xsZXIubQorKysgYi9Ub29scy9MYXlvdXRUZXN0 UmVsYXkvTGF5b3V0VGVzdFJlbGF5L0xUUmVsYXlDb250cm9sbGVyLm0KQEAgLTE5OCwxMyArMTk4 LDQwIEBAIC0gKHZvaWQpa2lsbEFwcAogICAgIFtzZWxmIHNldEFwcERpc3BhdGNoU291cmNlOm5p bF07CiB9CiAKKy0gKE5TRGljdGlvbmFyeSAqKV9lbnZpcm9ubWVudFZhcmlhYmxlcworeworICAg IHN0YXRpYyBOU0RpY3Rpb25hcnkgKmVudmlyb25tZW50VmFyaWFibGVzOworICAgIHN0YXRpYyBk aXNwYXRjaF9vbmNlX3Qgb25jZTsKKworICAgIGRpc3BhdGNoX29uY2UoJm9uY2UsIF57CisgICAg ICAgIE5TU3RyaW5nICpwcm9kdWN0RGlyZWN0b3J5ID0gW3NlbGYgcHJvZHVjdERpcl07CisKKyAg ICAgICAgTlNNdXRhYmxlRGljdGlvbmFyeSAqZGljdGlvbmFyeSA9IFtAeworICAgICAgICAgICAg QCJEWUxEX0ZSQU1FV09SS19QQVRIIjogcHJvZHVjdERpcmVjdG9yeSwKKyAgICAgICAgICAgIEAi X19YUENfRFlMRF9GUkFNRVdPUktfUEFUSCI6IHByb2R1Y3REaXJlY3RvcnksCisgICAgICAgICAg ICBAIkRZTERfTElCUkFSWV9QQVRIIjogcHJvZHVjdERpcmVjdG9yeSwKKyAgICAgICAgICAgIEAi X19YUENfRFlMRF9MSUJSQVJZX1BBVEgiOiBwcm9kdWN0RGlyZWN0b3J5LAorICAgICAgICB9IG11 dGFibGVDb3B5XTsKKworICAgICAgICBmb3IgKE5TU3RyaW5nICprZXlOYW1lIGluIEBbQCJEWUxE X0lOU0VSVF9MSUJSQVJJRVMiLCBAIk1hbGxvY1N0YWNrTG9nZ2luZyJdKSB7CisgICAgICAgICAg ICBjb25zdCBjaGFyKiB2YWx1ZSA9IGdldGVudihba2V5TmFtZSBVVEY4U3RyaW5nXSk7CisgICAg ICAgICAgICBpZiAodmFsdWUgJiYgc3RybGVuKHZhbHVlKSkgeworICAgICAgICAgICAgICAgIE5T U3RyaW5nICpuc1ZhbHVlID0gW05TU3RyaW5nIHN0cmluZ1dpdGhVVEY4U3RyaW5nOnZhbHVlXTsK KyAgICAgICAgICAgICAgICBbZGljdGlvbmFyeSBzZXRPYmplY3Q6bnNWYWx1ZSBmb3JLZXk6a2V5 TmFtZV07CisgICAgICAgICAgICAgICAgW2RpY3Rpb25hcnkgc2V0T2JqZWN0OltAIl9fWFBDXyIg c3RyaW5nQnlBcHBlbmRpbmdTdHJpbmc6bnNWYWx1ZV0gZm9yS2V5OmtleU5hbWVdOworICAgICAg ICAgICAgfQorICAgICAgICB9CisKKyAgICAgICAgZW52aXJvbm1lbnRWYXJpYWJsZXMgPSBbZGlj dGlvbmFyeSBjb3B5XTsKKyAgICB9KTsKKworICAgIHJldHVybiBlbnZpcm9ubWVudFZhcmlhYmxl czsKK30KKwogLSAodm9pZClsYXVuY2hBcHAKIHsKICAgICBOU0RpY3Rpb25hcnkgKmxhdW5jaE9w dGlvbnMgPSBAewotICAgICAgICBrU2ltRGV2aWNlTGF1bmNoQXBwbGljYXRpb25FbnZpcm9ubWVu dDogQHsKLSAgICAgICAgICAgIEAiRFlMRF9MSUJSQVJZX1BBVEgiOiBbc2VsZiBwcm9kdWN0RGly XSwKLSAgICAgICAgICAgIEAiRFlMRF9GUkFNRVdPUktfUEFUSCI6IFtzZWxmIHByb2R1Y3REaXJd LAotICAgICAgICB9LAorICAgICAgICBrU2ltRGV2aWNlTGF1bmNoQXBwbGljYXRpb25FbnZpcm9u bWVudDogW3NlbGYgX2Vudmlyb25tZW50VmFyaWFibGVzXSwKICAgICAgICAga1NpbURldmljZUxh dW5jaEFwcGxpY2F0aW9uQXJndW1lbnRzOiBbc2VsZiBkdW1wVG9vbEFyZ3VtZW50c10sCiAgICAg fTsKIAo=