142144 2015-03-01 07:21:50 -0800 [Cairo] Implement Path::addEllipse 2015-03-01 20:33:34 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong clopez commit-queue d-r gyuyoung.kim mrobinson ossy oldest_to_newest 1073146 0 hs85.jeong 2015-03-01 07:21:50 -0800 Add support for addEllipse method for platforms using cairo. 1073148 1 247628 hs85.jeong 2015-03-01 07:25:23 -0800 Created attachment 247628 Patch 1073149 2 hs85.jeong 2015-03-01 07:29:44 -0800 Pass the below tests after applying this patch on EFL, GTK+ port. fast/canvas/canvas-ellipse-360-winding.html [ Failure ] fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ] fast/canvas/canvas-ellipse.html [ Failure ] fast/canvas/canvas-ellipse-connecting-line.html [ ImageOnlyFailure ] 1073150 3 247629 hs85.jeong 2015-03-01 07:31:27 -0800 Created attachment 247629 Patch 1073217 4 gyuyoung.kim 2015-03-01 16:55:17 -0800 (In reply to comment #2) > Pass the below tests after applying this patch on EFL, GTK+ port. > fast/canvas/canvas-ellipse-360-winding.html [ Failure ] > fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ] > fast/canvas/canvas-ellipse.html [ Failure ] > fast/canvas/canvas-ellipse-connecting-line.html [ ImageOnlyFailure ] Please unskip the passing tests with this patch. 1073218 5 gyuyoung.kim 2015-03-01 16:55:38 -0800 CC'ing Martin. 1073219 6 247629 mrobinson 2015-03-01 17:00:16 -0800 Comment on attachment 247629 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247629&action=review > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:287 > +void Path::addEllipse(FloatPoint p, float radiusX, float radiusY, float rotation, float startAngle, float endAngle, bool anticlockwise) In WebKit we try to use full words for variable names, so p should be point, otherwise this looks good to me. 1073220 7 mrobinson 2015-03-01 17:00:40 -0800 (In reply to comment #4) > (In reply to comment #2) > > Pass the below tests after applying this patch on EFL, GTK+ port. > > fast/canvas/canvas-ellipse-360-winding.html [ Failure ] > > fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ] > > fast/canvas/canvas-ellipse.html [ Failure ] > > fast/canvas/canvas-ellipse-connecting-line.html [ ImageOnlyFailure ] > > Please unskip the passing tests with this patch. I definitely agree with Gyuyoung here. :) 1073223 8 hs85.jeong 2015-03-01 17:04:05 -0800 (In reply to comment #4) > (In reply to comment #2) > > Pass the below tests after applying this patch on EFL, GTK+ port. > > fast/canvas/canvas-ellipse-360-winding.html [ Failure ] > > fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ] > > fast/canvas/canvas-ellipse.html [ Failure ] > > fast/canvas/canvas-ellipse-connecting-line.html [ ImageOnlyFailure ] > > Please unskip the passing tests with this patch. That tests was added after 180790. Already failed on EFL bot. https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/20114/steps/layout-test/logs/stdio 1073225 9 gyuyoung.kim 2015-03-01 17:07:50 -0800 (In reply to comment #8) > (In reply to comment #4) > > (In reply to comment #2) > > > Pass the below tests after applying this patch on EFL, GTK+ port. > > > fast/canvas/canvas-ellipse-360-winding.html [ Failure ] > > > fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ] > > > fast/canvas/canvas-ellipse.html [ Failure ] > > > fast/canvas/canvas-ellipse-connecting-line.html [ ImageOnlyFailure ] > > > > Please unskip the passing tests with this patch. > > That tests was added after 180790. > > Already failed on EFL bot. > https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/ > builds/20114/steps/layout-test/logs/stdio Do you mean the tests aren't gardening yet both on EFL and GTK ports ? If so, please change the argument name. 1073226 10 247644 hs85.jeong 2015-03-01 17:08:54 -0800 Created attachment 247644 Patch 1073228 11 hs85.jeong 2015-03-01 17:22:35 -0800 (In reply to comment #10) > Created attachment 247644 [details] > Patch Yes, (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #4) > > > (In reply to comment #2) > > > > Pass the below tests after applying this patch on EFL, GTK+ port. > > > > fast/canvas/canvas-ellipse-360-winding.html [ Failure ] > > > > fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ] > > > > fast/canvas/canvas-ellipse.html [ Failure ] > > > > fast/canvas/canvas-ellipse-connecting-line.html [ ImageOnlyFailure ] > > > > > > Please unskip the passing tests with this patch. > > > > That tests was added after 180790. > > > > Already failed on EFL bot. > > https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/ > > builds/20114/steps/layout-test/logs/stdio > > Do you mean the tests aren't gardening yet both on EFL and GTK ports ? If > so, please change the argument name. Yes. You are right. I changed the argument name. 1073229 12 247644 gyuyoung.kim 2015-03-01 17:23:40 -0800 Comment on attachment 247644 Patch r+ed based on Martin's review. 1073249 13 247644 commit-queue 2015-03-01 20:33:28 -0800 Comment on attachment 247644 Patch Clearing flags on attachment: 247644 Committed r180881: <http://trac.webkit.org/changeset/180881> 1073250 14 commit-queue 2015-03-01 20:33:34 -0800 All reviewed patches have been landed. Closing bug. 247628 2015-03-01 07:25:23 -0800 2015-03-01 07:31:22 -0800 Patch bug-142144-20150302002507.patch text/plain 1709 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzcxMmFkMmVjMTExMzFm OTJiMWI0MDk2MjhiZTg3NzU4MjdmYzllMS4uNWZiNmYzOGIzNDM4ODcwNWRjMGZjNTkyZTZjMmIy Yzk2MzFmY2FkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTAxICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIElt cGxlbWVudCBQYXRoOjphZGRFbGxpcHNlIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGFkZEVsbGlwc2UgbWV0aG9kIGZvciBw bGF0Zm9ybXMgdXNpbmcgY2Fpcm8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWly by9QYXRoQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6YWRkRWxsaXBzZSk6CisK IDIwMTUtMDItMjggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgVmlld3BvcnQgdW5pdHMgc2hvdWxkIG5vdCBkaXJ0eSBzdHlsZSBqdXN0IGJlZm9yZSB3 ZSBkbyBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL1BhdGhDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9QYXRoQ2Fpcm8uY3BwCmluZGV4IDEyZTkwN2MyYjZkN2UxMjY5MDFmZjQ5ZTViOGVkMTkz M2QwMjA5OTIuLmY2ZjQ2YWIzNjVjMzA2ZDM3NWZhMmQzOGNlNTkwMTU3NmQzMTZmZjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BhdGhDYWlyby5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJv LmNwcApAQCAtMjg2LDcgKzI4NiwxOCBAQCB2b2lkIFBhdGg6OmFkZEFyY1RvKGNvbnN0IEZsb2F0 UG9pbnQmIHAxLCBjb25zdCBGbG9hdFBvaW50JiBwMiwgZmxvYXQgcmFkaXVzKQogCiB2b2lkIFBh dGg6OmFkZEVsbGlwc2UoRmxvYXRQb2ludCwgZmxvYXQsIGZsb2F0LCBmbG9hdCwgZmxvYXQsIGZs b2F0LCBib29sKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgY2Fpcm9fdCogY3IgPSBl bnN1cmVQbGF0Zm9ybVBhdGgoKS0+Y29udGV4dCgpOworICAgIGNhaXJvX3NhdmUoY3IpOworICAg IGNhaXJvX3RyYW5zbGF0ZShjciwgcC54KCksIHAueSgpKTsKKyAgICBjYWlyb19yb3RhdGUoY3Is IHJvdGF0aW9uKTsKKyAgICBjYWlyb19zY2FsZShjciwgcmFkaXVzWCwgcmFkaXVzWSk7CisKKyAg ICBpZiAoYW50aWNsb2Nrd2lzZSkKKyAgICAgICAgY2Fpcm9fYXJjX25lZ2F0aXZlKGNyLCAwLCAw LCAxLCBzdGFydEFuZ2xlLCBlbmRBbmdsZSk7CisgICAgZWxzZQorICAgICAgICBjYWlyb19hcmMo Y3IsIDAsIDAsIDEsIHN0YXJ0QW5nbGUsIGVuZEFuZ2xlKTsKKworICAgIGNhaXJvX3Jlc3RvcmUo Y3IpOwogfQogCiB2b2lkIFBhdGg6OmFkZEVsbGlwc2UoY29uc3QgRmxvYXRSZWN0JiByZWN0KQo= 247629 2015-03-01 07:31:27 -0800 2015-03-01 17:08:46 -0800 Patch bug-142144-20150302003110.patch text/plain 1896 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzcxMmFkMmVjMTExMzFm OTJiMWI0MDk2MjhiZTg3NzU4MjdmYzllMS4uNWZiNmYzOGIzNDM4ODcwNWRjMGZjNTkyZTZjMmIy Yzk2MzFmY2FkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTAxICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIElt cGxlbWVudCBQYXRoOjphZGRFbGxpcHNlIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGFkZEVsbGlwc2UgbWV0aG9kIGZvciBw bGF0Zm9ybXMgdXNpbmcgY2Fpcm8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWly by9QYXRoQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6YWRkRWxsaXBzZSk6CisK IDIwMTUtMDItMjggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgVmlld3BvcnQgdW5pdHMgc2hvdWxkIG5vdCBkaXJ0eSBzdHlsZSBqdXN0IGJlZm9yZSB3 ZSBkbyBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL1BhdGhDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9QYXRoQ2Fpcm8uY3BwCmluZGV4IDEyZTkwN2MyYjZkN2UxMjY5MDFmZjQ5ZTViOGVkMTkz M2QwMjA5OTIuLmRhYTY3MWZmM2M5MGYxMDUxMWFhYjdmODA0MGIwYWFlYmVmMmRjNGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BhdGhDYWlyby5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJv LmNwcApAQCAtMjg0LDkgKzI4NCwyMCBAQCB2b2lkIFBhdGg6OmFkZEFyY1RvKGNvbnN0IEZsb2F0 UG9pbnQmIHAxLCBjb25zdCBGbG9hdFBvaW50JiBwMiwgZmxvYXQgcmFkaXVzKQogICAgIGFkZEFy YyhwLCByYWRpdXMsIHNhLCBlYSwgYW50aWNsb2Nrd2lzZSk7CiB9CiAKLXZvaWQgUGF0aDo6YWRk RWxsaXBzZShGbG9hdFBvaW50LCBmbG9hdCwgZmxvYXQsIGZsb2F0LCBmbG9hdCwgZmxvYXQsIGJv b2wpCit2b2lkIFBhdGg6OmFkZEVsbGlwc2UoRmxvYXRQb2ludCBwLCBmbG9hdCByYWRpdXNYLCBm bG9hdCByYWRpdXNZLCBmbG9hdCByb3RhdGlvbiwgZmxvYXQgc3RhcnRBbmdsZSwgZmxvYXQgZW5k QW5nbGUsIGJvb2wgYW50aWNsb2Nrd2lzZSkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IGNhaXJvX3QqIGNyID0gZW5zdXJlUGxhdGZvcm1QYXRoKCktPmNvbnRleHQoKTsKKyAgICBjYWly b19zYXZlKGNyKTsKKyAgICBjYWlyb190cmFuc2xhdGUoY3IsIHAueCgpLCBwLnkoKSk7CisgICAg Y2Fpcm9fcm90YXRlKGNyLCByb3RhdGlvbik7CisgICAgY2Fpcm9fc2NhbGUoY3IsIHJhZGl1c1gs IHJhZGl1c1kpOworCisgICAgaWYgKGFudGljbG9ja3dpc2UpCisgICAgICAgIGNhaXJvX2FyY19u ZWdhdGl2ZShjciwgMCwgMCwgMSwgc3RhcnRBbmdsZSwgZW5kQW5nbGUpOworICAgIGVsc2UKKyAg ICAgICAgY2Fpcm9fYXJjKGNyLCAwLCAwLCAxLCBzdGFydEFuZ2xlLCBlbmRBbmdsZSk7CisKKyAg ICBjYWlyb19yZXN0b3JlKGNyKTsKIH0KIAogdm9pZCBQYXRoOjphZGRFbGxpcHNlKGNvbnN0IEZs b2F0UmVjdCYgcmVjdCkK 247644 2015-03-01 17:08:54 -0800 2015-03-01 20:33:28 -0800 Patch bug-142144-20150302100822.patch text/plain 1889 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVkMGQwYjRiMTY3N2Yw MTEzYmVjYmQxMWQ1M2E1ZTNiNzU0Mjc2Ni4uNDc0Y2IyZDZhMjVlOTRhYmQxM2MzOWFhNjg2ZWY2 ZDI0MTJkMjFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTAxICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIElt cGxlbWVudCBQYXRoOjphZGRFbGxpcHNlIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGFkZEVsbGlwc2UgbWV0aG9kIGZvciBw bGF0Zm9ybXMgdXNpbmcgY2Fpcm8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWly by9QYXRoQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6YWRkRWxsaXBzZSk6CisK IDIwMTUtMDMtMDEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBN YWtlIE5vdGlmaWNhdGlvbkNlbnRlciAvIE5vdGlmaWNhdGlvbiBzdXNwZW5kYWJsZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BhdGhDYWlyby5jcHAK aW5kZXggMTJlOTA3YzJiNmQ3ZTEyNjkwMWZmNDllNWI4ZWQxOTMzZDAyMDk5Mi4uZGVkMjNlMzNh ZDFlZjZhOTE3NDc4ZGI1NWE2YmEyYzczNjk5Zjc0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwCkBAIC0yODQsOSArMjg0 LDIwIEBAIHZvaWQgUGF0aDo6YWRkQXJjVG8oY29uc3QgRmxvYXRQb2ludCYgcDEsIGNvbnN0IEZs b2F0UG9pbnQmIHAyLCBmbG9hdCByYWRpdXMpCiAgICAgYWRkQXJjKHAsIHJhZGl1cywgc2EsIGVh LCBhbnRpY2xvY2t3aXNlKTsKIH0KIAotdm9pZCBQYXRoOjphZGRFbGxpcHNlKEZsb2F0UG9pbnQs IGZsb2F0LCBmbG9hdCwgZmxvYXQsIGZsb2F0LCBmbG9hdCwgYm9vbCkKK3ZvaWQgUGF0aDo6YWRk RWxsaXBzZShGbG9hdFBvaW50IHBvaW50LCBmbG9hdCByYWRpdXNYLCBmbG9hdCByYWRpdXNZLCBm bG9hdCByb3RhdGlvbiwgZmxvYXQgc3RhcnRBbmdsZSwgZmxvYXQgZW5kQW5nbGUsIGJvb2wgYW50 aWNsb2Nrd2lzZSkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGNhaXJvX3QqIGNyID0g ZW5zdXJlUGxhdGZvcm1QYXRoKCktPmNvbnRleHQoKTsKKyAgICBjYWlyb19zYXZlKGNyKTsKKyAg ICBjYWlyb190cmFuc2xhdGUoY3IsIHBvaW50LngoKSwgcG9pbnQueSgpKTsKKyAgICBjYWlyb19y b3RhdGUoY3IsIHJvdGF0aW9uKTsKKyAgICBjYWlyb19zY2FsZShjciwgcmFkaXVzWCwgcmFkaXVz WSk7CisKKyAgICBpZiAoYW50aWNsb2Nrd2lzZSkKKyAgICAgICAgY2Fpcm9fYXJjX25lZ2F0aXZl KGNyLCAwLCAwLCAxLCBzdGFydEFuZ2xlLCBlbmRBbmdsZSk7CisgICAgZWxzZQorICAgICAgICBj YWlyb19hcmMoY3IsIDAsIDAsIDEsIHN0YXJ0QW5nbGUsIGVuZEFuZ2xlKTsKKworICAgIGNhaXJv X3Jlc3RvcmUoY3IpOwogfQogCiB2b2lkIFBhdGg6OmFkZEVsbGlwc2UoY29uc3QgRmxvYXRSZWN0 JiByZWN0KQo=