142140 2015-02-28 16:33:59 -0800 Document::recalcStyle() shouldn't call viewportContentsChanged() if there is a pending layout 2015-03-05 20:38:48 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser cdumez cdumez commit-queue esprehn+autocc kangil.han simon.fraser oldest_to_newest 1073111 0 simon.fraser 2015-02-28 16:33:59 -0800 It's wasteful for viewportContentsChanged() to be called from recalcStyle() if a layout is pending, because that's going to move things around, and then we'll call viewportContentsChanged() again. 1073113 1 simon.fraser 2015-02-28 16:34:58 -0800 It's actually positively bad, because resumePausedImageAnimationsIfNeeded() does repaints which assume the render tree is in a valid state. 1074152 2 cdumez 2015-03-04 11:50:55 -0800 I am busy with other things right now but I'll try to get to it asap. If someone else want to volunteer to make the change before then, feel free to reassign though. 1074195 3 247887 cdumez 2015-03-04 13:18:42 -0800 Created attachment 247887 Patch 1074822 4 247887 commit-queue 2015-03-05 20:38:42 -0800 Comment on attachment 247887 Patch Clearing flags on attachment: 247887 Committed r181133: <http://trac.webkit.org/changeset/181133> 1074823 5 commit-queue 2015-03-05 20:38:48 -0800 All reviewed patches have been landed. Closing bug. 247887 2015-03-04 13:18:42 -0800 2015-03-05 20:38:42 -0800 Patch bug-142140-20150304131823.patch text/plain 2377 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwOTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMxZTIyOGM2ZTY1YTI0 MjEwYzg3MWIyMTE4YTgyYThiZTJhNmE3ZS4uMzQxNjhkM2QxZDI5ZWE5YmFkMGY3YjE4NGIzNGU1 OWZiZTBiZTFiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTAzLTA0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRG9jdW1lbnQ6OnJlY2FsY1N0 eWxlKCkgc2hvdWxkbid0IGNhbGwgdmlld3BvcnRDb250ZW50c0NoYW5nZWQoKSBpZiB0aGVyZSBp cyBhIHBlbmRpbmcgbGF5b3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDIxNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTdG9wIGNhbGxpbmcgRnJhbWVWaWV3Ojp2aWV3cG9ydENvbnRlbnRzQ2hhbmdl ZCgpIGluIERvY3VtZW50OjpyZWNhbGNTdHlsZSgpCisgICAgICAgIGlmIHRoZXJlIGlzIGEgbGF5 b3V0IHBlbmRpbmcgdG8gYXZvaWQgZG9pbmcgdW5uY2Vzc2FyeSB3b3JrLiBJZiB0aGVyZSBpcyBh CisgICAgICAgIGxheW91dCBwZW5kaW5nLCB3ZSBkb24ndCBuZWVkIHRvIGRvIGFueXRoaW5nIGJl Y2F1c2Ugdmlld3BvcnRDb250ZW50c0NoYW5nZWQoKQorICAgICAgICB3aWxsIGJlIGNhbGxlZCBh ZnRlciBsYXlvdXQuCisKKyAgICAgICAgV2Ugb25seSBuZWVkIHRvIGNhbGwgRnJhbWVWaWV3Ojp2 aWV3cG9ydENvbnRlbnRzQ2hhbmdlZCgpIGluCisgICAgICAgIERvY3VtZW50OjpyZWNhbGNTdHls ZSgpIGlmIGEgc3R5bGUgcmVjYWxjIGRvZXMgbm90IGNhdXNlIGEgbGF5b3V0LiBGb3IgZS5nLgor ICAgICAgICBhICctd2Via2l0LXRyYW5zZm9ybScgY291bGQgbWFrZSBhbiBhbmltYXRlZCBHSUYg dmlzaWJsZSB3aXRob3V0IGNhdXNpbmcgYQorICAgICAgICBsYXlvdXQsIGluIHdoaWNoIGNhc2Ug d2UgbmVlZCB0byByZXN1bWUgdGhlIGFuaW1hdGVkIEdJRiBhZnRlciBzdHlsZSByZWNhbGMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5IGNvdmVyZWQgYnk6CisgICAgICAgIGZhc3Qv aW1hZ2VzL2FuaW1hdGVkLWdpZi13ZWJraXQtdHJhbnNmb3JtLmh0bWwKKworICAgICAgICAqIGRv bS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6cmVjYWxjU3R5bGUp OgorCiAyMDE1LTAzLTAzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTgwNjgzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKaW5kZXggYmFkZTI0OTU2Y2QzMzUzOGVmMTBjMjcwNzUyZWI3MjUyNDczYmI1MC4u ODM2ZjVkZjQyMGNkYmZiYmY0ODZhZTk3MzY5YTIyZGM5YzM4M2U4NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCkBAIC0xNzkwLDggKzE3OTAsMTAgQEAgdm9pZCBEb2N1bWVudDo6cmVjYWxjU3R5 bGUoU3R5bGU6OkNoYW5nZSBjaGFuZ2UpCiAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpk aWRSZWNhbGN1bGF0ZVN0eWxlKGNvb2tpZSk7CiAKICAgICAvLyBTb21lIGFuaW1hdGVkIGltYWdl cyBtYXkgbm93IGJlIGluc2lkZSB0aGUgdmlld3BvcnQgZHVlIHRvIHN0eWxlIHJlY2FsYywKLSAg ICAvLyByZXN1bWUgdGhlbSBpZiBuZWNlc3NhcnkuCi0gICAgZnJhbWVWaWV3LnZpZXdwb3J0Q29u dGVudHNDaGFuZ2VkKCk7CisgICAgLy8gcmVzdW1lIHRoZW0gaWYgbmVjZXNzYXJ5IGlmIHRoZXJl IGlzIG5vIGxheW91dCBwZW5kaW5nLiBPdGhlcndpc2UsIHdlJ2xsCisgICAgLy8gY2hlY2sgaWYg dGhleSBuZWVkIHRvIGJlIHJlc3VtZWQgYWZ0ZXIgbGF5b3V0LgorICAgIGlmICghZnJhbWVWaWV3 Lm5lZWRzTGF5b3V0KCkpCisgICAgICAgIGZyYW1lVmlldy52aWV3cG9ydENvbnRlbnRzQ2hhbmdl ZCgpOwogCiAgICAgLy8gQXMgYSByZXN1bHQgb2YgdGhlIHN0eWxlIHJlY2FsY3VsYXRpb24sIHRo ZSBjdXJyZW50bHkgaG92ZXJlZCBlbGVtZW50IG1pZ2h0IGhhdmUgYmVlbgogICAgIC8vIGRldGFj aGVkIChmb3IgZXhhbXBsZSwgYnkgc2V0dGluZyBkaXNwbGF5Om5vbmUgaW4gdGhlIDpob3ZlciBz dHlsZSksIHNjaGVkdWxlIGFub3RoZXIgbW91c2VNb3ZlIGV2ZW50Cg==