142137 2015-02-28 14:12:40 -0800 WebsiteDataStore should handle fetching and deleting local storage data 2015-02-28 14:20:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1073084 0 andersca 2015-02-28 14:12:40 -0800 WebsiteDataStore should handle fetching and deleting local storage data 1073086 1 247614 andersca 2015-02-28 14:14:02 -0800 Created attachment 247614 Patch 1073087 2 commit-queue 2015-02-28 14:15:48 -0800 Attachment 247614 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:593: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1073090 3 andersca 2015-02-28 14:20:36 -0800 Committed r180842: <http://trac.webkit.org/changeset/180842> 247614 2015-02-28 14:14:02 -0800 2015-02-28 14:15:44 -0800 Patch bug-142137-20150228141347.patch text/plain 6622 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmY2YTg1OGRkNTVhMzhi ZGI2MGJlZjE1MjY2NWQ5NWZhNTQ1YTk2MC4uNDMzMGNhYzc0ZjE1MDU3OWZiOWI4MDkxYjY1YjEy MzJjOWMwMjQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE1LTAyLTI4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgV2Vic2l0ZURhdGFT dG9yZSBzaG91bGQgaGFuZGxlIGZldGNoaW5nIGFuZCBkZWxldGluZyBsb2NhbCBzdG9yYWdlIGRh dGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjEz NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpTdG9y YWdlTWFuYWdlcjo6ZGVsZXRlRW50cmllc0Zvck9yaWdpbnMpOgorICAgICAgICBBZGQgYSBuZXcg ZnVuY3Rpb24gdGhhdCBkZWxldGVzIGVudHJpZXMgZnJvbSBtdWx0aXBsZSBvcmlnaW5zLgorCisg ICAgICAgICogVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuaDoKKyAgICAgICAgQWRk IG5ldyBtZW1iZXJzLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVE YXRhU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpmZXRjaERh dGEpOgorICAgICAgICBGZXRjaCBsb2NhbCBzdG9yYWdlIGRhdGEgYXMgd2VsbC4KKworICAgICAg ICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpyZW1vdmVEYXRhKToKKyAgICAgICAgRGVsZXRl IGxvY2FsIHN0b3JhZ2UgZGF0YSBhcyB3ZWxsLgorCisyMDE1LTAyLTI4ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgRmV0Y2ggY2FjaGUgb3JpZ2lucyBm cm9tIHRoZSBuZXR3b3JrIHByb2Nlc3MKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0MjEzNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAKaW5kZXggODkyNDdkMjk3YmQyM2RmOTEwOTYz NzM1NTQ5MzUzNDUwMDVkNjgxNi4uMGI5YWM2NGJhNzZhYjQ3YjU0NDBiZDk0YTE3OWQ4MGNkNWI3 ODZiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFn ZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3Jh Z2VNYW5hZ2VyLmNwcApAQCAtNTkwLDYgKzU5MCwzMCBAQCB2b2lkIFN0b3JhZ2VNYW5hZ2VyOjpk ZWxldGVMb2NhbFN0b3JhZ2VPcmlnaW5zTW9kaWZpZWRTaW5jZShzdGQ6OmNocm9ubzo6c3lzdGVt XwogICAgIH0pOwogfQogCit2b2lkIFN0b3JhZ2VNYW5hZ2VyOjpkZWxldGVFbnRyaWVzRm9yT3Jp Z2lucyhjb25zdCBWZWN0b3I8UmVmUHRyPFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luPj4mIG9yaWdp bnMsIHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4gY29tcGxldGlvbkhhbmRsZXIpCit7CisgICAgVmVj dG9yPFJlZlB0cjxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbj4+IGNvcGllZE9yaWdpbnM7CisgICAg Y29waWVkT3JpZ2lucy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KG9yaWdpbnMuc2l6ZSgpKTsKKwor ICAgIGZvciAoYXV0byYgb3JpZ2luIDogb3JpZ2lucykKKyAgICAgICAgY29waWVkT3JpZ2lucy51 bmNoZWNrZWRBcHBlbmQob3JpZ2luLT5pc29sYXRlZENvcHkoKSk7CisKKyAgICBSZWZQdHI8U3Rv cmFnZU1hbmFnZXI+IHN0b3JhZ2VNYW5hZ2VyKHRoaXMpOworICAgIG1fcXVldWUtPmRpc3BhdGNo KFtzdG9yYWdlTWFuYWdlciwgY29waWVkT3JpZ2lucywgY29tcGxldGlvbkhhbmRsZXJdIHsKKyAg ICAgICAgZm9yIChhdXRvJiBvcmlnaW4gOiBjb3BpZWRPcmlnaW5zKSB7CisgICAgICAgICAgICBm b3IgKGF1dG8mIGxvY2FsU3RvcmFnZU5hbWVzcGFjZSA6IHN0b3JhZ2VNYW5hZ2VyLT5tX2xvY2Fs U3RvcmFnZU5hbWVzcGFjZXMudmFsdWVzKCkpCisgICAgICAgICAgICAgICAgbG9jYWxTdG9yYWdl TmFtZXNwYWNlLT5jbGVhclN0b3JhZ2VBcmVhc01hdGNoaW5nT3JpZ2luKCpvcmlnaW4pOworCisg ICAgICAgICAgICBmb3IgKGF1dG8mIHRyYW5zaWVudExvY2FsU3RvcmFnZU5hbWVzcGFjZSA6IHN0 b3JhZ2VNYW5hZ2VyLT5tX3RyYW5zaWVudExvY2FsU3RvcmFnZU5hbWVzcGFjZXMudmFsdWVzKCkp CisgICAgICAgICAgICAgICAgdHJhbnNpZW50TG9jYWxTdG9yYWdlTmFtZXNwYWNlLT5jbGVhclN0 b3JhZ2VBcmVhc01hdGNoaW5nT3JpZ2luKCpvcmlnaW4pOworCisgICAgICAgICAgICBzdG9yYWdl TWFuYWdlci0+bV9sb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXItPmRlbGV0ZURhdGFiYXNlV2l0 aE9yaWdpbihvcmlnaW4uZ2V0KCkpOworICAgICAgICB9CisKKyAgICAgICAgUnVuTG9vcDo6bWFp bigpLmRpc3BhdGNoKGNvbXBsZXRpb25IYW5kbGVyKTsKKyAgICB9KTsKK30KKwogdm9pZCBTdG9y YWdlTWFuYWdlcjo6Y3JlYXRlTG9jYWxTdG9yYWdlTWFwKElQQzo6Q29ubmVjdGlvbiYgY29ubmVj dGlvbiwgdWludDY0X3Qgc3RvcmFnZU1hcElELCB1aW50NjRfdCBzdG9yYWdlTmFtZXNwYWNlSUQs IGNvbnN0IFNlY3VyaXR5T3JpZ2luRGF0YSYgc2VjdXJpdHlPcmlnaW5EYXRhKQogewogICAgIHN0 ZDo6cGFpcjxSZWZQdHI8SVBDOjpDb25uZWN0aW9uPiwgdWludDY0X3Q+IGNvbm5lY3Rpb25BbmRT dG9yYWdlTWFwSURQYWlyKCZjb25uZWN0aW9uLCBzdG9yYWdlTWFwSUQpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmgKaW5kZXggYjFmNTJk MGZlZGEzNDgxZGQ3YTlhMzhiMDNhY2M4YzA2OGIzODFlMC4uODQ1NGNjZmFlMTY5MjA4NTk5ZmYw YTYzOWIzMGQzYWI3ZmJjYmVmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv U3RvcmFnZS9TdG9yYWdlTWFuYWdlci5oCkBAIC02Myw2ICs2Myw3IEBAIHB1YmxpYzoKICAgICB2 b2lkIGRlbGV0ZUFsbEVudHJpZXMoKTsKIAogICAgIHZvaWQgZGVsZXRlTG9jYWxTdG9yYWdlT3Jp Z2luc01vZGlmaWVkU2luY2Uoc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCwg c3RkOjpmdW5jdGlvbjx2b2lkICgpPiBjb21wbGV0aW9uSGFuZGxlcik7CisgICAgdm9pZCBkZWxl dGVFbnRyaWVzRm9yT3JpZ2lucyhjb25zdCBWZWN0b3I8UmVmUHRyPFdlYkNvcmU6OlNlY3VyaXR5 T3JpZ2luPj4mLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGNvbXBsZXRpb25IYW5kbGVyKTsKIAog cHJpdmF0ZToKICAgICBleHBsaWNpdCBTdG9yYWdlTWFuYWdlcihjb25zdCBTdHJpbmcmIGxvY2Fs U3RvcmFnZURpcmVjdG9yeSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKaW5kZXggNGYyYjE3ODQ2ZTY5MzU4 NDMyOTQ2YWFiNzgwNjVlYjBiMjg5MjYyYS4uZmZkNDYxN2ZmNDZiOWVhMWQwNGU0MDgxMzBmMGEz YTEwZTZkYjFiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYnNpdGVE YXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcApAQCAtMjQ2LDYgKzI0NiwxOCBAQCB2b2lk IFdlYnNpdGVEYXRhU3RvcmU6OmZldGNoRGF0YShXZWJzaXRlRGF0YVR5cGVzIGRhdGFUeXBlcywg c3RkOjpmdW5jdGlvbjx2b2lkCiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiAoZGF0YVR5cGVz ICYgV2Vic2l0ZURhdGFUeXBlTG9jYWxTdG9yYWdlICYmIG1fc3RvcmFnZU1hbmFnZXIpIHsKKyAg ICAgICAgY2FsbGJhY2tBZ2dyZWdhdG9yLT5hZGRQZW5kaW5nQ2FsbGJhY2soKTsKKworICAgICAg ICBtX3N0b3JhZ2VNYW5hZ2VyLT5nZXRPcmlnaW5zKFtjYWxsYmFja0FnZ3JlZ2F0b3JdKFZlY3Rv cjxSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4+PiBvcmlnaW5zKSB7CisgICAgICAgICAg ICBXZWJzaXRlRGF0YSB3ZWJzaXRlRGF0YTsKKyAgICAgICAgICAgIGZvciAoYXV0byYgb3JpZ2lu IDogb3JpZ2lucykKKyAgICAgICAgICAgICAgICB3ZWJzaXRlRGF0YS5lbnRyaWVzLmFwcGVuZChX ZWJzaXRlRGF0YTo6RW50cnkgeyBXVEY6Om1vdmUob3JpZ2luKSwgV2Vic2l0ZURhdGFUeXBlTG9j YWxTdG9yYWdlIH0pOworCisgICAgICAgICAgICBjYWxsYmFja0FnZ3JlZ2F0b3ItPnJlbW92ZVBl bmRpbmdDYWxsYmFjayhXVEY6Om1vdmUod2Vic2l0ZURhdGEpKTsKKyAgICAgICAgfSk7CisgICAg fQorCiAgICAgY2FsbGJhY2tBZ2dyZWdhdG9yLT5jYWxsSWZOZWVkZWQoKTsKIH0KIApAQCAtMzc4 LDYgKzM5MCwxMyBAQCB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OnJlbW92ZURhdGEoV2Vic2l0ZURh dGFUeXBlcyBkYXRhVHlwZXMsIHN0ZDo6Y2hyb25vOjpzeXN0ZQogCiB2b2lkIFdlYnNpdGVEYXRh U3RvcmU6OnJlbW92ZURhdGEoV2Vic2l0ZURhdGFUeXBlcyBkYXRhVHlwZXMsIGNvbnN0IFZlY3Rv cjxXZWJzaXRlRGF0YVJlY29yZD4mIGRhdGFSZWNvcmRzLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+ IGNvbXBsZXRpb25IYW5kbGVyKQogeworICAgIFZlY3RvcjxSZWZQdHI8V2ViQ29yZTo6U2VjdXJp dHlPcmlnaW4+PiBvcmlnaW5zOworCisgICAgZm9yIChjb25zdCBhdXRvJiBkYXRhUmVjb3JkIDog ZGF0YVJlY29yZHMpIHsKKyAgICAgICAgZm9yIChhdXRvJiBvcmlnaW4gOiBkYXRhUmVjb3JkLm9y aWdpbnMpCisgICAgICAgICAgICBvcmlnaW5zLmFwcGVuZChvcmlnaW4pOworICAgIH0KKwogICAg IHN0cnVjdCBDYWxsYmFja0FnZ3JlZ2F0b3IgOiBwdWJsaWMgUmVmQ291bnRlZDxDYWxsYmFja0Fn Z3JlZ2F0b3I+IHsKICAgICAgICAgZXhwbGljaXQgQ2FsbGJhY2tBZ2dyZWdhdG9yIChzdGQ6OmZ1 bmN0aW9uPHZvaWQgKCk+IGNvbXBsZXRpb25IYW5kbGVyKQogICAgICAgICAgICAgOiBjb21wbGV0 aW9uSGFuZGxlcihXVEY6Om1vdmUoY29tcGxldGlvbkhhbmRsZXIpKQpAQCAtNDI4LDEyICs0NDcs NiBAQCB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OnJlbW92ZURhdGEoV2Vic2l0ZURhdGFUeXBlcyBk YXRhVHlwZXMsIGNvbnN0IFZlY3RvcjxXZWJzaQogICAgICAgICAgICAgfQogCiAgICAgICAgICAg ICBjYWxsYmFja0FnZ3JlZ2F0b3ItPmFkZFBlbmRpbmdDYWxsYmFjaygpOwotICAgICAgICAgICAg VmVjdG9yPFJlZlB0cjxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbj4+IG9yaWdpbnM7Ci0KLSAgICAg ICAgICAgIGZvciAoY29uc3QgYXV0byYgZGF0YVJlY29yZCA6IGRhdGFSZWNvcmRzKSB7Ci0gICAg ICAgICAgICAgICAgZm9yIChhdXRvJiBvcmlnaW4gOiBkYXRhUmVjb3JkLm9yaWdpbnMpCi0gICAg ICAgICAgICAgICAgICAgIG9yaWdpbnMuYXBwZW5kKG9yaWdpbik7Ci0gICAgICAgICAgICB9CiAK ICAgICAgICAgICAgIHByb2Nlc3MtPmRlbGV0ZVdlYnNpdGVEYXRhRm9yT3JpZ2lucyhtX3Nlc3Np b25JRCwgZGF0YVR5cGVzLCBvcmlnaW5zLCBbY2FsbGJhY2tBZ2dyZWdhdG9yXSB7CiAgICAgICAg ICAgICAgICAgY2FsbGJhY2tBZ2dyZWdhdG9yLT5yZW1vdmVQZW5kaW5nQ2FsbGJhY2soKTsKQEAg LTQ0MSw2ICs0NTQsMTQgQEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpyZW1vdmVEYXRhKFdlYnNp dGVEYXRhVHlwZXMgZGF0YVR5cGVzLCBjb25zdCBWZWN0b3I8V2Vic2kKICAgICAgICAgfQogICAg IH0KIAorICAgIGlmIChkYXRhVHlwZXMgJiBXZWJzaXRlRGF0YVR5cGVMb2NhbFN0b3JhZ2UgJiYg bV9zdG9yYWdlTWFuYWdlcikgeworICAgICAgICBjYWxsYmFja0FnZ3JlZ2F0b3ItPmFkZFBlbmRp bmdDYWxsYmFjaygpOworCisgICAgICAgIG1fc3RvcmFnZU1hbmFnZXItPmRlbGV0ZUVudHJpZXNG b3JPcmlnaW5zKG9yaWdpbnMsIFtjYWxsYmFja0FnZ3JlZ2F0b3JdIHsKKyAgICAgICAgICAgIGNh bGxiYWNrQWdncmVnYXRvci0+cmVtb3ZlUGVuZGluZ0NhbGxiYWNrKCk7CisgICAgICAgIH0pOwor ICAgIH0KKwogICAgIC8vIFRoZXJlJ3MgYSBjaGFuY2UgdGhhdCB3ZSBkb24ndCBoYXZlIGFueSBw ZW5kaW5nIGNhbGxiYWNrcy4gSWYgc28sIHdlIHdhbnQgdG8gZGlzcGF0Y2ggdGhlIGNvbXBsZXRp b24gaGFuZGxlciByaWdodCBhd2F5LgogICAgIGNhbGxiYWNrQWdncmVnYXRvci0+Y2FsbElmTmVl ZGVkKCk7CiB9Cg==