142127 2015-02-27 21:50:47 -0800 [EFL][GTK] Fix build break after r180790,180798 2015-02-27 23:26:34 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82791 142109 1 hs85.jeong hs85.jeong commit-queue dino d-r gyuyoung.kim krit lucas.de.marchi ossy sam thorton oldest_to_newest 1072983 0 hs85.jeong 2015-02-27 21:50:47 -0800 CanvasPathMethods.cpp:(.text._ZN7WebCore17CanvasPathMethods7ellipseEfffffffbRi+0x306): undefined reference to `WebCore::Path::addEllipse(WebCore::FloatPoint, float, float, float, float, float, bool)' collect2: error: ld returned 1 exit status 1072984 1 hs85.jeong 2015-02-27 21:54:24 -0800 Need to implement the "addEllipse(FloatPoint, float radiusX, float radiusY, float rotation, float startAngle, float endAngle, bool anticlockwise);" in PathCairo. 1072991 2 247590 hs85.jeong 2015-02-27 22:26:35 -0800 Created attachment 247590 HotFix 1072992 3 hs85.jeong 2015-02-27 22:29:08 -0800 After this patch, another build break occurred : Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebFrame.cpp.o:WebFrame.cpp:function WebKit::WebFrame::jsWrapperForWorld(WebKit::InjectedBundleFileHandle*, WebKit::InjectedBundleScriptWorld*): error: undefined reference to 'WebKit::InjectedBundleFileHandle::coreFile()' collect2: error: ld returned 1 exit status 1072993 4 gyuyoung.kim 2015-02-27 22:33:49 -0800 (In reply to comment #3) > After this patch, another build break occurred : > > Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebFrame.cpp.o: > WebFrame.cpp:function > WebKit::WebFrame::jsWrapperForWorld(WebKit::InjectedBundleFileHandle*, > WebKit::InjectedBundleScriptWorld*): error: undefined reference to > 'WebKit::InjectedBundleFileHandle::coreFile()' > collect2: error: ld returned 1 exit status Please fix it as well. 1072995 5 247591 hs85.jeong 2015-02-27 22:37:41 -0800 Created attachment 247591 Patch 1072996 6 247591 gyuyoung.kim 2015-02-27 22:39:35 -0800 Comment on attachment 247591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247591&action=review > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:289 > + // FIXME: Need to implement the Path::addEllipse(). Looks like a redundant comment. "notImplement()" is enough. 1072997 7 247592 hs85.jeong 2015-02-27 22:41:46 -0800 Created attachment 247592 Patch 1073002 8 247592 ossy 2015-02-27 23:26:24 -0800 Comment on attachment 247592 Patch Clearing flags on attachment: 247592 Committed r180817: <http://trac.webkit.org/changeset/180817> 1073003 9 ossy 2015-02-27 23:26:34 -0800 All reviewed patches have been landed. Closing bug. 247590 2015-02-27 22:26:35 -0800 2015-02-27 22:37:35 -0800 HotFix bug-142127-20150228152620.patch text/plain 1436 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJiZjA2M2NjYzE4YTIy NDM5MDQ4MjAxZjhlNzBkNjNkMTUzOGU0My4uODZlZGIxZDRlYzZhN2NlN2I0OThkMWU2MTRkNzRj ODcyOWEwMzBlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAyLTI3ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtHVEtd IEZpeCBidWlsZCBicmVhayBhZnRlciByMTgwNzkwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIxMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BhdGhDYWly by5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjphZGRFbGxpcHNlKToKKwogMjAxNS0wMi0y NyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBOb2RlOjpoYXNF ZGl0YWJsZVN0eWxlIGFuZCBpc0VkaXRhYmxlUG9zaXRpb24gaGF2ZSB0b28gbWFueSBvcHRpb25z CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRo Q2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENh aXJvLmNwcAppbmRleCBiZjVjOTg1YzljZmUwNTgwZWM2ZjBmZmZhMDE3YjNmMDg4NDljNmMyLi41 MDNiMDFlZThlNGEyOTY2MTYzMjdiMDI0MzBkYjYyZTk2ODRmYjIyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BhdGhDYWlyby5jcHAKQEAgLTI4 NCw2ICsyODQsMTIgQEAgdm9pZCBQYXRoOjphZGRBcmNUbyhjb25zdCBGbG9hdFBvaW50JiBwMSwg Y29uc3QgRmxvYXRQb2ludCYgcDIsIGZsb2F0IHJhZGl1cykKICAgICBhZGRBcmMocCwgcmFkaXVz LCBzYSwgZWEsIGFudGljbG9ja3dpc2UpOwogfQogCit2b2lkIFBhdGg6OmFkZEVsbGlwc2UoRmxv YXRQb2ludCwgZmxvYXQsIGZsb2F0LCBmbG9hdCwgZmxvYXQsIGZsb2F0LCBib29sKQoreworICAg IC8vIEZJWE1FOiBOZWVkIHRvIGltcGxlbWVudCB0aGUgUGF0aDo6YWRkRWxsaXBzZSgpLgorICAg IG5vdEltcGxlbWVudGVkKCk7Cit9CisKIHZvaWQgUGF0aDo6YWRkRWxsaXBzZShjb25zdCBGbG9h dFJlY3QmIHJlY3QpCiB7CiAgICAgY2Fpcm9fdCogY3IgPSBlbnN1cmVQbGF0Zm9ybVBhdGgoKS0+ Y29udGV4dCgpOwo= 247591 2015-02-27 22:37:41 -0800 2015-02-27 22:41:40 -0800 Patch bug-142127-20150228153725.patch text/plain 2656 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJiZjA2M2NjYzE4YTIy NDM5MDQ4MjAxZjhlNzBkNjNkMTUzOGU0My4uOTUyMGQxMjE0YjUzZGZlN2RkZmM5NGU0MDU5ODBk NjUxNTIzN2Y3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAyLTI3ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtHVEtd IEZpeCBidWlsZCBicmVhayBhZnRlciByMTgwNzkwLDE4MDc5OAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMTI3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Q YXRoQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6YWRkRWxsaXBzZSk6CisKIDIw MTUtMDItMjcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTm9k ZTo6aGFzRWRpdGFibGVTdHlsZSBhbmQgaXNFZGl0YWJsZVBvc2l0aW9uIGhhdmUgdG9vIG1hbnkg b3B0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCmluZGV4IGZmZDBlN2Y0MWNmMTM4NTQwZTFkZDk1NTM0YjhhNTQ4Njk1 NDRmNmIuLjNkYTE0NWIzODNiOGFiMDhmM2U2N2I3M2MxODBlMzkwMjNmNmZhZjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0wMi0yNyAgSHVuc2VvcCBKZW9uZyAgPGhzODUuamVv bmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bR1RLXSBGaXggYnVpbGQgYnJlYWsgYWZ0 ZXIgcjE4MDc5MCwxODA3OTggCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDIxMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE1LTAyLTI3ICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gRHJvcCBsZWdhY3kgV0tCdW5kbGVQ YWdlRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQgQVBJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcAppbmRleCBiZjVjOTg1YzljZmUw NTgwZWM2ZjBmZmZhMDE3YjNmMDg4NDljNmMyLi41MDNiMDFlZThlNGEyOTY2MTYzMjdiMDI0MzBk YjYyZTk2ODRmYjIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jYWlyby9QYXRoQ2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL1BhdGhDYWlyby5jcHAKQEAgLTI4NCw2ICsyODQsMTIgQEAgdm9pZCBQYXRoOjph ZGRBcmNUbyhjb25zdCBGbG9hdFBvaW50JiBwMSwgY29uc3QgRmxvYXRQb2ludCYgcDIsIGZsb2F0 IHJhZGl1cykKICAgICBhZGRBcmMocCwgcmFkaXVzLCBzYSwgZWEsIGFudGljbG9ja3dpc2UpOwog fQogCit2b2lkIFBhdGg6OmFkZEVsbGlwc2UoRmxvYXRQb2ludCwgZmxvYXQsIGZsb2F0LCBmbG9h dCwgZmxvYXQsIGZsb2F0LCBib29sKQoreworICAgIC8vIEZJWE1FOiBOZWVkIHRvIGltcGxlbWVu dCB0aGUgUGF0aDo6YWRkRWxsaXBzZSgpLgorICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKIHZv aWQgUGF0aDo6YWRkRWxsaXBzZShjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7CiAgICAgY2Fpcm9f dCogY3IgPSBlbnN1cmVQbGF0Zm9ybVBhdGgoKS0+Y29udGV4dCgpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4 dAppbmRleCA2ODE0OTA1NjZlY2ZjNmVkMTVjOGQ1NzczMTJlMzU1YTQ5YzhmYzAzLi5jMTkyYjli M2ZmY2NiN2QzMDA4NjdiZjg0MDc3ODQ4MzY4NDMxODY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dApA QCAtNTM1LDYgKzUzNSw3IEBAIHNldChXZWJLaXQyX1NPVVJDRVMKICAgICBXZWJQcm9jZXNzL0lu amVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlU2NyaXB0V29ybGQuY3BwCiAKICAgICBXZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZUNTU1N0eWxlRGVjbGFyYXRpb25I YW5kbGUuY3BwCisgICAgV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5k bGVGaWxlSGFuZGxlLmNwcAogICAgIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVj dGVkQnVuZGxlTm9kZUhhbmRsZS5jcHAKICAgICBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RP TS9JbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmNwcAogCg== 247592 2015-02-27 22:41:46 -0800 2015-02-27 23:26:24 -0800 Patch bug-142127-20150228154131.patch text/plain 2599 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJiZjA2M2NjYzE4YTIy NDM5MDQ4MjAxZjhlNzBkNjNkMTUzOGU0My4uOTUyMGQxMjE0YjUzZGZlN2RkZmM5NGU0MDU5ODBk NjUxNTIzN2Y3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAyLTI3ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtHVEtd IEZpeCBidWlsZCBicmVhayBhZnRlciByMTgwNzkwLDE4MDc5OAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMTI3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Q YXRoQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6YWRkRWxsaXBzZSk6CisKIDIw MTUtMDItMjcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTm9k ZTo6aGFzRWRpdGFibGVTdHlsZSBhbmQgaXNFZGl0YWJsZVBvc2l0aW9uIGhhdmUgdG9vIG1hbnkg b3B0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCmluZGV4IGZmZDBlN2Y0MWNmMTM4NTQwZTFkZDk1NTM0YjhhNTQ4Njk1 NDRmNmIuLjNkYTE0NWIzODNiOGFiMDhmM2U2N2I3M2MxODBlMzkwMjNmNmZhZjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0wMi0yNyAgSHVuc2VvcCBKZW9uZyAgPGhzODUuamVv bmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bR1RLXSBGaXggYnVpbGQgYnJlYWsgYWZ0 ZXIgcjE4MDc5MCwxODA3OTggCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDIxMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE1LTAyLTI3ICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gRHJvcCBsZWdhY3kgV0tCdW5kbGVQ YWdlRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQgQVBJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcAppbmRleCBiZjVjOTg1YzljZmUw NTgwZWM2ZjBmZmZhMDE3YjNmMDg4NDljNmMyLi4xMmU5MDdjMmI2ZDdlMTI2OTAxZmY0OWU1Yjhl ZDE5MzNkMDIwOTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jYWlyby9QYXRoQ2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL1BhdGhDYWlyby5jcHAKQEAgLTI4NCw2ICsyODQsMTEgQEAgdm9pZCBQYXRoOjph ZGRBcmNUbyhjb25zdCBGbG9hdFBvaW50JiBwMSwgY29uc3QgRmxvYXRQb2ludCYgcDIsIGZsb2F0 IHJhZGl1cykKICAgICBhZGRBcmMocCwgcmFkaXVzLCBzYSwgZWEsIGFudGljbG9ja3dpc2UpOwog fQogCit2b2lkIFBhdGg6OmFkZEVsbGlwc2UoRmxvYXRQb2ludCwgZmxvYXQsIGZsb2F0LCBmbG9h dCwgZmxvYXQsIGZsb2F0LCBib29sKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKIHZv aWQgUGF0aDo6YWRkRWxsaXBzZShjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7CiAgICAgY2Fpcm9f dCogY3IgPSBlbnN1cmVQbGF0Zm9ybVBhdGgoKS0+Y29udGV4dCgpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4 dAppbmRleCA2ODE0OTA1NjZlY2ZjNmVkMTVjOGQ1NzczMTJlMzU1YTQ5YzhmYzAzLi5jMTkyYjli M2ZmY2NiN2QzMDA4NjdiZjg0MDc3ODQ4MzY4NDMxODY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dApA QCAtNTM1LDYgKzUzNSw3IEBAIHNldChXZWJLaXQyX1NPVVJDRVMKICAgICBXZWJQcm9jZXNzL0lu amVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlU2NyaXB0V29ybGQuY3BwCiAKICAgICBXZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZUNTU1N0eWxlRGVjbGFyYXRpb25I YW5kbGUuY3BwCisgICAgV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5k bGVGaWxlSGFuZGxlLmNwcAogICAgIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVj dGVkQnVuZGxlTm9kZUhhbmRsZS5jcHAKICAgICBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RP TS9JbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmNwcAogCg==