142103 2015-02-27 14:27:45 -0800 <attachment> should have an inactive style (gray in background) 2015-02-27 15:00:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton commit-queue enrica esprehn+autocc glenn kondapallykalyan mitz sam simon.fraser oldest_to_newest 1072827 0 thorton 2015-02-27 14:27:45 -0800 <attachment> should have an inactive style (gray in background) 1072828 1 247551 thorton 2015-02-27 14:28:02 -0800 Created attachment 247551 Patch 1072830 2 commit-queue 2015-02-27 14:30:56 -0800 Attachment 247551 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1072833 3 247551 mitz 2015-02-27 14:32:22 -0800 Comment on attachment 247551 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247551&action=review > Source/WebCore/ChangeLog:4 > + Need the bug URL (OOPS!). OOPS! 1072852 4 thorton 2015-02-27 15:00:36 -0800 http://trac.webkit.org/changeset/180784 247551 2015-02-27 14:28:02 -0800 2015-02-27 14:32:22 -0800 Patch bug-142103-20150227142747.patch text/plain 4354 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmZmYjU3MGE3NmIwY2Rk MDFkMDI3ODY1YzQwYzZhOTY0YmMyNzU4Mi4uNWExYjY3ZGI0MTM0ZTY2YjQ5MjExNDk2NTg2YThj ZWVkNTZmMGMwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE1LTAyLTI3ICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAorICAgICAgICA8YXR0YWNo bWVudD4gc2hvdWxkIGhhdmUgYW4gaW5hY3RpdmUgc3R5bGUgKGdyYXkgaW4gYmFja2dyb3VuZCkK KyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTk5ODI0ODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjph dHRhY2htZW50TGFiZWxJbmFjdGl2ZUJhY2tncm91bmRDb2xvcik6CisgICAgICAgIChXZWJDb3Jl OjphdHRhY2htZW50TGFiZWxJbmFjdGl2ZVRleHRDb2xvcik6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUaGVtZU1hYzo6cGFpbnRBdHRhY2htZW50TGFiZWxCYWNrZ3JvdW5kKToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpwYWludEF0dGFjaG1lbnRMYWJlbCk6CisgICAgICAg IFVzZSBhIGdyYXkgYmFja2dyb3VuZCBhbmQgZ3JheSB0ZXh0IHdoZW4gdGhlIHNlbGVjdGlvbiBj b250YWluaW5nIHRoZQorICAgICAgICBhdHRhY2htZW50IGlzbid0IGZvY3VzZWQgYW5kIGFjdGl2 ZS4KKworMjAxNS0wMi0yNyAgVGltb3RoeSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5j b20+CisKICAgICAgICAgPGF0dGFjaG1lbnQ+J3MgbGFiZWwgYmFzZWxpbmUgc2hvdWxkIG1hdGNo IHRoYXQgb2YgdGhlIHN1cnJvdW5kaW5nIHRleHQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjA5OQogICAgICAgICByZGFyOi8vcHJvYmxlbS8xOTk4 MjQ5NQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmluZGV4IGJh NjJkN2M3NTE0NWRmOTM3MDc4ZjU2ZWQ5NTBlNjYzZjUwODViMzcuLjM5N2Y3NTM4NzYyZjFkZGJj MmUwMWEzZTA4MTkyN2Q4MTZlZGQ5Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVNYWMubW0KQEAgLTMzLDYgKzMzLDcgQEAKICNpbXBvcnQgIkZsb2F0Um91bmRlZFJl Y3QuaCIKICNpbXBvcnQgIkZvY3VzQ29udHJvbGxlci5oIgogI2ltcG9ydCAiRnJhbWUuaCIKKyNp bXBvcnQgIkZyYW1lU2VsZWN0aW9uLmgiCiAjaW1wb3J0ICJGcmFtZVZpZXcuaCIKICNpbXBvcnQg IkdyYXBoaWNzQ29udGV4dENHLmgiCiAjaW1wb3J0ICJIVE1MQXR0YWNobWVudEVsZW1lbnQuaCIK QEAgLTIwODYsNiArMjA4Nyw5IEBAIGNvbnN0IENHRmxvYXQgYXR0YWNobWVudExhYmVsRm9udFNp emUgPSAxMjsKIGNvbnN0IENHRmxvYXQgYXR0YWNobWVudExhYmVsQmFja2dyb3VuZFJhZGl1cyA9 IDM7CiBjb25zdCBDR0Zsb2F0IGF0dGFjaG1lbnRMYWJlbEJhY2tncm91bmRQYWRkaW5nID0gMzsK IAorc3RhdGljIENvbG9yIGF0dGFjaG1lbnRMYWJlbEluYWN0aXZlQmFja2dyb3VuZENvbG9yKCkg eyByZXR1cm4gQ29sb3IoMjA0LCAyMDQsIDIwNCwgMjU1KTsgfQorc3RhdGljIENvbG9yIGF0dGFj aG1lbnRMYWJlbEluYWN0aXZlVGV4dENvbG9yKCkgeyByZXR1cm4gQ29sb3IoMTAwLCAxMDAsIDEw MCwgMjU1KTsgfQorCiBjb25zdCBDR0Zsb2F0IGF0dGFjaG1lbnRNYXJnaW4gPSAzOwogCiBzdHJ1 Y3QgQXR0YWNobWVudExheW91dCB7CkBAIC0yMTk4LDIwICsyMjAyLDM2IEBAIHN0YXRpYyB2b2lk IHBhaW50QXR0YWNobWVudEljb24oY29uc3QgUmVuZGVyQXR0YWNobWVudCYgYXR0YWNobWVudCwg R3JhcGhpY3NDb250CiAgICAgY29udGV4dC5kcmF3TmF0aXZlSW1hZ2UoaWNvbi5nZXQoKSwgaWNv blNpemVJblBvaW50cywgQ29sb3JTcGFjZURldmljZVJHQiwgbGF5b3V0Lmljb25SZWN0LCBGbG9h dFJlY3QoRmxvYXRQb2ludCgpLCBpY29uU2l6ZUluUG9pbnRzKSk7CiB9CiAKLXZvaWQgUmVuZGVy VGhlbWVNYWM6OnBhaW50QXR0YWNobWVudExhYmVsQmFja2dyb3VuZChjb25zdCBSZW5kZXJBdHRh Y2htZW50JiwgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBBdHRhY2htZW50TGF5b3V0JiBsYXlv dXQpIGNvbnN0Cit2b2lkIFJlbmRlclRoZW1lTWFjOjpwYWludEF0dGFjaG1lbnRMYWJlbEJhY2tn cm91bmQoY29uc3QgUmVuZGVyQXR0YWNobWVudCYgYXR0YWNobWVudCwgR3JhcGhpY3NDb250ZXh0 JiBjb250ZXh0LCBBdHRhY2htZW50TGF5b3V0JiBsYXlvdXQpIGNvbnN0CiB7CiAgICAgUGF0aCBi YWNrZ3JvdW5kUGF0aDsKICAgICBiYWNrZ3JvdW5kUGF0aC5hZGRSb3VuZGVkUmVjdChsYXlvdXQu dGV4dEJhY2tncm91bmRSZWN0LCBGbG9hdFNpemUoYXR0YWNobWVudExhYmVsQmFja2dyb3VuZFJh ZGl1cywgYXR0YWNobWVudExhYmVsQmFja2dyb3VuZFJhZGl1cykpOwotICAgIGNvbnRleHQuc2V0 RmlsbENvbG9yKGNvbnZlcnROU0NvbG9yVG9Db2xvcihbTlNDb2xvciBhbHRlcm5hdGVTZWxlY3Rl ZENvbnRyb2xDb2xvcl0pLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKKworICAgIENvbG9yIGJhY2tn cm91bmRDb2xvcjsKKyAgICBpZiAoYXR0YWNobWVudC5mcmFtZSgpLnNlbGVjdGlvbigpLmlzRm9j dXNlZEFuZEFjdGl2ZSgpKQorICAgICAgICBiYWNrZ3JvdW5kQ29sb3IgPSBjb252ZXJ0TlNDb2xv clRvQ29sb3IoW05TQ29sb3IgYWx0ZXJuYXRlU2VsZWN0ZWRDb250cm9sQ29sb3JdKTsKKyAgICBl bHNlCisgICAgICAgIGJhY2tncm91bmRDb2xvciA9IGF0dGFjaG1lbnRMYWJlbEluYWN0aXZlQmFj a2dyb3VuZENvbG9yKCk7CisKKyAgICBjb250ZXh0LnNldEZpbGxDb2xvcihiYWNrZ3JvdW5kQ29s b3IsIENvbG9yU3BhY2VEZXZpY2VSR0IpOwogICAgIGNvbnRleHQuZmlsbFBhdGgoYmFja2dyb3Vu ZFBhdGgpOwogfQogCi12b2lkIFJlbmRlclRoZW1lTWFjOjpwYWludEF0dGFjaG1lbnRMYWJlbChj b25zdCBSZW5kZXJBdHRhY2htZW50JiwgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBBdHRhY2ht ZW50TGF5b3V0JiBsYXlvdXQsIGJvb2wgdXNlU2VsZWN0ZWRTdHlsZSkgY29uc3QKK3ZvaWQgUmVu ZGVyVGhlbWVNYWM6OnBhaW50QXR0YWNobWVudExhYmVsKGNvbnN0IFJlbmRlckF0dGFjaG1lbnQm IGF0dGFjaG1lbnQsIEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgQXR0YWNobWVudExheW91dCYg bGF5b3V0LCBib29sIHVzZVNlbGVjdGVkU3R5bGUpIGNvbnN0CiB7CiAgICAgRmxvYXRQb2ludCB0 ZXh0TG9jYXRpb24gPSBsYXlvdXQudGV4dFJlY3QubWluWE1heFlDb3JuZXIoKTsKICAgICB0ZXh0 TG9jYXRpb24ubW92ZSgwLCAtbGF5b3V0LmxhYmVsRm9udENhc2NhZGUuZm9udE1ldHJpY3MoKS5k ZXNjZW50KCkpOwogCi0gICAgY29udGV4dC5zZXRGaWxsQ29sb3IodXNlU2VsZWN0ZWRTdHlsZSA/ IGNvbnZlcnROU0NvbG9yVG9Db2xvcihbTlNDb2xvciBhbHRlcm5hdGVTZWxlY3RlZENvbnRyb2xU ZXh0Q29sb3JdKSA6IENvbG9yOjpibGFjaywgQ29sb3JTcGFjZURldmljZVJHQik7CisgICAgQ29s b3IgdGV4dENvbG9yOworICAgIGlmICh1c2VTZWxlY3RlZFN0eWxlKSB7CisgICAgICAgIGlmIChh dHRhY2htZW50LmZyYW1lKCkuc2VsZWN0aW9uKCkuaXNGb2N1c2VkQW5kQWN0aXZlKCkpCisgICAg ICAgICAgICB0ZXh0Q29sb3IgPSBjb252ZXJ0TlNDb2xvclRvQ29sb3IoW05TQ29sb3IgYWx0ZXJu YXRlU2VsZWN0ZWRDb250cm9sVGV4dENvbG9yXSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAg IHRleHRDb2xvciA9IGF0dGFjaG1lbnRMYWJlbEluYWN0aXZlVGV4dENvbG9yKCk7CisgICAgfSBl bHNlCisgICAgICAgIHRleHRDb2xvciA9IENvbG9yOjpibGFjazsKKworICAgIGNvbnRleHQuc2V0 RmlsbENvbG9yKHRleHRDb2xvciwgQ29sb3JTcGFjZURldmljZVJHQik7CiAgICAgY29udGV4dC5k cmF3QmlkaVRleHQobGF5b3V0LmxhYmVsRm9udENhc2NhZGUsICpsYXlvdXQubGFiZWxUZXh0UnVu LCB0ZXh0TG9jYXRpb24pOwogfQogCg==