142084 2015-02-27 07:15:27 -0800 W3C test importer should use filesystem to read and write files 2015-02-28 03:49:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142085 1 youennf youennf bjonesbe commit-queue glenn oldest_to_newest 1072692 0 youennf 2015-02-27 07:15:27 -0800 The importer currently directly use open to access to files. filesystem should be used instead. 1072695 1 247513 youennf 2015-02-27 07:25:44 -0800 Created attachment 247513 Patch 1072935 2 247513 bjonesbe 2015-02-27 17:27:15 -0800 Comment on attachment 247513 Patch r=me 1073021 3 247513 commit-queue 2015-02-28 03:49:40 -0800 Comment on attachment 247513 Patch Clearing flags on attachment: 247513 Committed r180830: <http://trac.webkit.org/changeset/180830> 1073022 4 commit-queue 2015-02-28 03:49:44 -0800 All reviewed patches have been landed. Closing bug. 247513 2015-02-27 07:25:44 -0800 2015-02-28 03:49:40 -0800 Patch bug-142084-20150227162529.patch text/plain 5621 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2Q4M2E5OTk2Y2M0MDA4ZDcyODM5YzBlOGQ4YzUzZjA1 YzE3ODY4My4uZjI5OGIwNDJiNGVjZTcxMmIzN2I1MTAwZWU3MWJlNDUwOGNkZWJiMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTAyLTI3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CisKKyAgICAgICAgVzNDIHRlc3QgaW1wb3J0ZXIgc2hvdWxkIHVzZSBmaWxlc3lzdGVtIHRv IHJlYWQgYW5kIHdyaXRlIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDIwODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVc2Ugb2YgRmlsZVN5c3RlbS53cml0ZV9iaW5hcnlfZmlsZSwgcmVhZF90 ZXh0X2ZpbGUgYW5kIHdyaXRlX3RleHRfZmlsZSBpbiBsaWV1IG9mIG9wZW4oKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHk6CisgICAgICAgIChUZXN0 SW1wb3J0ZXIuaW1wb3J0X3Rlc3RzKToKKyAgICAgICAgKFRlc3RJbXBvcnRlci5yZW1vdmVfZGVs ZXRlZF9maWxlcyk6CisgICAgICAgIChUZXN0SW1wb3J0ZXIud3JpdGVfaW1wb3J0X2xvZyk6CisK IDIwMTUtMDItMjEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4K IAogICAgICAgICBUZXN0cyBkb24ndCB3b3JrIG9uIHNvbWUgYm90czogRmFpbGVkIHRvIHN0b3Ag d3B0d2sKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0 ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2ltcG9ydGVyLnB5CmluZGV4 IGUxZjRkMzA1YjRjMTJlOGNhZmIzMTYyMDkyNjZhMzVjZDZlMmViNDMuLmNlYTVkMDI4MmFmODU1 ZDYxMWU0NjU3ZDg3NTZiZGJmNzkyZWUyMzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93 M2MvdGVzdF9pbXBvcnRlci5weQpAQCAtMzI1LDkgKzMyNSw3IEBAIGNsYXNzIFRlc3RJbXBvcnRl cihvYmplY3QpOgogCiAgICAgICAgICAgICAgICAgICAgICAgICBwcmVmaXhlZF9wcm9wZXJ0eV92 YWx1ZXMuZXh0ZW5kKHNldChjb252ZXJ0ZWRfZmlsZVsxXSkgLSBzZXQocHJlZml4ZWRfcHJvcGVy dHlfdmFsdWVzKSkKIAotICAgICAgICAgICAgICAgICAgICAgICAgb3V0ZmlsZSA9IG9wZW4obmV3 X2ZpbGVwYXRoLCAnd2InKQotICAgICAgICAgICAgICAgICAgICAgICAgb3V0ZmlsZS53cml0ZShj b252ZXJ0ZWRfZmlsZVsyXSkKLSAgICAgICAgICAgICAgICAgICAgICAgIG91dGZpbGUuY2xvc2Uo KQorICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5maWxlc3lzdGVtLndyaXRlX2JpbmFyeV9m aWxlKG5ld19maWxlcGF0aCwgY29udmVydGVkX2ZpbGVbMl0pCiAgICAgICAgICAgICAgICAgZWxp ZiBvcmlnX2ZpbGVwYXRoLmVuZHN3aXRoKCdfX2luaXRfXy5weScpIGFuZCBub3Qgc2VsZi5maWxl c3lzdGVtLmdldHNpemUob3JpZ19maWxlcGF0aCk6CiAgICAgICAgICAgICAgICAgICAgICMgU29t ZSBib3RzIGRpc2xpa2UgZW1wdHkgX19pbml0X18ucHkuCiAgICAgICAgICAgICAgICAgICAgIHNl bGYuZmlsZXN5c3RlbS53cml0ZV90ZXh0X2ZpbGUobmV3X2ZpbGVwYXRoLCAnIyBUaGlzIGZpbGUg aXMgcmVxdWlyZWQgZm9yIFB5dGhvbiB0byBzZWFyY2ggdGhpcyBkaXJlY3RvcnkgZm9yIG1vZHVs ZXMuJykKQEAgLTM2Nyw4ICszNjUsNyBAQCBjbGFzcyBUZXN0SW1wb3J0ZXIob2JqZWN0KToKICAg ICAgICAgaWYgbm90IG9zLnBhdGguZXhpc3RzKGltcG9ydF9sb2dfZmlsZSk6CiAgICAgICAgICAg ICByZXR1cm4KIAotICAgICAgICBpbXBvcnRfbG9nID0gb3BlbihpbXBvcnRfbG9nX2ZpbGUsICdy JykKLSAgICAgICAgY29udGVudHMgPSBpbXBvcnRfbG9nLnJlYWRsaW5lcygpCisgICAgICAgIGNv bnRlbnRzID0gc2VsZi5maWxlc3lzdGVtLnJlYWRfdGV4dF9maWxlKGltcG9ydF9sb2dfZmlsZSku c3BsaXQoJ1xuJykKIAogICAgICAgICBpZiAnTGlzdCBvZiBmaWxlc1xuJyBpbiBjb250ZW50czoK ICAgICAgICAgICAgIGxpc3RfaW5kZXggPSBjb250ZW50cy5pbmRleCgnTGlzdCBvZiBmaWxlczpc bicpICsgMQpAQCAtMzgwLDM2ICszNzcsMzQgQEAgY2xhc3MgVGVzdEltcG9ydGVyKG9iamVjdCk6 CiAgICAgICAgICAgICBkZWxldGVkX2ZpbGUgPSBvcy5wYXRoLmpvaW4oc2VsZi5fd2Via2l0X3Jv b3QsIGRlbGV0ZWRfZmlsZSkKICAgICAgICAgICAgIG9zLnJlbW92ZShkZWxldGVkX2ZpbGUpCiAK LSAgICAgICAgaW1wb3J0X2xvZy5jbG9zZSgpCi0KICAgICBkZWYgd3JpdGVfaW1wb3J0X2xvZyhz ZWxmLCBpbXBvcnRfZGlyZWN0b3J5LCBmaWxlX2xpc3QsIHByb3BfbGlzdCwgcHJvcGVydHlfdmFs dWVzX2xpc3QpOgogICAgICAgICAiIiIgV3JpdGVzIGEgdzNjLWltcG9ydC5sb2cgZmlsZSBpbiBl YWNoIGRpcmVjdG9yeSB3aXRoIGltcG9ydGVkIGZpbGVzLiAiIiIKIAotICAgICAgICBpbXBvcnRf bG9nID0gb3Blbihvcy5wYXRoLmpvaW4oaW1wb3J0X2RpcmVjdG9yeSwgJ3czYy1pbXBvcnQubG9n JyksICd3JykKLSAgICAgICAgaW1wb3J0X2xvZy53cml0ZSgnVGhlIHRlc3RzIGluIHRoaXMgZGly ZWN0b3J5IHdlcmUgaW1wb3J0ZWQgZnJvbSB0aGUgVzNDIHJlcG9zaXRvcnkuXG4nKQotICAgICAg ICBpbXBvcnRfbG9nLndyaXRlKCdEbyBOT1QgbW9kaWZ5IHRoZXNlIHRlc3RzIGRpcmVjdGx5IGlu IFdlYmtpdC5cbicpCi0gICAgICAgIGltcG9ydF9sb2cud3JpdGUoJ0luc3RlYWQsIHB1c2ggY2hh bmdlcyB0byB0aGUgVzNDIENTUyByZXBvOlxuJykKLSAgICAgICAgaW1wb3J0X2xvZy53cml0ZSgn XHRodHRwOi8vaGcuY3Nzd2cub3JnL3Rlc3RcbicpCi0gICAgICAgIGltcG9ydF9sb2cud3JpdGUo J09yIGNyZWF0ZSBhIHB1bGwgcmVxdWVzdCBvbiB0aGUgVzNDIENTUyBnaXRodWI6XG4nKQotICAg ICAgICBpbXBvcnRfbG9nLndyaXRlKCdcdGh0dHBzOi8vZ2l0aHViLmNvbS93M2MvY3Nzd2ctdGVz dFxuXG4nKQotICAgICAgICBpbXBvcnRfbG9nLndyaXRlKCdUaGVuIHJ1biB0aGUgVG9vbHMvU2Ny aXB0cy9pbXBvcnQtdzNjLXRlc3RzIGluIFdlYmtpdCB0byByZWltcG9ydFxuXG4nKQotICAgICAg ICBpbXBvcnRfbG9nLndyaXRlKCdEbyBOT1QgbW9kaWZ5IG9yIHJlbW92ZSB0aGlzIGZpbGVcblxu JykKLSAgICAgICAgaW1wb3J0X2xvZy53cml0ZSgnLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tXG4nKQotICAgICAg ICBpbXBvcnRfbG9nLndyaXRlKCdQcm9wZXJ0aWVzIHJlcXVpcmluZyB2ZW5kb3IgcHJlZml4ZXM6 XG4nKQorICAgICAgICBpbXBvcnRfbG9nID0gW10KKyAgICAgICAgaW1wb3J0X2xvZy5hcHBlbmQo J1RoZSB0ZXN0cyBpbiB0aGlzIGRpcmVjdG9yeSB3ZXJlIGltcG9ydGVkIGZyb20gdGhlIFczQyBy ZXBvc2l0b3J5LlxuJykKKyAgICAgICAgaW1wb3J0X2xvZy5hcHBlbmQoJ0RvIE5PVCBtb2RpZnkg dGhlc2UgdGVzdHMgZGlyZWN0bHkgaW4gV2Via2l0LlxuJykKKyAgICAgICAgaW1wb3J0X2xvZy5h cHBlbmQoJ0luc3RlYWQsIHB1c2ggY2hhbmdlcyB0byB0aGUgVzNDIENTUyByZXBvOlxuJykKKyAg ICAgICAgaW1wb3J0X2xvZy5hcHBlbmQoJ1x0aHR0cDovL2hnLmNzc3dnLm9yZy90ZXN0XG4nKQor ICAgICAgICBpbXBvcnRfbG9nLmFwcGVuZCgnT3IgY3JlYXRlIGEgcHVsbCByZXF1ZXN0IG9uIHRo ZSBXM0MgQ1NTIGdpdGh1YjpcbicpCisgICAgICAgIGltcG9ydF9sb2cuYXBwZW5kKCdcdGh0dHBz Oi8vZ2l0aHViLmNvbS93M2MvY3Nzd2ctdGVzdFxuXG4nKQorICAgICAgICBpbXBvcnRfbG9nLmFw cGVuZCgnVGhlbiBydW4gdGhlIFRvb2xzL1NjcmlwdHMvaW1wb3J0LXczYy10ZXN0cyBpbiBXZWJr aXQgdG8gcmVpbXBvcnRcblxuJykKKyAgICAgICAgaW1wb3J0X2xvZy5hcHBlbmQoJ0RvIE5PVCBt b2RpZnkgb3IgcmVtb3ZlIHRoaXMgZmlsZVxuXG4nKQorICAgICAgICBpbXBvcnRfbG9nLmFwcGVu ZCgnLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tXG4nKQorICAgICAgICBpbXBvcnRfbG9nLmFwcGVuZCgnUHJvcGVy dGllcyByZXF1aXJpbmcgdmVuZG9yIHByZWZpeGVzOlxuJykKICAgICAgICAgaWYgcHJvcF9saXN0 OgogICAgICAgICAgICAgZm9yIHByb3AgaW4gcHJvcF9saXN0OgotICAgICAgICAgICAgICAgIGlt cG9ydF9sb2cud3JpdGUocHJvcCArICdcbicpCisgICAgICAgICAgICAgICAgaW1wb3J0X2xvZy5h cHBlbmQocHJvcCArICdcbicpCiAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICBpbXBvcnRfbG9n LndyaXRlKCdOb25lXG4nKQotICAgICAgICBpbXBvcnRfbG9nLndyaXRlKCdQcm9wZXJ0eSB2YWx1 ZXMgcmVxdWlyaW5nIHZlbmRvciBwcmVmaXhlczpcbicpCisgICAgICAgICAgICBpbXBvcnRfbG9n LmFwcGVuZCgnTm9uZVxuJykKKyAgICAgICAgaW1wb3J0X2xvZy5hcHBlbmQoJ1Byb3BlcnR5IHZh bHVlcyByZXF1aXJpbmcgdmVuZG9yIHByZWZpeGVzOlxuJykKICAgICAgICAgaWYgcHJvcGVydHlf dmFsdWVzX2xpc3Q6CiAgICAgICAgICAgICBmb3IgdmFsdWUgaW4gcHJvcGVydHlfdmFsdWVzX2xp c3Q6Ci0gICAgICAgICAgICAgICAgaW1wb3J0X2xvZy53cml0ZSh2YWx1ZSArICdcbicpCisgICAg ICAgICAgICAgICAgaW1wb3J0X2xvZy5hcHBlbmQodmFsdWUgKyAnXG4nKQogICAgICAgICBlbHNl OgotICAgICAgICAgICAgaW1wb3J0X2xvZy53cml0ZSgnTm9uZVxuJykKLSAgICAgICAgaW1wb3J0 X2xvZy53cml0ZSgnLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tXG4nKQotICAgICAgICBpbXBvcnRfbG9nLndyaXRl KCdMaXN0IG9mIGZpbGVzOlxuJykKKyAgICAgICAgICAgIGltcG9ydF9sb2cuYXBwZW5kKCdOb25l XG4nKQorICAgICAgICBpbXBvcnRfbG9nLmFwcGVuZCgnLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tXG4nKQorICAg ICAgICBpbXBvcnRfbG9nLmFwcGVuZCgnTGlzdCBvZiBmaWxlczpcbicpCiAgICAgICAgIGZvciBp dGVtIGluIHNvcnRlZChmaWxlX2xpc3QpOgotICAgICAgICAgICAgaW1wb3J0X2xvZy53cml0ZShp dGVtICsgJ1xuJykKKyAgICAgICAgICAgIGltcG9ydF9sb2cuYXBwZW5kKGl0ZW0gKyAnXG4nKQog Ci0gICAgICAgIGltcG9ydF9sb2cuY2xvc2UoKQorICAgICAgICBzZWxmLmZpbGVzeXN0ZW0ud3Jp dGVfdGV4dF9maWxlKHNlbGYuZmlsZXN5c3RlbS5qb2luKGltcG9ydF9kaXJlY3RvcnksICd3M2Mt aW1wb3J0LmxvZycpLCAnJy5qb2luKGltcG9ydF9sb2cpKQo=