142064 2015-02-26 16:46:22 -0800 The bool returning form of BytecodeGenerator::addVar() can be removed 2015-02-26 18:28:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 142067 141174 1 fpizlo fpizlo bfulgham commit-queue mark.lam oldest_to_newest 1072552 0 fpizlo 2015-02-26 16:46:22 -0800 Patch forthcoming. 1072555 1 247467 fpizlo 2015-02-26 16:51:14 -0800 Created attachment 247467 the patch 1072556 2 commit-queue 2015-02-26 16:52:21 -0800 Attachment 247467 did not pass style-queue: ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616: The parameter name "ident" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616: The parameter name "constantMode" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616: The parameter name "watchMode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1072557 3 247467 mark.lam 2015-02-26 16:52:54 -0800 Comment on attachment 247467 the patch r=me 1072558 4 fpizlo 2015-02-26 16:55:59 -0800 Landed in http://trac.webkit.org/changeset/180711 1072568 5 bfulgham 2015-02-26 17:12:24 -0800 This may have caused a bunch of Debug assertions Windows. I'm trying to debug locally. 1072592 6 commit-queue 2015-02-26 17:58:52 -0800 Re-opened since this is blocked by bug 142067 1072594 7 247478 mark.lam 2015-02-26 18:05:44 -0800 Created attachment 247478 patch for commit of assertion failure fix. 1072597 8 mark.lam 2015-02-26 18:08:42 -0800 Fix for assertion failure landed in r180719: <http://trac.webkit.org/r180719>. 1072600 9 fpizlo 2015-02-26 18:28:29 -0800 (In reply to comment #8) > Fix for assertion failure landed in r180719: > <http://trac.webkit.org/r180719>. Thanks! 247467 2015-02-26 16:51:14 -0800 2015-02-26 16:52:54 -0800 the patch blah.patch text/plain 3813 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwNzEwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE1LTAyLTI2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg VGhlIGJvb2wgcmV0dXJuaW5nIGZvcm0gb2YgQnl0ZWNvZGVHZW5lcmF0b3I6OmFkZFZhcigpIGNh biBiZSByZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDIwNjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgCisgICAgICAgIEl0J3MgZWFzaWVyIHRvIGltcGxlbWVudCBhZGRWYXIoKSB3aGVuIHlvdSBk b24ndCBoYXZlIHRvIHJldHVybiB3aGV0aGVyIGl0J3MgYSBuZXcKKyAgICAgICAgdmFyaWFibGUg b3Igbm90LgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcDoK KyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmFkZFZhcik6CisgICAgICAgICogYnl0 ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmg6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2Vu ZXJhdG9yOjphZGRWYXIpOiBEZWxldGVkLgorCiAyMDE1LTAyLTI2ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVmFyaW91cyBhcnJheSBhY2Nlc3MgY29ybmVyIGNh c2VzIHNob3VsZCB0YWtlIE9TUiBleGl0IGZlZWRiYWNrCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAko cmV2aXNpb24gMTgwNzAyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9C eXRlY29kZUdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMyw4ICsxMjMsOCBAQCBQ YXJzZXJFcnJvciBCeXRlY29kZUdlbmVyYXRvcjo6Z2VuZXJhdGUoCiAgICAgcmV0dXJuIFBhcnNl ckVycm9yKFBhcnNlckVycm9yOjpFcnJvck5vbmUpOwogfQogCi1ib29sIEJ5dGVjb2RlR2VuZXJh dG9yOjphZGRWYXIoCi0gICAgY29uc3QgSWRlbnRpZmllciYgaWRlbnQsIENvbnN0YW50TW9kZSBj b25zdGFudE1vZGUsIFdhdGNoTW9kZSB3YXRjaE1vZGUsIFJlZ2lzdGVySUQqJiByMCkKK1JlZ2lz dGVySUQqIEJ5dGVjb2RlR2VuZXJhdG9yOjphZGRWYXIoCisgICAgY29uc3QgSWRlbnRpZmllciYg aWRlbnQsIENvbnN0YW50TW9kZSBjb25zdGFudE1vZGUsIFdhdGNoTW9kZSB3YXRjaE1vZGUpCiB7 CiAgICAgQVNTRVJUKHN0YXRpY19jYXN0PHNpemVfdD4obV9jb2RlQmxvY2stPm1fbnVtVmFycykg PT0gbV9jYWxsZWVSZWdpc3RlcnMuc2l6ZSgpKTsKICAgICAKQEAgLTEzMywxMCArMTMzLDggQEAg Ym9vbCBCeXRlY29kZUdlbmVyYXRvcjo6YWRkVmFyKAogICAgIFN5bWJvbFRhYmxlRW50cnkgbmV3 RW50cnkoaW5kZXgsIGNvbnN0YW50TW9kZSA9PSBJc0NvbnN0YW50ID8gUmVhZE9ubHkgOiAwKTsK ICAgICBTeW1ib2xUYWJsZTo6TWFwOjpBZGRSZXN1bHQgcmVzdWx0ID0gc3ltYm9sVGFibGUoKS5h ZGQobG9ja2VyLCBpZGVudC5pbXBsKCksIG5ld0VudHJ5KTsKIAotICAgIGlmICghcmVzdWx0Lmlz TmV3RW50cnkpIHsKLSAgICAgICAgcjAgPSAmcmVnaXN0ZXJGb3IocmVzdWx0Lml0ZXJhdG9yLT52 YWx1ZS5nZXRJbmRleCgpKTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KKyAgICBpZiAo IXJlc3VsdC5pc05ld0VudHJ5KQorICAgICAgICByZXR1cm4gJnJlZ2lzdGVyRm9yKHJlc3VsdC5p dGVyYXRvci0+dmFsdWUuZ2V0SW5kZXgoKSk7CiAgICAgCiAgICAgaWYgKHdhdGNoTW9kZSA9PSBJ c1dhdGNoYWJsZSkgewogICAgICAgICB3aGlsZSAobV93YXRjaGFibGVWYXJpYWJsZXMuc2l6ZSgp IDwgc3RhdGljX2Nhc3Q8c2l6ZV90PihtX2NvZGVCbG9jay0+bV9udW1WYXJzKSkKQEAgLTE0NCwx MSArMTQyLDkgQEAgYm9vbCBCeXRlY29kZUdlbmVyYXRvcjo6YWRkVmFyKAogICAgICAgICBtX3dh dGNoYWJsZVZhcmlhYmxlcy5hcHBlbmQoaWRlbnQpOwogICAgIH0KICAgICAKLSAgICByMCA9IGFk ZFZhcigpOwotICAgIAogICAgIEFTU0VSVCh3YXRjaE1vZGUgPT0gTm90V2F0Y2hhYmxlIHx8IHN0 YXRpY19jYXN0PHNpemVfdD4obV9jb2RlQmxvY2stPm1fbnVtVmFycykgPT0gbV93YXRjaGFibGVW YXJpYWJsZXMuc2l6ZSgpKTsKICAgICAKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gYWRk VmFyKCk7CiB9CiAKIEJ5dGVjb2RlR2VuZXJhdG9yOjpCeXRlY29kZUdlbmVyYXRvcihWTSYgdm0s IFByb2dyYW1Ob2RlKiBwcm9ncmFtTm9kZSwgVW5saW5rZWRQcm9ncmFtQ29kZUJsb2NrKiBjb2Rl QmxvY2ssIERlYnVnZ2VyTW9kZSBkZWJ1Z2dlck1vZGUsIFByb2ZpbGVyTW9kZSBwcm9maWxlck1v ZGUpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2Vu ZXJhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxl ci9CeXRlY29kZUdlbmVyYXRvci5oCShyZXZpc2lvbiAxODA3MDIpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkK QEAgLTYxMywxNiArNjEzLDggQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAgICAgLy8gQWRkcyBh IHZhciBzbG90IGFuZCBtYXBzIGl0IHRvIHRoZSBuYW1lIGlkZW50IGluIHN5bWJvbFRhYmxlKCku CiAgICAgICAgIGVudW0gV2F0Y2hNb2RlIHsgSXNXYXRjaGFibGUsIE5vdFdhdGNoYWJsZSB9Owot ICAgICAgICBSZWdpc3RlcklEKiBhZGRWYXIoY29uc3QgSWRlbnRpZmllciYgaWRlbnQsIENvbnN0 YW50TW9kZSBjb25zdGFudE1vZGUsIFdhdGNoTW9kZSB3YXRjaE1vZGUpCi0gICAgICAgIHsKLSAg ICAgICAgICAgIFJlZ2lzdGVySUQqIGxvY2FsOwotICAgICAgICAgICAgYWRkVmFyKGlkZW50LCBj b25zdGFudE1vZGUsIHdhdGNoTW9kZSwgbG9jYWwpOwotICAgICAgICAgICAgcmV0dXJuIGxvY2Fs OwotICAgICAgICB9CisgICAgICAgIFJlZ2lzdGVySUQqIGFkZFZhcihjb25zdCBJZGVudGlmaWVy JiBpZGVudCwgQ29uc3RhbnRNb2RlIGNvbnN0YW50TW9kZSwgV2F0Y2hNb2RlIHdhdGNoTW9kZSk7 CiAKLSAgICAgICAgLy8gRGl0dG8uIFJldHVybnMgdHJ1ZSBpZiBhIG5ldyBSZWdpc3RlcklEIHdh cyBhZGRlZCwgZmFsc2UgaWYgYSBwcmUtZXhpc3RpbmcgUmVnaXN0ZXJJRCB3YXMgcmUtdXNlZC4K LSAgICAgICAgYm9vbCBhZGRWYXIoY29uc3QgSWRlbnRpZmllciYsIENvbnN0YW50TW9kZSwgV2F0 Y2hNb2RlLCBSZWdpc3RlcklEKiYpOwotICAgICAgICAKICAgICAgICAgLy8gQWRkcyBhbiBhbm9u eW1vdXMgdmFyIHNsb3QuIFRvIGdpdmUgdGhpcyBzbG90IGEgbmFtZSwgYWRkIGl0IHRvIHN5bWJv bFRhYmxlKCkuCiAgICAgICAgIFJlZ2lzdGVySUQqIGFkZFZhcigpCiAgICAgICAgIHsK 247478 2015-02-26 18:05:44 -0800 2015-02-26 18:05:44 -0800 patch for commit of assertion failure fix. bug-142064fix.patch text/plain 1452 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwNzE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAyLTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB c3NlcnRpb24gZml4IGZvciByMTgwNzExOiBUaGUgYm9vbCByZXR1cm5pbmcgZm9ybSBvZiBCeXRl Y29kZUdlbmVyYXRvcjo6YWRkVmFyKCkgY2FuIGJlIHJlbW92ZWQuCisgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xNDIwNjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBlY29y YXJvLgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcDoKKyAg ICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmFkZFZhcik6CisKIDIwMTUtMDItMjYgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIE1hY2hpbmVUaHJlYWRzOjpU aHJlYWQgY2xlYW4gdXAgaGFzIGEgdXNlIGFmdGVyIGZyZWUgcmFjZSBjb25kaXRpb24uCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVj b2RlR2VuZXJhdG9yLmNwcAkocmV2aXNpb24gMTgwNzE2KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE0Miw5ICsxNDIsMTAgQEAgUmVnaXN0ZXJJRCogQnl0ZWNvZGVHZW5lcmF0b3I6OmFkZFZhcigK ICAgICAgICAgbV93YXRjaGFibGVWYXJpYWJsZXMuYXBwZW5kKGlkZW50KTsKICAgICB9CiAgICAg CisgICAgUmVnaXN0ZXJJRCogcmVnSUQgPSBhZGRWYXIoKTsKICAgICBBU1NFUlQod2F0Y2hNb2Rl ID09IE5vdFdhdGNoYWJsZSB8fCBzdGF0aWNfY2FzdDxzaXplX3Q+KG1fY29kZUJsb2NrLT5tX251 bVZhcnMpID09IG1fd2F0Y2hhYmxlVmFyaWFibGVzLnNpemUoKSk7CiAgICAgCi0gICAgcmV0dXJu IGFkZFZhcigpOworICAgIHJldHVybiByZWdJRDsKIH0KIAogQnl0ZWNvZGVHZW5lcmF0b3I6OkJ5 dGVjb2RlR2VuZXJhdG9yKFZNJiB2bSwgUHJvZ3JhbU5vZGUqIHByb2dyYW1Ob2RlLCBVbmxpbmtl ZFByb2dyYW1Db2RlQmxvY2sqIGNvZGVCbG9jaywgRGVidWdnZXJNb2RlIGRlYnVnZ2VyTW9kZSwg UHJvZmlsZXJNb2RlIHByb2ZpbGVyTW9kZSkK