142057 2015-02-26 14:41:25 -0800 Fix the !ENABLE(WEBGL) build after r180609 2015-03-09 13:52:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Windows XP RESOLVED FIXED P2 Normal --- 141567 1 ossy ossy commit-queue darin dino gyuyoung.kim kondapallykalyan noam ossy roger_fong simon.fraser oldest_to_newest 1072491 0 ossy 2015-02-26 14:41:25 -0800 log: lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp.o):GraphicsContext3DOpenGLCommon.cpp:function WebCore::GraphicsContext3D::forceContextLost(): error: undefined reference to 'WebCore::WebGLRenderingContextBase::forceLostContext(WebCore::WebGLRenderingContextBase::LostContextMode)' collect2: error: ld returned 1 exit status The problem is that forceLostContext() is defined inside ENABLE(WEBGL) guard, but used unconditionally in GraphicsContext3DOpenGLCommon.cpp after http://trac.webkit.org/changeset/180609 1072493 1 247447 ossy 2015-02-26 14:44:38 -0800 Created attachment 247447 Patch 1074439 2 ossy 2015-03-05 01:50:51 -0800 Dean or Roger, could you possibly review the patch fixes the build breakage your patch caused? 1074980 3 ossy 2015-03-06 09:42:00 -0800 ping? 1075739 4 247447 commit-queue 2015-03-09 13:52:35 -0700 Comment on attachment 247447 Patch Clearing flags on attachment: 247447 Committed r181281: <http://trac.webkit.org/changeset/181281> 1075740 5 commit-queue 2015-03-09 13:52:40 -0700 All reviewed patches have been landed. Closing bug. 247447 2015-02-26 14:44:38 -0800 2015-03-09 13:52:35 -0700 Patch bug-142057-20150226144424.patch text/plain 1654 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM2Mjk0YzIzOWVjZDdh NmJlNDJkODAzY2FjODdkMGNjYzEzZmRjNy4uNzU5NGUzNGY3YjZiNjdiYmU5ZDk5MTk5OWJhYmQy Mjk4NTAzNzFiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE1LTAyLTI2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKFdFQkdMKSBidWlsZCBhZnRlciByMTgwNjA5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIwNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGlj c0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQzRDo6Zm9yY2VDb250ZXh0TG9zdCk6CisKKzIwMTUtMDItMjYgIENzYWJhIE9zenRyb2dv bsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwogICAgICAgICBGaXggdGhlICFFTkFCTEUoR0VPTE9D QVRJT04pIGJ1aWxkIGFmdGVyIHIxODA1MzMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MjA1MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4 dDNET3BlbkdMQ29tbW9uLmNwcAppbmRleCA4OTBjMTY3MTZmZmQ1MjMwODdiMjcyNTUxZWY3NjNj YzUwZjZjMmViLi45ZWU5N2NjYzU1YjU2MDI1MmNlMDAyOTc5NmU1MmYxNTkyNDMxMjBmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3ND b250ZXh0M0RPcGVuR0xDb21tb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKQEAgLTE3Njks OCArMTc2OSwxMCBAQCBib29sIEdyYXBoaWNzQ29udGV4dDNEOjpsYXllckNvbXBvc2l0ZWQoKSBj b25zdAogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpmb3JjZUNvbnRleHRMb3N0KCkKIHsKKyNp ZiBFTkFCTEUoV0VCR0wpCiAgICAgaWYgKG1fd2ViZ2xDb250ZXh0KQogICAgICAgICBtX3dlYmds Q29udGV4dC0+Zm9yY2VMb3N0Q29udGV4dChXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlOjpSZWFs TG9zdENvbnRleHQpOworI2VuZGlmCiB9CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnRleElt YWdlMkREaXJlY3QoR0MzRGVudW0gdGFyZ2V0LCBHQzNEaW50IGxldmVsLCBHQzNEZW51bSBpbnRl cm5hbGZvcm1hdCwgR0MzRHNpemVpIHdpZHRoLCBHQzNEc2l6ZWkgaGVpZ2h0LCBHQzNEaW50IGJv cmRlciwgR0MzRGVudW0gZm9ybWF0LCBHQzNEZW51bSB0eXBlLCBjb25zdCB2b2lkKiBwaXhlbHMp Cg==