142055 2015-02-26 14:11:23 -0800 bmalloc: Large object free list can grow infinitely 2015-02-26 14:24:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren commit-queue oldest_to_newest 1072481 0 ggaren 2015-02-26 14:11:23 -0800 bmalloc: Large object free list can grow infinitely 1072482 1 247444 ggaren 2015-02-26 14:17:44 -0800 Created attachment 247444 Patch 1072483 2 commit-queue 2015-02-26 14:19:42 -0800 Attachment 247444 did not pass style-queue: ERROR: Source/bmalloc/bmalloc/BoundaryTag.h:88: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1072484 3 247444 kling 2015-02-26 14:22:52 -0800 Comment on attachment 247444 Patch r=me 1072487 4 ggaren 2015-02-26 14:24:53 -0800 Committed r180701: <http://trac.webkit.org/changeset/180701> 247444 2015-02-26 14:17:44 -0800 2015-02-26 14:22:52 -0800 Patch bug-142055-20150226141730.patch text/plain 7293 ggaren SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDY5NykKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ5IEBACisyMDE1LTAyLTI2ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogTGFyZ2Ugb2Jq ZWN0IGZyZWUgbGlzdCBjYW4gZ3JvdyBpbmZpbml0ZWx5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIwNTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSBkZXNpZ24sIHdlIGRvbid0IGVhZ2VybHkgcmVt b3ZlIGxhcmdlIG9iamVjdHMgZnJvbSB0aGUgZnJlZSBsaXN0LgorICAgICAgICBUaGlzIGNyZWF0 ZXMgdHdvIHNpbXBsZSBwYXRob2xvZ2llczoKKworICAgICAgICAgICAgKDEpIElmIHlvdSBmcmVl IGFuZCB0aGVuIGFsbG9jYXRlIHRoZSBzYW1lIG9iamVjdCByZXBlYXRlZGx5LCBpdCB3aWxsCisg ICAgICAgICAgICBkdXBsaWNhdGUgaXRzZWxmIGluIHRoZSBmcmVlIGxpc3QgcmVwZWF0ZWRseS4g U2luY2UgaXQgaXMgbmV2ZXIKKyAgICAgICAgICAgIGludmFsaWQgYXQgdGhlIHRpbWUgb2YgYWxs b2NhdGlvbiwgaXQgd2lsbCBuZXZlciBiZSByZW1vdmVkLgorCisgICAgICAgICAgICAoMikgSWYg eW91IHNwbGl0IGFuZCB0aGVuIG1lcmdlIHRoZSBzYW1lIG9iamVjdCByZXBlYXRlZGx5LCBpdCB3 aWxsCisgICAgICAgICAgICBkdXBsaWNhdGUgaXRzIHNwbGl0IHNpYmxpbmcgaW4gdGhlIGZyZWUg bGlzdCByZXBlYXRlZGx5LiBJZiBpdHMKKyAgICAgICAgICAgIHNpYmxpbmcgaXMgaW4gYSBzZXBh cmF0ZSBmcmVlIGxpc3Qgc2l6ZSBjbGFzcywgaXQgd2lsbCBuZXZlciBiZQorICAgICAgICAgICAg Y29uc3VsdGVkIGF0IHRoZSB0aW1lIG9mIGFsbG9jYXRpb24sIHNvIGl0IHdpbGwgbmV2ZXIgYmUg cmVtb3ZlZC4KKworICAgICAgICBTbywgYSBzaW1wbGUgIndoaWxlICgxKSB7IGZyZWUobWFsbG9j KHgpKTsgfSIgY2F1c2VzIGluZmluaXRlIG1lbW9yeQorICAgICAgICB1c2UgaW4gdGhlIGZyZWUg bGlzdC4KKworICAgICAgICBUaGUgc29sdXRpb24gaW4gdGhpcyBwYXRjaCBpcyBhIHNpbXBsZSBo ZWxwZXIgdG8gcmVtb3ZlIGdhcmJhZ2UgZnJvbSB0aGUKKyAgICAgICAgZnJlZSBsaXN0IGlmIGl0 IGdyb3dzIHRvbyBsYXJnZS4gVGhpcyBwYXRob2xvZ3kgaXMgbm90IGNvbW1vbiwgc28gdGhlCisg ICAgICAgIGNvc3QgaXMgT0suCisKKyAgICAgICAgTG9uZy10ZXJtLCBwZXJoYXBzIHdlIHNob3Vs ZCByZXRoaW5rIHRoZSBsYXppbmVzcyBvZiB0aGVzZSBmcmVlIGxpc3RzLgorCisgICAgICAgICog Ym1hbGxvYy9Cb3VuZGFyeVRhZy5oOgorICAgICAgICAoYm1hbGxvYzo6Qm91bmRhcnlUYWc6Omlz TWFya2VkKToKKyAgICAgICAgKGJtYWxsb2M6OkJvdW5kYXJ5VGFnOjpzZXRNYXJrZWQpOiBOZXcg Yml0LCB1c2VkIGJ5IGZyZWUgbGlzdCBHQy4KKworICAgICAgICAqIGJtYWxsb2MvRnJlZUxpc3Qu Y3BwOgorICAgICAgICAoYm1hbGxvYzo6RnJlZUxpc3Q6OnJlbW92ZUludmFsaWRBbmREdXBsaWNh dGVFbnRyaWVzKTogVGhlIEdDIGFsZ29yaXRobS4KKworICAgICAgICAqIGJtYWxsb2MvRnJlZUxp c3QuaDoKKyAgICAgICAgKGJtYWxsb2M6OkZyZWVMaXN0OjpGcmVlTGlzdCk6CisgICAgICAgIChi bWFsbG9jOjpGcmVlTGlzdDo6cHVzaCk6IEludm9rZSB0aGUgR0MgaWYgd2UncmUgZ2V0dGluZyBo dWdlLgorCisgICAgICAgICogYm1hbGxvYy9MYXJnZU9iamVjdC5oOgorICAgICAgICAoYm1hbGxv Yzo6TGFyZ2VPYmplY3Q6OmlzTWFya2VkKToKKyAgICAgICAgKGJtYWxsb2M6OkxhcmdlT2JqZWN0 OjpzZXRNYXJrZWQpOgorICAgICAgICAoYm1hbGxvYzo6TGFyZ2VPYmplY3Q6OnZhbGlkYXRlU2Vs Zik6IEV4cG9zZSB0aGUgbmV3IGJpdC4KKworICAgICAgICAqIGJtYWxsb2MvU2l6ZXMuaDogTmV3 IGNvbnN0YW50IHRvIGNvbnRyb2wgR0MgZnJlcXVlbmN5LgorCiAyMDE1LTAyLTI2ICBDc2FiYSBP c3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVVJUQkYgYWZ0ZXIgcjE4 MDY5My4KSW5kZXg6IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQm91bmRhcnlUYWcuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JvdW5kYXJ5VGFnLmgJKHJldmlzaW9uIDE4 MDY4OCkKKysrIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQm91bmRhcnlUYWcuaAkod29ya2luZyBj b3B5KQpAQCAtNTEsNiArNTEsOSBAQCBwdWJsaWM6CiAKICAgICBib29sIGhhc1BoeXNpY2FsUGFn ZXMoKSB7IHJldHVybiBtX2hhc1BoeXNpY2FsUGFnZXM7IH0KICAgICB2b2lkIHNldEhhc1BoeXNp Y2FsUGFnZXMoYm9vbCBoYXNQaHlzaWNhbFBhZ2VzKSB7IG1faGFzUGh5c2ljYWxQYWdlcyA9IGhh c1BoeXNpY2FsUGFnZXM7IH0KKyAgICAKKyAgICBib29sIGlzTWFya2VkKCkgeyByZXR1cm4gbV9p c01hcmtlZDsgfQorICAgIHZvaWQgc2V0TWFya2VkKGJvb2wgaXNNYXJrZWQpIHsgbV9pc01hcmtl ZCA9IGlzTWFya2VkOyB9CiAKICAgICBib29sIGlzTnVsbCgpIHsgcmV0dXJuICFtX3NpemU7IH0K ICAgICB2b2lkIGNsZWFyKCkgeyBzdGQ6Om1lbXNldCh0aGlzLCAwLCBzaXplb2YoKnRoaXMpKTsg fQpAQCAtNjcsNyArNzAsNyBAQCBwdWJsaWM6CiAgICAgQmVnaW5UYWcqIG5leHQoKTsKIAogcHJp dmF0ZToKLSAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IGZsYWdCaXRzID0gMzsKKyAgICBzdGF0aWMg Y29uc3Qgc2l6ZV90IGZsYWdCaXRzID0gNDsKICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IGNvbXBh Y3RCZWdpbkJpdHMgPSA0OwogICAgIHN0YXRpYyBjb25zdCBzaXplX3Qgc2l6ZUJpdHMgPSBiaXRD b3VudDx1bnNpZ25lZD4oKSAtIGZsYWdCaXRzIC0gY29tcGFjdEJlZ2luQml0czsKIApAQCAtODIs NiArODUsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9pc0ZyZWU6IDE7CiAgICAgYm9vbCBtX2lz RW5kOiAxOwogICAgIGJvb2wgbV9oYXNQaHlzaWNhbFBhZ2VzOiAxOworICAgIGJvb2wgbV9pc01h cmtlZDogMTsKICAgICB1bnNpZ25lZCBtX2NvbXBhY3RCZWdpbjogY29tcGFjdEJlZ2luQml0czsK ICAgICB1bnNpZ25lZCBtX3NpemU6IHNpemVCaXRzOwogfTsKSW5kZXg6IFNvdXJjZS9ibWFsbG9j L2JtYWxsb2MvRnJlZUxpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2JtYWxs b2MvRnJlZUxpc3QuY3BwCShyZXZpc2lvbiAxODA2OTMpCisrKyBTb3VyY2UvYm1hbGxvYy9ibWFs bG9jL0ZyZWVMaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA3LDQgKzEwNywyOCBAQCBMYXJn ZU9iamVjdCBGcmVlTGlzdDo6dGFrZShzaXplX3QgYWxpZ25tCiAgICAgcmV0dXJuIGZpcnN0Owog fQogCit2b2lkIEZyZWVMaXN0OjpyZW1vdmVJbnZhbGlkQW5kRHVwbGljYXRlRW50cmllcygpCit7 CisgICAgZm9yIChzaXplX3QgaSA9IG1fdmVjdG9yLnNpemUoKTsgaS0tID4gMDsgKSB7CisgICAg ICAgIExhcmdlT2JqZWN0IGxhcmdlT2JqZWN0KExhcmdlT2JqZWN0OjpEb05vdFZhbGlkYXRlLCBt X3ZlY3RvcltpXS5iZWdpbigpKTsKKyAgICAgICAgaWYgKCFsYXJnZU9iamVjdC5pc1ZhbGlkQW5k RnJlZShtX3ZlY3RvcltpXS5zaXplKCkpKSB7CisgICAgICAgICAgICBtX3ZlY3Rvci5wb3AoaSk7 CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgbGFy Z2VPYmplY3Quc2V0TWFya2VkKGZhbHNlKTsKKyAgICB9CisKKyAgICBmb3IgKHNpemVfdCBpID0g bV92ZWN0b3Iuc2l6ZSgpOyBpLS0gPiAwOyApIHsKKyAgICAgICAgTGFyZ2VPYmplY3QgbGFyZ2VP YmplY3QoTGFyZ2VPYmplY3Q6OkRvTm90VmFsaWRhdGUsIG1fdmVjdG9yW2ldLmJlZ2luKCkpOwor ICAgICAgICBpZiAobGFyZ2VPYmplY3QuaXNNYXJrZWQoKSkgeworICAgICAgICAgICAgbV92ZWN0 b3IucG9wKGkpOworICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIH0KKworICAgICAgICBs YXJnZU9iamVjdC5zZXRNYXJrZWQodHJ1ZSk7CisgICAgfQorfQorCisKIH0gLy8gbmFtZXNwYWNl IGJtYWxsb2MKSW5kZXg6IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRnJlZUxpc3QuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0ZyZWVMaXN0LmgJKHJldmlzaW9uIDE4MDY5 MykKKysrIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRnJlZUxpc3QuaAkod29ya2luZyBjb3B5KQpA QCAtMzUsMTkgKzM1LDM1IEBAIG5hbWVzcGFjZSBibWFsbG9jIHsKIAogY2xhc3MgRnJlZUxpc3Qg ewogcHVibGljOgorICAgIEZyZWVMaXN0KCk7CisKICAgICB2b2lkIHB1c2goY29uc3QgTGFyZ2VP YmplY3QmKTsKIAogICAgIExhcmdlT2JqZWN0IHRha2Uoc2l6ZV90KTsKICAgICBMYXJnZU9iamVj dCB0YWtlKHNpemVfdCBhbGlnbm1lbnQsIHNpemVfdCwgc2l6ZV90IHVuYWxpZ25lZFNpemUpOwor ICAgIAogICAgIExhcmdlT2JqZWN0IHRha2VHcmVlZHkoc2l6ZV90KTsKKworICAgIHZvaWQgcmVt b3ZlSW52YWxpZEFuZER1cGxpY2F0ZUVudHJpZXMoKTsKICAgICAKIHByaXZhdGU6CiAgICAgVmVj dG9yPFJhbmdlPiBtX3ZlY3RvcjsKKyAgICBzaXplX3QgbV9saW1pdDsKIH07CiAKK2lubGluZSBG cmVlTGlzdDo6RnJlZUxpc3QoKQorICAgIDogbV92ZWN0b3IoKQorICAgICwgbV9saW1pdChmcmVl TGlzdFNlYXJjaERlcHRoKQoreworfQorCiBpbmxpbmUgdm9pZCBGcmVlTGlzdDo6cHVzaChjb25z dCBMYXJnZU9iamVjdCYgbGFyZ2VPYmplY3QpCiB7CiAgICAgQkFTU0VSVChsYXJnZU9iamVjdC5p c0ZyZWUoKSk7CisgICAgaWYgKG1fdmVjdG9yLnNpemUoKSA9PSBtX2xpbWl0KSB7CisgICAgICAg IHJlbW92ZUludmFsaWRBbmREdXBsaWNhdGVFbnRyaWVzKCk7CisgICAgICAgIG1fbGltaXQgPSBz dGQ6Om1heChtX3ZlY3Rvci5zaXplKCkgKiBmcmVlTGlzdEdyb3dGYWN0b3IsIGZyZWVMaXN0U2Vh cmNoRGVwdGgpOworICAgIH0KICAgICBtX3ZlY3Rvci5wdXNoKGxhcmdlT2JqZWN0LnJhbmdlKCkp OwogfQogCkluZGV4OiBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0xhcmdlT2JqZWN0LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9MYXJnZU9iamVjdC5oCShyZXZpc2lvbiAx ODA2OTMpCisrKyBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0xhcmdlT2JqZWN0LmgJKHdvcmtpbmcg Y29weSkKQEAgLTU1LDYgKzU1LDkgQEAgcHVibGljOgogICAgIGJvb2wgaGFzUGh5c2ljYWxQYWdl cygpIGNvbnN0OwogICAgIHZvaWQgc2V0SGFzUGh5c2ljYWxQYWdlcyhib29sKSBjb25zdDsKICAg ICAKKyAgICBib29sIGlzTWFya2VkKCkgY29uc3Q7CisgICAgdm9pZCBzZXRNYXJrZWQoYm9vbCkg Y29uc3Q7CisgICAgCiAgICAgYm9vbCBpc1ZhbGlkQW5kRnJlZShzaXplX3QpIGNvbnN0OwogCiAg ICAgTGFyZ2VPYmplY3QgbWVyZ2UoKSBjb25zdDsKQEAgLTEyNiw2ICsxMjksMTkgQEAgaW5saW5l IHZvaWQgTGFyZ2VPYmplY3Q6OnNldEhhc1BoeXNpY2FsUAogICAgIG1fZW5kVGFnLT5zZXRIYXNQ aHlzaWNhbFBhZ2VzKGhhc1BoeXNpY2FsUGFnZXMpOwogfQogCitpbmxpbmUgYm9vbCBMYXJnZU9i amVjdDo6aXNNYXJrZWQoKSBjb25zdAoreworICAgIHZhbGlkYXRlKCk7CisgICAgcmV0dXJuIG1f YmVnaW5UYWctPmlzTWFya2VkKCk7Cit9CisKK2lubGluZSB2b2lkIExhcmdlT2JqZWN0OjpzZXRN YXJrZWQoYm9vbCBpc01hcmtlZCkgY29uc3QKK3sKKyAgICB2YWxpZGF0ZSgpOworICAgIG1fYmVn aW5UYWctPnNldE1hcmtlZChpc01hcmtlZCk7CisgICAgbV9lbmRUYWctPnNldE1hcmtlZChpc01h cmtlZCk7Cit9CisKIGlubGluZSBib29sIExhcmdlT2JqZWN0Ojppc1ZhbGlkQW5kRnJlZShzaXpl X3QgZXhwZWN0ZWRTaXplKSBjb25zdAogewogICAgIGlmICghbV9iZWdpblRhZy0+aXNGcmVlKCkp CkBAIC0yMjMsNiArMjM5LDcgQEAgaW5saW5lIHZvaWQgTGFyZ2VPYmplY3Q6OnZhbGlkYXRlU2Vs ZigpIAogICAgIEJBU1NFUlQobV9iZWdpblRhZy0+c2l6ZSgpID09IG1fZW5kVGFnLT5zaXplKCkp OwogICAgIEJBU1NFUlQobV9iZWdpblRhZy0+aXNGcmVlKCkgPT0gbV9lbmRUYWctPmlzRnJlZSgp KTsKICAgICBCQVNTRVJUKG1fYmVnaW5UYWctPmhhc1BoeXNpY2FsUGFnZXMoKSA9PSBtX2VuZFRh Zy0+aGFzUGh5c2ljYWxQYWdlcygpKTsKKyAgICBCQVNTRVJUKG1fYmVnaW5UYWctPmlzTWFya2Vk KCkgPT0gbV9lbmRUYWctPmlzTWFya2VkKCkpOwogfQogCiBpbmxpbmUgdm9pZCBMYXJnZU9iamVj dDo6dmFsaWRhdGUoKSBjb25zdApJbmRleDogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TaXplcy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvU2l6ZXMuaAkocmV2aXNpb24g MTgwNjkzKQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TaXplcy5oCSh3b3JraW5nIGNvcHkp CkBAIC04Miw2ICs4Miw3IEBAIG5hbWVzcGFjZSBTaXplcyB7CiAgICAgc3RhdGljIGNvbnN0IHNp emVfdCB4TGFyZ2VBbGlnbm1lbnQgPSB2bVBhZ2VTaXplOwogCiAgICAgc3RhdGljIGNvbnN0IHNp emVfdCBmcmVlTGlzdFNlYXJjaERlcHRoID0gMTY7CisgICAgc3RhdGljIGNvbnN0IHNpemVfdCBm cmVlTGlzdEdyb3dGYWN0b3IgPSAyOwogCiAgICAgc3RhdGljIGNvbnN0IHVpbnRwdHJfdCB0eXBl TWFzayA9IChzdXBlckNodW5rU2l6ZSAtIDEpICYgfigoc3VwZXJDaHVua1NpemUgLyA0KSAtIDEp OyAvLyA0IHRhZ2dhYmxlIGNodW5rcwogICAgIHN0YXRpYyBjb25zdCB1aW50cHRyX3Qgc21hbGxU eXBlID0gKHN1cGVyQ2h1bmtTaXplICsgc21hbGxDaHVua09mZnNldCkgJiB0eXBlTWFzazsK