142047 2015-02-26 11:05:35 -0800 Make WKPageGroupRemoveAllUserContentFilters actually remove all user content filters 2015-02-26 11:30:19 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson ggaren oldest_to_newest 1072436 0 beidson 2015-02-26 11:05:35 -0800 Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters http://trac.webkit.org/changeset/178869 added this SPI but implemented it incorrectly. 1072437 1 247433 beidson 2015-02-26 11:10:48 -0800 Created attachment 247433 Patch v1 1072440 2 247433 ggaren 2015-02-26 11:28:05 -0800 Comment on attachment 247433 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=247433&action=review r=me Plz fix tyop. > LayoutTests/ChangeLog:3 > + Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters Should be "remove". > Source/WebKit2/ChangeLog:3 > + Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters Should be "remove". > Source/WebKit2/UIProcess/API/C/WKPageGroup.cpp:95 > + toImpl(pageGroupRef)->removeAllUserContentFilters(); lol 1072442 3 beidson 2015-02-26 11:30:19 -0800 http://trac.webkit.org/changeset/180687 247433 2015-02-26 11:10:48 -0800 2015-02-26 11:28:05 -0800 Patch v1 patch text/plain 2463 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwODExNzM0Li4wOTdkZDkyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMDIt MjYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgV0tQ YWdlR3JvdXBSZW1vdmVBbGxVc2VyQ29udGVudEZpbHRlcnMgYWN0dWFsbHkgcmVtb3RlIGFsbCB1 c2VyIGNvbnRlbnQgZmlsdGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQyMDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbmFibGUg Y29udGVudCBmaWx0ZXIgdGVzdHMsIGFzIHRoZXkgc2hvdWxkIG5vIGxvbmdlciBpbnRlcmZlcmUg d2l0aCBvdGhlcnMuCisKIDIwMTUtMDItMjYgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxs YXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbnVwIFJlbmRlclNWR1Jlc291cmNlQ2xpcHBl ciBjbGFzcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4 cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9u cwppbmRleCA2MTAwNzZlLi5mZDRjMWQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj LXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC01MTYsMyArNTE2LDUgQEAgd2Via2l0Lm9yZy9iLzE0 MTA4NSBbIFlvc2VtaXRlIF0gaHR0cC90ZXN0cy9tZWRpYS92aWRlby1xdWVyeS11cmwuaHRtbCBb IFBhc3MgVGkKIAogIyMjIEVORCBPRiAoNykgTmV3IFdlYktpdDItb25seSBmYWlsdXJlcyBpbiBZ b3NlbWl0ZQogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIworCitodHRw L3Rlc3RzL3VzZXJjb250ZW50ZmlsdGVyIFsgUGFzcyBdClwgTm8gbmV3bGluZSBhdCBlbmQgb2Yg ZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCmluZGV4IGQ1OTI4NGMuLjAyNjc4NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMyBAQAorMjAxNS0wMi0yNiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisK KyAgICAgICAgTWFrZSBXS1BhZ2VHcm91cFJlbW92ZUFsbFVzZXJDb250ZW50RmlsdGVycyBhY3R1 YWxseSByZW1vdGUgYWxsIHVzZXIgY29udGVudCBmaWx0ZXJzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIwNDcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2VHcm91 cC5jcHA6CisgICAgICAgIChXS1BhZ2VHcm91cFJlbW92ZUFsbFVzZXJDb250ZW50RmlsdGVycyk6 IFJlbW92ZSBhbGwgY29udGVudCBmaWx0ZXJzIGluc3RlYWQgb2YgcmVtb3ZpbmcgYWxsIHVzZXIg c2NyaXB0cy4KKwogMjAxNS0wMi0yNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCAodW51c2VkIGZvciBub3cpIGNvZGUgdG8gZGVsZXRlIHdlYnNp dGUgZGF0YSBmb3IgYSBzZXQgb2Ygb3JpZ2lucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL1dLUGFnZUdyb3VwLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQy9XS1BhZ2VHcm91cC5jcHAKaW5kZXggYmJjZWY5Ny4uMzUwZDVkNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZUdyb3VwLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlR3JvdXAuY3BwCkBAIC05Miw3ICs5 Miw3IEBAIHZvaWQgV0tQYWdlR3JvdXBBZGRVc2VyQ29udGVudEZpbHRlcihXS1BhZ2VHcm91cFJl ZiBwYWdlR3JvdXBSZWYsIFdLVXNlckNvbnRlbnRGCiB2b2lkIFdLUGFnZUdyb3VwUmVtb3ZlQWxs VXNlckNvbnRlbnRGaWx0ZXJzKFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cFJlZikKIHsKICNpZiBF TkFCTEUoQ09OVEVOVF9FWFRFTlNJT05TKQotICAgIHRvSW1wbChwYWdlR3JvdXBSZWYpLT5yZW1v dmVBbGxVc2VyU2NyaXB0cygpOworICAgIHRvSW1wbChwYWdlR3JvdXBSZWYpLT5yZW1vdmVBbGxV c2VyQ29udGVudEZpbHRlcnMoKTsKICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKHBhZ2VHcm91cFJl Zik7CiAjZW5kaWYK