142044 2015-02-26 06:37:22 -0800 [FreeType] REGRESSION(r180563): Introduced crashes 2015-02-26 08:25:03 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue mcatanzaro mmaxfield mrobinson zan oldest_to_newest 1072363 0 mcatanzaro 2015-02-26 06:37:22 -0800 Zan noticed the following after r180563: > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:307 > - cairo_font_options_t* options = getDefaultFontOptions(); > + cairo_font_options_t* options = getDefaultCairoFontOptions(); > + FcPattern* optionsPattern = m_pattern ? m_pattern.get() : getDefaultFontconfigOptions(); > + setCairoFontOptionsFromFontConfigPattern(options, optionsPattern); This properly checks for and works around the possibly-null m_pattern ... > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:324 > + for (int i = 0; FcPatternGetMatrix(m_pattern.get(), FC_MATRIX, i, &tempFontConfigMatrix) == FcResultMatch; i++) > + FcMatrixMultiply(&fontConfigMatrix, &fontConfigMatrix, tempFontConfigMatrix); ... but this doesn't anymore (though it used to), which leads to crashes. It should be using optionsPattern rather than m_pattern. 1072378 1 247426 mcatanzaro 2015-02-26 07:30:50 -0800 Created attachment 247426 Patch 1072381 2 247426 commit-queue 2015-02-26 08:24:59 -0800 Comment on attachment 247426 Patch Clearing flags on attachment: 247426 Committed r180675: <http://trac.webkit.org/changeset/180675> 1072382 3 commit-queue 2015-02-26 08:25:03 -0800 All reviewed patches have been landed. Closing bug. 247426 2015-02-26 07:30:50 -0800 2015-02-26 08:24:59 -0800 Patch bug-142044-20150226093037.patch text/plain 2514 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzNhYTE0MjhmYjYzNzU3 M2EzMzllNGRmYjNhYzdhNmM4ZjcyOWNjZS4uYjM5MjRlNTVkNTcwYWU1ZWFjNTU2MzU2YjYwZjdl OGJkNGI4NmZiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTI2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbRnJlZVR5 cGVdIFJFR1JFU1NJT04ocjE4MDU2Myk6IEludHJvZHVjZWQgY3Jhc2hlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMDQ0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaG91bGQg YmUgY2F1Z2h0IGJ5IGFueSB3b2ZmIGZvbnQgdGVzdC4KKworICAgICAgICBVc2Ugb3B0aW9uc1Bh dHRlcm4sIG5vdCBtX3BhdHRlcm4sIHdoZW4gbV9wYXR0ZXJuIG1heSBiZSBudWxsLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3JtRGF0YUZyZWVUeXBl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OmluaXRpYWxpemVXaXRo Rm9udEZhY2UpOgorCiAyMDE1LTAyLTI0ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TIE1lZGlhXSBCZSBzcGVjaWZpYyBhYm91dCB3aGljaCBkb2N1bWVudCB0 byB1c2UgZm9yIHRoZSB0aW1lbGluZSBiYWNrZ3JvdW5kIGNhbnZhcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3JtRGF0YUZy ZWVUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0Zv bnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAKaW5kZXggNTM4YzliMjFiODVlY2JlZjE3NzYzMTMz MjJjNDFiYTY0NDFiMDI2YS4uZTljNWYyOGY1MTk5ZWI0NDIzY2Y0NDg3ODk3YzMyZjNkZjhhMGU3 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUv Rm9udFBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCkBAIC0zMjAs MTQgKzMyMCwxNCBAQCB2b2lkIEZvbnRQbGF0Zm9ybURhdGE6OmluaXRpYWxpemVXaXRoRm9udEZh Y2UoY2Fpcm9fZm9udF9mYWNlX3QqIGZvbnRGYWNlLCBjb25zdAogICAgIEZjTWF0cml4SW5pdCgm Zm9udENvbmZpZ01hdHJpeCk7CiAKICAgICAvLyBUaGVzZSBtYXRyaWNlcyBtYXkgYmUgc3RhY2tl ZCBpbiB0aGUgcGF0dGVybiwgc28gaXQncyBvdXIgam9iIHRvIGdldCB0aGVtIGFsbCBhbmQgbXVs dGlwbHkgdGhlbS4KLSAgICBmb3IgKGludCBpID0gMDsgRmNQYXR0ZXJuR2V0TWF0cml4KG1fcGF0 dGVybi5nZXQoKSwgRkNfTUFUUklYLCBpLCAmdGVtcEZvbnRDb25maWdNYXRyaXgpID09IEZjUmVz dWx0TWF0Y2g7IGkrKykKKyAgICBmb3IgKGludCBpID0gMDsgRmNQYXR0ZXJuR2V0TWF0cml4KG9w dGlvbnNQYXR0ZXJuLCBGQ19NQVRSSVgsIGksICZ0ZW1wRm9udENvbmZpZ01hdHJpeCkgPT0gRmNS ZXN1bHRNYXRjaDsgaSsrKQogICAgICAgICBGY01hdHJpeE11bHRpcGx5KCZmb250Q29uZmlnTWF0 cml4LCAmZm9udENvbmZpZ01hdHJpeCwgdGVtcEZvbnRDb25maWdNYXRyaXgpOwogICAgIGNhaXJv X21hdHJpeF9pbml0KCZmb250TWF0cml4LCBmb250Q29uZmlnTWF0cml4Lnh4LCAtZm9udENvbmZp Z01hdHJpeC55eCwKICAgICAgICAgLWZvbnRDb25maWdNYXRyaXgueHksIGZvbnRDb25maWdNYXRy aXgueXksIDAsIDApOwogCiAgICAgLy8gV2UgcmVxdWVzdGVkIGFuIGl0YWxpYyBmb250LCBidXQg Rm9udGNvbmZpZyBnYXZlIHVzIG9uZSB0aGF0IHdhcyBuZWl0aGVyIG9ibGlxdWUgbm9yIGl0YWxp Yy4KICAgICBpbnQgYWN0dWFsRm9udFNsYW50OwotICAgIGlmIChmb250RGVzY3JpcHRpb24uaXRh bGljKCkgJiYgRmNQYXR0ZXJuR2V0SW50ZWdlcihtX3BhdHRlcm4uZ2V0KCksIEZDX1NMQU5ULCAw LCAmYWN0dWFsRm9udFNsYW50KSA9PSBGY1Jlc3VsdE1hdGNoKQorICAgIGlmIChmb250RGVzY3Jp cHRpb24uaXRhbGljKCkgJiYgRmNQYXR0ZXJuR2V0SW50ZWdlcihvcHRpb25zUGF0dGVybiwgRkNf U0xBTlQsIDAsICZhY3R1YWxGb250U2xhbnQpID09IEZjUmVzdWx0TWF0Y2gpCiAgICAgICAgIG1f c3ludGhldGljT2JsaXF1ZSA9IGFjdHVhbEZvbnRTbGFudCA9PSBGQ19TTEFOVF9ST01BTjsKIAog ICAgIC8vIFRoZSBtYXRyaXggZnJvbSBGb250Q29uZmlnIGRvZXMgbm90IGluY2x1ZGUgdGhlIHNj YWxlLiAK