142043 2015-02-26 06:06:01 -0800 [webkitpy] Remove unused functions from git.py 2015-02-26 10:29:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 ossy ossy commit-queue dbates glenn matthew_hanson ossy rniwa oldest_to_newest 1072352 0 ossy 2015-02-26 06:06:01 -0800 [webkitpy] Remove unused functions from git.py 1072353 1 247423 ossy 2015-02-26 06:06:15 -0800 Created attachment 247423 Patch 1072354 2 ossy 2015-02-26 06:08:44 -0800 These functions were added by http://trac.webkit.org/changeset/175606 and http://trac.webkit.org/changeset/175605 , but weren't used ever. Let's remove them. 1072398 3 247423 rniwa 2015-02-26 09:39:12 -0800 Comment on attachment 247423 Patch Oh, I think these are used by Apple internal tools. 1072404 4 ossy 2015-02-26 09:41:38 -0800 It would be great to have a reference to it somewhere. 1072417 5 matthew_hanson 2015-02-26 10:19:42 -0800 I hear what you're saying, Csaba. But can't it also be useful in and of itself? E.g. for use in personal workflow automation scripts? The git.py module is supposed to be an interface to the Git tool, and cherrypick merging is something that a person with a merge-based workflow would use fairly often. 1072421 6 ossy 2015-02-26 10:29:12 -0800 (In reply to comment #5) > I hear what you're saying, Csaba. But can't it also be useful in and of > itself? E.g. for use in personal workflow automation scripts? Of course it can be. But I thought git.py is only used by webkitpy scripts, that's why thought it is unused. > The git.py module is supposed to be an interface to the Git tool, and > cherrypick merging is something that a person with a merge-based workflow > would use fairly often. See. I could imagine a publicly available webkit-patch cherry-pick <svn-revision> command. I assume you use these functions for similar use-case. 247423 2015-02-26 06:06:15 -0800 2015-02-26 09:39:12 -0800 Patch bug-142043-20150226060601.patch text/plain 2166 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNjcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmI2MGJhN2M4YTQ3NmI2Y2FmMGY2M2Q0MDhkMmVhZmNk ZGQ4YThjMy4uZWU5NWFhYWE1ZTRlNTI2ZDFhYjFjYTFjYjg0MmZlNjE3YjM5YTRhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTAyLTI2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW3dlYmtpdHB5XSBSZW1vdmUgdW51c2VkIGZ1bmN0aW9ucyBmcm9tIGdpdC5weQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMDQzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vZ2l0LnB5OgorICAgICAgICAoR2l0LnN2bl9y ZXZpc2lvbik6CisgICAgICAgIChHaXQucmVtb3RlX2JyYW5jaF9yZWYpOgorICAgICAgICAoR2l0 LnN2bl91cmwpOiBEZWxldGVkLgorICAgICAgICAoR2l0LmNoZXJyeXBpY2tfbWVyZ2UpOiBEZWxl dGVkLgorCiAyMDE1LTAyLTI1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgog CiAgICAgICAgIFtXaW5dIFVzZSBXRUJDT1JFX0VYUE9SVCBpbnN0ZWFkIG9mIERlZmluaXRpb24g ZmlsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQv c2NtL2dpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9n aXQucHkKaW5kZXggYWFkNmVhZGIyOTYzMGM1NzkyZmEwMTUwYmM4NmZiYmU4Nzc5MWJlZi4uNzcy Zjg1YzIwODIyMjVkMjNmZjg2YmQ2Yjc1Y2EzODkxN2E1YTc4YyAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL2dpdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vZ2l0LnB5CkBAIC0yNzIsMTQgKzI3 Miw2IEBAIGNsYXNzIEdpdChTQ00sIFNWTlJlcG9zaXRvcnkpOgogICAgICAgICAgICAgcmV0dXJu ICIiCiAgICAgICAgIHJldHVybiBzdHIobWF0Y2guZ3JvdXAoJ3N2bl9yZXZpc2lvbicpKQogCi0g ICAgZGVmIHN2bl91cmwoc2VsZik6Ci0gICAgICAgIGdpdF9jb21tYW5kID0gWydzdm4nLCAnaW5m byddCi0gICAgICAgIHN0YXR1cyA9IHNlbGYuX3J1bl9naXQoZ2l0X2NvbW1hbmQpCi0gICAgICAg IG1hdGNoID0gcmUuc2VhcmNoKHInXlVSTDogKD9QPHVybD4uKikkJywgc3RhdHVzLCByZS5NVUxU SUxJTkUpCi0gICAgICAgIGlmIG5vdCBtYXRjaDoKLSAgICAgICAgICAgIHJldHVybiAiIgotICAg ICAgICByZXR1cm4gbWF0Y2guZ3JvdXAoJ3VybCcpCi0KICAgICBkZWYgdGltZXN0YW1wX29mX3Jl dmlzaW9uKHNlbGYsIHBhdGgsIHJldmlzaW9uKToKICAgICAgICAgZ2l0X2xvZyA9IHNlbGYuX21v c3RfcmVjZW50X2xvZ19tYXRjaGluZygnZ2l0LXN2bi1pZDouKkAlcycgJSByZXZpc2lvbiwgcGF0 aCkKICAgICAgICAgbWF0Y2ggPSByZS5zZWFyY2goIl5EYXRlOlxzKihcZHs0fSktKFxkezJ9KS0o XGR7Mn0pIChcZHsyfSk6KFxkezJ9KTooXGR7Mn0pIChbKy1dKShcZHsyfSkoXGR7Mn0pJCIsIGdp dF9sb2csIHJlLk1VTFRJTElORSkKQEAgLTQ5NSwxMCArNDg3LDYgQEAgY2xhc3MgR2l0KFNDTSwg U1ZOUmVwb3NpdG9yeSk6CiAgICAgICAgIGZpcnN0X3JlbW90ZV9icmFuY2hfcmVmID0gcmVtb3Rl X2JyYW5jaF9yZWZzLnNwbGl0KCdcbicpWzBdCiAgICAgICAgIHJldHVybiBmaXJzdF9yZW1vdGVf YnJhbmNoX3JlZi5zcGxpdCgnOicpWzFdCiAKLSAgICBkZWYgY2hlcnJ5cGlja19tZXJnZShzZWxm LCBjb21taXQpOgotICAgICAgICBnaXRfYXJncyA9IFsnY2hlcnJ5LXBpY2snLCAnLW4nLCBjb21t aXRdCi0gICAgICAgIHJldHVybiBzZWxmLl9ydW5fZ2l0KGdpdF9hcmdzKQotCiAgICAgZGVmIGNv bW1pdF9sb2NhbGx5X3dpdGhfbWVzc2FnZShzZWxmLCBtZXNzYWdlKToKICAgICAgICAgc2VsZi5f cnVuX2dpdChbJ2NvbW1pdCcsICctLWFsbCcsICctRicsICctJ10sIGlucHV0PW1lc3NhZ2UpCiAK