142017 2015-02-25 09:33:18 -0800 [Win] [Attachment] New Tests fail on Windows 2015-03-04 09:37:37 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 141993 1 bfulgham bfulgham bfulgham sam thorton oldest_to_newest 1072073 0 bfulgham 2015-02-25 09:33:18 -0800 The new <attachment> stuff added in <https://trac.webkit.org/changeset/180601> does not seem to work properly on Windows. The following layout test is failing on Windows fast/attachment/attachment-dom.html The Failing looks like the following: --- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-dom-expected.txt +++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-dom-actual.txt @@ -1,14 +1,10 @@ +CONSOLE MESSAGE: line 1: ReferenceError: Can't find variable: HTMLAttachmentElement This tests that attachments have an instance type of HTMLElement. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS attachment is an instance of HTMLAttachmentElement -PASS attachment.file is null -Setting attachment.file to a file created from resources/test-file.txt -PASS attachment.file is file -PASS attachment.file.name is 'test-file.txt' -PASS successfullyParsed is true +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). TEST COMPLETE 1072074 1 bfulgham 2015-02-25 09:36:27 -0800 Failing test skipped on Windows in r180629. <https://trac.webkit.org/r180629> 1073968 2 bfulgham 2015-03-03 21:29:32 -0800 Committed r180990: <http://trac.webkit.org/changeset/180990> 1073969 3 bfulgham 2015-03-03 21:30:19 -0800 This needed two things: 1. Activate the feature on Windows. 2. Update baselines for Windows display metrics. 1074017 4 ap 2015-03-04 00:53:03 -0800 This broke Windows build: 1>C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\css\CSSPrimitiveValueMappings.h(613): error C2065: 'CSSValueAttachment' : undeclared identifier (C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj32\WebCore\DerivedSources\StyleBuilder.cpp) 1074096 5 bfulgham 2015-03-04 09:37:37 -0800 (In reply to comment #4) > This broke Windows build: > > > 1>C:\cygwin\home\buildbot\slave\win- > release\build\Source\WebCore\css\CSSPrimitiveValueMappings.h(613): error > C2065: 'CSSValueAttachment' : undeclared identifier > (C:\cygwin\home\buildbot\slave\win- > release\build\WebKitBuild\Release\obj32\WebCore\DerivedSources\StyleBuilder. > cpp) Fixed with a clean build. But see also Bug 142284, where we are fixing this problem permanently.