142013 2015-02-25 01:35:21 -0800 W3C test importer should use argparse instead of optparse 2015-02-25 13:05:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf bjonesbe commit-queue glenn oldest_to_newest 1072015 0 youennf 2015-02-25 01:35:21 -0800 Using argparse makes it easier for other python scripts to set correctly test importer options without calling the script as executable. One user would be the test conformance runner (bug 134766). 1072016 1 247324 youennf 2015-02-25 01:54:19 -0800 Created attachment 247324 Patch 1072082 2 247324 bjonesbe 2015-02-25 10:04:23 -0800 Comment on attachment 247324 Patch r=me 1072109 3 247324 commit-queue 2015-02-25 13:05:53 -0800 Comment on attachment 247324 Patch Clearing flags on attachment: 247324 Committed r180635: <http://trac.webkit.org/changeset/180635> 1072110 4 commit-queue 2015-02-25 13:05:57 -0800 All reviewed patches have been landed. Closing bug. 247324 2015-02-25 01:54:19 -0800 2015-02-25 13:05:53 -0800 Patch bug-142013-20150225105406.patch text/plain 3603 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2Q4M2E5OTk2Y2M0MDA4ZDcyODM5YzBlOGQ4YzUzZjA1 YzE3ODY4My4uMGVmYzQ2ZTFiZTk4ZDY2NTY4NDhkOWQxY2QyYjFiMjI5ZDI0NzYyNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTAyLTI1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CisKKyAgICAgICAgVzNDIHRlc3QgaW1wb3J0ZXIgc2hvdWxkIHVzZSBhcmdwYXJzZSBpbnN0 ZWFkIG9mIG9wdHBhcnNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDIwMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHk6CisgICAgICAg IChtYWluKTogVXBkYXRpbmcgYWNjb3JkaW5nIGFyZ3BhcnNlLgorICAgICAgICAocGFyc2VfYXJn cyk6IE1vdmluZyBmcm9tIG9wdHBhcnNlIHRvIGFyZ3BhcnNlLgorCiAyMDE1LTAyLTIxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgVGVzdHMg ZG9uJ3Qgd29yayBvbiBzb21lIGJvdHM6IEZhaWxlZCB0byBzdG9wIHdwdHdrCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2ltcG9ydGVyLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS93M2MvdGVzdF9pbXBvcnRlci5weQppbmRleCBlMWY0ZDMwNWI0YzEyZThj YWZiMzE2MjA5MjY2YTM1Y2Q2ZTJlYjQzLi4xMmI0OTkwZDNmMTM2MzA5NzVjMGUzN2NjMmQ0MDQy NGM3ZDVjZmIxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2lt cG9ydGVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIu cHkKQEAgLTcwLDEwICs3MCwxMCBAQAogCiAjIEZJWE1FOiBDaGFuZ2UgdGhpcyBmaWxlIHRvIHVz ZSB0aGUgSG9zdCBhYnN0cmFjdGlvbnMgcmF0aGVyIHRoYXQgb3MsIHN5cywgc2h1dGlscywgZXRj LgogCitpbXBvcnQgYXJncGFyc2UKIGltcG9ydCBkYXRldGltZQogaW1wb3J0IGxvZ2dpbmcKIGlt cG9ydCBtaW1ldHlwZXMKLWltcG9ydCBvcHRwYXJzZQogaW1wb3J0IG9zCiBpbXBvcnQgc2h1dGls CiBpbXBvcnQgc3lzCkBAIC05MCw3ICs5MCw3IEBAIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihf X25hbWVfXykKIAogCiBkZWYgbWFpbihfYXJndiwgX3N0ZG91dCwgX3N0ZGVycik6Ci0gICAgb3B0 aW9ucywgYXJncyA9IHBhcnNlX2FyZ3MoKQorICAgIG9wdGlvbnMsIGFyZ3MgPSBwYXJzZV9hcmdz KF9hcmd2KQogICAgIGltcG9ydF9kaXIgPSBhcmdzWzBdCiAKICAgICBpZiBub3Qgb3MucGF0aC5l eGlzdHMoaW1wb3J0X2Rpcik6CkBAIC0xMTgsMjIgKzExOCwyMiBAQCBkZWYgY29uZmlndXJlX2xv Z2dpbmcoKToKICAgICByZXR1cm4gaGFuZGxlcgogCiAKLWRlZiBwYXJzZV9hcmdzKCk6Ci0gICAg cGFyc2VyID0gb3B0cGFyc2UuT3B0aW9uUGFyc2VyKHVzYWdlPSd1c2FnZTogJXByb2cgW29wdGlv bnNdIHczY190ZXN0X2RpcmVjdG9yeScpCitkZWYgcGFyc2VfYXJncyhhcmdzKToKKyAgICBwYXJz ZXIgPSBhcmdwYXJzZS5Bcmd1bWVudFBhcnNlcihwcm9nPSdpbXBvcnQtdzNjLXRlc3RzIHczY190 ZXN0X3NvdXJjZV9kaXJlY3RvcnknKQogCi0gICAgcGFyc2VyLmFkZF9vcHRpb24oJy1uJywgJy0t bm8tb3ZlcndyaXRlJywgZGVzdD0nb3ZlcndyaXRlJywgYWN0aW9uPSdzdG9yZV9mYWxzZScsIGRl ZmF1bHQ9VHJ1ZSwKKyAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCctbicsICctLW5vLW92ZXJ3cml0 ZScsIGRlc3Q9J292ZXJ3cml0ZScsIGFjdGlvbj0nc3RvcmVfZmFsc2UnLCBkZWZhdWx0PVRydWUs CiAgICAgICAgIGhlbHA9J0ZsYWcgdG8gcHJldmVudCBkdXBsaWNhdGUgdGVzdCBmaWxlcyBmcm9t IG92ZXJ3cml0aW5nIGV4aXN0aW5nIHRlc3RzLiBCeSBkZWZhdWx0LCB0aGV5IHdpbGwgYmUgb3Zl cndyaXR0ZW4nKQotICAgIHBhcnNlci5hZGRfb3B0aW9uKCctbCcsICctLW5vLWxpbmtzLWNvbnZl cnNpb24nLCBkZXN0PSdjb252ZXJ0X3Rlc3RfaGFybmVzc19saW5rcycsIGFjdGlvbj0nc3RvcmVf ZmFsc2UnLCBkZWZhdWx0PVRydWUsCisgICAgcGFyc2VyLmFkZF9hcmd1bWVudCgnLWwnLCAnLS1u by1saW5rcy1jb252ZXJzaW9uJywgZGVzdD0nY29udmVydF90ZXN0X2hhcm5lc3NfbGlua3MnLCBh Y3Rpb249J3N0b3JlX2ZhbHNlJywgZGVmYXVsdD1UcnVlLAogICAgICAgICBoZWxwPSdEbyBub3Qg Y2hhbmdlIGxpbmtzICh0ZXN0aGFybmVzcyBqcyBvciBjc3MgZS5nLikuIEJ5IGRlZmF1bHQsIGxp bmtzIGFyZSBjb252ZXJ0ZWQgdG8gcG9pbnQgdG8gV2ViS2l0IHRlc3RoYXJuZXNzIGZpbGVzLicp CiAKLSAgICBwYXJzZXIuYWRkX29wdGlvbignLWEnLCAnLS1hbGwnLCBhY3Rpb249J3N0b3JlX3Ry dWUnLCBkZWZhdWx0PUZhbHNlLAorICAgIHBhcnNlci5hZGRfYXJndW1lbnQoJy1hJywgJy0tYWxs JywgYWN0aW9uPSdzdG9yZV90cnVlJywgZGVmYXVsdD1GYWxzZSwKICAgICAgICAgaGVscD0nSW1w b3J0IGFsbCB0ZXN0cyBpbmNsdWRpbmcgcmVmdGVzdHMsIEpTIHRlc3RzLCBhbmQgbWFudWFsL3Bp eGVsIHRlc3RzLiBCeSBkZWZhdWx0LCBvbmx5IHJlZnRlc3RzIGFuZCBKUyB0ZXN0cyBhcmUgaW1w b3J0ZWQnKQotICAgIHBhcnNlci5hZGRfb3B0aW9uKCctZCcsICctLWRlc3QtZGlyJywgZGVzdD0n ZGVzdGluYXRpb24nLCBkZWZhdWx0PSd3M2MnLAorICAgIHBhcnNlci5hZGRfYXJndW1lbnQoJy1k JywgJy0tZGVzdC1kaXInLCBkZXN0PSdkZXN0aW5hdGlvbicsIGRlZmF1bHQ9J3czYycsCiAgICAg ICAgIGhlbHA9J0ltcG9ydCBpbnRvIGEgc3BlY2lmaWVkIGRpcmVjdG9yeSByZWxhdGl2ZSB0byB0 aGUgTGF5b3V0VGVzdHMgcm9vdC4gQnkgZGVmYXVsdCwgaW1wb3J0cyBpbnRvIHczYycpCi0gICAg cGFyc2VyLmFkZF9vcHRpb24oJy10JywgJy0tdGVzdC1wYXRoJywgYWN0aW9uPSdhcHBlbmQnLCBk ZXN0PSd0ZXN0X3BhdGhzJywgZGVmYXVsdD1bXSwKKyAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCct dCcsICctLXRlc3QtcGF0aCcsIGFjdGlvbj0nYXBwZW5kJywgZGVzdD0ndGVzdF9wYXRocycsIGRl ZmF1bHQ9W10sCiAgICAgICAgIGhlbHA9J0ltcG9ydCBvbmx5IHRlc3RzIGluIHRoZSBzdXBwbGll ZCBzdWJkaXJlY3Rvcnkgb2YgdGhlIHczY190ZXN0X2RpcmVjdG9yeS4gQ2FuIGJlIHN1cHBsaWVk IG11bHRpcGxlIHRpbWVzIHRvIGdpdmUgbXVsdGlwbGUgcGF0aHMnKQogCi0gICAgb3B0aW9ucywg YXJncyA9IHBhcnNlci5wYXJzZV9hcmdzKCkKKyAgICBvcHRpb25zLCBhcmdzID0gcGFyc2VyLnBh cnNlX2tub3duX2FyZ3MoYXJncykKICAgICBpZiBsZW4oYXJncykgIT0gMToKICAgICAgICAgcGFy c2VyLmVycm9yKCdJbmNvcnJlY3QgbnVtYmVyIG9mIGFyZ3VtZW50cycpCiAgICAgcmV0dXJuIG9w dGlvbnMsIGFyZ3MK