141989 2015-02-24 15:29:00 -0800 CMake build of libllvmForJSC.so should limit its export list like the Xcode build does 2015-02-24 23:00:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue ossy oldest_to_newest 1071815 0 fpizlo 2015-02-24 15:29:00 -0800 Our Xcode build of libllvmForJSC.dylib only exports one symbol. This protects our LLVM instance from having any interaction with other LLVMs that might be linked by the client. We do it in Configurations/LLVMForJSC.xcconfig: OTHER_LDFLAGS_HIDE_SYMBOLS = -Wl,-exported_symbol -Wl,_initializeAndGetJSCLLVMAPI -Wl,-all_load; Looking at libllvmForJSC.so, it's clear that it's exporting the world. I just did an nm on it and there are many symbols with uppercase letter codes, indicating that they are global. 1071942 1 247303 fpizlo 2015-02-24 20:49:08 -0800 Created attachment 247303 Patch 1071943 2 247304 fpizlo 2015-02-24 20:49:55 -0800 Created attachment 247304 Patch 1071969 3 247304 gyuyoung.kim 2015-02-24 22:15:07 -0800 Comment on attachment 247304 Patch LGTM 1071977 4 247304 commit-queue 2015-02-24 23:00:12 -0800 Comment on attachment 247304 Patch Clearing flags on attachment: 247304 Committed r180618: <http://trac.webkit.org/changeset/180618> 1071978 5 commit-queue 2015-02-24 23:00:16 -0800 All reviewed patches have been landed. Closing bug. 247303 2015-02-24 20:49:08 -0800 2015-02-24 20:49:52 -0800 Patch bug-141989-20150224204837.patch text/plain 3021 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwNjExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAyLTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q01ha2UgYnVpbGQgb2YgbGlibGx2bUZvckpTQy5zbyBzaG91bGQgbGltaXQgaXRzIGV4cG9ydCBs aXN0IGxpa2UgdGhlIFhjb2RlIGJ1aWxkIGRvZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTk4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogbGx2bS9s aWJyYXJ5L2xpYmxsdm1Gb3JKU0MudmVyc2lvbjogQWRkZWQuCisKIDIwMTUtMDItMjQgIENvbW1p dCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIxODA1OTkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VM aXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMu dHh0CShyZXZpc2lvbiAxODA0NTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0 cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTgwOCw3ICs4MDgsNyBAQCBpZiAoRU5BQkxFX0ZUTF9K SVQpCiAKICAgICBXRUJLSVRfV1JBUF9TT1VSQ0VMSVNUKCR7bGx2bUZvckpTQ19TT1VSQ0VTfSkK ICAgICBhZGRfbGlicmFyeShsbHZtRm9ySlNDIFNIQVJFRCAke2xsdm1Gb3JKU0NfU09VUkNFU30g JHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9XZWJLaXRMTFZNTGlicmFyeVRv a2VuLmgpCi0gICAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKGxsdm1Gb3JKU0MgJHtMTFZNX1NUQVRJ Q19MSUJSQVJJRVN9ICJwdGhyZWFkIiAiZGwiKQorICAgIHRhcmdldF9saW5rX2xpYnJhcmllcyhs bHZtRm9ySlNDICR7TExWTV9TVEFUSUNfTElCUkFSSUVTfSAicHRocmVhZCIgImRsIiAtV2wsLS12 ZXJzaW9uLXNjcmlwdD0ke0pBVkFTQ1JJUFRDT1JFX0RJUn0vbGx2bS9saWJyYXJ5L2xpYmxsdm1G b3JKU0MudmVyc2lvbikKIAogICAgICMgQWRkZWQgZXh0cmEgaXRlbXMgZm9yIEphdmFTY3JpcHRD b3JlCiAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsdm0vbGlicmFyeS9saWJsbHZtRm9ySlNDLnZl cnNpb24KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsdm0vbGlicmFyeS9s aWJsbHZtRm9ySlNDLnZlcnNpb24JKHJldmlzaW9uIDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvbGx2bS9saWJyYXJ5L2xpYmxsdm1Gb3JKU0MudmVyc2lvbgkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDQgQEAKK0xMVk1GT1JKU0MgeworICAgIGdsb2JhbDogaW5pdGlhbGl6ZUFuZEdldEpT Q0xMVk1BUEk7CisgICAgbG9jYWw6ICo7Cit9OwpJbmRleDogU291cmNlL1dURi9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dURi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDYxMSkKKysr IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIw MTUtMDItMjQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBDTWFr ZSBidWlsZCBvZiBsaWJsbHZtRm9ySlNDLnNvIHNob3VsZCBsaW1pdCBpdHMgZXhwb3J0IGxpc3Qg bGlrZSB0aGUgWGNvZGUgYnVpbGQgZG9lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQxOTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxNS0wMi0yMyAgQnJlbnQg RnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBXVEY6OldlYWtQdHIgc2hv dWxkIHJlbmFtZSAnZm9yZ290JyB0byAnY2xlYXInIGFuZCBzdXBwb3J0IG51bGxwdHIgYXNzaWdu bWVudApJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAxODA0NTIpCisrKyBTb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC03MzMsNyArNzMzLDcgQEAKICAgIHZhbHVl cyBnZXQgc3RvcmVkIHRvIGF0b21pY2FsbHkuIFRoaXMgaXMgdHJpdmlhbGx5IHRydWUgb24gNjQt Yml0IHBsYXRmb3JtcywKICAgIGJ1dCBub3QgdHJ1ZSBhdCBhbGwgb24gMzItYml0IHBsYXRmb3Jt cyB3aGVyZSB2YWx1ZXMgYXJlIGNvbXBvc2VkIG9mIHR3bwogICAgc2VwYXJhdGUgc3ViLXZhbHVl cy4gKi8KLSNpZiAoT1MoREFSV0lOKSB8fCBQTEFURk9STShFRkwpKSAmJiAhUExBVEZPUk0oR1RL KSAmJiBFTkFCTEUoREZHX0pJVCkgJiYgVVNFKEpTVkFMVUU2NCkKKyNpZiAoT1MoREFSV0lOKSB8 fCBQTEFURk9STShFRkwpIHx8IFBMQVRGT1JNKEdUSykpICYmIEVOQUJMRShERkdfSklUKSAmJiBV U0UoSlNWQUxVRTY0KQogI2RlZmluZSBFTkFCTEVfQ09OQ1VSUkVOVF9KSVQgMQogI2VuZGlmCiAK 247304 2015-02-24 20:49:55 -0800 2015-02-24 23:00:12 -0800 Patch bug-141989-20150224204924.patch text/plain 1796 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwNjExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAyLTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q01ha2UgYnVpbGQgb2YgbGlibGx2bUZvckpTQy5zbyBzaG91bGQgbGltaXQgaXRzIGV4cG9ydCBs aXN0IGxpa2UgdGhlIFhjb2RlIGJ1aWxkIGRvZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTk4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogbGx2bS9s aWJyYXJ5L2xpYmxsdm1Gb3JKU0MudmVyc2lvbjogQWRkZWQuCisKIDIwMTUtMDItMjQgIENvbW1p dCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIxODA1OTkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VM aXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMu dHh0CShyZXZpc2lvbiAxODA0NTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0 cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTgwOCw3ICs4MDgsNyBAQCBpZiAoRU5BQkxFX0ZUTF9K SVQpCiAKICAgICBXRUJLSVRfV1JBUF9TT1VSQ0VMSVNUKCR7bGx2bUZvckpTQ19TT1VSQ0VTfSkK ICAgICBhZGRfbGlicmFyeShsbHZtRm9ySlNDIFNIQVJFRCAke2xsdm1Gb3JKU0NfU09VUkNFU30g JHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9XZWJLaXRMTFZNTGlicmFyeVRv a2VuLmgpCi0gICAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKGxsdm1Gb3JKU0MgJHtMTFZNX1NUQVRJ Q19MSUJSQVJJRVN9ICJwdGhyZWFkIiAiZGwiKQorICAgIHRhcmdldF9saW5rX2xpYnJhcmllcyhs bHZtRm9ySlNDICR7TExWTV9TVEFUSUNfTElCUkFSSUVTfSAicHRocmVhZCIgImRsIiAtV2wsLS12 ZXJzaW9uLXNjcmlwdD0ke0pBVkFTQ1JJUFRDT1JFX0RJUn0vbGx2bS9saWJyYXJ5L2xpYmxsdm1G b3JKU0MudmVyc2lvbikKIAogICAgICMgQWRkZWQgZXh0cmEgaXRlbXMgZm9yIEphdmFTY3JpcHRD b3JlCiAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsdm0vbGlicmFyeS9saWJsbHZtRm9ySlNDLnZl cnNpb24KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsdm0vbGlicmFyeS9s aWJsbHZtRm9ySlNDLnZlcnNpb24JKHJldmlzaW9uIDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvbGx2bS9saWJyYXJ5L2xpYmxsdm1Gb3JKU0MudmVyc2lvbgkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDQgQEAKK0xMVk1GT1JKU0MgeworICAgIGdsb2JhbDogaW5pdGlhbGl6ZUFuZEdldEpT Q0xMVk1BUEk7CisgICAgbG9jYWw6ICo7Cit9Owo=