141962 2015-02-24 01:47:11 -0800 [GTK] Layout Test http/tests/notifications/legacy/notification-request-permission-then-navigate.html is failing 2015-03-19 06:26:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 chavarria1991 webkit-unassigned cgarcia chavarria1991 clopez commit-queue gustavo oldest_to_newest 1071592 0 chavarria1991 2015-02-24 01:47:11 -0800 The http/tests/notifications/legacy/notification-request-permission-then-navigate.html layout test is since r177073 (https://trac.webkit.org/changeset/r177073). This revision implements support for HTML5 notifications. The diff is the following: --- /home/ch01/wk-tools/layout-test-results/http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt +++ /home/ch01/wk-tools/layout-test-results/http/tests/notifications/legacy/notification-request-permission-then-navigate-actual.txt @@ -1,4 +1,5 @@ main frame - has 1 onunload handler(s) +CONSOLE MESSAGE: line 5: TypeError: undefined is not an object (evaluating 'window.webkitNotifications.requestPermission') Tests that we are not crashing when a permission request is answered after navigating On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". 1078517 1 249032 chavarria1991 2015-03-19 05:11:06 -0700 Created attachment 249032 Patch 1078523 2 249032 cgarcia 2015-03-19 05:40:12 -0700 Comment on attachment 249032 Patch Isn't this a gardening patch? does it need to be reviewed? 1078525 3 249032 commit-queue 2015-03-19 06:26:02 -0700 Comment on attachment 249032 Patch Clearing flags on attachment: 249032 Committed r181746: <http://trac.webkit.org/changeset/181746> 1078526 4 commit-queue 2015-03-19 06:26:06 -0700 All reviewed patches have been landed. Closing bug. 249032 2015-03-19 05:11:06 -0700 2015-03-19 06:26:02 -0700 Patch bug-141962-20150319131033.patch text/plain 2108 chavarria1991 U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNjkwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2U4NTZiYTRmNWM5OWYxZWViNTZk YTYzMDllYjRmNGM5NzYwNzJhZC4uOWIwMDM4OWMzYWI5OTJkZDMxNTYzMzQ5YzgxMjcyZDQ0ZTc2 N2VkZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAzLTE5ICBNYXJjb3MgQ2hhdmFycsOt YSBUZWlqZWlybyAgPGNoYXZhcnJpYTE5OTFAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIFNr aXAgTGVnYWN5IFdlYk5vdGlmaWNhdGlvbnMgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxOTYyCisKKyAgICAgICAgVGhlIHJldmlzaW9uIHIx NzcwNzMgc2tpcHMgYWxsIGxlZ2FjeSB0ZXN0cyBmb3Igbm90aWZpY2F0aW9ucyBleGNlcHQgZnJv bQorICAgICAgICBodHRwL3Rlc3RzL25vdGlmaWNhdGlvbnMvbGVnYWN5L25vdGlmaWNhdGlvbi1y ZXF1ZXN0LXBlcm1pc3Npb24tdGhlbi1uYXZpZ2F0ZS5odG1sCisgICAgICAgIHdoaWNoIHdhcyBm YWlsaW5nLiBXZSBza2lwIHRoaXMgdGVzdCBub3cgdG9vLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlv bnM6CisKIDIwMTUtMDMtMTcgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxODE2NjcsIHIxODE2ODIsIGFu ZCByMTgxNjgzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRl eCA1MzZlNWUwNGQxMTViNzNjZDQ1NGYyYTkxY2Y0MTExMmQyNTUzZWRlLi44YWM2N2Y1MjhkZTg0 ZmE1ODlkOTQ4N2E3YmM3NjM0NjQxMDVhZDExIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv VGVzdEV4cGVjdGF0aW9ucwpAQCAtMTU4LDYgKzE1OCw3IEBAIGh0dHAvdGVzdHMvbm90aWZpY2F0 aW9ucy9sZWdhY3kvcmVxdWVzdC1uby1jYWxsYmFjay5odG1sCiBodHRwL3Rlc3RzL25vdGlmaWNh dGlvbnMvbGVnYWN5L2V2ZW50cy5odG1sCiBodHRwL3Rlc3RzL25vdGlmaWNhdGlvbnMvbGVnYWN5 L3Nob3cuaHRtbAogaHR0cC90ZXN0cy9ub3RpZmljYXRpb25zL2xlZ2FjeS9kb3VibGUtc2hvdy5o dG1sCitodHRwL3Rlc3RzL25vdGlmaWNhdGlvbnMvbGVnYWN5L25vdGlmaWNhdGlvbi1yZXF1ZXN0 LXBlcm1pc3Npb24tdGhlbi1uYXZpZ2F0ZS5odG1sCiAKICMgRGF0YWxpc3QgaXMgbm90IHlldCBl bmFibGVkLgogd2Via2l0Lm9yZy9iLzk4OTM0IGZhc3QvZm9ybXMvZGF0YWxpc3QgWyBTa2lwIF0K QEAgLTU5OSw3ICs2MDAsNiBAQCB3ZWJraXQub3JnL2IvMTQxNDU4IGltcG9ydGVkL21vemlsbGEv c3ZnL3BhdHRlcm4tc2NhbGUtMDFjLnN2ZyBbIEltYWdlT25seUZhaWx1cgogd2Via2l0Lm9yZy9i LzE0MTQ1OCBpbXBvcnRlZC9tb3ppbGxhL3N2Zy9zeW1ib2wtMDEuc3ZnIFsgSW1hZ2VPbmx5RmFp bHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNDE5NjEgZmFzdC9tdWx0aWNvbC9zcGFuL3NwYW4tYXMt aW1tZWRpYXRlLWNvbHVtbnMtY2hpbGQuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE0 MTk2MiBodHRwL3Rlc3RzL25vdGlmaWNhdGlvbnMvbGVnYWN5L25vdGlmaWNhdGlvbi1yZXF1ZXN0 LXBlcm1pc3Npb24tdGhlbi1uYXZpZ2F0ZS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2Iv MTQxNTkxIGluc3BlY3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9icmVha3BvaW50LWV2YWwtd2l0aC1l eGNlcHRpb24uaHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTE4MTI2IGNzczMvZmxl eGJveC9pbWFnZS1wZXJjZW50LW1heC1oZWlnaHQuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQo=