141934 2015-02-23 16:41:31 -0800 [Mac][WK2] ASSERTION FAILED: m_sendPort in IPC::Connection::open() 2015-02-25 23:38:22 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez andersca ap benjamin commit-queue sam oldest_to_newest 1071409 0 cdumez 2015-02-23 16:41:31 -0800 I recently hit the following assertion while navigating: ASSERTION FAILED: m_sendPort /Volumes/Data/cdumez/WebKit/OpenSource/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm(182) : bool IPC::Connection::open() 1 0x115764cb0 WTFCrash 2 0x111f263ba IPC::Connection::open() 3 0x111ef2344 WebKit::ChildProcess::initialize(WebKit::ChildProcessInitializationParameters const&) 4 0x11240ead9 void WebKit::XPCServiceInitializer<WebKit::WebProcess, WebKit::XPCServiceInitializerDelegate>(WTF::OSObjectPtr<_xpc_connection_s*>, void*) 5 0x11240e8a1 WebContentServiceInitializer 6 0x10ad6868d invocation function for block in WebKit::XPCServiceEventHandler(NSObject<OS_xpc_object>*) 7 0x7fff8a388d51 _xpc_connection_call_event_handler 8 0x7fff8a3888cf _xpc_connection_mach_event 9 0x7fff90dd20f8 _dispatch_client_callout4 10 0x7fff90dd31a3 _dispatch_mach_msg_invoke 11 0x7fff90dd0154 _dispatch_queue_drain 12 0x7fff90dd1a10 _dispatch_mach_invoke 13 0x7fff90dd8b02 _dispatch_main_queue_callback_4CF 14 0x7fff8f93d939 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ 15 0x7fff8f8f8d8f __CFRunLoopRun 16 0x7fff8f8f82d8 CFRunLoopRunSpecific 17 0x7fff8b23663f RunCurrentEventLoopInMode 18 0x7fff8b2363ba ReceiveNextEventCommon 19 0x7fff8b2361fb _BlockUntilNextEventMatchingListInModeWithFilter 20 0x7fff864abe3d _DPSNextEvent 21 0x7fff864ab440 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 22 0x7fff864a1133 -[NSApplication run] 23 0x7fff8641d814 NSApplicationMain 24 0x7fff8a398958 _xpc_objc_main 25 0x7fff8a39a060 _parse_sysctl_once 26 0x10ad68185 main 27 0x7fff8f4495c9 start I had a very quick look and the culprit might be XPCServiceInitializerDelegate::getConnectionIdentifier() which returns true unconditionally although xpc_dictionary_copy_mach_send() can return MACH_PORT_NULL. I am not familiar with this code though. 1071416 1 247166 cdumez 2015-02-23 16:52:08 -0800 Created attachment 247166 Patch 1071914 2 247166 commit-queue 2015-02-24 19:52:57 -0800 Comment on attachment 247166 Patch Clearing flags on attachment: 247166 Committed r180606: <http://trac.webkit.org/changeset/180606> 1071915 3 commit-queue 2015-02-24 19:53:03 -0800 All reviewed patches have been landed. Closing bug. 1072309 4 ap 2015-02-25 23:38:22 -0800 Doesn't this make IPC problems harder to detect? Instead of an assertion, we now just get a mysterious exit with no diagnostics at all. 247166 2015-02-23 16:52:08 -0800 2015-02-24 19:52:57 -0800 Patch bug-141934-20150223165157.patch text/plain 2369 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDE0YzRjZTY0MzhlZDIy NGUwYzAwMzhiZjg2NDI0ZTRiODk5YTAzMC4uNTU0ODljMjk0OWU0YmFkNTllMTUzNDZlYmE0OWUz ZTUxODg5MGQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE1LTAyLTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgW01hY11bV0syXSBBU1NFUlRJ T04gRkFJTEVEOiBtX3NlbmRQb3J0IGluIElQQzo6Q29ubmVjdGlvbjo6b3BlbigpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE5MzQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjdWxhdGl2ZSBmaXgg Zm9yICJBU1NFUlRJT04gRkFJTEVEOiBtX3NlbmRQb3J0IiBpbgorICAgICAgICBJUEM6OkNvbm5l Y3Rpb246Om9wZW4oKS4gVGhpcyBhc3NlcnRpb24gc2VlbXMgdG8gaW5kaWNhdGUgd2UgZW5kZWQK KyAgICAgICAgdXAgaW4gSVBDOjpDb25uZWN0aW9uOjpvcGVuKCkgd2l0aCBNQUNIX1BPUlRfTlVM TCBhcyBwb3J0LgorCisgICAgICAgIEkgZm91bmQgdGhhdCBpbiBYUENTZXJ2aWNlSW5pdGlhbGl6 ZXJEZWxlZ2F0ZTo6Z2V0Q29ubmVjdGlvbklkZW50aWZpZXIoKQorICAgICAgICB3ZSByZXR1cm4g dHJ1ZSB1bmNvbmRpdGlvbmFsbHksIGV2ZW4gdGhvdWdoCisgICAgICAgIHhwY19kaWN0aW9uYXJ5 X2NvcHlfbWFjaF9zZW5kKCkgY2FuIHJldHVybiBNQUNIX1BPUlRfTlVMTC4gVGhpcyBwYXRjaAor ICAgICAgICB1cGRhdGVzIHRoaXMgbWV0aG9kIHRvIGFkZCBhIGNoZWNrIGZvciBNQUNIX1BPUlRf TlVMTCBhbmQgcmV0dXJuIGZhbHNlCisgICAgICAgIGluIHRoaXMgY2FzZS4KKworICAgICAgICAq IFNoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL21hYy9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VFbnRy eVBvaW50Lm1tOgorICAgICAgICAoV2ViS2l0OjpYUENTZXJ2aWNlSW5pdGlhbGl6ZXJEZWxlZ2F0 ZTo6Z2V0Q29ubmVjdGlvbklkZW50aWZpZXIpOgorCisyMDE1LTAyLTIzICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGRpYWdub3N0aWMg bG9nZ2luZyBtZXNzYWdlcyBzYW1wbGluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQxODIzCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xOTg5OTAz MD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVz L21hYy9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VFbnRyeVBvaW50Lm1tIGIvU291cmNlL1dlYktpdDIv U2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvbWFjL1hQQ1NlcnZpY2UvWFBDU2VydmljZUVudHJ5 UG9pbnQubW0KaW5kZXggOTc5MTYxNzAzNjQyZTZjNzBlYzA3NjkyZDY5MmU2ODkwZjQ0NzE4MC4u NmFmZWY4MGQ2ODdjZDk3MWRlZmU0NGFkMDA4MTlhYWI2ZmExYjc2NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvbWFjL1hQQ1NlcnZpY2UvWFBD U2VydmljZUVudHJ5UG9pbnQubW0KKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0VudHJ5UG9p bnRVdGlsaXRpZXMvbWFjL1hQQ1NlcnZpY2UvWFBDU2VydmljZUVudHJ5UG9pbnQubW0KQEAgLTY1 LDcgKzY1LDExIEBAIGJvb2wgWFBDU2VydmljZUluaXRpYWxpemVyRGVsZWdhdGU6OmNoZWNrRW50 aXRsZW1lbnRzKCkKIAogYm9vbCBYUENTZXJ2aWNlSW5pdGlhbGl6ZXJEZWxlZ2F0ZTo6Z2V0Q29u bmVjdGlvbklkZW50aWZpZXIoSVBDOjpDb25uZWN0aW9uOjpJZGVudGlmaWVyJiBpZGVudGlmaWVy KQogewotICAgIGlkZW50aWZpZXIgPSBJUEM6OkNvbm5lY3Rpb246OklkZW50aWZpZXIoeHBjX2Rp Y3Rpb25hcnlfY29weV9tYWNoX3NlbmQobV9pbml0aWFsaXplck1lc3NhZ2UsICJzZXJ2ZXItcG9y dCIpLCBtX2Nvbm5lY3Rpb24pOworICAgIG1hY2hfcG9ydF90IHBvcnQgPSB4cGNfZGljdGlvbmFy eV9jb3B5X21hY2hfc2VuZChtX2luaXRpYWxpemVyTWVzc2FnZSwgInNlcnZlci1wb3J0Iik7Cisg ICAgaWYgKHBvcnQgPT0gTUFDSF9QT1JUX05VTEwpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwor ICAgIGlkZW50aWZpZXIgPSBJUEM6OkNvbm5lY3Rpb246OklkZW50aWZpZXIocG9ydCwgbV9jb25u ZWN0aW9uKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo=