141925 2015-02-23 14:04:54 -0800 Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch 2015-02-23 15:06:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue thorton oldest_to_newest 1071324 0 ap 2015-02-23 14:04:54 -0800 Bot watcher's dashboard shows a popover with commit history when there are two bubbles, and they correspond to different revisions. But when all revisions in between are for a different branch, the popover doesn't appear - even though the revision number is highlighted on hover. 1071336 1 247146 ap 2015-02-23 14:11:49 -0800 Created attachment 247146 proposed fix 1071355 2 247146 commit-queue 2015-02-23 15:06:49 -0800 Comment on attachment 247146 proposed fix Clearing flags on attachment: 247146 Committed r180524: <http://trac.webkit.org/changeset/180524> 1071356 3 commit-queue 2015-02-23 15:06:55 -0800 All reviewed patches have been landed. Closing bug. 247146 2015-02-23 14:11:49 -0800 2015-02-23 15:06:49 -0800 proposed fix NoChangePopover.txt text/plain 2246 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MDUxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTAyLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEJvdCB3YXRjaGVyJ3MgZGFzaGJvYXJkIGRvZXNuJ3Qgc2hvdyBhIHBvcG92 ZXIgZm9yIGNvbW1pdCBoaXN0b3J5IHdoZW4gYWxsIGNvbW1pdHMgd2VyZSB0byBhbm90aGVyIGJy YW5jaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQx OTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlVmlldy5qczoKKyAgICAgICAgKEJ1aWxkYm90UXVl dWVWaWV3LnByb3RvdHlwZS5fcHJlc2VudFBvcG92ZXJGb3JSZXZpc2lvblJhbmdlKToKKwogMjAx NS0wMi0yMyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtp T1NdIHJ1bi13ZWJraXQtdGVzdHMgLS1sZWFrcyBpcyBicm9rZW4gYmVjYXVzZSBJT1NTaW11bGF0 b3JQb3J0IGhhcyBubyBpc19zbm93bGVvcGFyZCBhdHRyaWJ1dGUKSW5kZXg6IFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TY3JpcHRzL0J1aWxkYm90UXVldWVWaWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TY3JpcHRzL0J1aWxkYm90UXVldWVWaWV3LmpzCShyZXZpc2lvbiAxODA1MDQpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9k YXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlVmlldy5qcwkod29ya2luZyBjb3B5KQpAQCAt MTkxLDE0ICsxOTEsMTggQEAgQnVpbGRib3RRdWV1ZVZpZXcucHJvdG90eXBlID0gewogCiAgICAg ICAgIC8vIEZJWE1FOiBOb3RoaW5nIGd1YXJhbnRlZXMgdGhhdCBUcmFjIGhhcyBoaXN0b3JpY2Fs IGRhdGEgZm9yIHRoZXNlIHJldmlzaW9ucy4KICAgICAgICAgdmFyIGxpbmVzRm9yQ29tbWl0cyA9 IHRoaXMuX3BvcG92ZXJMaW5lc0ZvckNvbW1pdFJhbmdlKGNvbnRleHQudHJhYywgY29udGV4dC5i cmFuY2gsIGNvbnRleHQuZmlyc3RSZXZpc2lvbiwgY29udGV4dC5sYXN0UmV2aXNpb24pOwotICAg ICAgICBpZiAoIWxpbmVzRm9yQ29tbWl0cy5sZW5ndGgpCi0gICAgICAgICAgICByZXR1cm4gZmFs c2U7CiAKICAgICAgICAgdmFyIGxpbmUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsK ICAgICAgICAgbGluZS5jbGFzc05hbWUgPSAidGl0bGUiOwotICAgICAgICBsaW5lLnRleHRDb250 ZW50ID0gImNvbW1pdHMgc2luY2UgcHJldmlvdXMgcmVzdWx0IjsKLSAgICAgICAgY29udGVudC5h cHBlbmRDaGlsZChsaW5lKTsKLSAgICAgICAgdGhpcy5fYWRkRGl2aWRlclRvUG9wb3Zlcihjb250 ZW50KTsKKworICAgICAgICBpZiAobGluZXNGb3JDb21taXRzLmxlbmd0aCkgeworICAgICAgICAg ICAgbGluZS50ZXh0Q29udGVudCA9ICJjb21taXRzIHNpbmNlIHByZXZpb3VzIHJlc3VsdCI7Cisg ICAgICAgICAgICBjb250ZW50LmFwcGVuZENoaWxkKGxpbmUpOworICAgICAgICAgICAgdGhpcy5f YWRkRGl2aWRlclRvUG9wb3Zlcihjb250ZW50KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAg ICAgIGxpbmUudGV4dENvbnRlbnQgPSAibm8gY29tbWl0cyB0byAiICsgY29udGV4dC5icmFuY2gg KyAiIHNpbmNlIHByZXZpb3VzIHJlc3VsdCI7CisgICAgICAgICAgICBjb250ZW50LmFwcGVuZENo aWxkKGxpbmUpOworICAgICAgICB9CiAKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgIT0gbGlu ZXNGb3JDb21taXRzLmxlbmd0aDsgKytpKQogICAgICAgICAgICAgY29udGVudC5hcHBlbmRDaGls ZChsaW5lc0ZvckNvbW1pdHNbaV0pOwo=