141920 2015-02-23 13:21:26 -0800 build.webkit.org/dashboard CrashOnly queues should not show two green bubbles 2015-02-23 15:09:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue dburkart thorton oldest_to_newest 1071304 0 ap 2015-02-23 13:21:26 -0800 We check for the flag when showing a bubble, but not when deciding whether to show another one. 1071305 1 247141 ap 2015-02-23 13:23:57 -0800 Created attachment 247141 proposed fix 1071314 2 ap 2015-02-23 13:52:28 -0800 rdar://problem/19914648 1071358 3 247141 commit-queue 2015-02-23 15:09:48 -0800 Comment on attachment 247141 proposed fix Clearing flags on attachment: 247141 Committed r180525: <http://trac.webkit.org/changeset/180525> 1071359 4 commit-queue 2015-02-23 15:09:55 -0800 All reviewed patches have been landed. Closing bug. 247141 2015-02-23 13:23:57 -0800 2015-02-23 15:09:48 -0800 proposed fix TwoGreenBubbles.txt text/plain 2039 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MDUxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTAyLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkIENyYXNoT25seSBxdWV1ZXMg c2hvdWxkIG5vdCBzaG93IHR3byBncmVlbiBidWJibGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE5MjAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90VGVzdGVy UXVldWVWaWV3LmpzOgorICAgICAgICAoQnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcucHJvdG90eXBl LnVwZGF0ZS5hcHBlbmRCdWlsZGVyUXVldWVTdGF0dXMpOgorICAgICAgICBEbyB0aGUgc2FtZSB0 aGluZyBhcyB3ZSBkbyBmb3IgcmVndWxhciBncmVlbiBidWJibGVzLgorCiAyMDE1LTAyLTIzICBE YXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gcnVuLXdl YmtpdC10ZXN0cyAtLWxlYWtzIGlzIGJyb2tlbiBiZWNhdXNlIElPU1NpbXVsYXRvclBvcnQgaGFz IG5vIGlzX3Nub3dsZW9wYXJkIGF0dHJpYnV0ZQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMv QnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Nj cmlwdHMvQnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMJKHJldmlzaW9uIDE4MDUwMykKKysrIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90VGVzdGVyUXVldWVWaWV3LmpzCSh3b3JraW5nIGNv cHkpCkBAIC04Miw2ICs4Miw3IEBAIEJ1aWxkYm90VGVzdGVyUXVldWVWaWV3LnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKHF1ZXVlLmNyYXNoZXNPbmx5ICYmICFsYXlv dXRUZXN0UmVzdWx0cy5jcmFzaENvdW50KSB7CiAgICAgICAgICAgICAgICAgICAgIHZhciB1cmwg PSBpdGVyYXRpb24ucXVldWUuYnVpbGRib3QuYnVpbGRQYWdlVVJMRm9ySXRlcmF0aW9uKGl0ZXJh dGlvbik7CiAgICAgICAgICAgICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVzTGluZVZp ZXcobWVzc2FnZUVsZW1lbnQsIFN0YXR1c0xpbmVWaWV3LlN0YXR1cy5Hb29kLCAibm8gY3Jhc2hl cyBmb3VuZCIsIHVuZGVmaW5lZCwgdXJsKTsKKyAgICAgICAgICAgICAgICAgICAgbGltaXQgPSAw OwogICAgICAgICAgICAgICAgIH0gZWxzZSBpZiAocXVldWUuY3Jhc2hlc09ubHkgJiYgbGF5b3V0 VGVzdFJlc3VsdHMuY3Jhc2hDb3VudCkgewogICAgICAgICAgICAgICAgICAgICB2YXIgdXJsID0g aXRlcmF0aW9uLnF1ZXVlLmJ1aWxkYm90LmxheW91dFRlc3RSZXN1bHRzVVJMRm9ySXRlcmF0aW9u KGl0ZXJhdGlvbik7CiAgICAgICAgICAgICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVz TGluZVZpZXcobWVzc2FnZUVsZW1lbnQsIFN0YXR1c0xpbmVWaWV3LlN0YXR1cy5CYWQsIGxheW91 dFRlc3RSZXN1bHRzLmNyYXNoQ291bnQgPT09IDEgPyAiY3Jhc2ggZm91bmQiIDogImNyYXNoZXMg Zm91bmQiLCBsYXlvdXRUZXN0UmVzdWx0cy5jcmFzaENvdW50LCB1cmwpOwo=