141912 2015-02-23 10:20:21 -0800 Weak symbol warning when linking TestWebKitAPI 2021-04-20 09:16:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224812 P2 Normal --- 142320 1 burg achristensen achristensen ap commit-queue dbates ddkilzer oldest_to_newest 1071235 0 burg 2015-02-23 10:20:21 -0800 I started noticing this issue a while ago, I think it was before the full switch away from WebCore.exp.in but I'm not sure. I have done several full builds since then IIRC. Full output as follows: === BUILD TARGET TestWebKitAPI OF PROJECT TestWebKitAPI WITH CONFIGURATION Release === Check dependencies DebugRelease.xcconfig line 23: Unable to find included file "../../../../Internal/Configurations/HaveInternalSDK.xcconfig" Ld /Users/burg/repos/replay-staging/OpenSource/WebKitBuild/Release/TestWebKitAPI normal x86_64 cd /Users/burg/repos/replay-staging/OpenSource/Tools/TestWebKitAPI export MACOSX_DEPLOYMENT_TARGET=10.10 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -L/Users/burg/repos/replay-staging/OpenSource/WebKitBuild/Release -F/Users/burg/repos/replay-staging/OpenSource/WebKitBuild/Release -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Quartz.framework/Frameworks -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/ApplicationServices.framework/Frameworks -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks -filelist /Users/burg/repos/replay-staging/OpenSource/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPI.build/Objects-normal/x86_64/TestWebKitAPI.LinkFileList -Xlinker --no-demangle -mmacosx-version-min=10.10 -lgtest -force_load /Users/burg/repos/replay-staging/OpenSource/WebKitBuild/Release/libTestWebKitAPI.a -framework JavaScriptCore -framework WebKit -framework WebKit2 -framework Cocoa -framework Carbon -stdlib=libc++ -fobjc-link-runtime -Xlinker -dependency_info -Xlinker /Users/burg/repos/replay-staging/OpenSource/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPI.build/Objects-normal/x86_64/TestWebKitAPI_dependency_info.dat -o /Users/burg/repos/replay-staging/OpenSource/WebKitBuild/Release/TestWebKitAPI ld: warning: direct access in __GLOBAL__I_a to global weak symbol __ZN7testing4Test13SetUpTestCaseEv means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings. ld: warning: direct access in __GLOBAL__I_a to global weak symbol __ZN7testing4Test16TearDownTestCaseEv means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings. 1071278 1 achristensen 2015-02-23 12:10:25 -0800 I'm pretty sure that I did indeed cause this when I switched away from WebCore.exp.in. This doesn't seem to be breaking any builds, but this should be fixed along with the final cleaning up from that switch. 1074276 2 247907 achristensen 2015-03-04 16:05:45 -0800 Created attachment 247907 Patch 1074287 3 247907 ddkilzer 2015-03-04 16:33:42 -0800 Comment on attachment 247907 Patch r=me 1074301 4 247907 commit-queue 2015-03-04 17:19:06 -0800 Comment on attachment 247907 Patch Clearing flags on attachment: 247907 Committed r181054: <http://trac.webkit.org/changeset/181054> 1074302 5 commit-queue 2015-03-04 17:19:10 -0800 All reviewed patches have been landed. Closing bug. 1074342 6 commit-queue 2015-03-04 18:31:17 -0800 Re-opened since this is blocked by bug 142320 1074634 7 247978 achristensen 2015-03-05 12:37:38 -0800 Created attachment 247978 Patch 1074637 8 achristensen 2015-03-05 12:38:45 -0800 The previous patch broke some API tests even though it compiled correctly. I'm honestly not sure why. This patch compiles correctly and doesn't break run-api-tests. 1074720 9 247978 ddkilzer 2015-03-05 15:44:00 -0800 Comment on attachment 247978 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247978&action=review r=me > Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:27 > +UNEXPORTED_SYMBOL_LDFLAGS = -Wl,-unexported_symbol -Wl,__ZN7testing4Test16TearDownTestCaseEv -Wl,-unexported_symbol -Wl,__ZN7testing4Test13SetUpTestCaseEv If we have to add more of these symbols in the future, we should put them in an *.unexp file. This is slightly ugly to maintain. 1074742 10 247978 commit-queue 2015-03-05 16:29:50 -0800 Comment on attachment 247978 Patch Clearing flags on attachment: 247978 Committed r181113: <http://trac.webkit.org/changeset/181113> 1074743 11 commit-queue 2015-03-05 16:29:55 -0800 All reviewed patches have been landed. Closing bug. 247907 2015-03-04 16:05:45 -0800 2015-03-05 12:37:35 -0800 Patch bug-141912-20150304160526.patch text/plain 1203 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTA0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTAzLTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgRml4IGxpbmtlciB3YXJuaW5ncyBpbiBUZXN0V2ViS2l0QVBJ LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxOTEy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWc6CisgICAgICAgIFVzZSBHQ0Nf U1lNQk9MU19QUklWQVRFX0VYVEVSTiBsaWtlIHdlIGRvIGluIFdlYkNvcmUuCisKIDIwMTUtMDMt MDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBNb3ZlIGNvbnRlbnQgZXh0ZW5zaW9ucyB0ZXN0IHRvIHByb3Blcmx5IG5hbWVkIGRpcmVjdG9y eS4KSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZp Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL0Jhc2Uu eGNjb25maWcJKHJldmlzaW9uIDE4MTA0MykKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmln dXJhdGlvbnMvQmFzZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsNyBAQCBH Q0NfQ19MQU5HVUFHRV9TVEFOREFSRCA9IGdudTk5CiBHQ0NfRU5BQkxFX0NQUF9FWENFUFRJT05T ID0gTk87CiBHQ0NfRU5BQkxFX0NQUF9SVFRJID0gTk87CiBHQ0NfUFJFQ09NUElMRV9QUkVGSVhf SEVBREVSID0gWUVTCitHQ0NfU1lNQk9MU19QUklWQVRFX0VYVEVSTiA9IFlFUzsKIEdDQ19UUkVB VF9XQVJOSU5HU19BU19FUlJPUlMgPSBZRVMKIEdDQ19WRVJTSU9OID0gY29tLmFwcGxlLmNvbXBp bGVycy5sbHZtLmNsYW5nLjFfMDsKIEdDQ19XQVJOX0FCT1VUX0RFUFJFQ0FURURfRlVOQ1RJT05T ID0gTk8K 247978 2015-03-05 12:37:38 -0800 2015-03-05 16:29:50 -0800 Patch bug-141912-20150305123718.patch text/plain 1754 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTA5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTAzLTA1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgRml4IGxpbmtlciB3YXJuaW5ncyBpbiBUZXN0V2ViS2l0QVBJ LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxOTEy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRBUEkueGNjb25maWc6CisgICAgICAg IERvIG5vdCBleHBvcnQgVGVhckRvd25UZXN0Q2FzZSBvciBTZXRVcFRlc3RDYXNlIHN5bWJvbHMu CisKIDIwMTUtMDMtMDUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg ICBydW4td2Via2l0LXRlc3RzIGFuZCBydW4tcGVyZi10ZXN0cyBzaG91bGQgdXNlIFdlYktpdFRl c3RSdW5uZXIgYnkgZGVmYXVsdApJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9Db25maWd1cmF0 aW9ucy9UZXN0V2ViS2l0QVBJLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJL aXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSS54Y2NvbmZpZwkocmV2aXNpb24gMTgx MDQzKQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V2ViS2l0QVBJ LnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw3ICsyNCw4IEBACiBQUk9EVUNUX05BTUUg PSBUZXN0V2ViS2l0QVBJOwogR0NDX0VOQUJMRV9PQkpDX0VYQ0VQVElPTlMgPSBZRVM7CiAKLU9U SEVSX0xERkxBR1MgPSAkKGluaGVyaXRlZCkgLWxndGVzdCAtZm9yY2VfbG9hZCAkKEJVSUxUX1BS T0RVQ1RTX0RJUikvbGliVGVzdFdlYktpdEFQSS5hIC1mcmFtZXdvcmsgSmF2YVNjcmlwdENvcmUg LWZyYW1ld29yayBXZWJLaXQgLWZyYW1ld29yayBXZWJLaXQyICQoT1RIRVJfTERGTEFHU18kKFBM QVRGT1JNX05BTUUpKTsKK1VORVhQT1JURURfU1lNQk9MX0xERkxBR1MgPSAtV2wsLXVuZXhwb3J0 ZWRfc3ltYm9sIC1XbCxfX1pON3Rlc3Rpbmc0VGVzdDE2VGVhckRvd25UZXN0Q2FzZUV2IC1XbCwt dW5leHBvcnRlZF9zeW1ib2wgLVdsLF9fWk43dGVzdGluZzRUZXN0MTNTZXRVcFRlc3RDYXNlRXYK K09USEVSX0xERkxBR1MgPSAkKGluaGVyaXRlZCkgJChVTkVYUE9SVEVEX1NZTUJPTF9MREZMQUdT KSAtbGd0ZXN0IC1mb3JjZV9sb2FkICQoQlVJTFRfUFJPRFVDVFNfRElSKS9saWJUZXN0V2ViS2l0 QVBJLmEgLWZyYW1ld29yayBKYXZhU2NyaXB0Q29yZSAtZnJhbWV3b3JrIFdlYktpdCAtZnJhbWV3 b3JrIFdlYktpdDIgJChPVEhFUl9MREZMQUdTXyQoUExBVEZPUk1fTkFNRSkpOwogT1RIRVJfTERG TEFHU19tYWNvc3ggPSAtZnJhbWV3b3JrIENvY29hIC1mcmFtZXdvcmsgQ2FyYm9uOwogCiAvLyBG SVhNRTogVGhpcyBzaG91bGQgbm90IGJlIGJ1aWx0IG9uIGlPUy4gSW5zdGVhZCB3ZSBzaG91bGQg Y3JlYXRlIGFuZCB1c2UgYSBUZXN0V2ViS2l0QVBJIGFwcGxpY2F0aW9uLgo=