141910 2015-02-23 09:16:08 -0800 Occasional crash in MediaPlayer::setPrivateBrowsingMode 2016-03-21 08:55:14 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=155721 InRadar P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 1071215 0 eric.carlson 2015-02-23 09:16:08 -0800 The iOS bots occasionally crash in MediaPlayer::setPrivateBrowsingMode: WebCore::MediaPlayer::setPrivateBrowsingMode(bool) + 4 WebCore::HTMLMediaElement::loadResource(WebCore::URL const&, WebCore::ContentType&, WTF::String const&) + 1160 WebCore::HTMLMediaElement::selectMediaResource() + 802 WebCore::HTMLMediaElement::loadTimerFired() + 77 1071217 1 247123 eric.carlson 2015-02-23 09:19:22 -0800 Created attachment 247123 Proposed patch 1071260 2 247123 jer.noble 2015-02-23 11:13:16 -0800 Comment on attachment 247123 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=247123&action=review > Source/WebCore/html/HTMLMediaElement.cpp:4743 > + clearMediaPlayer(-1); 😱 Could we add an entry to DelayedActionType called "AllActions" or something? 1071263 3 eric.carlson 2015-02-23 11:28:36 -0800 Committed r180510: https://trac.webkit.org/r180510 247123 2015-02-23 09:19:22 -0800 2015-02-23 11:29:06 -0800 Proposed patch patch_2.txt text/plain 1695 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDUwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAyLTIzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE9jY2FzaW9uYWwgY3Jh c2ggaW4gTWVkaWFQbGF5ZXI6OnNldFByaXZhdGVCcm93c2luZ01vZGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTkxMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgSSB3YXMgdW5h YmxlIHRvIHJlcHJvZHVjZSB0aGUgY3Jhc2guCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c3RvcCk6IENh bGwgY2xlYXJNZWRpYVBsYXllciBpbnN0ZWFkIG9mIGp1c3Qgc2V0dGluZyBtX3BsYXllcgorICAg ICAgICAgICAgdG8gTlVMTC4KKwogMjAxNS0wMi0yMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3Jt YW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gUmVkdW5kYW50IHRyYWNrIGxh bmd1YWdlIG5vdGlmaWNhdGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcAkocmV2aXNpb24gMTgwNTAyKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDczNyw5ICs0NzM3LDEwIEBAIHZv aWQgSFRNTE1lZGlhRWxlbWVudDo6c3RvcCgpCiAgICAgbV9hc3luY0V2ZW50UXVldWUuY2xvc2Uo KTsKIAogICAgIC8vIE9uY2UgYW4gYWN0aXZlIERPTSBvYmplY3QgaGFzIGJlZW4gc3RvcHBlZCBp dCBjYW4gbm90IGJlIHJlc3RhcnRlZCwgc28gd2UgY2FuIGRlYWxsb2NhdGUKLSAgICAvLyB0aGUg bWVkaWEgcGxheWVyIG5vdy4gTm90ZSB0aGF0IHVzZXJDYW5jZWxsZWRMb2FkIHdpbGwgYWxyZWFk eSBoYXZlIGNsZWFyZWQgdGhlIHBsYXllcgotICAgIC8vIGlmIHRoZSBtZWRpYSB3YXMgbm90IGZ1 bGx5IGxvYWRlZC4gVGhpcyBoYW5kbGVzIGFsbCBvdGhlciBjYXNlcy4KLSAgICBtX3BsYXllciA9 IG51bGxwdHI7CisgICAgLy8gdGhlIG1lZGlhIHBsYXllciBub3cuIE5vdGUgdGhhdCB1c2VyQ2Fu Y2VsbGVkTG9hZCB3aWxsIGFscmVhZHkgY2FsbGVkIGNsZWFyTWVkaWFQbGF5ZXIKKyAgICAvLyBp ZiB0aGUgbWVkaWEgd2FzIG5vdCBmdWxseSBsb2FkZWQsIGJ1dCB3ZSBuZWVkIHRoZSBzYW1lIGNs ZWFudXAgaWYgdGhlIGZpbGUgd2FzIGNvbXBsZXRlbHkKKyAgICAvLyBsb2FkZWQgYW5kIGNhbGxp bmcgaXQgYWdhaW4gd29uJ3QgY2F1c2UgYW55IHByb2JsZW1zLgorICAgIGNsZWFyTWVkaWFQbGF5 ZXIoLTEpOwogCiAgICAgdXBkYXRlU2xlZXBEaXNhYmxpbmcoKTsKIH0K