141907 2015-02-23 08:23:41 -0800 [WK2][Mac] WebPageProxy::supressVisibilityUpdates() should suppress visibility updates. 2015-03-02 09:39:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue thorton oldest_to_newest 1071201 0 jer.noble 2015-02-23 08:23:41 -0800 [WK2][Mac] WebPageProxy::supressVisibilityUpdates() should suppress visibility updates. 1071202 1 247118 jer.noble 2015-02-23 08:31:00 -0800 Created attachment 247118 Patch 1071293 2 247136 jer.noble 2015-02-23 12:52:52 -0800 Created attachment 247136 Patch 1071296 3 247136 thorton 2015-02-23 13:04:40 -0800 Comment on attachment 247136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247136&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1231 > + m_viewStateChangeDispatcher->schedule(); If one of the suppressed changes was a view-in-window change or any of the requests requested immediate dispatch, you should probably do that here instead of waiting for the next runloop. > Source/WebKit2/UIProcess/WebPageProxy.cpp:1262 > + if (m_suppressVisibilityUpdates) It is super dangerous for any viewStateDidChange call that wantsSynchronousReply or immediate dispatch to bail like this, because often the caller will be blocking waiting for a reply that won't come. You should add an assert or logging or something here. Or something? It's just scary and has caused lots of trouble in the past. 1072119 4 jer.noble 2015-02-25 13:40:54 -0800 (In reply to comment #3) > Comment on attachment 247136 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247136&action=review > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:1231 > > + m_viewStateChangeDispatcher->schedule(); > > If one of the suppressed changes was a view-in-window change or any of the > requests requested immediate dispatch, you should probably do that here > instead of waiting for the next runloop. Well, the immediate dispatch thing should never happen if we add an ASSERT, as you suggest below. But why should we do the view-in-window change immediately? It's already been delayed; what's wrong with delaying a bit longer? > > Source/WebKit2/UIProcess/WebPageProxy.cpp:1262 > > + if (m_suppressVisibilityUpdates) > > It is super dangerous for any viewStateDidChange call that > wantsSynchronousReply or immediate dispatch to bail like this, because often > the caller will be blocking waiting for a reply that won't come. > > You should add an assert or logging or something here. Or something? It's > just scary and has caused lots of trouble in the past. Ok, lets add an ASSERT. From looking at all the call points, this should never get hit, but better safe than sorry. 1072128 5 jer.noble 2015-02-25 13:49:55 -0800 (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 247136 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=247136&action=review > > > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:1231 > > > + m_viewStateChangeDispatcher->schedule(); > > > > If one of the suppressed changes was a view-in-window change or any of the > > requests requested immediate dispatch, you should probably do that here > > instead of waiting for the next runloop. > > Well, the immediate dispatch thing should never happen if we add an ASSERT, > as you suggest below. But why should we do the view-in-window change > immediately? It's already been delayed; what's wrong with delaying a bit > longer? > > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:1262 > > > + if (m_suppressVisibilityUpdates) > > > > It is super dangerous for any viewStateDidChange call that > > wantsSynchronousReply or immediate dispatch to bail like this, because often > > the caller will be blocking waiting for a reply that won't come. > > > > You should add an assert or logging or something here. Or something? It's > > just scary and has caused lots of trouble in the past. > > Ok, lets add an ASSERT. From looking at all the call points, this should > never get hit, but better safe than sorry. Actually, looking at all the call sites, I think it would be safe here to just ignore the m_suppressVisibilityUpdates flag if immediate dispatch is requested. 1072129 6 247343 jer.noble 2015-02-25 13:54:11 -0800 Created attachment 247343 Patch 1073350 7 247343 commit-queue 2015-03-02 09:39:31 -0800 Comment on attachment 247343 Patch Clearing flags on attachment: 247343 Committed r180886: <http://trac.webkit.org/changeset/180886> 1073351 8 commit-queue 2015-03-02 09:39:35 -0800 All reviewed patches have been landed. Closing bug. 247118 2015-02-23 08:31:00 -0800 2015-02-23 12:52:49 -0800 Patch bug-141907-20150223083050.patch text/plain 3704 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTEyNTAyNTM5NDMzZjgw NzZiOTA0YzEyODBhNzk3OGIyMjE1NTk0Zi4uOWI0ODBiOGJjMzU1MDhhYzM0NGJlMTRjMDEzMDBh OTFkNGU0ODFiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTAyLTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW01hY10gV2ViUGFn ZVByb3h5OjpzdXByZXNzVmlzaWJpbGl0eVVwZGF0ZXMoKSBzaG91bGQgc3VwcHJlc3MgdmlzaWJp bGl0eSB1cGRhdGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQxOTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXQgc29tZSBwb2ludCwgdGhlIHdpbmRvdy92aWV3L3BhZ2UgdmlzaWJpbGl0eSB1cGRh dGUgY29kZSB3YXMgcmVmYWN0b3JlZCBzdWNoIHRoYXQgc2V0dGluZworICAgICAgICBXZWJQYWdl UHJveHk6OnNldFN1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZSgpIG5vIGxvbmdlciBzdXBwcmVzc2Vk IHZpc2liaWxpdHkgdXBkYXRlcy4gVGhpcyBjYXVzZXMKKyAgICAgICAgZnVsbCBzY3JlZW4gYW5p bWF0aW9ucyB0byBiZWNvbWUgImZsYXNoeSIgd2hlbiBtb3ZpbmcgdGhlIFdlYlZpZXcgYmV0d2Vl biB0aGUgcmVndWxhciBhbmQgZnVsbAorICAgICAgICBzY3JlZW4gd2luZG93LCBhcyBhIEhUTUxN ZWRpYUVsZW1lbnQgaW4gdGhlIGZ1bGwgc2NyZWVuIGFuaW1hdGlvbiB3aWxsIHJlY2VpdmUgYSAi IXZpc2libGUiCisgICAgICAgIG5vdGlmaWNhdGlvbiBhbmQgZGlzY29ubmVjdCBpdHMgcmVuZGVy aW5nIHBpcGVsaW5lLgorCisgICAgICAgIEluIFdlYlBhZ2VQcm94eTo6dmlld1N0YXRlRGlkQ2hh bmdlKCksIHJlc3BlY3QgbV9zdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzIGFuZCBiYWlsIG91dCBl YXJseQorICAgICAgICBpZiBzZXQuIEluIFdlYlBhZ2VQcm94eTo6c2V0U3VwcHJlc3NWaXNpYmls aXR5VXBkYXRlcygpLCB0cmlnZ2VyIGFuIGV4cGxpY2l0IHVwZGF0ZSBhZnRlcgorICAgICAgICBj bGVhcmluZyBtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRT dXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 Ojp2aWV3U3RhdGVEaWRDaGFuZ2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHku aDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRTdXBwcmVzc1Zpc2liaWxpdHlV cGRhdGVzKTogRGVsZXRlZC4KKwogMjAxNS0wMi0xMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9y dG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB1bmRlciBSZW1vdGVMYXllclRyZWVEcmF3 aW5nQXJlYTo6Zmx1c2hMYXllcnMoKSB3aGVuIGNsb3NpbmcgYSB0YWIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYTg0YTNmYTIyMmVhYjg4MDBkMDMzYThk NzI0MTE4MTQ4NjkxZjM2Yy4uYzI0MDg2YzQ3OGYyZjBjNjY1NzEyY2Q5YzQ2N2VjNDc3NzA4YTQ1 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTEyMjAs NiArMTIyMCwxNiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6cmVxdWVzdFNjcm9sbChjb25zdCBGbG9h dFBvaW50JiBzY3JvbGxQb3NpdGlvbiwgYm9vbCBpc1Byb2dyYQogICAgIG1fcGFnZUNsaWVudC5y ZXF1ZXN0U2Nyb2xsKHNjcm9sbFBvc2l0aW9uLCBpc1Byb2dyYW1tYXRpY1Njcm9sbCk7CiB9CiAK K3ZvaWQgV2ViUGFnZVByb3h5OjpzZXRTdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzKGJvb2wgZmxh ZykKK3sKKyAgICBpZiAobV9zdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzID09IGZsYWcpCisgICAg ICAgIHJldHVybjsKKyAgICBtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMgPSBmbGFnOworCisg ICAgaWYgKCFtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMpCisgICAgICAgIG1fdmlld1N0YXRl Q2hhbmdlRGlzcGF0Y2hlci0+c2NoZWR1bGUoKTsKK30KKwogdm9pZCBXZWJQYWdlUHJveHk6OnVw ZGF0ZVZpZXdTdGF0ZShWaWV3U3RhdGU6OkZsYWdzIGZsYWdzVG9VcGRhdGUpCiB7CiAgICAgbV92 aWV3U3RhdGUgJj0gfmZsYWdzVG9VcGRhdGU7CkBAIC0xMjQ0LDYgKzEyNTQsOSBAQCB2b2lkIFdl YlBhZ2VQcm94eTo6dmlld1N0YXRlRGlkQ2hhbmdlKFZpZXdTdGF0ZTo6RmxhZ3MgbWF5SGF2ZUNo YW5nZWQsIGJvb2wgd2FudAogICAgIG1fcG90ZW50aWFsbHlDaGFuZ2VkVmlld1N0YXRlRmxhZ3Mg fD0gbWF5SGF2ZUNoYW5nZWQ7CiAgICAgbV92aWV3U3RhdGVDaGFuZ2VXYW50c1N5bmNocm9ub3Vz UmVwbHkgPSBtX3ZpZXdTdGF0ZUNoYW5nZVdhbnRzU3luY2hyb25vdXNSZXBseSB8fCB3YW50c1N5 bmNocm9ub3VzUmVwbHk7CiAKKyAgICBpZiAobV9zdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzKQor ICAgICAgICByZXR1cm47CisKICNpZiBQTEFURk9STShDT0NPQSkKICAgICBib29sIGlzTmV3bHlJ bldpbmRvdyA9ICFpc0luV2luZG93KCkgJiYgKG1heUhhdmVDaGFuZ2VkICYgVmlld1N0YXRlOjpJ c0luV2luZG93KSAmJiBtX3BhZ2VDbGllbnQuaXNWaWV3SW5XaW5kb3coKTsKICAgICBpZiAoZGlz cGF0Y2hNb2RlID09IFZpZXdTdGF0ZUNoYW5nZURpc3BhdGNoTW9kZTo6SW1tZWRpYXRlIHx8IGlz TmV3bHlJbldpbmRvdykgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCmlu ZGV4IGM5MmNhODliYTBkNmQ4ZTZiNzJkYTFlNDFjY2NlMzAyZjU2MzBlOWMuLmE1YWZjMzY0MTY2 NWFiNzMxYWRiMTljNWE0ZGQxNDJlZTNhNmQ0MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmgKQEAgLTg5MCw3ICs4OTAsNyBAQCBwdWJsaWM6CiAgICAgLy8gV2ViUG9w dXBNZW51UHJveHk6OkNsaWVudAogICAgIHZpcnR1YWwgTmF0aXZlV2ViTW91c2VFdmVudCogY3Vy cmVudGx5UHJvY2Vzc2VkTW91c2VEb3duRXZlbnQoKSBvdmVycmlkZTsKIAotICAgIHZvaWQgc2V0 U3VwcHJlc3NWaXNpYmlsaXR5VXBkYXRlcyhib29sIGZsYWcpIHsgbV9zdXBwcmVzc1Zpc2liaWxp dHlVcGRhdGVzID0gZmxhZzsgfQorICAgIHZvaWQgc2V0U3VwcHJlc3NWaXNpYmlsaXR5VXBkYXRl cyhib29sIGZsYWcpOwogICAgIGJvb2wgc3VwcHJlc3NWaXNpYmlsaXR5VXBkYXRlcygpIHsgcmV0 dXJuIG1fc3VwcHJlc3NWaXNpYmlsaXR5VXBkYXRlczsgfQogCiAjaWYgUExBVEZPUk0oSU9TKQo= 247136 2015-02-23 12:52:52 -0800 2015-02-25 13:54:09 -0800 Patch bug-141907-20150223125241.patch text/plain 3785 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTEyNTAyNTM5NDMzZjgw NzZiOTA0YzEyODBhNzk3OGIyMjE1NTk0Zi4uOWI0ODBiOGJjMzU1MDhhYzM0NGJlMTRjMDEzMDBh OTFkNGU0ODFiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTAyLTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW01hY10gV2ViUGFn ZVByb3h5OjpzdXByZXNzVmlzaWJpbGl0eVVwZGF0ZXMoKSBzaG91bGQgc3VwcHJlc3MgdmlzaWJp bGl0eSB1cGRhdGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQxOTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXQgc29tZSBwb2ludCwgdGhlIHdpbmRvdy92aWV3L3BhZ2UgdmlzaWJpbGl0eSB1cGRh dGUgY29kZSB3YXMgcmVmYWN0b3JlZCBzdWNoIHRoYXQgc2V0dGluZworICAgICAgICBXZWJQYWdl UHJveHk6OnNldFN1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZSgpIG5vIGxvbmdlciBzdXBwcmVzc2Vk IHZpc2liaWxpdHkgdXBkYXRlcy4gVGhpcyBjYXVzZXMKKyAgICAgICAgZnVsbCBzY3JlZW4gYW5p bWF0aW9ucyB0byBiZWNvbWUgImZsYXNoeSIgd2hlbiBtb3ZpbmcgdGhlIFdlYlZpZXcgYmV0d2Vl biB0aGUgcmVndWxhciBhbmQgZnVsbAorICAgICAgICBzY3JlZW4gd2luZG93LCBhcyBhIEhUTUxN ZWRpYUVsZW1lbnQgaW4gdGhlIGZ1bGwgc2NyZWVuIGFuaW1hdGlvbiB3aWxsIHJlY2VpdmUgYSAi IXZpc2libGUiCisgICAgICAgIG5vdGlmaWNhdGlvbiBhbmQgZGlzY29ubmVjdCBpdHMgcmVuZGVy aW5nIHBpcGVsaW5lLgorCisgICAgICAgIEluIFdlYlBhZ2VQcm94eTo6dmlld1N0YXRlRGlkQ2hh bmdlKCksIHJlc3BlY3QgbV9zdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzIGFuZCBiYWlsIG91dCBl YXJseQorICAgICAgICBpZiBzZXQuIEluIFdlYlBhZ2VQcm94eTo6c2V0U3VwcHJlc3NWaXNpYmls aXR5VXBkYXRlcygpLCB0cmlnZ2VyIGFuIGV4cGxpY2l0IHVwZGF0ZSBhZnRlcgorICAgICAgICBj bGVhcmluZyBtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRT dXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 Ojp2aWV3U3RhdGVEaWRDaGFuZ2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHku aDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRTdXBwcmVzc1Zpc2liaWxpdHlV cGRhdGVzKTogRGVsZXRlZC4KKwogMjAxNS0wMi0xMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9y dG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB1bmRlciBSZW1vdGVMYXllclRyZWVEcmF3 aW5nQXJlYTo6Zmx1c2hMYXllcnMoKSB3aGVuIGNsb3NpbmcgYSB0YWIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYTg0YTNmYTIyMmVhYjg4MDBkMDMzYThk NzI0MTE4MTQ4NjkxZjM2Yy4uNDI5ZDQ5YmM3ZTMyNDYzNjc3ZGU2ODYwMzRhMTlmMWMzY2ZiNDIw NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTEyMjAs NiArMTIyMCwyMSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6cmVxdWVzdFNjcm9sbChjb25zdCBGbG9h dFBvaW50JiBzY3JvbGxQb3NpdGlvbiwgYm9vbCBpc1Byb2dyYQogICAgIG1fcGFnZUNsaWVudC5y ZXF1ZXN0U2Nyb2xsKHNjcm9sbFBvc2l0aW9uLCBpc1Byb2dyYW1tYXRpY1Njcm9sbCk7CiB9CiAK K3ZvaWQgV2ViUGFnZVByb3h5OjpzZXRTdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzKGJvb2wgZmxh ZykKK3sKKyAgICBpZiAobV9zdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzID09IGZsYWcpCisgICAg ICAgIHJldHVybjsKKyAgICBtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMgPSBmbGFnOworCisg ICAgaWYgKCFtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMpIHsKKyNpZiBQTEFURk9STShDT0NP QSkKKyAgICAgICAgbV92aWV3U3RhdGVDaGFuZ2VEaXNwYXRjaGVyLT5zY2hlZHVsZSgpOworI2Vs c2UKKyAgICAgICAgZGlzcGF0Y2hWaWV3U3RhdGVDaGFuZ2UoKTsKKyNlbmRpZgorICAgIH0KK30K Kwogdm9pZCBXZWJQYWdlUHJveHk6OnVwZGF0ZVZpZXdTdGF0ZShWaWV3U3RhdGU6OkZsYWdzIGZs YWdzVG9VcGRhdGUpCiB7CiAgICAgbV92aWV3U3RhdGUgJj0gfmZsYWdzVG9VcGRhdGU7CkBAIC0x MjQ0LDYgKzEyNTksOSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6dmlld1N0YXRlRGlkQ2hhbmdlKFZp ZXdTdGF0ZTo6RmxhZ3MgbWF5SGF2ZUNoYW5nZWQsIGJvb2wgd2FudAogICAgIG1fcG90ZW50aWFs bHlDaGFuZ2VkVmlld1N0YXRlRmxhZ3MgfD0gbWF5SGF2ZUNoYW5nZWQ7CiAgICAgbV92aWV3U3Rh dGVDaGFuZ2VXYW50c1N5bmNocm9ub3VzUmVwbHkgPSBtX3ZpZXdTdGF0ZUNoYW5nZVdhbnRzU3lu Y2hyb25vdXNSZXBseSB8fCB3YW50c1N5bmNocm9ub3VzUmVwbHk7CiAKKyAgICBpZiAobV9zdXBw cmVzc1Zpc2liaWxpdHlVcGRhdGVzKQorICAgICAgICByZXR1cm47CisKICNpZiBQTEFURk9STShD T0NPQSkKICAgICBib29sIGlzTmV3bHlJbldpbmRvdyA9ICFpc0luV2luZG93KCkgJiYgKG1heUhh dmVDaGFuZ2VkICYgVmlld1N0YXRlOjpJc0luV2luZG93KSAmJiBtX3BhZ2VDbGllbnQuaXNWaWV3 SW5XaW5kb3coKTsKICAgICBpZiAoZGlzcGF0Y2hNb2RlID09IFZpZXdTdGF0ZUNoYW5nZURpc3Bh dGNoTW9kZTo6SW1tZWRpYXRlIHx8IGlzTmV3bHlJbldpbmRvdykgewpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5oCmluZGV4IGM5MmNhODliYTBkNmQ4ZTZiNzJkYTFlNDFjY2Nl MzAyZjU2MzBlOWMuLmE1YWZjMzY0MTY2NWFiNzMxYWRiMTljNWE0ZGQxNDJlZTNhNmQ0MmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKQEAgLTg5MCw3ICs4OTAsNyBA QCBwdWJsaWM6CiAgICAgLy8gV2ViUG9wdXBNZW51UHJveHk6OkNsaWVudAogICAgIHZpcnR1YWwg TmF0aXZlV2ViTW91c2VFdmVudCogY3VycmVudGx5UHJvY2Vzc2VkTW91c2VEb3duRXZlbnQoKSBv dmVycmlkZTsKIAotICAgIHZvaWQgc2V0U3VwcHJlc3NWaXNpYmlsaXR5VXBkYXRlcyhib29sIGZs YWcpIHsgbV9zdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzID0gZmxhZzsgfQorICAgIHZvaWQgc2V0 U3VwcHJlc3NWaXNpYmlsaXR5VXBkYXRlcyhib29sIGZsYWcpOwogICAgIGJvb2wgc3VwcHJlc3NW aXNpYmlsaXR5VXBkYXRlcygpIHsgcmV0dXJuIG1fc3VwcHJlc3NWaXNpYmlsaXR5VXBkYXRlczsg fQogCiAjaWYgUExBVEZPUk0oSU9TKQo= 247343 2015-02-25 13:54:11 -0800 2015-03-02 09:39:31 -0800 Patch bug-141907-20150225135358.patch text/plain 3834 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjllNDMwNGY0NmJjODA0 MmRjYjAwOTFjMzI2OWMzN2Q5NDE3MmNjMi4uZTM1MWFmY2Q1MTg1ZjhmOWIxNjUzYjcxY2Y5YzBi YWJjOWYwZmQ4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTAyLTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW01hY10gV2ViUGFn ZVByb3h5OjpzdXByZXNzVmlzaWJpbGl0eVVwZGF0ZXMoKSBzaG91bGQgc3VwcHJlc3MgdmlzaWJp bGl0eSB1cGRhdGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQxOTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXQgc29tZSBwb2ludCwgdGhlIHdpbmRvdy92aWV3L3BhZ2UgdmlzaWJpbGl0eSB1cGRh dGUgY29kZSB3YXMgcmVmYWN0b3JlZCBzdWNoIHRoYXQgc2V0dGluZworICAgICAgICBXZWJQYWdl UHJveHk6OnNldFN1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZSgpIG5vIGxvbmdlciBzdXBwcmVzc2Vk IHZpc2liaWxpdHkgdXBkYXRlcy4gVGhpcyBjYXVzZXMKKyAgICAgICAgZnVsbCBzY3JlZW4gYW5p bWF0aW9ucyB0byBiZWNvbWUgImZsYXNoeSIgd2hlbiBtb3ZpbmcgdGhlIFdlYlZpZXcgYmV0d2Vl biB0aGUgcmVndWxhciBhbmQgZnVsbAorICAgICAgICBzY3JlZW4gd2luZG93LCBhcyBhIEhUTUxN ZWRpYUVsZW1lbnQgaW4gdGhlIGZ1bGwgc2NyZWVuIGFuaW1hdGlvbiB3aWxsIHJlY2VpdmUgYSAi IXZpc2libGUiCisgICAgICAgIG5vdGlmaWNhdGlvbiBhbmQgZGlzY29ubmVjdCBpdHMgcmVuZGVy aW5nIHBpcGVsaW5lLgorCisgICAgICAgIEluIFdlYlBhZ2VQcm94eTo6dmlld1N0YXRlRGlkQ2hh bmdlKCksIHJlc3BlY3QgbV9zdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzIGFuZCBiYWlsIG91dCBl YXJseQorICAgICAgICBpZiBzZXQuIEluIFdlYlBhZ2VQcm94eTo6c2V0U3VwcHJlc3NWaXNpYmls aXR5VXBkYXRlcygpLCB0cmlnZ2VyIGFuIGV4cGxpY2l0IHVwZGF0ZSBhZnRlcgorICAgICAgICBj bGVhcmluZyBtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRT dXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 Ojp2aWV3U3RhdGVEaWRDaGFuZ2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHku aDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRTdXBwcmVzc1Zpc2liaWxpdHlV cGRhdGVzKTogRGVsZXRlZC4KKwogMjAxNS0wMi0yMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBBUEkgZm9yIGZldGNoaW5nIHdlYnNpdGUgZGF0 YSByZWNvcmRzIHRvIF9XS1dlYnNpdGVEYXRhU3RvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggOTUyZTlhNGU4OGQwNGE4YmNlYWRiYzlhYTdlYmQ0MmZi Y2M5ZjM3Yi4uOTBkMWY3NmI2ZDc4NjhmMTFhZjczZjdlNjAwMjhmZDhiODQ2YTJhOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTEyMjcsNiArMTIyNywy MSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6cmVxdWVzdFNjcm9sbChjb25zdCBGbG9hdFBvaW50JiBz Y3JvbGxQb3NpdGlvbiwgYm9vbCBpc1Byb2dyYQogICAgIG1fcGFnZUNsaWVudC5yZXF1ZXN0U2Ny b2xsKHNjcm9sbFBvc2l0aW9uLCBpc1Byb2dyYW1tYXRpY1Njcm9sbCk7CiB9CiAKK3ZvaWQgV2Vi UGFnZVByb3h5OjpzZXRTdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzKGJvb2wgZmxhZykKK3sKKyAg ICBpZiAobV9zdXBwcmVzc1Zpc2liaWxpdHlVcGRhdGVzID09IGZsYWcpCisgICAgICAgIHJldHVy bjsKKyAgICBtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMgPSBmbGFnOworCisgICAgaWYgKCFt X3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMpIHsKKyNpZiBQTEFURk9STShDT0NPQSkKKyAgICAg ICAgbV92aWV3U3RhdGVDaGFuZ2VEaXNwYXRjaGVyLT5zY2hlZHVsZSgpOworI2Vsc2UKKyAgICAg ICAgZGlzcGF0Y2hWaWV3U3RhdGVDaGFuZ2UoKTsKKyNlbmRpZgorICAgIH0KK30KKwogdm9pZCBX ZWJQYWdlUHJveHk6OnVwZGF0ZVZpZXdTdGF0ZShWaWV3U3RhdGU6OkZsYWdzIGZsYWdzVG9VcGRh dGUpCiB7CiAgICAgbV92aWV3U3RhdGUgJj0gfmZsYWdzVG9VcGRhdGU7CkBAIC0xMjUxLDYgKzEy NjYsOSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6dmlld1N0YXRlRGlkQ2hhbmdlKFZpZXdTdGF0ZTo6 RmxhZ3MgbWF5SGF2ZUNoYW5nZWQsIGJvb2wgd2FudAogICAgIG1fcG90ZW50aWFsbHlDaGFuZ2Vk Vmlld1N0YXRlRmxhZ3MgfD0gbWF5SGF2ZUNoYW5nZWQ7CiAgICAgbV92aWV3U3RhdGVDaGFuZ2VX YW50c1N5bmNocm9ub3VzUmVwbHkgPSBtX3ZpZXdTdGF0ZUNoYW5nZVdhbnRzU3luY2hyb25vdXNS ZXBseSB8fCB3YW50c1N5bmNocm9ub3VzUmVwbHk7CiAKKyAgICBpZiAobV9zdXBwcmVzc1Zpc2li aWxpdHlVcGRhdGVzICYmIGRpc3BhdGNoTW9kZSAhPSBWaWV3U3RhdGVDaGFuZ2VEaXNwYXRjaE1v ZGU6OkltbWVkaWF0ZSkKKyAgICAgICAgcmV0dXJuOworCiAjaWYgUExBVEZPUk0oQ09DT0EpCiAg ICAgYm9vbCBpc05ld2x5SW5XaW5kb3cgPSAhaXNJbldpbmRvdygpICYmIChtYXlIYXZlQ2hhbmdl ZCAmIFZpZXdTdGF0ZTo6SXNJbldpbmRvdykgJiYgbV9wYWdlQ2xpZW50LmlzVmlld0luV2luZG93 KCk7CiAgICAgaWYgKGRpc3BhdGNoTW9kZSA9PSBWaWV3U3RhdGVDaGFuZ2VEaXNwYXRjaE1vZGU6 OkltbWVkaWF0ZSB8fCBpc05ld2x5SW5XaW5kb3cpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuaAppbmRleCAyOTI3YTZkOTE1YTUxNGQ1YzNkOGQxYjNiODExODljNjRlMzA2 Y2E4Li5hMDgwYjQwZDRiODAwMzA2M2RmMmRkZjllN2NkYjdmMDYwN2E0MmExIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC04OTIsNyArODkyLDcgQEAgcHVibGlj OgogICAgIC8vIFdlYlBvcHVwTWVudVByb3h5OjpDbGllbnQKICAgICB2aXJ0dWFsIE5hdGl2ZVdl Yk1vdXNlRXZlbnQqIGN1cnJlbnRseVByb2Nlc3NlZE1vdXNlRG93bkV2ZW50KCkgb3ZlcnJpZGU7 CiAKLSAgICB2b2lkIHNldFN1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXMoYm9vbCBmbGFnKSB7IG1f c3VwcHJlc3NWaXNpYmlsaXR5VXBkYXRlcyA9IGZsYWc7IH0KKyAgICB2b2lkIHNldFN1cHByZXNz VmlzaWJpbGl0eVVwZGF0ZXMoYm9vbCBmbGFnKTsKICAgICBib29sIHN1cHByZXNzVmlzaWJpbGl0 eVVwZGF0ZXMoKSB7IHJldHVybiBtX3N1cHByZXNzVmlzaWJpbGl0eVVwZGF0ZXM7IH0KIAogI2lm IFBMQVRGT1JNKElPUykK