141904 2015-02-23 06:20:00 -0800 UNREACHABLE_FOR_PLATFORM() should be release assert 2015-02-26 02:51:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy benjamin cmarcelo commit-queue fpizlo ossy oldest_to_newest 1071182 0 ossy 2015-02-23 06:20:00 -0800 UNREACHABLE_FOR_PLATFORM() should be release assert 1071183 1 247114 ossy 2015-02-23 06:21:15 -0800 Created attachment 247114 Patch 1071185 2 ossy 2015-02-23 06:25:36 -0800 Now it is relase assert with clang, but debug assert otherwise. Additionally RELEASE_ASSERT_NOT_REACHED(); is simple crash in release mode, but it is more verbose in debug mode. Releated discussion can be found here: https://bugs.webkit.org/show_bug.cgi?id=141489#c10 ( and c11, c12 ) just a note: It depends on bug141903. We should wait until bug141903 is fixed not to break the ARM traditional world. 1072327 3 247114 commit-queue 2015-02-26 02:51:16 -0800 Comment on attachment 247114 Patch Clearing flags on attachment: 247114 Committed r180668: <http://trac.webkit.org/changeset/180668> 1072328 4 commit-queue 2015-02-26 02:51:19 -0800 All reviewed patches have been landed. Closing bug. 247114 2015-02-23 06:21:15 -0800 2015-02-26 02:51:16 -0800 Patch bug-141904-20150223062102.patch text/plain 2421 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGVlODcyMDQxYzkzZDMyZDEwNjg5ODBl NGNmOGRjMTdhNzAzYjUwMDIuLmQyMzgyMzcxMGQ2ZjZhNTRiMjA0OTJhZjAzZTcwYTMyM2I2NDUx MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDItMjMgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBVTlJFQUNIQUJMRV9GT1JfUExBVEZPUk0oKSBz aG91bGQgYmUgcmVsZWFzZSBhc3NlcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0MTkwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogd3RmL0Fzc2VydGlvbnMuaDoKKyAgICAgICAgKFVOUkVBQ0hBQkxF X0ZPUl9QTEFURk9STSk6CisKIDIwMTUtMDItMjAgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgVENNYWxsb2MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL0Fzc2VydGlvbnMuaCBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCA5 YTYzOGJiYTM1OTE4MjBhYWE5NGZhYmUxOWY4MTJiOGY1ZGRiYjQ3Li5iZTM0ZTAxNzAxYmYxZDJk MDllZjVjMTNlNzk1NWY0N2MwNGY5ZmM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3Nl cnRpb25zLmgKKysrIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCkBAIC0zNTYsNiArMzU2 LDE4IEBAIHdoaWxlICgwKQogI2RlZmluZSBMT0dfVkVSQk9TRShjaGFubmVsLCAuLi4pIFdURkxv Z1ZlcmJvc2UoX19GSUxFX18sIF9fTElORV9fLCBXVEZfUFJFVFRZX0ZVTkNUSU9OLCAmSk9JTl9M T0dfQ0hBTk5FTF9XSVRIX1BSRUZJWChMT0dfQ0hBTk5FTF9QUkVGSVgsIGNoYW5uZWwpLCBfX1ZB X0FSR1NfXykKICNlbmRpZgogCisvKiBSRUxFQVNFX0FTU0VSVCAqLworCisjaWYgQVNTRVJUX0RJ U0FCTEVECisjZGVmaW5lIFJFTEVBU0VfQVNTRVJUKGFzc2VydGlvbikgKFVOTElLRUxZKCEoYXNz ZXJ0aW9uKSkgPyAoQ1JBU0goKSkgOiAodm9pZCkwKQorI2RlZmluZSBSRUxFQVNFX0FTU0VSVF9X SVRIX01FU1NBR0UoYXNzZXJ0aW9uLCAuLi4pIFJFTEVBU0VfQVNTRVJUKGFzc2VydGlvbikKKyNk ZWZpbmUgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKSBDUkFTSCgpCisjZWxzZQorI2RlZmlu ZSBSRUxFQVNFX0FTU0VSVChhc3NlcnRpb24pIEFTU0VSVChhc3NlcnRpb24pCisjZGVmaW5lIFJF TEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRShhc3NlcnRpb24sIC4uLikgQVNTRVJUX1dJVEhfTUVT U0FHRShhc3NlcnRpb24sIF9fVkFfQVJHU19fKQorI2RlZmluZSBSRUxFQVNFX0FTU0VSVF9OT1Rf UkVBQ0hFRCgpIEFTU0VSVF9OT1RfUkVBQ0hFRCgpCisjZW5kaWYKKwogLyogVU5SRUFDSEFCTEVf Rk9SX1BMQVRGT1JNICovCiAKICNpZiBDT01QSUxFUihDTEFORykKQEAgLTM2NSwyMSArMzc3LDEy IEBAIHdoaWxlICgwKQogI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XbWlzc2lu Zy1ub3JldHVybiIKIHN0YXRpYyBpbmxpbmUgdm9pZCBVTlJFQUNIQUJMRV9GT1JfUExBVEZPUk0o KQogewotICAgIENSQVNIKCk7CisgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0K ICNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKICNlbHNlCi0jZGVmaW5lIFVOUkVBQ0hBQkxF X0ZPUl9QTEFURk9STSgpIEFTU0VSVF9OT1RfUkVBQ0hFRCgpCisjZGVmaW5lIFVOUkVBQ0hBQkxF X0ZPUl9QTEFURk9STSgpIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCkKICNlbmRpZgogCi0j aWYgQVNTRVJUX0RJU0FCTEVECi0jZGVmaW5lIFJFTEVBU0VfQVNTRVJUKGFzc2VydGlvbikgKFVO TElLRUxZKCEoYXNzZXJ0aW9uKSkgPyAoQ1JBU0goKSkgOiAodm9pZCkwKQotI2RlZmluZSBSRUxF QVNFX0FTU0VSVF9XSVRIX01FU1NBR0UoYXNzZXJ0aW9uLCAuLi4pIFJFTEVBU0VfQVNTRVJUKGFz c2VydGlvbikKLSNkZWZpbmUgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKSBDUkFTSCgpCi0j ZWxzZQotI2RlZmluZSBSRUxFQVNFX0FTU0VSVChhc3NlcnRpb24pIEFTU0VSVChhc3NlcnRpb24p Ci0jZGVmaW5lIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRShhc3NlcnRpb24sIC4uLikgQVNT RVJUX1dJVEhfTUVTU0FHRShhc3NlcnRpb24sIF9fVkFfQVJHU19fKQotI2RlZmluZSBSRUxFQVNF X0FTU0VSVF9OT1RfUkVBQ0hFRCgpIEFTU0VSVF9OT1RfUkVBQ0hFRCgpCi0jZW5kaWYKIAogI2Vu ZGlmIC8qIFdURl9Bc3NlcnRpb25zX2ggKi8K