141903 2015-02-23 05:45:14 -0800 Add calleeSaveRegisters() implementation for ARM Traditional 2015-02-26 01:20:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 ossy ossy commit-queue fpizlo ossy oldest_to_newest 1071176 0 ossy 2015-02-23 05:45:14 -0800 Add calleeSaveRegisters() implementation for ARM Traditional 1071177 1 247112 ossy 2015-02-23 05:45:28 -0800 Created attachment 247112 Patch 1071178 2 ossy 2015-02-23 06:00:00 -0800 AAPCS (http://infocenter.arm.com/help/topic/com.arm.doc.ihi0042e/IHI0042E_aapcs.pdf) says that r4-r11 are callee-saved registers, only the role of r9 isn't clear. "The role of register r9 is platform specific. A virtual platform may assign any role to this register and must document this usage. For example, it may designate it as the static base (SB) in a position-independent data model, or it may designate it as the thread register (TR) in an environment with thread-local storage. The usage of this register may require that the value held is persistent across all calls. A virtual platform that has no need for such a special register may designate r9 as an additional callee-saved variable register, v6." But it seems GCC ARM EABI handles r9 as callee-saved register: https://github.com/gcc-mirror/gcc/blob/master/gcc/config/arm/arm.h#L775 I checked some disassembly of example codes and JSC too, and can confirm that r4-r11 registers are callee-saved. 1071180 3 ossy 2015-02-23 06:13:21 -0800 You omitted the fp/r7 from ARM Thumb2 callee-saved register list: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/jit/RegisterSet.cpp#L84 But registersToPreserve() explicitly removes fp from the list: http://trac.webkit.org/browser/branches/jsCStack/Source/JavaScriptCore/jit/RegisterPreservationWrapperGenerator.cpp#L37 I think it is confusing to omit r11/fp on ARM Traditional and r7/fp on ARM Thumb2, since these registers are general callee-saved registers. ARM EABI doesn't specify a dedicated frame pointer, additionally GCC omits using frame pointer with O1. 1072318 4 247112 commit-queue 2015-02-26 01:20:43 -0800 Comment on attachment 247112 Patch Clearing flags on attachment: 247112 Committed r180667: <http://trac.webkit.org/changeset/180667> 1072319 5 commit-queue 2015-02-26 01:20:47 -0800 All reviewed patches have been landed. Closing bug. 247112 2015-02-23 05:45:28 -0800 2015-02-26 01:20:43 -0800 Patch bug-141903-20150223054514.patch text/plain 1728 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NjM1MzQ0ODZlYmI4ZGEyMTFlZmRhN2IyZjU2ZmVhMDM0MzEwOWRjLi45ZjU0YWRiNzAwMGQzMWIx MjlmZmY0MDBjY2I1MTBlYWY5NGIyMTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0wMi0yMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEFkZCBjYWxsZWVTYXZlUmVnaXN0ZXJzKCkgaW1wbGVtZW50YXRpb24g Zm9yIEFSTSBUcmFkaXRpb25hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQxOTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBqaXQvUmVnaXN0ZXJTZXQuY3BwOgorICAgICAgICAoSlNDOjpSZWdpc3Rl clNldDo6Y2FsbGVlU2F2ZVJlZ2lzdGVycyk6CisKIDIwMTUtMDItMjEgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBHZW5lcmF0 ZSBQcmV2aWV3cyBtb3JlIG9mdGVuIGZvciBSZW1vdGVPYmplY3QgaW50ZXJhY3Rpb24KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVnaXN0ZXJTZXQuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9SZWdpc3RlclNldC5jcHAKaW5kZXggNjA4ZWJkNTgxOGZiYjFi YTI5ZDc3YTdmOTY0YjhhNDc2ZDgzOTBlZi4uMDNkMGYyZTEyYjU2OWYzMWI2MjcwOWZkYWMzOTRl ZThiM2E0YWEwYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZWdpc3Rl clNldC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZWdpc3RlclNldC5jcHAK QEAgLTg5LDYgKzg5LDE1IEBAIFJlZ2lzdGVyU2V0IFJlZ2lzdGVyU2V0OjpjYWxsZWVTYXZlUmVn aXN0ZXJzKCkKICAgICByZXN1bHQuc2V0KEFSTVJlZ2lzdGVyczo6cjkpOwogICAgIHJlc3VsdC5z ZXQoQVJNUmVnaXN0ZXJzOjpyMTApOwogICAgIHJlc3VsdC5zZXQoQVJNUmVnaXN0ZXJzOjpyMTEp OworI2VsaWYgQ1BVKEFSTV9UUkFESVRJT05BTCkKKyAgICByZXN1bHQuc2V0KEFSTVJlZ2lzdGVy czo6cjQpOworICAgIHJlc3VsdC5zZXQoQVJNUmVnaXN0ZXJzOjpyNSk7CisgICAgcmVzdWx0LnNl dChBUk1SZWdpc3RlcnM6OnI2KTsKKyAgICByZXN1bHQuc2V0KEFSTVJlZ2lzdGVyczo6cjcpOwor ICAgIHJlc3VsdC5zZXQoQVJNUmVnaXN0ZXJzOjpyOCk7CisgICAgcmVzdWx0LnNldChBUk1SZWdp c3RlcnM6OnI5KTsKKyAgICByZXN1bHQuc2V0KEFSTVJlZ2lzdGVyczo6cjEwKTsKKyAgICByZXN1 bHQuc2V0KEFSTVJlZ2lzdGVyczo6cjExKTsKICNlbGlmIENQVShBUk02NCkKICAgICAvLyBXZSBk b24ndCBpbmNsdWRlIExSIGluIHRoZSBzZXQgb2YgY2FsbGVlLXNhdmUgcmVnaXN0ZXJzIGV2ZW4g dGhvdWdoIGl0IHRlY2huaWNhbGx5IGJlbG9uZ3MKICAgICAvLyB0aGVyZS4gVGhpcyBpcyBiZWNh dXNlIHdlIHVzZSB0aGlzIHNldCB0byBkZXNjcmliZSB0aGUgc2V0IG9mIHJlZ2lzdGVycyB0aGF0 IG5lZWQgdG8gYmUgc2F2ZWQK