141898 2015-02-23 01:02:13 -0800 Web Inspector: Do not show "{}" after Date description in Object Previews 2015-02-24 16:32:26 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1071158 0 joepeck 2015-02-23 01:02:13 -0800 * SUMMARY In testing, I see "{}" empty property lists after date instance preview strings. That is misleading and poor. We should just not show it. * STEPS TO REPRODUCE 1. js> ({a: new Date}) => expand object * NOTES - Requires getProperties to send back object previews, and rendering those previews 1071159 1 247105 joepeck 2015-02-23 01:03:41 -0800 Created attachment 247105 [PATCH] Proposed Fix 1071791 2 247105 timothy 2015-02-24 14:27:42 -0800 Comment on attachment 247105 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=247105&action=review > Source/WebInspectorUI/ChangeLog:11 > + Only show "{...}" section for Date objects that have user > + defined properties. Otherwise, Dates do not have properties. We should consider this for RegExp too. 1071814 3 joepeck 2015-02-24 15:21:16 -0800 (In reply to comment #2) > Comment on attachment 247105 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247105&action=review > > > Source/WebInspectorUI/ChangeLog:11 > > + Only show "{...}" section for Date objects that have user > > + defined properties. Otherwise, Dates do not have properties. > > We should consider this for RegExp too. Yep, you pointed out RegExp and Error types. Those are slightly unique in that they have some base set of properties. I'll address them separately. RegExps for instance I'm wondering if there is value in having them still be expandable, or showing preview data if "lastIndex" is non-zero. The rare cases that is being used it would be useful to see that at a glance. Errors should just be expandable, and improve their "stack" output handling. 1071833 4 joepeck 2015-02-24 16:32:26 -0800 http://trac.webkit.org/changeset/180592 247105 2015-02-23 01:03:41 -0800 2015-02-24 14:27:42 -0800 [PATCH] Proposed Fix date-fix.patch text/plain 2074 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ4OGY0YTYuLjMwOWY5YTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IHNob3cgInt9IiBhZnRlciBEYXRlIGRlc2NyaXB0aW9uIGluIE9iamVjdCBQcmV2aWV3cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxODk4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL09iamVjdFByZXZpZXdWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk9i amVjdFByZXZpZXdWaWV3LnByb3RvdHlwZS5fYXBwZW5kUHJvcGVydHlQcmV2aWV3cyk6CisgICAg ICAgIE9ubHkgc2hvdyAiey4uLn0iIHNlY3Rpb24gZm9yIERhdGUgb2JqZWN0cyB0aGF0IGhhdmUg dXNlcgorICAgICAgICBkZWZpbmVkIHByb3BlcnRpZXMuIE90aGVyd2lzZSwgRGF0ZXMgZG8gbm90 IGhhdmUgcHJvcGVydGllcy4KKwogMjAxNS0wMi0yMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1ha2UgQ29uc29sZSBVSSBp Y29ucyAvIGxpbmVzIHNsaWdodGx5IGxhcmdlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0UHJldmlld1ZpZXcuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQcmV2aWV3Vmlldy5qcwpp bmRleCAzYzcwNDYyLi44OWE2YzVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQcmV2aWV3Vmlldy5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQcmV2aWV3Vmlldy5qcwpAQCAt MTQ2LDEzICsxNDYsMTkgQEAgV2ViSW5zcGVjdG9yLk9iamVjdFByZXZpZXdWaWV3LnByb3RvdHlw ZSA9IHsKIAogICAgIF9hcHBlbmRQcm9wZXJ0eVByZXZpZXdzOiBmdW5jdGlvbihlbGVtZW50LCBw cmV2aWV3KQogICAgIHsKKyAgICAgICAgLy8gRG8gbm90IHNob3cgZW1wdHkgcHJvcGVydGllcyBw cmV2aWV3IGZvciBEYXRlIHByZXZpZXdzLgorICAgICAgICB2YXIgaXNEYXRlID0gcHJldmlldy5z dWJ0eXBlID09PSAiZGF0ZSI7CisgICAgICAgIHZhciBudW1Qcm9wZXJ0aWVzID0gcHJldmlldy5w cm9wZXJ0eVByZXZpZXdzLmxlbmd0aDsKKyAgICAgICAgaWYgKCFudW1Qcm9wZXJ0aWVzICYmIGlz RGF0ZSkKKyAgICAgICAgICAgIHJldHVybiBwcmV2aWV3Lmxvc3NsZXNzOworCiAgICAgICAgIHZh ciBpc0FycmF5ID0gcHJldmlldy5zdWJ0eXBlID09PSAiYXJyYXkiOwogCiAgICAgICAgIGVsZW1l bnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoaXNBcnJheSA/ICJbIiA6ICJ7 IikpOwogCiAgICAgICAgIHZhciBudW1iZXJBZGRlZCA9IDA7CiAgICAgICAgIHZhciBsaW1pdCA9 IHRoaXMuX251bWJlck9mUHJvcGVydGllc1RvU2hvd0luTW9kZSgpOwotICAgICAgICBmb3IgKHZh ciBpID0gMDsgaSA8IHByZXZpZXcucHJvcGVydHlQcmV2aWV3cy5sZW5ndGggJiYgbnVtYmVyQWRk ZWQgPCBsaW1pdDsgKytpKSB7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbnVtUHJvcGVy dGllcyAmJiBudW1iZXJBZGRlZCA8IGxpbWl0OyArK2kpIHsKICAgICAgICAgICAgIHZhciBwcm9w ZXJ0eSA9IHByZXZpZXcucHJvcGVydHlQcmV2aWV3c1tpXTsKIAogICAgICAgICAgICAgLy8gRklY TUU6IEJldHRlciBoYW5kbGUgZ2V0dGVyL3NldHRlciBhY2Nlc3NvcnMuIFNob3VsZCB3ZSBzaG93 IGdldHRlcnMgaW4gcHJldmlld3M/Cg==