141890 2015-02-22 22:33:32 -0800 CSS Property parsing error experiments 2015-02-22 23:24:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 benjamin benjamin joepeck oldest_to_newest 1071131 0 benjamin 2015-02-22 22:33:32 -0800 CSS Property parsing error experiments 1071132 1 247100 benjamin 2015-02-22 22:34:34 -0800 Created attachment 247100 Patch 1071136 2 benjamin 2015-02-22 22:38:24 -0800 It is unusable as it is, waaaayyy too many false positive. My first question is: do you care about the line numbers? 1071142 3 joepeck 2015-02-22 23:24:55 -0800 (In reply to comment #2) > It is unusable as it is, waaaayyy too many false positive. > > My first question is: do you care about the line numbers? We care about sourceURL:line:column if we think the user might want to jump to the occurrence that caused the error. I think it would be useful here. "Hey invalid color property? => jump right to the line". 247100 2015-02-22 22:34:34 -0800 2015-02-22 22:34:34 -0800 Patch bug-141890-20150222223423.patch text/plain 6724 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTAxNzZlN2QxMWQ0ZTYx OWE5NzkyMzcwYTY0Mjg1OTZiZGU1MTQ3OC4uNTIyN2UwMmUzYzBhODM2MTU2NDgxMTBlNjFkMzk4 MTY4MGVlMGFjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTAyLTIyICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAorICAgICAgICBDU1MgUHJvcGVy dHkgcGFyc2luZyBlcnJvciBleHBlcmltZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvQ1NTR3JhbW1hci55LmluOgorICAgICAgICAqIGNz cy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpzeW50YXhFcnJv cik6CisgICAgICAgICogY3NzL0NTU1BhcnNlci5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFy c2VyOjppczhCaXRTb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjp0b2tlblN0 YXJ0T2Zmc2V0KToKKworMjAxNS0wMi0yMiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdl YmtpdC5vcmc+CisKICAgICAgICAgQ1NTIEpJVDogYWRkIHN1cHBvcnQgZm9yIGNhc2UtaW5zZW5z aXRpdmUgYXR0cmlidXRlIG1hdGNoaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDE4ODAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L0NTU0dyYW1tYXIueS5pbiBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW4KaW5k ZXggODk0N2RlYzk2ZWJiYWZhZThlMjRjZThjYWJhZGE0YzY3NzNjZmMwYi4uM2ZiOTI1MjhmOWYy ZDFmMzVlZGIxZTdlMjhjYWQyMDZiNTliMWE3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU0dyYW1tYXIueS5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55 LmluCkBAIC0yMzgsNyArMjM4LDcgQEAgc3RhdGljIGJvb2wgc2VsZWN0b3JMaXN0RG9lc05vdE1h dGNoQW55UHNldWRvRWxlbWVudChjb25zdCBWZWN0b3I8c3RkOjp1bmlxdWVfcHQKICV0eXBlIDxy dWxlTGlzdD4gYmxvY2tfcnVsZV9saXN0IGJsb2NrX3ZhbGlkX3J1bGVfbGlzdAogJWRlc3RydWN0 b3IgeyBkZWxldGUgJCQ7IH0gYmxvY2tfcnVsZV9saXN0IGJsb2NrX3ZhbGlkX3J1bGVfbGlzdAog Ci0ldHlwZSA8c3RyaW5nPiBpZGVudF9vcl9zdHJpbmcgbWF5YmVfbnNfcHJlZml4IG5hbWVzcGFj ZV9zZWxlY3RvciBzdHJpbmdfb3JfdXJpCisldHlwZSA8c3RyaW5nPiBpZGVudF9vcl9zdHJpbmcg bWF5YmVfbnNfcHJlZml4IG5hbWVzcGFjZV9zZWxlY3RvciBwcm9wZXJ0eV9pZGVudGlmaWVyIHN0 cmluZ19vcl91cmkKIAogJXR5cGUgPG1hcmdpbkJveD4gbWFyZ2luX3N5bQogCkBAIC0zMTYsNiAr MzE2LDkgQEAgc3RhdGljIGJvb2wgc2VsZWN0b3JMaXN0RG9lc05vdE1hdGNoQW55UHNldWRvRWxl bWVudChjb25zdCBWZWN0b3I8c3RkOjp1bmlxdWVfcHQKICV1bmlvbiB7IGNoYXIgY2hhcmFjdGVy OyB9CiAldHlwZSA8Y2hhcmFjdGVyPiBvcGVyYXRvciBjYWxjX2Z1bmNfb3BlcmF0b3IKIAorJXVu aW9uIHsgdW5zaWduZWQgdW5zaWduZWRfaW50ZWdlcjsgfQorJXR5cGUgPHVuc2lnbmVkX2ludGVn ZXI+IGJlZm9yZV9wcm9wZXJ0eSBhZnRlcl9wcm9wZXJ0eQorCiAldW5pb24geyBDU1NQYXJzZXJW YWx1ZUxpc3QqIHZhbHVlTGlzdDsgfQogJXR5cGUgPHZhbHVlTGlzdD4gY2FsY19mdW5jX2V4cHIg Y2FsY19mdW5jX2V4cHJfbGlzdCBjYWxjX2Z1bmNfcGFyZW5fZXhwciBleHByIGtleV9saXN0IG1h eWJlX21lZGlhX3ZhbHVlIHZhbGlkX2NhbGNfZnVuY19leHByIHZhbGlkX2V4cHIKICVkZXN0cnVj dG9yIHsgZGVsZXRlICQkOyB9IGNhbGNfZnVuY19leHByIGNhbGNfZnVuY19leHByX2xpc3QgY2Fs Y19mdW5jX3BhcmVuX2V4cHIgZXhwciBrZXlfbGlzdCBtYXliZV9tZWRpYV92YWx1ZSB2YWxpZF9j YWxjX2Z1bmNfZXhwciB2YWxpZF9leHByCkBAIC0xNTg5LDcgKzE1OTIsMjEgQEAgZGVjbGFyYXRp b246CiAKIGRlY2xhcmF0aW9uX3JlY292ZXJ5OiBlcnJvciBlcnJvcl9sb2NhdGlvbiBlcnJvcl9y ZWNvdmVyeSB7IHBhcnNlci0+c3ludGF4RXJyb3IoJDIpOyB9IDsKIAotcHJvcGVydHk6IElERU5U IG1heWJlX3NwYWNlIHsgJCQgPSBjc3NQcm9wZXJ0eUlEKCQxKTsgfSA7Citwcm9wZXJ0eToKKyAg ICBiZWZvcmVfcHJvcGVydHkgcHJvcGVydHlfaWRlbnRpZmllciBhZnRlcl9wcm9wZXJ0eSB7Cisg ICAgICAgICQkID0gY3NzUHJvcGVydHlJRCgkMik7CisgICAgICAgIGlmICgkJCA9PSBDU1NQcm9w ZXJ0eUludmFsaWQpCisgICAgICAgICAgICBwYXJzZXItPnN5bnRheEVycm9yKFBhcnNpbmdFcnJv cjo6SW52YWxpZFByb3BlcnR5SWRlbnRpZmllciwgJDEsICQzLCAkMik7CisgICAgfTsKKworYmVm b3JlX3Byb3BlcnR5OiAvKiBlbXB0eSAqLworICAgIHsgJCQgPSBwYXJzZXItPnRva2VuU3RhcnRP ZmZzZXQoKTsgfTsKK3Byb3BlcnR5X2lkZW50aWZpZXI6CisgICAgSURFTlQgbWF5YmVfc3BhY2Ug eworICAgICAgICAkJCA9ICQxCisgICAgfTsKK2FmdGVyX3Byb3BlcnR5OiAvKiBlbXB0eSAqLwor ICAgIHsgJCQgPSBwYXJzZXItPnRva2VuU3RhcnRPZmZzZXQoKTsgfTsKIAogcHJpb3JpdHk6IElN UE9SVEFOVF9TWU0gbWF5YmVfc3BhY2UgeyAkJCA9IHRydWU7IH0gfCAvKiBlbXB0eSAqLyB7ICQk ID0gZmFsc2U7IH0gOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDlhYTY2MTliYTk2 YjU2NGFiODNiM2FmNDg3ZjI1ZGEyMGU1N2EwMjIuLjY1YTVmMDFlMjBiZmE4YzJiYzIzYWY2YjU0 YzU3MTdlY2Y3YmUxYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0xMTg1Niw2ICsx MTg1NiwyNyBAQCB2b2lkIENTU1BhcnNlcjo6c3ludGF4RXJyb3IoY29uc3QgTG9jYXRpb24mIGxv Y2F0aW9uLCBTeW50YXhFcnJvclR5cGUgZXJyb3IpCiAgICAgbV9pZ25vcmVFcnJvcnNJbkRlY2xh cmF0aW9uID0gdHJ1ZTsKIH0KIAorLy8gRklYTUU6IFNob3VsZCB3ZSBnZXQgdGhlIGxpbmUgbnVt YmVyPwordm9pZCBDU1NQYXJzZXI6OnN5bnRheEVycm9yKFBhcnNpbmdFcnJvciBwYXJzaW5nRXJy b3IsIHVuc2lnbmVkIHN0YXJ0LCB1bnNpZ25lZCBlbmQsIGNvbnN0IENTU1BhcnNlclN0cmluZyYg dG9rZW4pCit7CisgICAgc3dpdGNoIChwYXJzaW5nRXJyb3IpIHsKKyAgICBjYXNlIFBhcnNpbmdF cnJvcjo6SW52YWxpZFByb3BlcnR5SWRlbnRpZmllcjogeworICAgICAgICBTdHJpbmcgdG9rZW5T dHJpbmcgPSB0b2tlbjsKKworICAgICAgICAvLyBGSVhNRTogRG8gbm90IHJlcG9ydCBhbmQgZXJy b3IgZm9yIHVucHJlZml4ZWQgdmVyc2lvbiBvZiBwcm9wZXJ0aWVzIGlmIHRoZXJlIGlzIGEgcHJl Zml4ZWQgdmVyc2lvbi4KKyAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBoYW5kbGUgcHJvcGVy dGllcyB0aGF0IG9ubHkgZXhpc3Qgb24gc29tZSBwb3J0cyAoZS5nLiAtd2Via2l0LW92ZXJmbG93 LXNjcm9sbGluZz8pCisKKyAgICAgICAgLy8gRklYTUU6IG1ha2UgdGhpcyAqYSBsb3QqIGZhc3Rl ci4KKyAgICAgICAgaWYgKHRva2VuU3RyaW5nLnN0YXJ0c1dpdGgoIi1tb3otIikgfHwgdG9rZW5T dHJpbmcuc3RhcnRzV2l0aCgiLW8tIikgfHwgdG9rZW5TdHJpbmcuc3RhcnRzV2l0aCgiLW1zLSIp KQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIC8vIEZJWE1FOiBpZiB3ZSByZWFjaCBo ZXJlLCB3ZSBzaG91bGQgdHJ5IHRvIGZpbmQgd2hhdCB2YWxpZCBwcm9wZXJ0eSBjb3VsZCBiZSBk ZXNpcmVkIGZvciB0aGUgaW52YWxpZAorICAgICAgICAvLyBuYW1lLCBmb3IgZXhhbXBsZSAiLXdl YmtpdC1hbGlnbi1jb250ZW50cyIgc2hvdWxkIHN1Z2dlc3QgIi13ZWJraXQtYWxpZ24tY29udGVu dCIuCisgICAgICAgIFdURkxvZ0Fsd2F5cygiSW52YWxpZCBDU1MgUHJvcGVydHkgYXQgJXUgJXU6 ICVzXG4iLCBzdGFydCwgZW5kLCB0b2tlblN0cmluZy51dGY4KCkuZGF0YSgpKTsKKyAgICB9Cisg ICAgfQorfQorCiBib29sIENTU1BhcnNlcjo6aXNMb2dnaW5nRXJyb3JzKCkKIHsKICAgICByZXR1 cm4gbV9sb2dFcnJvcnMgJiYgIW1faWdub3JlRXJyb3JzSW5EZWNsYXJhdGlvbjsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuaAppbmRleCAwNzkyNWY2MmE2NzBlN2I4MjRmYTMyYzA4OGYxOThlYTcxYzI5OWY5 Li4yNjVkOTU4NGUzYTM2MzAwZDg5OTFmNGJkMGVjMGMzZjVhMjdkZWUyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5oCkBAIC03MCwxNCArNzAsMTggQEAgY2xhc3MgU3R5bGVLZXlmcmFtZTsKIGNsYXNz IFN0eWxlU2hlZXRDb250ZW50czsKIGNsYXNzIFN0eWxlZEVsZW1lbnQ7CiAKK2VudW0gY2xhc3Mg UGFyc2luZ0Vycm9yIHsKKyAgICBJbnZhbGlkUHJvcGVydHlJZGVudGlmaWVyCit9OworCiBjbGFz cyBDU1NQYXJzZXIgewogICAgIGZyaWVuZCBpbmxpbmUgaW50IGNzc3l5bGV4KHZvaWQqLCBDU1NQ YXJzZXIqKTsKIAogcHVibGljOgogICAgIHN0cnVjdCBMb2NhdGlvbjsKICAgICBlbnVtIFN5bnRh eEVycm9yVHlwZSB7Ci0gICAgICAgIFByb3BlcnR5RGVjbGFyYXRpb25FcnJvciwKLSAgICAgICAg R2VuZXJhbFN5bnRheEVycm9yCisgICAgICAgIEdlbmVyYWxTeW50YXhFcnJvciwKKyAgICAgICAg UHJvcGVydHlEZWNsYXJhdGlvbkVycm9yCiAgICAgfTsKIAogICAgIGNsYXNzIFZhbHVlV2l0aENh bGN1bGF0aW9uIHsKQEAgLTQwNiw2ICs0MTAsOCBAQCBwdWJsaWM6CiAgICAgUmVmUHRyPENTU1J1 bGVTb3VyY2VEYXRhPiBtX2N1cnJlbnRSdWxlRGF0YTsKICAgICBSdWxlU291cmNlRGF0YUxpc3Qq IG1fcnVsZVNvdXJjZURhdGFSZXN1bHQ7CiAKKyAgICB1bnNpZ25lZCB0b2tlblN0YXJ0T2Zmc2V0 KCkgY29uc3Q7CisKICAgICB2b2lkIGZpeFVucGFyc2VkUHJvcGVydHlSYW5nZXMoQ1NTUnVsZVNv dXJjZURhdGEqKTsKICAgICB2b2lkIG1hcmtSdWxlSGVhZGVyU3RhcnQoQ1NTUnVsZVNvdXJjZURh dGE6OlR5cGUpOwogICAgIHZvaWQgbWFya1J1bGVIZWFkZXJFbmQoKTsKQEAgLTQyNSw2ICs0MzEs NyBAQCBwdWJsaWM6CiAgICAgdm9pZCByZXNldFByb3BlcnR5UmFuZ2UoKSB7IG1fcHJvcGVydHlS YW5nZS5zdGFydCA9IG1fcHJvcGVydHlSYW5nZS5lbmQgPSBVSU5UX01BWDsgfQogICAgIGJvb2wg aXNFeHRyYWN0aW5nU291cmNlRGF0YSgpIGNvbnN0IHsgcmV0dXJuICEhbV9jdXJyZW50UnVsZURh dGFTdGFjazsgfQogICAgIHZvaWQgc3ludGF4RXJyb3IoY29uc3QgTG9jYXRpb24mLCBTeW50YXhF cnJvclR5cGUgPSBHZW5lcmFsU3ludGF4RXJyb3IpOworICAgIHZvaWQgc3ludGF4RXJyb3IoUGFy c2luZ0Vycm9yLCB1bnNpZ25lZCBzdGFydCwgdW5zaWduZWQgZW5kLCBjb25zdCBDU1NQYXJzZXJT dHJpbmcmKTsKIAogICAgIGlubGluZSBpbnQgbGV4KHZvaWQqIHl5bHZhbCkgeyByZXR1cm4gKHRo aXMtPiptX2xleEZ1bmMpKHl5bHZhbCk7IH0KIApAQCAtNDQ1LDcgKzQ1Miw3IEBAIHB1YmxpYzoK ICAgICBzdGF0aWMgYm9vbCBpc0NhbGN1bGF0aW9uKENTU1BhcnNlclZhbHVlJik7CiAKIHByaXZh dGU6Ci0gICAgYm9vbCBpczhCaXRTb3VyY2UoKSB7IHJldHVybiBtX2lzOEJpdFNvdXJjZTsgfQor ICAgIGJvb2wgaXM4Qml0U291cmNlKCkgY29uc3QgeyByZXR1cm4gbV9pczhCaXRTb3VyY2U7IH0K IAogICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBTb3VyY2VDaGFyYWN0ZXJUeXBlPgogICAgIGludCBy ZWFsTGV4KHZvaWQqIHl5bHZhbCk7CkBAIC00NjEsNyArNDY4LDYgQEAgcHJpdmF0ZToKICAgICB0 ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KICAgICBpbmxpbmUgdm9pZCBzZXRUb2tl blN0YXJ0KENoYXJhY3RlclR5cGUqKTsKIAotICAgIGlubGluZSB1bnNpZ25lZCB0b2tlblN0YXJ0 T2Zmc2V0KCk7CiAgICAgaW5saW5lIFVDaGFyIHRva2VuU3RhcnRDaGFyKCk7CiAKICAgICB0ZW1w bGF0ZSA8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KQEAgLTcwNiw3ICs3MTIsNyBAQCBpbmxpbmUg dm9pZCBDU1NQYXJzZXI6OnNldFRva2VuU3RhcnQ8VUNoYXI+KFVDaGFyKiB0b2tlblN0YXJ0KQog ICAgIG1fdG9rZW5TdGFydC5wdHIxNiA9IHRva2VuU3RhcnQ7CiB9CiAKLWlubGluZSB1bnNpZ25l ZCBDU1NQYXJzZXI6OnRva2VuU3RhcnRPZmZzZXQoKQoraW5saW5lIHVuc2lnbmVkIENTU1BhcnNl cjo6dG9rZW5TdGFydE9mZnNldCgpIGNvbnN0CiB7CiAgICAgaWYgKGlzOEJpdFNvdXJjZSgpKQog ICAgICAgICByZXR1cm4gbV90b2tlblN0YXJ0LnB0cjggLSBtX2RhdGFTdGFydDguZ2V0KCk7Cg==