141886 2015-02-22 18:38:31 -0800 [iOS] Max canvas size is lower than expected 2015-02-23 14:42:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino commit-queue esprehn+autocc graouts gyuyoung.kim oldest_to_newest 1071111 0 dino 2015-02-22 18:38:31 -0800 [iOS] Max canvas size is lower than expected 1071115 1 247091 dino 2015-02-22 18:42:30 -0800 Created attachment 247091 Patch 1071143 2 graouts 2015-02-22 23:32:29 -0800 While I greatly appreciate this limit being bumped to a more accurate limit, what exactly is the purpose of the limit? Is it for performance reason? Memory consumption reasons? If so, why not let content degrade and/or jetsam if values are too large? Especially as there is no mechanism in place to predictably figure out, in code, whether a given <canvas> size will actually allow the content to be rendered. 1071236 3 dino 2015-02-23 10:20:23 -0800 (In reply to comment #2) > While I greatly appreciate this limit being bumped to a more accurate limit, > what exactly is the purpose of the limit? Is it for performance reason? > Memory consumption reasons? If so, why not let content degrade and/or jetsam > if values are too large? Especially as there is no mechanism in place to > predictably figure out, in code, whether a given <canvas> size will actually > allow the content to be rendered. I tried Firefox and it fails silently when the canvas gets too big, like us. So I think it is worth keeping a limit in, just in case. Note that it's a pretty bad developer experience if their page instantly quits/crashes - that gives them no way to debug without removing random code and starting over. At least with a large limit they'll get a warning in the console as to what went wrong. 1071347 4 dino 2015-02-23 14:42:48 -0800 Committed r180520: <http://trac.webkit.org/changeset/180520> 247091 2015-02-22 18:42:30 -0800 2015-02-23 11:12:12 -0800 Patch bug-141886-20150223134219.patch text/plain 2168 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFlYWZjOTk3OTc5NDQ3 NmIyNjdjNjE2ZGQ2ZGI5OWE1YmVjY2YxZS4uMGE2YWNiZDQyNTRmOGEzYjIxYzBhNDdiNDQwMTYz OTlmY2MzODgyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTAyLTIyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICBbaU9TXSBNYXggY2FudmFzIHNp emUgaXMgbG93ZXIgdGhhbiBleHBlY3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQxODg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xOTcyOTI0 Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ug dGhlIHNhbWUgbWF4aW11bSBjYW52YXMgYXJlYSBmb3IgYWxsIHBvcnRzLAorICAgICAgICB3aGlj aCBidW1wcyB0aGUgaU9TIGxpbWl0IHVwIGZyb20gNDU4MCAqIDExNDUKKyAgICAgICAgdG8gMTZr ICogMTZrLgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6IFVwZGF0ZSBN YXhDYW52YXNBcmVhLgorCisyMDE1LTAyLTIyICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNv bT4KKwogICAgICAgICBQcmludCBhIGNvbnNvbGUgd2FybmluZyB3aGVuIEhUTUxDYW52YXNFbGVt ZW50IGV4Y2VlZHMgdGhlIG1heGltdW0gc2l6ZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxODYxCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xOTcy OTE0NT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKaW5kZXggNmMz NzIyNTU2MzliMGQ3YzhhNWJmOTlhMjdhOTk2ZmRiNGZkNWVmZi4uZmMzMGMyMzIxZDczODlhMTNj OWI2YTU2ZmI5NTUwZTEyNmNjYjIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MQ2FudmFzRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFz RWxlbWVudC5jcHAKQEAgLTYxLDE4ICs2MSwxNCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHVz aW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKLS8vIFRoZXNlIHZhbHVlcyBjb21lIGZyb20gdGhl IFdoYXRXRyBzcGVjLgorLy8gVGhlc2UgdmFsdWVzIGNvbWUgZnJvbSB0aGUgV2hhdFdHL1czQyBI VE1MIHNwZWMuCiBzdGF0aWMgY29uc3QgaW50IERlZmF1bHRXaWR0aCA9IDMwMDsKIHN0YXRpYyBj b25zdCBpbnQgRGVmYXVsdEhlaWdodCA9IDE1MDsKIAogLy8gRmlyZWZveCBsaW1pdHMgd2lkdGgv aGVpZ2h0IHRvIDMyNzY3IHBpeGVscywgYnV0IHNsb3dzIGRvd24gZHJhbWF0aWNhbGx5IGJlZm9y ZSBpdAogLy8gcmVhY2hlcyB0aGF0IGxpbWl0LiBXZSBsaW1pdCBieSBhcmVhIGluc3RlYWQsIGdp dmluZyB1cyBsYXJnZXIgbWF4aW11bSBkaW1lbnNpb25zLAotLy8gaW4gZXhjaGFuZ2UgZm9yIGEg c21hbGxlciBtYXhpbXVtIGNhbnZhcyBzaXplLiBUaGUgbWF4aW11bSBjYW52YXMgc2l6ZSBpcyBp biBDU1MgcGl4ZWxzLgotI2lmIFBMQVRGT1JNKElPUykKLXN0YXRpYyBjb25zdCBmbG9hdCBNYXhD YW52YXNBcmVhID0gNDU4MCAqIDExNDU7IC8vIDIwIE1CIGFzc3VtaW5nIDQgYnl0ZXMgcGVyIHBp eGVsCi0jZWxzZQotc3RhdGljIGNvbnN0IGZsb2F0IE1heENhbnZhc0FyZWEgPSAzMjc2OCAqIDgx OTI7Ci0jZW5kaWYKKy8vIGluIGV4Y2hhbmdlIGZvciBhIHNtYWxsZXIgbWF4aW11bSBjYW52YXMg c2l6ZS4gVGhlIG1heGltdW0gY2FudmFzIHNpemUgaXMgaW4gZGV2aWNlIHBpeGVscy4KK3N0YXRp YyBjb25zdCBmbG9hdCBNYXhDYW52YXNBcmVhID0gMTYzODQgKiAxNjM4NDsKIAogSFRNTENhbnZh c0VsZW1lbnQ6OkhUTUxDYW52YXNFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUs IERvY3VtZW50JiBkb2N1bWVudCkKICAgICA6IEhUTUxFbGVtZW50KHRhZ05hbWUsIGRvY3VtZW50 KQo=