141884 2015-02-22 18:06:12 -0800 [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute 2015-02-23 10:53:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer ap commit-queue dbates glenn jake.nielsen.webkit webkit-bug-importer oldest_to_newest 1071104 0 ddkilzer 2015-02-22 18:06:12 -0800 run-webkit-tests --leaks is broken because IOSSimulatorPort does not define an is_snowleopard attribute: $ ./Tools/Scripts/run-webkit-tests --release --ios-simulator --results-directory /tmp/layout-test-results-adhoc-test --leaks [...] Process worker/22: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap worker/22: AttributeError(''IOSSimulatorPort' object has no attribute 'is_snowleopard'') raised: File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/common/message_pool.py", line 255, in run worker.handle(message.name, message.src, *message.args) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 256, in handle self._run_test(test_input, test_list_name) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 280, in _run_test result = self._run_test_with_or_without_timeout(test_input, test_timeout_sec, stop_when_done) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 323, in _run_test_with_or_without_timeout return self._run_test_in_this_thread(test_input, stop_when_done) self.run() File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 404, in _run_test_in_this_thread return self._run_single_test(self._driver, test_input, stop_when_done) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/common/message_pool.py", line 271, in run File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 408, in _run_single_test self._name, driver, test_input, stop_when_done) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 46, in run_single_test return runner.run() worker.stop() File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 102, in run File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 293, in stop self._kill_driver() File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 318, in _kill_driver return self._run_reftest() File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 291, in _run_reftest driver.stop() File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/driver.py", line 635, in stop test_output = self._driver.run_test(self._driver_input(), self._stop_when_done) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/driver.py", line 629, in run_test self._driver.stop() return self._driver.run_test(driver_input, stop_when_done) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/driver.py", line 203, in run_test File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/driver.py", line 347, in stop out, err = self._server_process.stop(self._port.driver_stop_timeout() if stop_when_done else 0.0) self._server_process.stop(self._port.driver_stop_timeout()) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/server_process.py", line 337, in stop File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/server_process.py", line 337, in stop self._port.check_for_leaks(self.name(), self.pid()) self._port.check_for_leaks(self.name(), self.pid()) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/ios.py", line 257, in check_for_leaks File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/ios.py", line 257, in check_for_leaks self._leak_detector.check_for_leaks(process_name, process_pid) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/leakdetector.py", line 133, in check_for_leaks leaks_output = self._port._run_script("run-leaks", self._leaks_args(process_pid), include_configuration_arguments=False, decode_output=False) self._leak_detector.check_for_leaks(process_name, process_pid) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/leakdetector.py", line 80, in _leaks_args for callstack in self._callstacks_to_exclude_from_leaks(): File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/leakdetector.py", line 133, in check_for_leaks File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/leakdetector.py", line 60, in _callstacks_to_exclude_from_leaks if self._port.is_snowleopard(): leaks_output = self._port._run_script("run-leaks", self._leaks_args(process_pid)AttributeError: 'IOSSimulatorPort' object has no attribute 'is_snowleopard' , include_configuration_arguments=False, decode_output=False) File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/leakdetector.py", line 80, in _leaks_args for callstack in self._callstacks_to_exclude_from_leaks(): File "/Volumes/Data/WebKit.git/Tools/Scripts/webkitpy/port/leakdetector.py", line 60, in _callstacks_to_exclude_from_leaks if self._port.is_snowleopard(): Exception AttributeError: AttributeError("'IOSSimulatorPort' object has no attribute 'is_snowleopard'",) in <bound method IOSSimulatorDriver.__del__ of <webkitpy.port.driver.IOSSimulatorDriver object at 0x10a5ddd10>> ignored 1071105 1 ddkilzer 2015-02-22 18:06:34 -0800 <rdar://problem/19917423> 1071107 2 247089 ddkilzer 2015-02-22 18:15:44 -0800 Created attachment 247089 Patch v1 1071124 3 ddkilzer 2015-02-22 20:53:25 -0800 Interestingly, even after this fix, run-webkit-tests --ios-simulator is checking leaks on the LayouTestRelay process, not the DumpRenderTree.app process, and MallocStackLogging=1 is not being set when launching DumpRenderTree.app. So there is more work to do here. 1071229 4 ddkilzer 2015-02-23 10:07:49 -0800 (In reply to comment #3) > Interestingly, even after this fix, run-webkit-tests --ios-simulator is > checking leaks on the LayouTestRelay process, not the DumpRenderTree.app > process, and MallocStackLogging=1 is not being set when launching > DumpRenderTree.app. > > So there is more work to do here. Will do the follow-up work in another bug. 1071250 5 247089 commit-queue 2015-02-23 10:53:23 -0800 Comment on attachment 247089 Patch v1 Clearing flags on attachment: 247089 Committed r180509: <http://trac.webkit.org/changeset/180509> 1071251 6 commit-queue 2015-02-23 10:53:26 -0800 All reviewed patches have been landed. Closing bug. 247089 2015-02-22 18:15:44 -0800 2015-02-23 10:53:23 -0800 Patch v1 bug-141884-20150222181534.patch text/plain 3871 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwNDg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2Q4M2E5OTk2Y2M0MDA4ZDcyODM5YzBlOGQ4YzUzZjA1 YzE3ODY4My4uMTU0NTlkMzA5YTg3MjVjZjQ1YzUxN2FkMjc1MTQ0NDQ5MmUzYjY4YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE1LTAyLTIyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgW2lPU10gcnVuLXdlYmtpdC10ZXN0cyAtLWxlYWtzIGlzIGJyb2tlbiBiZWNhdXNlIElP U1NpbXVsYXRvclBvcnQgaGFzIG5vIGlzX3Nub3dsZW9wYXJkIGF0dHJpYnV0ZQorICAgICAgICA8 aHR0cDovL3dlYmtpdC5vcmcvYi8xNDE4ODQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGVha2RldGVjdG9y LnB5OgorICAgICAgICAoTGVha0RldGVjdG9yLl9jYWxsc3RhY2tzX3RvX2V4Y2x1ZGVfZnJvbV9s ZWFrcyk6IFJlbW92ZQorICAgICAgICBzbm93bGVvcGFyZCwgbGlvbiBhbmQgb2xkZXIgbGVha3Mu ICBBZGQga25vd24gbGVhayBmb3IKKyAgICAgICAgbWF2ZXJpY2tzLCBidXQgY2hlY2sgUG9ydC5v cGVyYXRpbmdfc3lzdGVtIGJlZm9yZSBjYWxsaW5nCisgICAgICAgIFBvcnQuaXNfbWF2ZXJpY2tz LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWMucHk6CisgICAgICAgIChNYWNQ b3J0LmlzX3Nub3dsZW9wYXJkKTogRGVsZXRlLgorICAgICAgICAoTWFjUG9ydC5pc19saW9uKTog RGVsZXRlLgorICAgICAgICAoTWFjUG9ydC5pc19tYXZlcmlja3MpOiBBZGQuCisKIDIwMTUtMDIt MjEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAg ICBUZXN0cyBkb24ndCB3b3JrIG9uIHNvbWUgYm90czogRmFpbGVkIHRvIHN0b3Agd3B0d2sKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9sZWFrZGV0ZWN0b3IucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGVha2RldGVjdG9yLnB5CmluZGV4IGY0NmNkMzRl NTU3Mjg0YjA5ODYyMmIzNTMxZGZiYzc3Yzk0YTAzY2MuLmY1ZWRlY2ZhNWE0OGE4NjgwZDRlOWVl NWE2NjBiMjhjZjRkM2Q5NTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9sZWFrZGV0ZWN0b3IucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xlYWtk ZXRlY3Rvci5weQpAQCAtNTMsMjUgKzUzLDEwIEBAIGNsYXNzIExlYWtEZXRlY3RvcihvYmplY3Qp OgogICAgICAgICByZXR1cm4gW10KIAogICAgIGRlZiBfY2FsbHN0YWNrc190b19leGNsdWRlX2Zy b21fbGVha3Moc2VsZik6Ci0gICAgICAgIGNhbGxzdGFja3MgPSBbCi0gICAgICAgICAgICAiRmxh c2hfRW5mb3JjZUxvY2FsU2VjdXJpdHkiLCAgIyBsZWFrcyBpbiBGbGFzaCBwbHVnLWluIGNvZGUs IHJkYXI6Ly9wcm9ibGVtLzQ0NDk3NDcKLSAgICAgICAgICAgICJTY2FuRnJvbVN0cmluZyIsICMg PGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9hbmdsZXByb2plY3QvaXNzdWVzL2RldGFpbD9pZD0y NDk+IGxlYWsgaW4gQU5HTEUKLSAgICAgICAgXQotICAgICAgICBpZiBzZWxmLl9wb3J0LmlzX3Nu b3dsZW9wYXJkKCk6CisgICAgICAgIGNhbGxzdGFja3MgPSBbXQorICAgICAgICBpZiBzZWxmLl9w b3J0Lm9wZXJhdGluZ19zeXN0ZW0gPT0gJ21hYycgYW5kIHNlbGYuX3BvcnQuaXNfbWF2ZXJpY2tz KCk6CiAgICAgICAgICAgICBjYWxsc3RhY2tzICs9IFsKLSAgICAgICAgICAgICAgICAicmVhZE1h a2VyTm90ZVByb3BzIiwgICMgPHJkYXI6Ly9wcm9ibGVtLzcxNTY0MzI+IGxlYWsgaW4gSW1hZ2VJ TwotICAgICAgICAgICAgICAgICJRVEtpdE1vdmllQ29udHJvbGxlclZpZXcgY29tcGxldGVVSVNl dHVwIiwgICMgPHJkYXI6Ly9wcm9ibGVtLzcxNTUxNTY+IGxlYWsgaW4gUVRLaXQKLSAgICAgICAg ICAgICAgICAiZ2V0Vk1Jbml0QXJncyIsICAjIDxyZGFyOi8vcHJvYmxlbS83NzE0NDQ0PiBsZWFr IGluIEphdmEKLSAgICAgICAgICAgICAgICAiSmF2YV9qYXZhX2xhbmdfU3lzdGVtX2luaXRQcm9w ZXJ0aWVzIiwgICMgPHJkYXI6Ly9wcm9ibGVtLzc3MTQ0NjU+IGxlYWsgaW4gSmF2YQotICAgICAg ICAgICAgICAgICJnbHJDb21wRXhlY3V0ZUtlcm5lbCIsICAjIDxyZGFyOi8vcHJvYmxlbS83ODE1 MzkxPiBsZWFrIGluIGdyYXBoaWNzIGRyaXZlciB3aGlsZSB1c2luZyBPcGVuR0wKLSAgICAgICAg ICAgICAgICAiTlNOdW1iZXJGb3JtYXR0ZXIgZ2V0T2JqZWN0VmFsdWU6Zm9yU3RyaW5nOmVycm9y RGVzY3JpcHRpb246IiwgICMgPHJkYXI6Ly9wcm9ibGVtLzcxNDkzNTA+IExlYWsgaW4gTlNOdW1i ZXJGb3JtYXR0ZXIKLSAgICAgICAgICAgIF0KLSAgICAgICAgZWxpZiBzZWxmLl9wb3J0LmlzX2xp b24oKToKLSAgICAgICAgICAgIGNhbGxzdGFja3MgKz0gWwotICAgICAgICAgICAgICAgICJGaWdC eXRlRmx1bWVDdXN0b21VUkxDcmVhdGVXaXRoVVJMIiwgIyA8cmRhcjovL3Byb2JsZW0vMTA0NjE5 MjY+IGxlYWsgaW4gQ29yZU1lZGlhCi0gICAgICAgICAgICAgICAgIlBERlBhZ2VcKFBERlBhZ2VJ bnRlcm5hbFwpIHBhZ2VMYXlvdXRJZkF2YWlsIiwgIyA8cmRhcjovL3Byb2JsZW0vMTA0NjIwNTU+ IGxlYWsgaW4gUERGS2l0Ci0gICAgICAgICAgICAgICAgIlNlY1RyYW5zZm9ybUV4ZWN1dGUiLCAj IDxyZGFyOi8vcHJvYmxlbS8xMDQ3MDY2Nz4gbGVhayBpbiBTZWN1cml0eS5mcmFtZXdvcmsKLSAg ICAgICAgICAgICAgICAiX05TQ29weVN0eWxlUmVmRm9yRm9jdXNSaW5nU3R5bGVDbGlwIiwgIyA8 cmRhcjovL3Byb2JsZW0vMTA0NjIwMzE+IGxlYWsgaW4gQXBwS2l0CisgICAgICAgICAgICAgICAg J0FWQXNzZXRSZXNvdXJjZUxvYWRlciBfcG9zZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlV2l0aEtl eTpkYXRhOnJlcXVlc3REaWN0aW9uYXJ5OmZhbGxiYWNrSGFuZGxlcjonLCAgIyA8cmRhcjovL3By b2JsZW0vMTk2OTk4ODc+IGxlYWsgaW4gQVZGb3VuZGF0aW9uCiAgICAgICAgICAgICBdCiAgICAg ICAgIHJldHVybiBjYWxsc3RhY2tzCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC9tYWMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CmluZGV4 IDNiMThkYmRlNmRkYjg1MDc1YzgxZjIwNDQ2YjdmZjgxZGI5NjgzZWYuLjE4ZDA2YzYwNTllNTRi ZDg5ZjgyNmY1ODBkZjU2MGI2Njc5MTg2YTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9tYWMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5w eQpAQCAtMTExLDEyICsxMTEsOCBAQCBjbGFzcyBNYWNQb3J0KEFwcGxlUG9ydCk6CiAgICAgICAg IHJldHVybiAnbWFjJwogCiAgICAgIyBCZWxvbmdzIG9uIGEgUGxhdGZvcm0gb2JqZWN0LgotICAg IGRlZiBpc19zbm93bGVvcGFyZChzZWxmKToKLSAgICAgICAgcmV0dXJuIHNlbGYuX3ZlcnNpb24g PT0gInNub3dsZW9wYXJkIgotCi0gICAgIyBCZWxvbmdzIG9uIGEgUGxhdGZvcm0gb2JqZWN0Lgot ICAgIGRlZiBpc19saW9uKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi5fdmVyc2lvbiA9PSAi bGlvbiIKKyAgICBkZWYgaXNfbWF2ZXJpY2tzKHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi5f dmVyc2lvbiA9PSAnbWF2ZXJpY2tzJwogCiAgICAgZGVmIGRlZmF1bHRfY2hpbGRfcHJvY2Vzc2Vz KHNlbGYpOgogICAgICAgICBpZiBzZWxmLl92ZXJzaW9uID09ICJzbm93bGVvcGFyZCI6Cg==