141873 2015-02-21 18:16:30 -0800 Web Inspector: Lazily Create GeneralTreeElement Status Elements 2015-02-22 08:49:32 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1071031 0 joepeck 2015-02-21 18:16:30 -0800 * SUMMARY Lazily Create GeneralTreeElement Status Elements. We do not always need status elements, so we are creating a lot more elements then we need. Soon the console we will have a lot of GeneralTreeElements with no need for status elements at all. 1071032 1 247069 joepeck 2015-02-21 18:18:25 -0800 Created attachment 247069 [PATCH] Proposed Fix 1071076 2 247069 commit-queue 2015-02-22 08:49:28 -0800 Comment on attachment 247069 [PATCH] Proposed Fix Clearing flags on attachment: 247069 Committed r180486: <http://trac.webkit.org/changeset/180486> 1071077 3 commit-queue 2015-02-22 08:49:32 -0800 All reviewed patches have been landed. Closing bug. 247069 2015-02-21 18:18:25 -0800 2015-02-22 08:49:28 -0800 [PATCH] Proposed Fix status.patch text/plain 4966 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMzYjhiMGQuLmE4MDMwZTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAyLTIxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTGF6aWx5 IENyZWF0ZSBHZW5lcmFsVHJlZUVsZW1lbnQgU3RhdHVzIEVsZW1lbnRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4NzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv R2VuZXJhbFRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkdlbmVyYWxUcmVl RWxlbWVudC5wcm90b3R5cGUuc2V0IHN0YXR1cyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuR2Vu ZXJhbFRyZWVFbGVtZW50LnByb3RvdHlwZS5vbmF0dGFjaCk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuR2VuZXJhbFRyZWVFbGVtZW50LnByb3RvdHlwZS5fY3JlYXRlRWxlbWVudHNJZk5lZWRlZCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuR2VuZXJhbFRyZWVFbGVtZW50LnByb3RvdHlwZS5fdXBk YXRlU3RhdHVzRWxlbWVudCk6CisgICAgICAgIExhemlseSBjcmVhdGUgYW5kIGF0dGFjaCB0aGUg c3RhdHVzIGVsZW1lbnQgY29udGFpbmVyIGlmCisgICAgICAgICJ0aGlzLnN0YXR1cyIgaXMgYWN0 dWFsbHkgdXNlZCBieSBhIEdlbmVyYWxUcmVlRWxlbWVudCBzdWJjbGFzcy4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5SZXNvdXJjZVRyZWVFbGVtZW50LnByb3RvdHlwZS5fdXBkYXRlU3RhdHVzKToK KyAgICAgICAgU2V0IHRvIHRoZSBlbXB0eSBzdHJpbmcgaW5zdGVhZCBvZiBudWxsIHRvIGF2b2lk IGluYWR2ZXJ0ZW50bHkKKyAgICAgICAgY3JlYXRpbmcgc3RhdHVzIGVsZW1lbnRzIGZvciBubyBy ZWFzb24uCisKIDIwMTUtMDItMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBVc2Ugb2YgQXJyYXkuZnJvbSBmb3IgTm9kZUxp c3QvQXJndW1lbnRzIHRvIEFycmF5IGNvbnZlcnNpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxUcmVlRWxlbWVudC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxUcmVlRWxlbWVu dC5qcwppbmRleCAwZmYzZTEwLi5jY2FhMmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVHJlZUVsZW1lbnQuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFRyZWVFbGVtZW50 LmpzCkBAIC0yMDYsNiArMjA2LDExIEBAIFdlYkluc3BlY3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQu cHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fc3RhdHVzID09PSB4KQogICAgICAgICAg ICAgcmV0dXJuOwogCisgICAgICAgIGlmICghdGhpcy5fc3RhdHVzRWxlbWVudCkgeworICAgICAg ICAgICAgdGhpcy5fc3RhdHVzRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIp OworICAgICAgICAgICAgdGhpcy5fc3RhdHVzRWxlbWVudC5jbGFzc05hbWUgPSBXZWJJbnNwZWN0 b3IuR2VuZXJhbFRyZWVFbGVtZW50LlN0YXR1c0VsZW1lbnRTdHlsZUNsYXNzTmFtZTsKKyAgICAg ICAgfQorCiAgICAgICAgIHRoaXMuX3N0YXR1cyA9IHggfHwgIiI7CiAgICAgICAgIHRoaXMuX3Vw ZGF0ZVN0YXR1c0VsZW1lbnQoKTsKICAgICB9LApAQCAtMjM2LDcgKzI0MSw2IEBAIFdlYkluc3Bl Y3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgdGhp cy5fY3JlYXRlRWxlbWVudHNJZk5lZWRlZCgpOwogICAgICAgICB0aGlzLl91cGRhdGVUaXRsZUVs ZW1lbnRzKCk7Ci0gICAgICAgIHRoaXMuX3VwZGF0ZVN0YXR1c0VsZW1lbnQoKTsKIAogICAgICAg ICB0aGlzLl9saXN0SXRlbU5vZGUuY2xhc3NMaXN0LmFkZChXZWJJbnNwZWN0b3IuR2VuZXJhbFRy ZWVFbGVtZW50LlN0eWxlQ2xhc3NOYW1lKTsKIApAQCAtMjUzLDcgKzI1Nyw2IEBAIFdlYkluc3Bl Y3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogCiAgICAgICAgIHRoaXMuX2xp c3RJdGVtTm9kZS5hcHBlbmRDaGlsZCh0aGlzLl9kaXNjbG9zdXJlQnV0dG9uKTsKICAgICAgICAg dGhpcy5fbGlzdEl0ZW1Ob2RlLmFwcGVuZENoaWxkKHRoaXMuX2ljb25FbGVtZW50KTsKLSAgICAg ICAgdGhpcy5fbGlzdEl0ZW1Ob2RlLmFwcGVuZENoaWxkKHRoaXMuX3N0YXR1c0VsZW1lbnQpOwog ICAgICAgICB0aGlzLl9saXN0SXRlbU5vZGUuYXBwZW5kQ2hpbGQodGhpcy5fdGl0bGVzRWxlbWVu dCk7CiAKICAgICAgICAgaWYgKHRoaXMub25jb250ZXh0bWVudSAmJiB0eXBlb2YgdGhpcy5vbmNv bnRleHRtZW51ID09PSAiZnVuY3Rpb24iKSB7CkBAIC0yNjUsNiArMjY4LDggQEAgV2ViSW5zcGVj dG9yLkdlbmVyYWxUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0aGlzLl9i b3VuZENvbnRleHRNZW51RXZlbnRIYW5kbGVyID0gZnVuY3Rpb24oZXZlbnQpIHsgdGhpcy50cmVl T3V0bGluZS5vbmNvbnRleHRtZW51KGV2ZW50LCB0aGlzKTsgfS5iaW5kKHRoaXMpOwogICAgICAg ICAgICAgdGhpcy5fbGlzdEl0ZW1Ob2RlLmFkZEV2ZW50TGlzdGVuZXIoImNvbnRleHRtZW51Iiwg dGhpcy5fYm91bmRDb250ZXh0TWVudUV2ZW50SGFuZGxlciwgdHJ1ZSk7CiAgICAgICAgIH0KKwor ICAgICAgICB0aGlzLl91cGRhdGVTdGF0dXNFbGVtZW50KCk7CiAgICAgfSwKIAogICAgIG9uZGV0 YWNoOiBmdW5jdGlvbigpCkBAIC0zMTQsOSArMzE5LDYgQEAgV2ViSW5zcGVjdG9yLkdlbmVyYWxU cmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2ljb25FbGVtZW50ID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgiaW1nIik7CiAgICAgICAgIHRoaXMuX2ljb25FbGVtZW50LmNs YXNzTmFtZSA9IFdlYkluc3BlY3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQuSWNvbkVsZW1lbnRTdHls ZUNsYXNzTmFtZTsKIAotICAgICAgICB0aGlzLl9zdGF0dXNFbGVtZW50ID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiZGl2Iik7Ci0gICAgICAgIHRoaXMuX3N0YXR1c0VsZW1lbnQuY2xhc3NOYW1l ID0gV2ViSW5zcGVjdG9yLkdlbmVyYWxUcmVlRWxlbWVudC5TdGF0dXNFbGVtZW50U3R5bGVDbGFz c05hbWU7Ci0KICAgICAgICAgdGhpcy5fdGl0bGVzRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoImRpdiIpOwogICAgICAgICB0aGlzLl90aXRsZXNFbGVtZW50LmNsYXNzTmFtZSA9IFdl Ykluc3BlY3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQuVGl0bGVzRWxlbWVudFN0eWxlQ2xhc3NOYW1l OwogCkBAIC0zODUsOSArMzg3LDEyIEBAIFdlYkluc3BlY3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQu cHJvdG90eXBlID0gewogCiAgICAgX3VwZGF0ZVN0YXR1c0VsZW1lbnQ6IGZ1bmN0aW9uKCkKICAg ICB7Ci0gICAgICAgIGlmICghdGhpcy5fY3JlYXRlZEVsZW1lbnRzKQorICAgICAgICBpZiAoIXRo aXMuX3N0YXR1c0VsZW1lbnQpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgaWYgKCF0 aGlzLl9zdGF0dXNFbGVtZW50LnBhcmVudE5vZGUgJiYgdGhpcy5fbGlzdEl0ZW1Ob2RlKQorICAg ICAgICAgICAgdGhpcy5fbGlzdEl0ZW1Ob2RlLmluc2VydEJlZm9yZSh0aGlzLl9zdGF0dXNFbGVt ZW50LCB0aGlzLl90aXRsZXNFbGVtZW50KTsKKwogICAgICAgICBpZiAodGhpcy5fc3RhdHVzIGlu c3RhbmNlb2YgTm9kZSkgewogICAgICAgICAgICAgdGhpcy5fc3RhdHVzRWxlbWVudC5yZW1vdmVD aGlsZHJlbigpOwogICAgICAgICAgICAgdGhpcy5fc3RhdHVzRWxlbWVudC5hcHBlbmRDaGlsZCh0 aGlzLl9zdGF0dXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmVzb3VyY2VUcmVlRWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVHJlZUVsZW1lbnQuanMKaW5kZXggMzBjNzVm ZC4uYjgwOThhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvUmVzb3VyY2VUcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRyZWVFbGVtZW50LmpzCkBAIC0xNjksNyAr MTY5LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewog ICAgICAgICAgICAgaWYgKHRoaXMuX3Jlc291cmNlLmlzTWFpblJlc291cmNlKCkgJiYgZnJhbWUg JiYgZnJhbWUuaXNNYWluRnJhbWUoKSAmJiB0aGlzIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkZy YW1lVHJlZUVsZW1lbnQpCiAgICAgICAgICAgICAgICAgdGhpcy51cGRhdGVTdGF0dXNGb3JNYWlu RnJhbWUoKTsKICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICB0aGlzLnN0YXR1cyA9 IG51bGw7CisgICAgICAgICAgICAgICAgdGhpcy5zdGF0dXMgPSAiIjsKICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgIHZhciBzcGlubmVyID0gbmV3IFdlYkluc3BlY3Rvci5JbmRldGVybWlu YXRlUHJvZ3Jlc3NTcGlubmVyOwogICAgICAgICAgICAgdGhpcy5zdGF0dXMgPSBzcGlubmVyLmVs ZW1lbnQ7Cg==