141854 2015-02-20 14:00:29 -0800 Invalid assert in CompositeEditCommand::insertNodeAfter/insertNodeBefore 2015-02-20 15:27:58 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue oldest_to_newest 1070819 0 zalan 2015-02-20 14:00:29 -0800 ASSERT(!refChild->hasTagName(bodyTag)); should be allowed 1070825 1 247002 zalan 2015-02-20 14:17:40 -0800 Created attachment 247002 Patch 1070826 2 247002 rniwa 2015-02-20 14:19:20 -0800 Comment on attachment 247002 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247002&action=review > Source/WebCore/ChangeLog:8 > + Inserting content before/after the body as the result of editing is a valid operation. I think we should elaborate that while we don't want to move nodes out of body element, we can't check that condition with these assertions. > LayoutTests/editing/inserting/insert-as-body-sibling.html:1 > +<head> Missing DOCTYPE. > LayoutTests/editing/inserting/insert-as-body-sibling.html:13 > + if (window.testRunner) > + testRunner.dumpAsText(); > + > + var iframe = document.createElement("iframe"); > + document.head.parentNode.insertBefore(iframe, document.head.nextSibling); > + document.execCommand("SelectAll"); > + document.designMode = "on"; > + document.execCommand("JustifyCenter", false, null); Please indent by 4 spaces, not 2 spaces. 1070831 3 247003 zalan 2015-02-20 14:22:40 -0800 Created attachment 247003 Patch 1070837 4 247004 zalan 2015-02-20 14:26:21 -0800 Created attachment 247004 Patch 1070838 5 zalan 2015-02-20 14:26:48 -0800 (In reply to comment #2) > Comment on attachment 247002 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247002&action=review > > > Source/WebCore/ChangeLog:8 > > + Inserting content before/after the body as the result of editing is a valid operation. > > I think we should elaborate that while we don't want to move nodes out of > body element, we can't check that condition with these assertions. > > > LayoutTests/editing/inserting/insert-as-body-sibling.html:1 > > +<head> > > Missing DOCTYPE. > > > LayoutTests/editing/inserting/insert-as-body-sibling.html:13 > > + if (window.testRunner) > > + testRunner.dumpAsText(); > > + > > + var iframe = document.createElement("iframe"); > > + document.head.parentNode.insertBefore(iframe, document.head.nextSibling); > > + document.execCommand("SelectAll"); > > + document.designMode = "on"; > > + document.execCommand("JustifyCenter", false, null); > > Please indent by 4 spaces, not 2 spaces. Done. Thanks. 1070849 6 247004 commit-queue 2015-02-20 15:27:53 -0800 Comment on attachment 247004 Patch Clearing flags on attachment: 247004 Committed r180464: <http://trac.webkit.org/changeset/180464> 1070850 7 commit-queue 2015-02-20 15:27:58 -0800 All reviewed patches have been landed. Closing bug. 247002 2015-02-20 14:17:40 -0800 2015-02-20 14:22:36 -0800 Patch bug-141854-20150220141731.patch text/plain 4026 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU2N2NkY2RmOGIyYzk2 NDMyYzliMzMzYTQ0MWZjMjk2NmVmYWYxZi4uNzk3OTFmODBjZWI3NWQ4NjJkOGVmZTlmZDYzODY0 YjlmZjllOTY0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAyLTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW52YWxpZCBhc3NlcnQgaW4g Q29tcG9zaXRlRWRpdENvbW1hbmQ6Omluc2VydE5vZGVBZnRlci9pbnNlcnROb2RlQmVmb3JlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4NTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnNlcnRpbmcg Y29udGVudCBiZWZvcmUvYWZ0ZXIgdGhlIGJvZHkgYXMgdGhlIHJlc3VsdCBvZiBlZGl0aW5nIGlz IGEgdmFsaWQgb3BlcmF0aW9uLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvaW5zZXJ0aW5nL2lu c2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbAorCisgICAgICAgICogZWRpdGluZy9Db21wb3NpdGVF ZGl0Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NpdGVFZGl0Q29tbWFuZDo6 aW5zZXJ0Tm9kZUJlZm9yZSk6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NpdGVFZGl0Q29tbWFu ZDo6aW5zZXJ0Tm9kZUFmdGVyKToKKwogMjAxNS0wMi0xOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBTT0ZUX0xJTktfRlVOQ1RJT05fe0RFQ0ws SU1QTH0oKSB0byBTT0ZUX0xJTktfRlVOQ1RJT05fe0hFQURFUixTT1VSQ0V9KCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKaW5kZXggOWRjMTMw ODg5M2U4NTFkMTA0NmRjNGQ2NmJiZDA2N2Q5MjYxZjllNy4uODQ2MWVlN2VjNDhkOTU5OTI5YTJm NWQ3ZjdiMzg3MGQwMzZmMDZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9D b21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21w b3NpdGVFZGl0Q29tbWFuZC5jcHAKQEAgLTMyMiw3ICszMjIsNiBAQCBib29sIENvbXBvc2l0ZUVk aXRDb21tYW5kOjppc1JlbW92YWJsZUJsb2NrKGNvbnN0IE5vZGUqIG5vZGUpCiAKIHZvaWQgQ29t cG9zaXRlRWRpdENvbW1hbmQ6Omluc2VydE5vZGVCZWZvcmUoUGFzc1JlZlB0cjxOb2RlPiBpbnNl cnRDaGlsZCwgUGFzc1JlZlB0cjxOb2RlPiByZWZDaGlsZCwgU2hvdWxkQXNzdW1lQ29udGVudElz QWx3YXlzRWRpdGFibGUgc2hvdWxkQXNzdW1lQ29udGVudElzQWx3YXlzRWRpdGFibGUpCiB7Ci0g ICAgQVNTRVJUKCFyZWZDaGlsZC0+aGFzVGFnTmFtZShib2R5VGFnKSk7CiAgICAgYXBwbHlDb21t YW5kVG9Db21wb3NpdGUoSW5zZXJ0Tm9kZUJlZm9yZUNvbW1hbmQ6OmNyZWF0ZShpbnNlcnRDaGls ZCwgcmVmQ2hpbGQsIHNob3VsZEFzc3VtZUNvbnRlbnRJc0Fsd2F5c0VkaXRhYmxlKSk7CiB9CiAK QEAgLTMzMCw3ICszMjksNiBAQCB2b2lkIENvbXBvc2l0ZUVkaXRDb21tYW5kOjppbnNlcnROb2Rl QWZ0ZXIoUGFzc1JlZlB0cjxOb2RlPiBpbnNlcnRDaGlsZCwgUGFzc1JlZgogewogICAgIEFTU0VS VChpbnNlcnRDaGlsZCk7CiAgICAgQVNTRVJUKHJlZkNoaWxkKTsKLSAgICBBU1NFUlQoIXJlZkNo aWxkLT5oYXNUYWdOYW1lKGJvZHlUYWcpKTsKICAgICBDb250YWluZXJOb2RlKiBwYXJlbnQgPSBy ZWZDaGlsZC0+cGFyZW50Tm9kZSgpOwogICAgIEFTU0VSVChwYXJlbnQpOwogICAgIEFTU0VSVCgh cGFyZW50LT5pc1NoYWRvd1Jvb3QoKSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2FhZWJmNzY0MTMwNTE2ZmMxMjcyNWM0 OWIzMmFlYmIzODI2YjVmYy4uZTBlYTg0NjRlMzBmOTVhNmVhMDUwMWRiZWQwMDE2MWU1NGI2NWVh NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTIwICBaYWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CisKKyAgICAgICAgSW52YWxpZCBhc3NlcnQgaW4gQ29tcG9zaXRlRWRpdENv bW1hbmQ6Omluc2VydE5vZGVBZnRlci9pbnNlcnROb2RlQmVmb3JlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4NTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnNlcnRpbmcgY29udGVudCBiZWZvcmUv YWZ0ZXIgdGhlIGJvZHkgYXMgdGhlIHJlc3VsdCBvZiBlZGl0aW5nIGlzIGEgdmFsaWQgb3BlcmF0 aW9uLgorCisgICAgICAgICogZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWFzLWJvZHktc2libGlu Zy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL2luc2Vy dC1hcy1ib2R5LXNpYmxpbmcuaHRtbDogQWRkZWQuCisKIDIwMTUtMDItMTkgIE15bGVzIEMuIE1h eGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGluZyBtb3JlIHRl c3RzIGFmdGVyIHIxNzc3NzQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0 aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRp dGluZy9pbnNlcnRpbmcvaW5zZXJ0LWFzLWJvZHktc2libGluZy1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uNjQyOTUxMWJjMWYwOTA1NDJkYzg4ZDk1N2I5OTk4NjdlOTJlOTNhZgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNp YmxpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorCitQYXNzIGlmIG5vIGFzc2VydCBv ciBjcmFzaCBpbiBkZWJ1Zy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0 aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5z ZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kMWU4ZDc3MmI4 M2MwNTAzMzk2OTZkN2JhYjQ5MGY4ZGM1NGU3N2EzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWFzLWJvZHktc2libGluZy5odG1sCkBAIC0w LDAgKzEsMTQgQEAKKzxoZWFkPgorPHRpdGxlPlRoaXMgdGVzdHMgaWYgaW5zZXJ0aW5nIGNvbnRl bnQgYXMgYm9keSBzaWJsaW5nIHRyaWdnZXJzIGFzc2VydGlvbi48L3RpdGxlPgorPC9oZWFkPgor PGRpdj5QYXNzIGlmIG5vIGFzc2VydCBvciBjcmFzaCBpbiBkZWJ1Zy48L2Rpdj4KKzxzY3JpcHQ+ CisgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsK KworICB2YXIgaWZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaWZyYW1lIik7CisgIGRv Y3VtZW50LmhlYWQucGFyZW50Tm9kZS5pbnNlcnRCZWZvcmUoaWZyYW1lLCBkb2N1bWVudC5oZWFk Lm5leHRTaWJsaW5nKTsKKyAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIlNlbGVjdEFsbCIpOworICBk b2N1bWVudC5kZXNpZ25Nb2RlID0gIm9uIjsKKyAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkp1c3Rp ZnlDZW50ZXIiLCBmYWxzZSwgbnVsbCk7Cis8L3NjcmlwdD4K 247003 2015-02-20 14:22:40 -0800 2015-02-20 14:23:13 -0800 Patch bug-141854-20150220142231.patch text/plain 4392 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU2N2NkY2RmOGIyYzk2 NDMyYzliMzMzYTQ0MWZjMjk2NmVmYWYxZi4uMmFjYzQzODI1NWJiZmIzNGI2MGVkYjEzNmViNTRh NDQxMmE0NGY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAyLTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW52YWxpZCBhc3NlcnQgaW4g Q29tcG9zaXRlRWRpdENvbW1hbmQ6Omluc2VydE5vZGVBZnRlci9pbnNlcnROb2RlQmVmb3JlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4NTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgSW5zZXJ0aW5nIGNv bnRlbnQgYmVmb3JlL2FmdGVyIHRoZSBib2R5IGFzIHRoZSByZXN1bHQgb2YgZWRpdGluZyBpcyBh IHZhbGlkIG9wZXJhdGlvbi4KKyAgICAgICAgVGhpcyBhc3NlcnQgd2FzIG9yaWdpbmFsbHkgaW50 cm9kdWNlZCB0byBjb3ZlciBjYXNlcyB3aGVyZSBlZGl0ZWQgY29udGVudCB3b3VsZCBnZXQgbW92 ZWQKKyAgICAgICAgb3V0IG9mIGJvZHkuIEhvd2V2ZXIsIGFzc2VydGluZyBzdWNoIG9wZXJhdGlv biBwcm9wZXJseSBpcyBub3QgcG9zc2libGUgYXRtLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcv aW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbAorCisgICAgICAgICogZWRpdGlu Zy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NpdGVF ZGl0Q29tbWFuZDo6aW5zZXJ0Tm9kZUJlZm9yZSk6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3Np dGVFZGl0Q29tbWFuZDo6aW5zZXJ0Tm9kZUFmdGVyKToKKwogMjAxNS0wMi0xOSAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBTT0ZUX0xJTktfRlVO Q1RJT05fe0RFQ0wsSU1QTH0oKSB0byBTT0ZUX0xJTktfRlVOQ1RJT05fe0hFQURFUixTT1VSQ0V9 KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1h bmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAK aW5kZXggOWRjMTMwODg5M2U4NTFkMTA0NmRjNGQ2NmJiZDA2N2Q5MjYxZjllNy4uODQ2MWVlN2Vj NDhkOTU5OTI5YTJmNWQ3ZjdiMzg3MGQwMzZmMDZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKQEAgLTMyMiw3ICszMjIsNiBAQCBib29s IENvbXBvc2l0ZUVkaXRDb21tYW5kOjppc1JlbW92YWJsZUJsb2NrKGNvbnN0IE5vZGUqIG5vZGUp CiAKIHZvaWQgQ29tcG9zaXRlRWRpdENvbW1hbmQ6Omluc2VydE5vZGVCZWZvcmUoUGFzc1JlZlB0 cjxOb2RlPiBpbnNlcnRDaGlsZCwgUGFzc1JlZlB0cjxOb2RlPiByZWZDaGlsZCwgU2hvdWxkQXNz dW1lQ29udGVudElzQWx3YXlzRWRpdGFibGUgc2hvdWxkQXNzdW1lQ29udGVudElzQWx3YXlzRWRp dGFibGUpCiB7Ci0gICAgQVNTRVJUKCFyZWZDaGlsZC0+aGFzVGFnTmFtZShib2R5VGFnKSk7CiAg ICAgYXBwbHlDb21tYW5kVG9Db21wb3NpdGUoSW5zZXJ0Tm9kZUJlZm9yZUNvbW1hbmQ6OmNyZWF0 ZShpbnNlcnRDaGlsZCwgcmVmQ2hpbGQsIHNob3VsZEFzc3VtZUNvbnRlbnRJc0Fsd2F5c0VkaXRh YmxlKSk7CiB9CiAKQEAgLTMzMCw3ICszMjksNiBAQCB2b2lkIENvbXBvc2l0ZUVkaXRDb21tYW5k OjppbnNlcnROb2RlQWZ0ZXIoUGFzc1JlZlB0cjxOb2RlPiBpbnNlcnRDaGlsZCwgUGFzc1JlZgog ewogICAgIEFTU0VSVChpbnNlcnRDaGlsZCk7CiAgICAgQVNTRVJUKHJlZkNoaWxkKTsKLSAgICBB U1NFUlQoIXJlZkNoaWxkLT5oYXNUYWdOYW1lKGJvZHlUYWcpKTsKICAgICBDb250YWluZXJOb2Rl KiBwYXJlbnQgPSByZWZDaGlsZC0+cGFyZW50Tm9kZSgpOwogICAgIEFTU0VSVChwYXJlbnQpOwog ICAgIEFTU0VSVCghcGFyZW50LT5pc1NoYWRvd1Jvb3QoKSk7CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2FhZWJmNzY0MTMw NTE2ZmMxMjcyNWM0OWIzMmFlYmIzODI2YjVmYy4uODhhNjhkZGViZmQxMGEyNTU2Zjg1M2I3MTFm NzhmYjRmYTAzZDg1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTIwICBaYWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW52YWxpZCBhc3NlcnQgaW4gQ29t cG9zaXRlRWRpdENvbW1hbmQ6Omluc2VydE5vZGVBZnRlci9pbnNlcnROb2RlQmVmb3JlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4NTQKKworICAg ICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgSW5zZXJ0aW5nIGNvbnRl bnQgYmVmb3JlL2FmdGVyIHRoZSBib2R5IGFzIHRoZSByZXN1bHQgb2YgZWRpdGluZyBpcyBhIHZh bGlkIG9wZXJhdGlvbi4KKyAgICAgICAgVGhpcyBhc3NlcnQgd2FzIG9yaWdpbmFsbHkgaW50cm9k dWNlZCB0byBjb3ZlciBjYXNlcyB3aGVyZSBlZGl0ZWQgY29udGVudCB3b3VsZCBnZXQgbW92ZWQK KyAgICAgICAgb3V0IG9mIGJvZHkuIEhvd2V2ZXIsIGFzc2VydGluZyBzdWNoIG9wZXJhdGlvbiBw cm9wZXJseSBpcyBub3QgcG9zc2libGUgYXRtLgorCisgICAgICAgICogZWRpdGluZy9pbnNlcnRp bmcvaW5zZXJ0LWFzLWJvZHktc2libGluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbDogQWRkZWQuCisK IDIwMTUtMDItMTkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAog ICAgICAgICBVcGRhdGluZyBtb3JlIHRlc3RzIGFmdGVyIHIxNzc3NzQKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmctZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWFzLWJvZHktc2li bGluZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjQyOTUxMWJjMWYwOTA1NDJkYzg4ZDk1N2I5 OTk4NjdlOTJlOTNhZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5z ZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBA QAorCitQYXNzIGlmIG5vIGFzc2VydCBvciBjcmFzaCBpbiBkZWJ1Zy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbCBi L0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi5kMWU4ZDc3MmI4M2MwNTAzMzk2OTZkN2JhYjQ5MGY4ZGM1NGU3N2EzCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWFz LWJvZHktc2libGluZy5odG1sCkBAIC0wLDAgKzEsMTQgQEAKKzxoZWFkPgorPHRpdGxlPlRoaXMg dGVzdHMgaWYgaW5zZXJ0aW5nIGNvbnRlbnQgYXMgYm9keSBzaWJsaW5nIHRyaWdnZXJzIGFzc2Vy dGlvbi48L3RpdGxlPgorPC9oZWFkPgorPGRpdj5QYXNzIGlmIG5vIGFzc2VydCBvciBjcmFzaCBp biBkZWJ1Zy48L2Rpdj4KKzxzY3JpcHQ+CisgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0 ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworICB2YXIgaWZyYW1lID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiaWZyYW1lIik7CisgIGRvY3VtZW50LmhlYWQucGFyZW50Tm9kZS5pbnNlcnRCZWZv cmUoaWZyYW1lLCBkb2N1bWVudC5oZWFkLm5leHRTaWJsaW5nKTsKKyAgZG9jdW1lbnQuZXhlY0Nv bW1hbmQoIlNlbGVjdEFsbCIpOworICBkb2N1bWVudC5kZXNpZ25Nb2RlID0gIm9uIjsKKyAgZG9j dW1lbnQuZXhlY0NvbW1hbmQoIkp1c3RpZnlDZW50ZXIiLCBmYWxzZSwgbnVsbCk7Cis8L3Njcmlw dD4K 247004 2015-02-20 14:26:21 -0800 2015-02-20 15:27:53 -0800 Patch bug-141854-20150220142612.patch text/plain 4414 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU2N2NkY2RmOGIyYzk2 NDMyYzliMzMzYTQ0MWZjMjk2NmVmYWYxZi4uMmFjYzQzODI1NWJiZmIzNGI2MGVkYjEzNmViNTRh NDQxMmE0NGY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAyLTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW52YWxpZCBhc3NlcnQgaW4g Q29tcG9zaXRlRWRpdENvbW1hbmQ6Omluc2VydE5vZGVBZnRlci9pbnNlcnROb2RlQmVmb3JlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4NTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgSW5zZXJ0aW5nIGNv bnRlbnQgYmVmb3JlL2FmdGVyIHRoZSBib2R5IGFzIHRoZSByZXN1bHQgb2YgZWRpdGluZyBpcyBh IHZhbGlkIG9wZXJhdGlvbi4KKyAgICAgICAgVGhpcyBhc3NlcnQgd2FzIG9yaWdpbmFsbHkgaW50 cm9kdWNlZCB0byBjb3ZlciBjYXNlcyB3aGVyZSBlZGl0ZWQgY29udGVudCB3b3VsZCBnZXQgbW92 ZWQKKyAgICAgICAgb3V0IG9mIGJvZHkuIEhvd2V2ZXIsIGFzc2VydGluZyBzdWNoIG9wZXJhdGlv biBwcm9wZXJseSBpcyBub3QgcG9zc2libGUgYXRtLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcv aW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbAorCisgICAgICAgICogZWRpdGlu Zy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NpdGVF ZGl0Q29tbWFuZDo6aW5zZXJ0Tm9kZUJlZm9yZSk6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3Np dGVFZGl0Q29tbWFuZDo6aW5zZXJ0Tm9kZUFmdGVyKToKKwogMjAxNS0wMi0xOSAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBTT0ZUX0xJTktfRlVO Q1RJT05fe0RFQ0wsSU1QTH0oKSB0byBTT0ZUX0xJTktfRlVOQ1RJT05fe0hFQURFUixTT1VSQ0V9 KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1h bmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAK aW5kZXggOWRjMTMwODg5M2U4NTFkMTA0NmRjNGQ2NmJiZDA2N2Q5MjYxZjllNy4uODQ2MWVlN2Vj NDhkOTU5OTI5YTJmNWQ3ZjdiMzg3MGQwMzZmMDZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKQEAgLTMyMiw3ICszMjIsNiBAQCBib29s IENvbXBvc2l0ZUVkaXRDb21tYW5kOjppc1JlbW92YWJsZUJsb2NrKGNvbnN0IE5vZGUqIG5vZGUp CiAKIHZvaWQgQ29tcG9zaXRlRWRpdENvbW1hbmQ6Omluc2VydE5vZGVCZWZvcmUoUGFzc1JlZlB0 cjxOb2RlPiBpbnNlcnRDaGlsZCwgUGFzc1JlZlB0cjxOb2RlPiByZWZDaGlsZCwgU2hvdWxkQXNz dW1lQ29udGVudElzQWx3YXlzRWRpdGFibGUgc2hvdWxkQXNzdW1lQ29udGVudElzQWx3YXlzRWRp dGFibGUpCiB7Ci0gICAgQVNTRVJUKCFyZWZDaGlsZC0+aGFzVGFnTmFtZShib2R5VGFnKSk7CiAg ICAgYXBwbHlDb21tYW5kVG9Db21wb3NpdGUoSW5zZXJ0Tm9kZUJlZm9yZUNvbW1hbmQ6OmNyZWF0 ZShpbnNlcnRDaGlsZCwgcmVmQ2hpbGQsIHNob3VsZEFzc3VtZUNvbnRlbnRJc0Fsd2F5c0VkaXRh YmxlKSk7CiB9CiAKQEAgLTMzMCw3ICszMjksNiBAQCB2b2lkIENvbXBvc2l0ZUVkaXRDb21tYW5k OjppbnNlcnROb2RlQWZ0ZXIoUGFzc1JlZlB0cjxOb2RlPiBpbnNlcnRDaGlsZCwgUGFzc1JlZgog ewogICAgIEFTU0VSVChpbnNlcnRDaGlsZCk7CiAgICAgQVNTRVJUKHJlZkNoaWxkKTsKLSAgICBB U1NFUlQoIXJlZkNoaWxkLT5oYXNUYWdOYW1lKGJvZHlUYWcpKTsKICAgICBDb250YWluZXJOb2Rl KiBwYXJlbnQgPSByZWZDaGlsZC0+cGFyZW50Tm9kZSgpOwogICAgIEFTU0VSVChwYXJlbnQpOwog ICAgIEFTU0VSVCghcGFyZW50LT5pc1NoYWRvd1Jvb3QoKSk7CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2FhZWJmNzY0MTMw NTE2ZmMxMjcyNWM0OWIzMmFlYmIzODI2YjVmYy4uODhhNjhkZGViZmQxMGEyNTU2Zjg1M2I3MTFm NzhmYjRmYTAzZDg1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTIwICBaYWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW52YWxpZCBhc3NlcnQgaW4gQ29t cG9zaXRlRWRpdENvbW1hbmQ6Omluc2VydE5vZGVBZnRlci9pbnNlcnROb2RlQmVmb3JlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4NTQKKworICAg ICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgSW5zZXJ0aW5nIGNvbnRl bnQgYmVmb3JlL2FmdGVyIHRoZSBib2R5IGFzIHRoZSByZXN1bHQgb2YgZWRpdGluZyBpcyBhIHZh bGlkIG9wZXJhdGlvbi4KKyAgICAgICAgVGhpcyBhc3NlcnQgd2FzIG9yaWdpbmFsbHkgaW50cm9k dWNlZCB0byBjb3ZlciBjYXNlcyB3aGVyZSBlZGl0ZWQgY29udGVudCB3b3VsZCBnZXQgbW92ZWQK KyAgICAgICAgb3V0IG9mIGJvZHkuIEhvd2V2ZXIsIGFzc2VydGluZyBzdWNoIG9wZXJhdGlvbiBw cm9wZXJseSBpcyBub3QgcG9zc2libGUgYXRtLgorCisgICAgICAgICogZWRpdGluZy9pbnNlcnRp bmcvaW5zZXJ0LWFzLWJvZHktc2libGluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbDogQWRkZWQuCisK IDIwMTUtMDItMTkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAog ICAgICAgICBVcGRhdGluZyBtb3JlIHRlc3RzIGFmdGVyIHIxNzc3NzQKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmctZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWFzLWJvZHktc2li bGluZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjQyOTUxMWJjMWYwOTA1NDJkYzg4ZDk1N2I5 OTk4NjdlOTJlOTNhZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5z ZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBA QAorCitQYXNzIGlmIG5vIGFzc2VydCBvciBjcmFzaCBpbiBkZWJ1Zy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRtbCBi L0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1hcy1ib2R5LXNpYmxpbmcuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi44ZDcwYWQ2NWI5NDUwYTE5NTVjN2E2YmIzZWRhNTY4YTMxNmVkYzkwCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWFz LWJvZHktc2libGluZy5odG1sCkBAIC0wLDAgKzEsMTUgQEAKKzwhRE9DVFlQRSBodG1sPgorPGhl YWQ+Cis8dGl0bGU+VGhpcyB0ZXN0cyBpZiBpbnNlcnRpbmcgY29udGVudCBhcyBib2R5IHNpYmxp bmcgdHJpZ2dlcnMgYXNzZXJ0aW9uLjwvdGl0bGU+Cis8L2hlYWQ+Cis8ZGl2PlBhc3MgaWYgbm8g YXNzZXJ0IG9yIGNyYXNoIGluIGRlYnVnLjwvZGl2PgorPHNjcmlwdD4KKwlpZiAod2luZG93LnRl c3RSdW5uZXIpCisgICAgCXRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgIAl2YXIgaWZyYW1l ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaWZyYW1lIik7CisgIAlkb2N1bWVudC5oZWFkLnBh cmVudE5vZGUuaW5zZXJ0QmVmb3JlKGlmcmFtZSwgZG9jdW1lbnQuaGVhZC5uZXh0U2libGluZyk7 CisgIAlkb2N1bWVudC5leGVjQ29tbWFuZCgiU2VsZWN0QWxsIik7CisgIAlkb2N1bWVudC5kZXNp Z25Nb2RlID0gIm9uIjsKKyAgCWRvY3VtZW50LmV4ZWNDb21tYW5kKCJKdXN0aWZ5Q2VudGVyIiwg ZmFsc2UsIG51bGwpOworPC9zY3JpcHQ+Cg==