141835 2015-02-20 03:17:03 -0800 [GTK] Layout Test media/video-controls-no-scripting.html is failing 2017-08-18 06:43:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=152797 InRadar P2 Normal --- 1 chavarria1991 Ms2ger ap bugs-noreply chavarria1991 clopez commit-queue Ms2ger webkit-bug-importer oldest_to_newest 1070665 0 chavarria1991 2015-02-20 03:17:03 -0800 The media/video-controls-no-scripting.html layout test is failing after rr178648. Probably we need to rebaseline the test here. Missing line number: --- /home/ch01/wk-tools/layout-test-results/media/video-controls-no-scripting-expected.txt +++ /home/ch01/wk-tools/layout-test-results/media/video-controls-no-scripting-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 10: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. +CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. CONSOLE MESSAGE: line 13: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. Tests that the built-in controls are always enabled when JavaScript is disabled. 1070710 1 ap 2015-02-20 09:46:05 -0800 It's probably fine to update the results for now, however this may be a sign of a bug in console that line number generation is flaky on this test. 1095076 2 chavarria1991 2015-05-15 02:50:09 -0700 The test is failing again after r184329 (). The new diff is the following: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-actual.txt @@ -1,5 +1,6 @@ CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. CONSOLE MESSAGE: line 13: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. +CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. Tests that the built-in controls are always enabled when JavaScript is disabled. 1153144 3 clopez 2016-01-06 12:27:38 -0800 This test is now timing out because of bug 152797 1340030 4 318488 Ms2ger 2017-08-18 03:20:21 -0700 Created attachment 318488 Patch 1340039 5 318488 clopez 2017-08-18 06:11:10 -0700 Comment on attachment 318488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318488&action=review > LayoutTests/ChangeLog:8 > + The output appears to be consistent based on local testing. You can see its still failing on the bot: media/video-controls-no-scripting-diff.txt $ curl -s https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/2689/steps/layout-test/logs/stdio/text|grep media/video-controls-no-scripting 03:22:36.244 11162 "ruby -I /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Websites/bugs.webkit.org/PrettyPatch /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Websites/bugs.webkit.org/PrettyPatch/prettify.rb /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-diff.txt" took 0.16s 03:22:36.245 11162 worker/9 media/video-controls-no-scripting.html failed: And you can find the diff here: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r220912%20(2689)/media/video-controls-no-scripting-pretty-diff.html 1340040 6 318488 clopez 2017-08-18 06:12:28 -0700 Comment on attachment 318488 Patch Ok... missed the rebaseline. Sorry /me goes for more coffee 1340043 7 318488 commit-queue 2017-08-18 06:42:01 -0700 Comment on attachment 318488 Patch Clearing flags on attachment: 318488 Committed r220915: <http://trac.webkit.org/changeset/220915> 1340044 8 commit-queue 2017-08-18 06:42:03 -0700 All reviewed patches have been landed. Closing bug. 1340045 9 webkit-bug-importer 2017-08-18 06:43:19 -0700 <rdar://problem/33961964> 318488 2017-08-18 03:20:21 -0700 2017-08-18 06:42:01 -0700 Patch bug-141835-20170818122020.patch text/plain 2788 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwODUxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzI2Y2FhZjBhNmQ5YmUyNjYyZmEw MGIxN2NhMjNiZjdjMzBjOTQxMC4uNDQzZmU3ZGMxYjFhZDU2YzFhMjNlZGNlYWUzYjE5YTQ3YTcy NzBjNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA4LTE4ICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBMYXlvdXQgVGVzdCBtZWRpYS92aWRlby1jb250 cm9scy1uby1zY3JpcHRpbmcuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4MzUKKworICAgICAgICBVbnJldmlld2VkIHRl c3QgZ2FyZGVuaW5nLgorCisgICAgICAgIFRoZSBvdXRwdXQgYXBwZWFycyB0byBiZSBjb25zaXN0 ZW50IGJhc2VkIG9uIGxvY2FsIHRlc3RpbmcuCisKKyAgICAgICAgUmViYXNlbGluZSB2aWRlby1j b250cm9scy1uby1zY3JpcHRpbmcuaHRtbC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0 RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9tZWRpYS92aWRlby1jb250cm9s cy1uby1zY3JpcHRpbmctZXhwZWN0ZWQudHh0OgorCiAyMDE3LTA4LTE3ICBNczJnZXIgIDxNczJn ZXJAZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMjIyZWZiY2Nh MDNkNjhiNTBkNGQ1YWY4ZWVhNjYwNGRhYjc0YzY4Mi4uMWJlOTZmNzI5Yjg1ZjBlYjI2MmYwZjkx ZThiZTdjZWYxYjM1Yzg3OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3Rh dGlvbnMKQEAgLTIxNjMsOCArMjE2Myw2IEBAIHdlYmtpdC5vcmcvYi8xNDQ2OTAgZWRpdGluZy9z cGVsbGluZy9zcGVsbGluZy1leGFjdGx5LXNlbGVjdGVkLXdvcmQuaHRtbCBbIFRpbWVvCiB3ZWJr aXQub3JnL2IvMTQ0NjkwIGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctd2l0aC1wdW5jdHVhdGlv bi1zZWxlY3Rpb24uaHRtbCBbIFRpbWVvdXQgXQogd2Via2l0Lm9yZy9iLzE0NDY5MCBlZGl0aW5n L3NwZWxsaW5nL2RlbGV0ZS1pbnRvLW1pc3NwZWxsZWQtd29yZC5odG1sIFsgVGltZW91dCBQYXNz IF0KIAotd2Via2l0Lm9yZy9iLzE0MTgzNSBtZWRpYS92aWRlby1jb250cm9scy1uby1zY3JpcHRp bmcuaHRtbCBbIEZhaWx1cmUgXQotCiAjIE1heSB0YWtlIHRvbyBsb25nIG9uIHRoZSBib3RzLgog CiBCdWcoR1RLKSBmYXN0L2hpc3RvcnkvZ28tYmFjay10by1pZnJhbWUtd2l0aC1wbHVnaW4uaHRt bCBbIFRpbWVvdXQgUGFzcyBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv bWVkaWEvdmlkZW8tY29udHJvbHMtbm8tc2NyaXB0aW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9tZWRpYS92aWRlby1jb250cm9scy1uby1zY3JpcHRpbmctZXhwZWN0 ZWQudHh0CmluZGV4IDAyMWU2MGEyODIwNTRmNzUwYzlkZWE4ZDQ5NTRhOTY1MmNjMzBmM2EuLjZl ZWRhYmIzZTViMTRmNmJlZTAxMzMzZmMxZjcwZWFkOGYwMTk4ODggMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9tZWRpYS92aWRlby1jb250cm9scy1uby1zY3JpcHRpbmctZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9tZWRpYS92aWRlby1jb250 cm9scy1uby1zY3JpcHRpbmctZXhwZWN0ZWQudHh0CkBAIC0xLDUgKzEsNyBAQAogQ09OU09MRSBN RVNTQUdFOiBCbG9ja2VkIHNjcmlwdCBleGVjdXRpb24gaW4gJ3ZpZGVvLWNvbnRyb2xzLW5vLXNj cmlwdGluZy1pZnJhbWUuaHRtbCcgYmVjYXVzZSB0aGUgZG9jdW1lbnQncyBmcmFtZSBpcyBzYW5k Ym94ZWQgYW5kIHRoZSAnYWxsb3ctc2NyaXB0cycgcGVybWlzc2lvbiBpcyBub3Qgc2V0LgogQ09O U09MRSBNRVNTQUdFOiBsaW5lIDEzOiBCbG9ja2VkIHNjcmlwdCBleGVjdXRpb24gaW4gJ3ZpZGVv LWNvbnRyb2xzLW5vLXNjcmlwdGluZy1pZnJhbWUuaHRtbCcgYmVjYXVzZSB0aGUgZG9jdW1lbnQn cyBmcmFtZSBpcyBzYW5kYm94ZWQgYW5kIHRoZSAnYWxsb3ctc2NyaXB0cycgcGVybWlzc2lvbiBp cyBub3Qgc2V0LgorQ09OU09MRSBNRVNTQUdFOiBCbG9ja2VkIHNjcmlwdCBleGVjdXRpb24gaW4g J3ZpZGVvLWNvbnRyb2xzLW5vLXNjcmlwdGluZy1pZnJhbWUuaHRtbCcgYmVjYXVzZSB0aGUgZG9j dW1lbnQncyBmcmFtZSBpcyBzYW5kYm94ZWQgYW5kIHRoZSAnYWxsb3ctc2NyaXB0cycgcGVybWlz c2lvbiBpcyBub3Qgc2V0LgorQ09OU09MRSBNRVNTQUdFOiBCbG9ja2VkIHNjcmlwdCBleGVjdXRp b24gaW4gJ3ZpZGVvLWNvbnRyb2xzLW5vLXNjcmlwdGluZy1pZnJhbWUuaHRtbCcgYmVjYXVzZSB0 aGUgZG9jdW1lbnQncyBmcmFtZSBpcyBzYW5kYm94ZWQgYW5kIHRoZSAnYWxsb3ctc2NyaXB0cycg cGVybWlzc2lvbiBpcyBub3Qgc2V0LgogCiBUZXN0cyB0aGF0IHRoZSBidWlsdC1pbiBjb250cm9s cyBhcmUgYWx3YXlzIGVuYWJsZWQgd2hlbiBKYXZhU2NyaXB0IGlzIGRpc2FibGVkLgogCg==