141829 2015-02-20 02:03:25 -0800 [WebEditingTester] Implement an open panel 2015-02-20 12:00:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca enrica sam simon.fraser oldest_to_newest 1070640 0 thorton 2015-02-20 02:03:25 -0800 [WebEditingTester] Implement an open panel 1070641 1 246950 thorton 2015-02-20 02:03:38 -0800 Created attachment 246950 Patch 1070753 2 246950 simon.fraser 2015-02-20 11:41:09 -0800 Comment on attachment 246950 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246950&action=review > Tools/WebEditingTester/AppDelegate.m:145 > +- (void)_useWebKit1ForOpeningDocument:(id)sender sounds like a BOOL. Maybe openDocumentWithWebKit1. > Tools/WebEditingTester/AppDelegate.m:150 > +- (void)_useWebKit2ForOpeningDocument:(id)sender Ditto > Tools/WebEditingTester/AppDelegate.m:160 > + [radioButtonPrototype setButtonType:NSRadioButton]; DOT > Tools/WebEditingTester/AppDelegate.m:182 > + [[controller window] makeKeyAndOrderFront:nil]; DOT 1070759 3 thorton 2015-02-20 12:00:08 -0800 http://trac.webkit.org/changeset/180438 246950 2015-02-20 02:03:38 -0800 2015-02-20 11:41:09 -0800 Patch bug-141829-20150220020329.patch text/plain 3546 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMzc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWZmMGZmMjZiNDY0OTU0NzZkZTc1ODYyNDRkMmEzMjkz MzExYmIxMS4uMzcxODEwNzA0M2IyOWQwYTQ2ODYzNWQ3NGRlNDlkOGQwZjJlZjUxZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDE1LTAyLTIwICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAorICAgICAgICBbV2ViRWRpdGluZ1Rlc3Rlcl0gSW1wbGVtZW50IGFuIG9wZW4gcGFuZWwK KyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViRWRpdGluZ1Rlc3Rlci9BcHBEZWxlZ2F0 ZS5tOgorICAgICAgICAoLVtXZWJFZGl0aW5nQXBwRGVsZWdhdGUgX3VzZVdlYktpdDFGb3JPcGVu aW5nRG9jdW1lbnQ6XSk6CisgICAgICAgICgtW1dlYkVkaXRpbmdBcHBEZWxlZ2F0ZSBfdXNlV2Vi S2l0MkZvck9wZW5pbmdEb2N1bWVudDpdKToKKyAgICAgICAgKC1bV2ViRWRpdGluZ0FwcERlbGVn YXRlIG9wZW5Eb2N1bWVudDpdKToKKyAgICAgICAgQWRkIGFuIG9wZW4gcGFuZWwgKHdpdGggcmFk aW8gYnV0dG9ucyB0byBwaWNrIHdoaWNoIFdlYktpdCB0byBvcGVuIHdpdGgpLgorICAgICAgICBM b2FkcyB0aGUgZmlsZSBhcyBhbiBIVE1MIHN0cmluZy4KKworMjAxNS0wMi0yMCAgVGltb3RoeSBI b3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgW1dlYkVkaXRpbmdU ZXN0ZXJdIEhvb2sgdXAga2V5IGVxdWl2YWxlbnRzIGZvciBuZXcgd2luZG93IGFjdGlvbgogICAg ICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYkVk aXRpbmdUZXN0ZXIvQXBwRGVsZWdhdGUubSBiL1Rvb2xzL1dlYkVkaXRpbmdUZXN0ZXIvQXBwRGVs ZWdhdGUubQppbmRleCA0MWUyMTZjMjQxZGJkNDdiNmY2YTA5MTdiODcyYWZjMTg2YzM5YTcxLi5i OTBjZDNlZjQ5NjA0ODY0NjNmZGViMjM2MTEwODcwYjMwOWJlZWQ0IDEwMDY0NAotLS0gYS9Ub29s cy9XZWJFZGl0aW5nVGVzdGVyL0FwcERlbGVnYXRlLm0KKysrIGIvVG9vbHMvV2ViRWRpdGluZ1Rl c3Rlci9BcHBEZWxlZ2F0ZS5tCkBAIC0zMSw3ICszMSwxMCBAQAogCiBzdGF0aWMgTlNTdHJpbmcg KiBjb25zdCBVc2VXZWJLaXQyQnlEZWZhdWx0UHJlZmVyZW5jZUtleSA9IEAiVXNlV2ViS2l0MkJ5 RGVmYXVsdCI7CiAKLUBpbXBsZW1lbnRhdGlvbiBXZWJFZGl0aW5nQXBwRGVsZWdhdGUKK0BpbXBs ZW1lbnRhdGlvbiBXZWJFZGl0aW5nQXBwRGVsZWdhdGUgeworICAgIENsYXNzIF9vcGVuaW5nRG9j dW1lbnRDb250cm9sbGVyOworfQorCiAtIChpZClpbml0CiB7CiAgICAgc2VsZiA9IFtzdXBlciBp bml0XTsKQEAgLTEzOSw2ICsxNDIsNDkgQEAgLSAoQk9PTCl2YWxpZGF0ZU1lbnVJdGVtOihOU01l bnVJdGVtICopbWVudUl0ZW0KICAgICByZXR1cm4gWUVTOwogfQogCistICh2b2lkKV91c2VXZWJL aXQxRm9yT3BlbmluZ0RvY3VtZW50OihpZClzZW5kZXIKK3sKKyAgICBfb3BlbmluZ0RvY3VtZW50 Q29udHJvbGxlciA9IFtXSzFXZWJEb2N1bWVudENvbnRyb2xsZXIgY2xhc3NdOworfQorCistICh2 b2lkKV91c2VXZWJLaXQyRm9yT3BlbmluZ0RvY3VtZW50OihpZClzZW5kZXIKK3sKKyAgICBfb3Bl bmluZ0RvY3VtZW50Q29udHJvbGxlciA9IFtXSzJXZWJEb2N1bWVudENvbnRyb2xsZXIgY2xhc3Nd OworfQorCistIChJQkFjdGlvbilvcGVuRG9jdW1lbnQ6KGlkKXNlbmRlcgoreworICAgIF9vcGVu aW5nRG9jdW1lbnRDb250cm9sbGVyID0gc2VsZi5fZGVmYXVsdFdlYkRvY3VtZW50Q29udHJvbGxl ckNsYXNzOworCisgICAgTlNCdXR0b25DZWxsICpyYWRpb0J1dHRvblByb3RvdHlwZSA9IFtbTlNC dXR0b25DZWxsIGFsbG9jXSBpbml0XTsKKyAgICBbcmFkaW9CdXR0b25Qcm90b3R5cGUgc2V0QnV0 dG9uVHlwZTpOU1JhZGlvQnV0dG9uXTsKKworICAgIE5TTWF0cml4ICpvcGVuUGFuZWxBY2Nlc3Nv cnlWaWV3ID0gW1tOU01hdHJpeCBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU1plcm9SZWN0IG1vZGU6 TlNSYWRpb01vZGVNYXRyaXggcHJvdG90eXBlOnJhZGlvQnV0dG9uUHJvdG90eXBlIG51bWJlck9m Um93czoyIG51bWJlck9mQ29sdW1uczoxXTsKKyAgICBvcGVuUGFuZWxBY2Nlc3NvcnlWaWV3LmF1 dG9yZWNhbGN1bGF0ZXNDZWxsU2l6ZSA9IFlFUzsKKyAgICBvcGVuUGFuZWxBY2Nlc3NvcnlWaWV3 LmF1dG9zaXplc0NlbGxzID0gWUVTOworICAgIE5TQXJyYXkgKmNlbGxzID0gW29wZW5QYW5lbEFj Y2Vzc29yeVZpZXcgY2VsbHNdOworICAgIFtbY2VsbHMgb2JqZWN0QXRJbmRleDowXSBzZXRUaXRs ZTpAIk9wZW4gd2l0aCBXZWJLaXQxIl07CisgICAgW1tjZWxscyBvYmplY3RBdEluZGV4OjBdIHNl dEFjdGlvbjpAc2VsZWN0b3IoX3VzZVdlYktpdDFGb3JPcGVuaW5nRG9jdW1lbnQ6KV07CisgICAg W1tjZWxscyBvYmplY3RBdEluZGV4OjBdIHNldFN0YXRlOiFzZWxmLnVzZVdlYktpdDJCeURlZmF1 bHRdOworICAgIFtbY2VsbHMgb2JqZWN0QXRJbmRleDoxXSBzZXRUaXRsZTpAIk9wZW4gd2l0aCBX ZWJLaXQyIl07CisgICAgW1tjZWxscyBvYmplY3RBdEluZGV4OjFdIHNldEFjdGlvbjpAc2VsZWN0 b3IoX3VzZVdlYktpdDJGb3JPcGVuaW5nRG9jdW1lbnQ6KV07CisgICAgW1tjZWxscyBvYmplY3RB dEluZGV4OjFdIHNldFN0YXRlOnNlbGYudXNlV2ViS2l0MkJ5RGVmYXVsdF07CisgICAgW29wZW5Q YW5lbEFjY2Vzc29yeVZpZXcgc2l6ZVRvRml0XTsKKworICAgIE5TT3BlblBhbmVsICpwYW5lbCA9 IFtOU09wZW5QYW5lbCBvcGVuUGFuZWxdOworICAgIFtwYW5lbCBzZXRBY2Nlc3NvcnlWaWV3Om9w ZW5QYW5lbEFjY2Vzc29yeVZpZXddOworCisgICAgW3BhbmVsIGJlZ2luV2l0aENvbXBsZXRpb25I YW5kbGVyOl4oTlNJbnRlZ2VyIHJlc3VsdCkgeworICAgICAgICBpZiAocmVzdWx0ICE9IE5TRmls ZUhhbmRsaW5nUGFuZWxPS0J1dHRvbikKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBX ZWJEb2N1bWVudENvbnRyb2xsZXIgKmNvbnRyb2xsZXIgPSBbW19vcGVuaW5nRG9jdW1lbnRDb250 cm9sbGVyIGFsbG9jXSBpbml0XTsKKyAgICAgICAgW1tjb250cm9sbGVyIHdpbmRvd10gbWFrZUtl eUFuZE9yZGVyRnJvbnQ6bmlsXTsKKyAgICAgICAgW193ZWJEb2N1bWVudHMgYWRkT2JqZWN0OmNv bnRyb2xsZXJdOworICAgICAgICBbY29udHJvbGxlciBsb2FkSFRNTFN0cmluZzpbTlNTdHJpbmcg c3RyaW5nV2l0aENvbnRlbnRzT2ZVUkw6cGFuZWwuVVJMcy5sYXN0T2JqZWN0IGVuY29kaW5nOk5T VVRGOFN0cmluZ0VuY29kaW5nIGVycm9yOm5pbF1dOworICAgIH1dOworfQorCiAtICh2b2lkKV91 cGRhdGVOZXdXaW5kb3dLZXlFcXVpdmFsZW50cwogewogICAgIGlmIChzZWxmLnVzZVdlYktpdDJC eURlZmF1bHQpIHsK