141820 2015-02-19 18:03:24 -0800 RunLoop::dispatch() should drop the mutex before calling wakeUp(). 2015-02-20 11:36:18 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser andersca benjamin cmarcelo commit-queue sam simon.fraser oldest_to_newest 1070578 0 simon.fraser 2015-02-19 18:03:24 -0800 It's possible for RunLoop::performWork() to return without handling all the functions in the queue. In that case, CF is going to unset the CFRunLoopSource "signaled" state, which means that source won't get processed again until RunLoop::dispatch is called. We should re-signal the source at the end of RunLoop::performWork() if there's still work to do. This is OK, because CF unsets the signaled bit before it calls us. Also, RunLoop::dispatch() should drop the mutex before calling wakeUp(). 1070581 1 simon.fraser 2015-02-19 18:28:34 -0800 Never mind. If something was added to the m_functionQueue inside of RunLoop::performWork(), it would have had to have been via RunLoop::dispatch, which would have signaled. So I'll just keep this for the mutex fix. 1070583 2 246931 simon.fraser 2015-02-19 18:32:31 -0800 Created attachment 246931 Patch 1070750 3 246931 commit-queue 2015-02-20 11:36:13 -0800 Comment on attachment 246931 Patch Clearing flags on attachment: 246931 Committed r180434: <http://trac.webkit.org/changeset/180434> 1070751 4 commit-queue 2015-02-20 11:36:18 -0800 All reviewed patches have been landed. Closing bug. 246931 2015-02-19 18:32:31 -0800 2015-02-20 11:36:13 -0800 Patch bug-141820-20150219183223.patch text/plain 1367 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBlODFlMmUyODVmMDRmZTk5OGM1M2Jl ZTQ2YzNjNGM5MTBhZjMyMDMuLjU3OTIxNzRjOGMyYjQ3YTk1YmM3OWI5NzQwNzRlM2Y4MjdjZDNl NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDItMTkgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUnVuTG9vcDo6ZGlzcGF0Y2goKSBzaG91bGQg ZHJvcCB0aGUgbXV0ZXggYmVmb3JlIGNhbGxpbmcgd2FrZVVwKCkuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4MjAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFJ1bkxvb3A6Ondha2VVcCgp IGNhbGxzIGludG8gQ29yZUZvdW5kYXRpb24gd2hpY2ggY291bGQgdGFrZSB0aW1lLAorICAgICAg ICBzbyBzY29wZSB0aGUgbXV0ZXgganVzdCB0byBwcm90ZWN0IG1fZnVuY3Rpb25RdWV1ZS4KKwor ICAgICAgICAqIHd0Zi9SdW5Mb29wLmNwcDoKKyAgICAgICAgKFdURjo6UnVuTG9vcDo6ZGlzcGF0 Y2gpOgorCiAyMDE1LTAyLTEzICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5j b20+CiAKICAgICAgICAgW0VGTF0gRW5hYmxlIGJtYWxsb2MgZm9yIEVGTCBwb3J0IApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvUnVuTG9vcC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9SdW5Mb29w LmNwcAppbmRleCA0ZDQzMTBhMjE4ODJlOWY1NTQ5MjgzNjkxNDU1MDM4OWE2Zjc5MmMwLi5kYzI0 NDViNzI4ZDRiNDNkYzRhYjlmMzY2YzcyMTkzNDI2YjE4NWIxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9SdW5Mb29wLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9SdW5Mb29wLmNwcApAQCAt MTIyLDggKzEyMiwxMCBAQCB2b2lkIFJ1bkxvb3A6OnBlcmZvcm1Xb3JrKCkKIAogdm9pZCBSdW5M b29wOjpkaXNwYXRjaChzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGZ1bmN0aW9uKQogewotICAgIE11 dGV4TG9ja2VyIGxvY2tlcihtX2Z1bmN0aW9uUXVldWVMb2NrKTsKLSAgICBtX2Z1bmN0aW9uUXVl dWUuYXBwZW5kKFdURjo6bW92ZShmdW5jdGlvbikpOworICAgIHsKKyAgICAgICAgTXV0ZXhMb2Nr ZXIgbG9ja2VyKG1fZnVuY3Rpb25RdWV1ZUxvY2spOworICAgICAgICBtX2Z1bmN0aW9uUXVldWUu YXBwZW5kKFdURjo6bW92ZShmdW5jdGlvbikpOworICAgIH0KIAogICAgIHdha2VVcCgpOwogfQo=