<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>141813</bug_id>
          
          <creation_ts>2015-02-19 14:06:04 -0800</creation_ts>
          <short_desc>[WK2][GTK] Fix the build after r180362</short_desc>
          <delta_ts>2015-02-23 23:32:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>141808</blocked>
    
    <blocked>141836</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Gyuyoung Kim">gyuyoung.kim</assigned_to>
          <cc>andersca</cc>
    
    <cc>berto</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gustavo</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mrobinson</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1070521</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-02-19 14:06:04 -0800</bug_when>
    <thetext>SSIA. I won&apos;t be online until monday morning, feel free to pick it up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070621</commentid>
    <comment_count>1</comment_count>
      <attachid>246942</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-02-20 00:22:40 -0800</bug_when>
    <thetext>Created attachment 246942
Hot Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070622</commentid>
    <comment_count>2</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-02-20 00:24:39 -0800</bug_when>
    <thetext>I don&apos;t find what is correct fix against r180362. However if we don&apos;t use API::Object::wrap | API::Object::unwrap, EFL and GTK ports are fine at the moment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070623</commentid>
    <comment_count>3</comment_count>
      <attachid>246943</attachid>
    <who name="Hunseop Jeong">hs85.jeong</who>
    <bug_when>2015-02-20 00:24:51 -0800</bug_when>
    <thetext>Created attachment 246943
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070624</commentid>
    <comment_count>4</comment_count>
      <attachid>246943</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-02-20 00:27:32 -0800</bug_when>
    <thetext>Comment on attachment 246943
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246943&amp;action=review

&gt; Source/WebKit2/Shared/API/c/WKSharedAPICast.h:131
&gt; +#if PLATFORM(COCOA)

I&apos;m not sure whether r180362 was only related with COCOA platform. I think my previous patch looks better.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070625</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-02-20 00:29:12 -0800</bug_when>
    <thetext>I&apos;m not sure this is the correct fix. wrap/unwrapp are defined in cross-platform code and there&apos;s an implementation using static casts when !DELEGATE_REF_COUNTING_TO_COCOA</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070626</commentid>
    <comment_count>6</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-02-20 00:30:37 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; I&apos;m not sure this is the correct fix. wrap/unwrapp are defined in
&gt; cross-platform code and there&apos;s an implementation using static casts when
&gt; !DELEGATE_REF_COUNTING_TO_COCOA

Yes, that&apos;s why I just uploaded a hot fix. I&apos;m still looking this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070628</commentid>
    <comment_count>7</comment_count>
      <attachid>246945</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-02-20 01:32:17 -0800</bug_when>
    <thetext>Created attachment 246945
Fix

This fixes the build fot GTK+ let&apos;s see what happens with EFL</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070629</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-02-20 01:34:44 -0800</bug_when>
    <thetext>Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070630</commentid>
    <comment_count>9</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-02-20 01:54:33 -0800</bug_when>
    <thetext>Since fixes a different between ports, and I don&apos;t know how to fix the EFL build, I think it would be better to use different bugs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070631</commentid>
    <comment_count>10</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-02-20 01:55:39 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; Since fixes a different between ports, and I don&apos;t know how to fix the EFL
&gt; build, I think it would be better to use different bugs.

Ok, I&apos;m going to file a new bug for EFL port.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070662</commentid>
    <comment_count>11</comment_count>
      <attachid>246945</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2015-02-20 02:59:50 -0800</bug_when>
    <thetext>Comment on attachment 246945
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246945&amp;action=review

&gt; Source/WebKit2/UIProcess/API/C/gtk/WKAPICastGtk.h:48
&gt; +inline WKViewRef toAPI(WebKitWebViewBase* view)
&gt; +{
&gt; +    return static_cast&lt;WKViewRef&gt;(static_cast&lt;void*&gt;(view));
&gt; +}
&gt; +
&gt; +inline WebKitWebViewBase* toImpl(WKViewRef view)
&gt; +{
&gt; +    return static_cast&lt;WebKitWebViewBase*&gt;(static_cast&lt;void*&gt;(const_cast&lt;OpaqueWKView*&gt;(view)));
&gt; +}

These should be specializations of the respective templates. They should also mimic the previous behavior of the generic toAPI&lt;&gt;() and toImpl&lt;&gt;() templates.
But ideally you&apos;d have WebKitWebViewBase somehow inherit from API::Object, if that&apos;s even possible.

I ended up with this, built with Clang but not tested:

&gt; template&lt;&gt;
&gt; inline WKViewRef toAPI&lt;&gt;(WebKitWebViewBase* view)
&gt; {
&gt;     return reinterpret_cast&lt;WKViewRef&gt;(static_cast&lt;void*&gt;(view));
&gt; }
&gt; 
&gt; template&lt;&gt;
&gt; inline WebKitWebViewBase* toImpl&lt;&gt;(WKViewRef view)
&gt; {
&gt;     return static_cast&lt;WebKitWebViewBase*&gt;(static_cast&lt;void*&gt;(const_cast&lt;typename std::remove_const&lt;typename std::remove_pointer&lt;WKViewRef&gt;::type&gt;::type*&gt;(view)));
&gt; }</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070663</commentid>
    <comment_count>12</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-02-20 03:07:28 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; Comment on attachment 246945 [details]
&gt; Fix
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=246945&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/C/gtk/WKAPICastGtk.h:48
&gt; &gt; +inline WKViewRef toAPI(WebKitWebViewBase* view)
&gt; &gt; +{
&gt; &gt; +    return static_cast&lt;WKViewRef&gt;(static_cast&lt;void*&gt;(view));
&gt; &gt; +}
&gt; &gt; +
&gt; &gt; +inline WebKitWebViewBase* toImpl(WKViewRef view)
&gt; &gt; +{
&gt; &gt; +    return static_cast&lt;WebKitWebViewBase*&gt;(static_cast&lt;void*&gt;(const_cast&lt;OpaqueWKView*&gt;(view)));
&gt; &gt; +}
&gt; 
&gt; These should be specializations of the respective templates. They should
&gt; also mimic the previous behavior of the generic toAPI&lt;&gt;() and toImpl&lt;&gt;()
&gt; templates.
&gt; But ideally you&apos;d have WebKitWebViewBase somehow inherit from API::Object,
&gt; if that&apos;s even possible.
&gt; 
&gt; I ended up with this, built with Clang but not tested:
&gt; 
&gt; &gt; template&lt;&gt;
&gt; &gt; inline WKViewRef toAPI&lt;&gt;(WebKitWebViewBase* view)
&gt; &gt; {
&gt; &gt;     return reinterpret_cast&lt;WKViewRef&gt;(static_cast&lt;void*&gt;(view));
&gt; &gt; }
&gt; &gt; 
&gt; &gt; template&lt;&gt;
&gt; &gt; inline WebKitWebViewBase* toImpl&lt;&gt;(WKViewRef view)
&gt; &gt; {
&gt; &gt;     return static_cast&lt;WebKitWebViewBase*&gt;(static_cast&lt;void*&gt;(const_cast&lt;typename std::remove_const&lt;typename std::remove_pointer&lt;WKViewRef&gt;::type&gt;::type*&gt;(view)));
&gt; &gt; }

That works here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070664</commentid>
    <comment_count>13</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-02-20 03:16:35 -0800</bug_when>
    <thetext>Committed r180409: &lt;http://trac.webkit.org/changeset/180409&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1071348</commentid>
    <comment_count>14</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2015-02-23 14:51:34 -0800</bug_when>
    <thetext>&gt; &gt; I ended up with this, built with Clang but not tested:
&gt; &gt; 
&gt; &gt; &gt; template&lt;&gt;
&gt; &gt; &gt; inline WKViewRef toAPI&lt;&gt;(WebKitWebViewBase* view)
&gt; &gt; &gt; {
&gt; &gt; &gt;     return reinterpret_cast&lt;WKViewRef&gt;(static_cast&lt;void*&gt;(view));
&gt; &gt; &gt; }
&gt; &gt; &gt; 
&gt; &gt; &gt; template&lt;&gt;
&gt; &gt; &gt; inline WebKitWebViewBase* toImpl&lt;&gt;(WKViewRef view)
&gt; &gt; &gt; {
&gt; &gt; &gt;     return static_cast&lt;WebKitWebViewBase*&gt;(static_cast&lt;void*&gt;(const_cast&lt;typename std::remove_const&lt;typename std::remove_pointer&lt;WKViewRef&gt;::type&gt;::type*&gt;(view)));
&gt; &gt; &gt; }
&gt; 
&gt; That works here.

Why didn&apos;t you add traits instead?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1071564</commentid>
    <comment_count>15</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-02-23 23:32:24 -0800</bug_when>
    <thetext>(In reply to comment #14)
&gt; &gt; &gt; I ended up with this, built with Clang but not tested:
&gt; &gt; &gt; 
&gt; &gt; &gt; &gt; template&lt;&gt;
&gt; &gt; &gt; &gt; inline WKViewRef toAPI&lt;&gt;(WebKitWebViewBase* view)
&gt; &gt; &gt; &gt; {
&gt; &gt; &gt; &gt;     return reinterpret_cast&lt;WKViewRef&gt;(static_cast&lt;void*&gt;(view));
&gt; &gt; &gt; &gt; }
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; template&lt;&gt;
&gt; &gt; &gt; &gt; inline WebKitWebViewBase* toImpl&lt;&gt;(WKViewRef view)
&gt; &gt; &gt; &gt; {
&gt; &gt; &gt; &gt;     return static_cast&lt;WebKitWebViewBase*&gt;(static_cast&lt;void*&gt;(const_cast&lt;typename std::remove_const&lt;typename std::remove_pointer&lt;WKViewRef&gt;::type&gt;::type*&gt;(view)));
&gt; &gt; &gt; &gt; }
&gt; &gt; 
&gt; &gt; That works here.
&gt; 
&gt; Why didn&apos;t you add traits instead?

Where? Could you elaborate a bit more? The thing is WebKitWebViewBase is not an API::Object, because it&apos;s not even a C++ class, but a GObject, so adding toAPI/toImpl for it was the only way I knew how to fix the problem. If there&apos;s a better way, I&apos;ll land a follow up patch.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>246942</attachid>
            <date>2015-02-20 00:22:40 -0800</date>
            <delta_ts>2015-02-20 00:24:43 -0800</delta_ts>
            <desc>Hot Fix</desc>
            <filename>bug-141813-20150220172234.patch</filename>
            <type>text/plain</type>
            <size>1935</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmYyNTUzZWUyNTNmM2Y1
NDUyMzQxMmEyYzg4NTYxMDA5MDE2N2YyNi4uZDZkNzkwMDE1MzgzYmE3ODMyNjY2YzU4NWMyODIz
NWUyY2U1MjZmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAyLTIwICBHeXV5
b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dLMl0gRml4
IHRoZSBHVEsvRUZMIGJ1aWxkIGFmdGVyIHIxODAzNjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTgxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5o
OiBEb24ndCB1c2UgQVBJOjpPYmplY3Q6OndyYXAgfCBBUEk6Ok9iamVjdDo6dW53cmFwIG9uIEVG
TCBhbmQgR1RLIHBvcnRzLgorCiAyMDE1LTAyLTE5ICBTaGl2YWt1bWFyIEpNICA8c2hpdmEuam1A
c2Ftc3VuZy5jb20+CiAKICAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmcgaW4gV2ViS2l0Mi9XZWJQ
cm9jZXNzIGFuZCBVSVByb2Nlc3MgbW9kdWxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv
U2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQ
SS9jL1dLU2hhcmVkQVBJQ2FzdC5oCmluZGV4IDk0MGQ3MjY1MzJjODk2MGY0ZTE0NTc3MTU3YzU3
MGNhMzQyMGZkMjguLmM4NjVhZmExODQ5ZTY4YTkzMjg0ODBlNDg1YWQwZDEwMDI5NzZlNWIgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1NoYXJlZEFQSUNhc3QuaAor
KysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgKQEAgLTEy
OCwxMyArMTI4LDIxIEBAIFdLX0FERF9BUElfTUFQUElORyhXS09iakNUeXBlV3JhcHBlclJlZiwg
T2JqQ09iamVjdEdyYXBoKQogdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgQVBJVHlwZSA9
IHR5cGVuYW1lIEltcGxUeXBlSW5mbzxUPjo6QVBJVHlwZT4KIGF1dG8gdG9BUEkoVCogdCkgLT4g
QVBJVHlwZQogeworI2lmIFBMQVRGT1JNKEVGTCkgfHwgUExBVEZPUk0oR1RLKQorICAgIHJldHVy
biByZWludGVycHJldF9jYXN0PEFQSVR5cGU+KHQpOworI2Vsc2UKICAgICByZXR1cm4gcmVpbnRl
cnByZXRfY2FzdDxBUElUeXBlPihBUEk6Ok9iamVjdDo6d3JhcCh0KSk7CisjZW5kaWYKIH0KIAog
dGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgSW1wbFR5cGUgPSB0eXBlbmFtZSBBUElUeXBl
SW5mbzxUPjo6SW1wbFR5cGU+CiBhdXRvIHRvSW1wbChUIHQpIC0+IEltcGxUeXBlKgogeworI2lm
IFBMQVRGT1JNKEVGTCkgfHwgUExBVEZPUk0oR1RLKQorICAgIHJldHVybiBzdGF0aWNfY2FzdDxJ
bXBsVHlwZSo+KHN0YXRpY19jYXN0PHZvaWQqPihjb25zdF9jYXN0PHR5cGVuYW1lIHN0ZDo6cmVt
b3ZlX2NvbnN0PHR5cGVuYW1lIHN0ZDo6cmVtb3ZlX3BvaW50ZXI8VD46OnR5cGU+Ojp0eXBlKj4o
dCkpKTsKKyNlbHNlCiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEltcGxUeXBlKj4oQVBJOjpPYmpl
Y3Q6OnVud3JhcChzdGF0aWNfY2FzdDx2b2lkKj4oY29uc3RfY2FzdDx0eXBlbmFtZSBzdGQ6OnJl
bW92ZV9jb25zdDx0eXBlbmFtZSBzdGQ6OnJlbW92ZV9wb2ludGVyPFQ+Ojp0eXBlPjo6dHlwZSo+
KHQpKSkpOworI2VuZGlmCiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1lIEltcGxUeXBlLCB0eXBlbmFt
ZSBBUElUeXBlID0gdHlwZW5hbWUgSW1wbFR5cGVJbmZvPEltcGxUeXBlPjo6QVBJVHlwZT4K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>246943</attachid>
            <date>2015-02-20 00:24:51 -0800</date>
            <delta_ts>2015-02-20 01:32:17 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-141813-20150220172430.patch</filename>
            <type>text/plain</type>
            <size>1885</size>
            <attacher name="Hunseop Jeong">hs85.jeong</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTc5MjUyMDQyMDllZTM4
ODE4ZGJlZTI1YjNmZmQwYzRhNDA0NjAzZS4uNmZiNmI1NGUyY2MxYTc1OGFmZmEwOGQzYWE2OTRi
NTc2MWUyNWVlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAyLTIwICBIdW5z
ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBGaXgg
dGhlIEdUSy9FRkwgYnVpbGQgYWZ0ZXIgcjE4MDM2MiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTgxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5o
OgorCiAyMDE1LTAyLTE5ICBSZW15IERlbWFyZXN0ICA8cmRlbWFyZXN0QGFwcGxlLmNvbT4KIAog
ICAgICAgICBNYWtlIEVudmlyb25tZW50VmFyaWFibGVzOjphcHBlbmRWYWx1ZSgpIGhhbmRsZSB0
aGUgY2FzZSB3aGVyZSB0aGUgZXhpc3RpbmcgdmFsdWUgaXMgYW4gZW1wdHkgc3RyaW5nLgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oIGIv
U291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oCmluZGV4IDk0MGQ3
MjY1MzJjODk2MGY0ZTE0NTc3MTU3YzU3MGNhMzQyMGZkMjguLmU0NjQ5MzIyNGYxMjMzZTg5NDU1
M2RhNDQ4ZGM5MDlmNjM0NzZlYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9B
UEkvYy9XS1NoYXJlZEFQSUNhc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2Mv
V0tTaGFyZWRBUElDYXN0LmgKQEAgLTEyNywxNCArMTI3LDIyIEBAIFdLX0FERF9BUElfTUFQUElO
RyhXS09iakNUeXBlV3JhcHBlclJlZiwgT2JqQ09iamVjdEdyYXBoKQogCiB0ZW1wbGF0ZTx0eXBl
bmFtZSBULCB0eXBlbmFtZSBBUElUeXBlID0gdHlwZW5hbWUgSW1wbFR5cGVJbmZvPFQ+OjpBUElU
eXBlPgogYXV0byB0b0FQSShUKiB0KSAtPiBBUElUeXBlCi17Cit7ICAgICAgICAKKyNpZiBQTEFU
Rk9STShDT0NPQSkKICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxBUElUeXBlPihBUEk6Ok9i
amVjdDo6d3JhcCh0KSk7CisjZWxzZQorICAgIHJldHVybiByZWludGVycHJldF9jYXN0PEFQSVR5
cGU+KHQpOworI2VuZGlmCiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIEltcGxU
eXBlID0gdHlwZW5hbWUgQVBJVHlwZUluZm88VD46OkltcGxUeXBlPgogYXV0byB0b0ltcGwoVCB0
KSAtPiBJbXBsVHlwZSoKIHsKKyNpZiBQTEFURk9STShDT0NPQSkKICAgICByZXR1cm4gc3RhdGlj
X2Nhc3Q8SW1wbFR5cGUqPihBUEk6Ok9iamVjdDo6dW53cmFwKHN0YXRpY19jYXN0PHZvaWQqPihj
b25zdF9jYXN0PHR5cGVuYW1lIHN0ZDo6cmVtb3ZlX2NvbnN0PHR5cGVuYW1lIHN0ZDo6cmVtb3Zl
X3BvaW50ZXI8VD46OnR5cGU+Ojp0eXBlKj4odCkpKSk7CisjZWxzZQorICAgIHJldHVybiBzdGF0
aWNfY2FzdDxJbXBsVHlwZSo+KHN0YXRpY19jYXN0PHZvaWQqPihjb25zdF9jYXN0PHR5cGVuYW1l
IHN0ZDo6cmVtb3ZlX2NvbnN0PHR5cGVuYW1lIHN0ZDo6cmVtb3ZlX3BvaW50ZXI8VD46OnR5cGU+
Ojp0eXBlKj4odCkpKTsKKyNlbmRpZgogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBJbXBsVHlwZSwg
dHlwZW5hbWUgQVBJVHlwZSA9IHR5cGVuYW1lIEltcGxUeXBlSW5mbzxJbXBsVHlwZT46OkFQSVR5
cGU+Cg==
</data>
<flag name="review"
          id="271898"
          type_id="1"
          status="-"
          setter="gyuyoung.kim"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>246945</attachid>
            <date>2015-02-20 01:32:17 -0800</date>
            <delta_ts>2015-02-20 03:13:34 -0800</delta_ts>
            <desc>Fix</desc>
            <filename>wk2-build-fix.diff</filename>
            <type>text/plain</type>
            <size>3899</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCBmZjI1NTNlLi45ZWFhMDI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg
QEAKKzIwMTUtMDItMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgorCisgICAgICAgIFtXSzJdIEZpeCB0aGUgR1RLL0VGTCBidWlsZCBhZnRlciByMTgwMzYyCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE4MTMKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc2V2ZXJh
bCBtaXNzaW5nIGluY2x1ZGVzIGFuZCBhIHNwZWNpZmljIGltcGxlbWVudGF0aW9uIG9mCisgICAg
ICAgIHRvQVBJL3RvSW1wbCBmb3IgR1RLKyBXZWJWaWV3LgorCisgICAgICAgICogVUlQcm9jZXNz
L0FQSS9DL2d0ay9XS0FQSUNhc3RHdGsuaDoKKyAgICAgICAgKFdlYktpdDo6dG9BUEkpOgorICAg
ICAgICAoV2ViS2l0Ojp0b0ltcGwpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9ndGsvV0tW
aWV3LmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRGb3JtQ2xpZW50LmNw
cDoKKyAgICAgICAgKiBVSVByb2Nlc3MvTmV0d29yay9DdXN0b21Qcm90b2NvbHMvc291cC9XZWJT
b3VwQ3VzdG9tUHJvdG9jb2xSZXF1ZXN0TWFuYWdlckNsaWVudC5jcHA6CisgICAgICAgICogVUlQ
cm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JDbGllbnRHdGsuY3BwOgorCiAyMDE1LTAyLTE5ICBTaGl2
YWt1bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgRml4IGJ1aWxkIHdh
cm5pbmcgaW4gV2ViS2l0Mi9XZWJQcm9jZXNzIGFuZCBVSVByb2Nlc3MgbW9kdWxlLgpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS0FQSUNhc3RHdGsuaCBi
L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9ndGsvV0tBUElDYXN0R3RrLmgKaW5kZXgg
OWViMGM3OC4uMzliYmY2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ
SS9DL2d0ay9XS0FQSUNhc3RHdGsuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ
L0MvZ3RrL1dLQVBJQ2FzdEd0ay5oCkBAIC0zNyw2ICszNywxNiBAQCBuYW1lc3BhY2UgV2ViS2l0
IHsKIAogV0tfQUREX0FQSV9NQVBQSU5HKFdLVmlld1JlZiwgV2ViS2l0V2ViVmlld0Jhc2UpCiAK
K2lubGluZSBXS1ZpZXdSZWYgdG9BUEkoV2ViS2l0V2ViVmlld0Jhc2UqIHZpZXcpCit7CisgICAg
cmV0dXJuIHN0YXRpY19jYXN0PFdLVmlld1JlZj4oc3RhdGljX2Nhc3Q8dm9pZCo+KHZpZXcpKTsK
K30KKworaW5saW5lIFdlYktpdFdlYlZpZXdCYXNlKiB0b0ltcGwoV0tWaWV3UmVmIHZpZXcpCit7
CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYktpdFdlYlZpZXdCYXNlKj4oc3RhdGljX2Nhc3Q8
dm9pZCo+KGNvbnN0X2Nhc3Q8T3BhcXVlV0tWaWV3Kj4odmlldykpKTsKK30KKwogfQogCiAjZW5k
aWYgLy8gV0tBUElDYXN0R3RrX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9BUEkvQy9ndGsvV0tWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9n
dGsvV0tWaWV3LmNwcAppbmRleCA4ODc4ZGNlLi4wNTExZjEzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktp
dDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1ZpZXcuY3BwCkBAIC0zMSw2ICszMSw4IEBACiAjaW5j
bHVkZSAiV0tBUElDYXN0LmgiCiAjaW5jbHVkZSAiV0tWaWV3UHJpdmF0ZS5oIgogI2luY2x1ZGUg
IldlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZS5oIgorI2luY2x1ZGUgIldlYlBhZ2VHcm91cC5oIgor
I2luY2x1ZGUgIldlYlByb2Nlc3NQb29sLmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1
c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9BUEkvZ3RrL1dlYktpdEZvcm1DbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL0FQSS9ndGsvV2ViS2l0Rm9ybUNsaWVudC5jcHAKaW5kZXggN2ZiZDNhOC4uMTg5ZDM1ZCAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0Rm9ybUNs
aWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0Rm9y
bUNsaWVudC5jcHAKQEAgLTIwLDYgKzIwLDggQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs
dWRlICJXZWJLaXRGb3JtQ2xpZW50LmgiCiAKKyNpbmNsdWRlICJBUElEaWN0aW9uYXJ5LmgiCisj
aW5jbHVkZSAiV2ViRm9ybVN1Ym1pc3Npb25MaXN0ZW5lclByb3h5LmgiCiAjaW5jbHVkZSAiV2Vi
S2l0Rm9ybVN1Ym1pc3Npb25SZXF1ZXN0UHJpdmF0ZS5oIgogI2luY2x1ZGUgIldlYktpdFByaXZh
dGUuaCIKICNpbmNsdWRlICJXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaCIKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL0N1c3RvbVByb3RvY29scy9zb3VwL1dl
YlNvdXBDdXN0b21Qcm90b2NvbFJlcXVlc3RNYW5hZ2VyQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9OZXR3b3JrL0N1c3RvbVByb3RvY29scy9zb3VwL1dlYlNvdXBDdXN0b21Q
cm90b2NvbFJlcXVlc3RNYW5hZ2VyQ2xpZW50LmNwcAppbmRleCAzNWFhY2Q3Li41MDkxYTI2IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTmV0d29yay9DdXN0b21Qcm90b2Nv
bHMvc291cC9XZWJTb3VwQ3VzdG9tUHJvdG9jb2xSZXF1ZXN0TWFuYWdlckNsaWVudC5jcHAKKysr
IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL05ldHdvcmsvQ3VzdG9tUHJvdG9jb2xzL3NvdXAv
V2ViU291cEN1c3RvbVByb3RvY29sUmVxdWVzdE1hbmFnZXJDbGllbnQuY3BwCkBAIC0yMCw2ICsy
MCw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViU291cEN1c3RvbVByb3Rv
Y29sUmVxdWVzdE1hbmFnZXJDbGllbnQuaCIKIAorI2luY2x1ZGUgIldlYlNvdXBDdXN0b21Qcm90
b2NvbFJlcXVlc3RNYW5hZ2VyLmgiCisKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBib29sIFdlYlNv
dXBDdXN0b21Qcm90b2NvbFJlcXVlc3RNYW5hZ2VyQ2xpZW50OjpzdGFydExvYWRpbmcoV2ViU291
cEN1c3RvbVByb3RvY29sUmVxdWVzdE1hbmFnZXIqIHNvdXBSZXF1ZXN0TWFuYWdlciwgdWludDY0
X3QgY3VzdG9tUHJvdG9jb2xJRCwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXF1
ZXN0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0
b3JDbGllbnRHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0
b3JDbGllbnRHdGsuY3BwCmluZGV4IDFjOTVjMmMuLmY0MjQ3MzMgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yQ2xpZW50R3RrLmNwcAorKysgYi9T
b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkluc3BlY3RvckNsaWVudEd0ay5jcHAKQEAg
LTI3LDcgKzI3LDcgQEAKICNpbmNsdWRlICJXZWJJbnNwZWN0b3JDbGllbnRHdGsuaCIKIAogI2lu
Y2x1ZGUgIldLQVBJQ2FzdC5oIgotI2luY2x1ZGUgIldLU2hhcmVkQVBJQ2FzdC5oIgorI2luY2x1
ZGUgIldlYkluc3BlY3RvclByb3h5LmgiCiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+
CiAKIG5hbWVzcGFjZSBXZWJLaXQgewo=
</data>
<flag name="review"
          id="271900"
          type_id="1"
          status="+"
          setter="zan"
    />
          </attachment>
      

    </bug>

</bugzilla>