141794 2015-02-19 02:07:11 -0800 Fix build warning in WebKit2/WebProcess and UIProcess module 2015-02-19 22:14:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm shiva.jm andersca commit-queue gyuyoung.kim ossy thorton oldest_to_newest 1070372 0 shiva.jm 2015-02-19 02:07:11 -0800 Got below build warning on latest build, might have casued by issue: https://bugs.webkit.org/show_bug.cgi?id=141724 ../../Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:115:26: warning: unused parameter ‘isNonPersistentStore’ [-Wunused-parameter] static ProcessAccessType computeWebProcessAccessType(WebsiteDataTypes dataTypes, bool isNonPersistentStore) ^ [4500/5125] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp.o [4501/5125] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp.o [4502/5125] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Databases/WebToDatabaseProcessConnection.cpp.o [4503/5125] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/FileAPI/BlobRegistryProxy.cpp.o [4504/5125] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/FullScreen/WebFullScreenManager.cpp.o ../../Source/WebKit2/WebProcess/WebProcess.cpp:1136:6: warning: unused parameter ‘modifiedSince’ [-Wunused-parameter] void WebProcess::deleteWebsiteData(SessionID sessionID, uint64_t websiteDataTypes, std::chrono::system_clock::time_point modifiedSince, uint64_t callbackID) 1070373 1 246887 shiva.jm 2015-02-19 02:11:39 -0800 Created attachment 246887 Patch Fix build warnings by removing parameter name from functions 1070379 2 246887 ossy 2015-02-19 03:26:07 -0800 Comment on attachment 246887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246887&action=review > Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:115 > -static ProcessAccessType computeWebProcessAccessType(WebsiteDataTypes dataTypes, bool isNonPersistentStore) > +static ProcessAccessType computeWebProcessAccessType(WebsiteDataTypes dataTypes, bool) I don't know why http://trac.webkit.org/changeset/180265 added this unused parameter to computeWebProcessAccessType(). This function is called from one place with passing this unused parameter. If it isn't passed due to recent / planned feature, I'd remove it completely. Anders? > Source/WebKit2/WebProcess/WebProcess.cpp:1136 > -void WebProcess::deleteWebsiteData(SessionID sessionID, uint64_t websiteDataTypes, std::chrono::system_clock::time_point modifiedSince, uint64_t callbackID) > +void WebProcess::deleteWebsiteData(SessionID sessionID, uint64_t websiteDataTypes, std::chrono::system_clock::time_point, uint64_t callbackID) It seems it can be removed. But why can't we remove it from the message and from WebPageProxy too if it is unused? Or is it intentional to have exactly the same deleteWebsiteData message format in WebProcess and Networkprocess? 1070391 3 246887 andersca 2015-02-19 06:25:57 -0800 Comment on attachment 246887 Patch This is work in progress. I'd rather this used UNUSED_PARAM for now! 1070597 4 246935 shiva.jm 2015-02-19 20:28:28 -0800 Created attachment 246935 Patch-Updated-Review1 updated the patch with review comments 1070607 5 246935 commit-queue 2015-02-19 22:14:22 -0800 Comment on attachment 246935 Patch-Updated-Review1 Clearing flags on attachment: 246935 Committed r180386: <http://trac.webkit.org/changeset/180386> 1070608 6 commit-queue 2015-02-19 22:14:26 -0800 All reviewed patches have been landed. Closing bug. 246887 2015-02-19 02:11:39 -0800 2015-02-19 20:28:28 -0800 Patch bug-141794.patch text/plain 2256 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDM0MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTE5ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViS2l0Mi9XZWJQcm9jZXNzIGFuZCBVSVByb2Nlc3MgbW9kdWxlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNzk0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmdz IGJ5IHJlbW92aW5nIHBhcmFtZXRlciBuYW1lIGZyb20gZnVuY3Rpb25zCisKKyAgICAgICAgKiBV SVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHA6CisgICAgICAgIChXZWJL aXQ6OmNvbXB1dGVXZWJQcm9jZXNzQWNjZXNzVHlwZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6ZGVsZXRlV2Vic2l0 ZURhdGEpOgorCiAyMDE1LTAyLTE4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dLMl1baU9TXSBGaXggTmV0d29ya0NhY2hlIGJ1aWxkCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRh U3RvcmUuY3BwCShyZXZpc2lvbiAxODAzNDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMiw3 ICsxMTIsNyBAQCBzdGF0aWMgUHJvY2Vzc0FjY2Vzc1R5cGUgY29tcHV0ZU5ldHdvcmtQCiAgICAg cmV0dXJuIHByb2Nlc3NBY2Nlc3NUeXBlOwogfQogCi1zdGF0aWMgUHJvY2Vzc0FjY2Vzc1R5cGUg Y29tcHV0ZVdlYlByb2Nlc3NBY2Nlc3NUeXBlKFdlYnNpdGVEYXRhVHlwZXMgZGF0YVR5cGVzLCBi b29sIGlzTm9uUGVyc2lzdGVudFN0b3JlKQorc3RhdGljIFByb2Nlc3NBY2Nlc3NUeXBlIGNvbXB1 dGVXZWJQcm9jZXNzQWNjZXNzVHlwZShXZWJzaXRlRGF0YVR5cGVzIGRhdGFUeXBlcywgYm9vbCkK IHsKICAgICBQcm9jZXNzQWNjZXNzVHlwZSBwcm9jZXNzQWNjZXNzVHlwZSA9IFByb2Nlc3NBY2Nl c3NUeXBlOjpOb25lOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nl c3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vz cy5jcHAJKHJldmlzaW9uIDE4MDM0MikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMzMsNyArMTEzMyw3IEBAIHZvaWQgV2Vi UHJvY2Vzczo6cmVsZWFzZVBhZ2VDYWNoZSgpCiAgICAgUGFnZUNhY2hlOjpzaW5nbGV0b24oKS5w cnVuZVRvU2l6ZU5vdygwLCBQcnVuaW5nUmVhc29uOjpNZW1vcnlQcmVzc3VyZSk7CiB9CiAKLXZv aWQgV2ViUHJvY2Vzczo6ZGVsZXRlV2Vic2l0ZURhdGEoU2Vzc2lvbklEIHNlc3Npb25JRCwgdWlu dDY0X3Qgd2Vic2l0ZURhdGFUeXBlcywgc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9w b2ludCBtb2RpZmllZFNpbmNlLCB1aW50NjRfdCBjYWxsYmFja0lEKQordm9pZCBXZWJQcm9jZXNz OjpkZWxldGVXZWJzaXRlRGF0YShTZXNzaW9uSUQgc2Vzc2lvbklELCB1aW50NjRfdCB3ZWJzaXRl RGF0YVR5cGVzLCBzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0aW1lX3BvaW50LCB1aW50NjRf dCBjYWxsYmFja0lEKQogewogICAgIGlmICh3ZWJzaXRlRGF0YVR5cGVzICYgV2Vic2l0ZURhdGFU eXBlTWVtb3J5Q2FjaGUpIHsKICAgICAgICAgUGFnZUNhY2hlOjpzaW5nbGV0b24oKS5wcnVuZVRv U2l6ZU5vdygwLCBQcnVuaW5nUmVhc29uOjpOb25lKTsK 246935 2015-02-19 20:28:28 -0800 2015-02-19 22:14:22 -0800 Patch-Updated-Review1 bug-141794-updated.patch text/plain 2158 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDM3OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTE5ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViS2l0Mi9XZWJQcm9jZXNzIGFuZCBVSVByb2Nlc3MgbW9kdWxlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNzk0LgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5n IGJ5IHVzaW5nIFVOVVNFRF9QQVJBTSBtYWNyby4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJz aXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Y29tcHV0ZVdl YlByb2Nlc3NBY2Nlc3NUeXBlKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjpkZWxldGVXZWJzaXRlRGF0YSk6CisKIDIw MTUtMDItMTkgIFJlbXkgRGVtYXJlc3QgIDxyZGVtYXJlc3RAYXBwbGUuY29tPgogCiAgICAgICAg IE1ha2UgRW52aXJvbm1lbnRWYXJpYWJsZXM6OmFwcGVuZFZhbHVlKCkgaGFuZGxlIHRoZSBjYXNl IHdoZXJlIHRoZSBleGlzdGluZyB2YWx1ZSBpcyBhbiBlbXB0eSBzdHJpbmcuCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVE YXRhU3RvcmUuY3BwCShyZXZpc2lvbiAxODAzNDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEx NCw2ICsxMTQsOCBAQCBzdGF0aWMgUHJvY2Vzc0FjY2Vzc1R5cGUgY29tcHV0ZU5ldHdvcmtQCiAK IHN0YXRpYyBQcm9jZXNzQWNjZXNzVHlwZSBjb21wdXRlV2ViUHJvY2Vzc0FjY2Vzc1R5cGUoV2Vi c2l0ZURhdGFUeXBlcyBkYXRhVHlwZXMsIGJvb2wgaXNOb25QZXJzaXN0ZW50U3RvcmUpCiB7Cisg ICAgVU5VU0VEX1BBUkFNKGlzTm9uUGVyc2lzdGVudFN0b3JlKTsKKwogICAgIFByb2Nlc3NBY2Nl c3NUeXBlIHByb2Nlc3NBY2Nlc3NUeXBlID0gUHJvY2Vzc0FjY2Vzc1R5cGU6Ok5vbmU7CiAKICAg ICBpZiAoZGF0YVR5cGVzICYgV2Vic2l0ZURhdGFUeXBlTWVtb3J5Q2FjaGUpCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHJldmlzaW9uIDE4MDM0MikKKysr IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTExMzUsNiArMTEzNSw4IEBAIHZvaWQgV2ViUHJvY2Vzczo6cmVsZWFzZVBhZ2VDYWNoZSgp CiAKIHZvaWQgV2ViUHJvY2Vzczo6ZGVsZXRlV2Vic2l0ZURhdGEoU2Vzc2lvbklEIHNlc3Npb25J RCwgdWludDY0X3Qgd2Vic2l0ZURhdGFUeXBlcywgc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6 dGltZV9wb2ludCBtb2RpZmllZFNpbmNlLCB1aW50NjRfdCBjYWxsYmFja0lEKQogeworICAgIFVO VVNFRF9QQVJBTShtb2RpZmllZFNpbmNlKTsKKwogICAgIGlmICh3ZWJzaXRlRGF0YVR5cGVzICYg V2Vic2l0ZURhdGFUeXBlTWVtb3J5Q2FjaGUpIHsKICAgICAgICAgUGFnZUNhY2hlOjpzaW5nbGV0 b24oKS5wcnVuZVRvU2l6ZU5vdygwLCBQcnVuaW5nUmVhc29uOjpOb25lKTsKICAgICAgICAgTWVt b3J5Q2FjaGU6OnNpbmdsZXRvbigpLmV2aWN0UmVzb3VyY2VzKHNlc3Npb25JRCk7Cg==