141790 2015-02-18 21:46:05 -0800 Web Inspector: DOMTree / Node Details Sidebar do not update as <input> content changes 2015-02-19 07:39:19 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev sam timothy webkit-bug-importer oldest_to_newest 1070339 0 joepeck 2015-02-18 21:46:05 -0800 * SUMMARY DOMTree / Node Details Sidebar do not update as <input> content changes. 1. When <input> goes from single text node child to multiple => inline shadow content editable div updates expand triangle, but fails to update inline text node, shows stale text 2. When text node is selected and and changes text content => Node details sidebar still shows old value * STEPS TO REPRODUCE (1) 1. Inspect <input> on data:text/html,<input value="test"> 2. Show Shadow DOM if needed 3. Select the <div contenteditable> shadow element of the <input> 4. Select the "test" text and delete it => DOM Tree updated but <div contenteditable> still shows "test" inline text value. Should be "..." * STEPS TO REPRODUCE (2) 1. Inspect <input> on data:text/html,<input value="test"> 2. Show Shadow DOM if needed 3. Select the <div contenteditable> shadow element of the <input> 4. Select the "test" text and replace it with "foo" (this triggers another inline text node 5. Expand the <div contenteditable> and select the text node containing "foo" 6. Show Node details sidebar 7. Start typing in the <input> to change the selected text node => Sidebar's Value field should update like the DOM Tree and Navigation Bar, it doesn't 1070340 1 webkit-bug-importer 2015-02-18 21:46:19 -0800 <rdar://problem/19885587> 1070342 2 246878 joepeck 2015-02-18 21:48:12 -0800 Created attachment 246878 [PATCH] Proposed Fix 1070404 3 246878 commit-queue 2015-02-19 07:39:14 -0800 Comment on attachment 246878 [PATCH] Proposed Fix Clearing flags on attachment: 246878 Committed r180344: <http://trac.webkit.org/changeset/180344> 1070405 4 commit-queue 2015-02-19 07:39:19 -0800 All reviewed patches have been landed. Closing bug. 246878 2015-02-18 21:48:12 -0800 2015-02-19 07:39:14 -0800 [PATCH] Proposed Fix tada.patch text/plain 3287 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMzNGVhMGMuLmI0ZjQ3MDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE1LTAyLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRE9NVHJl ZSAvIE5vZGUgRGV0YWlscyBTaWRlYmFyIGRvIG5vdCB1cGRhdGUgYXMgPGlucHV0PiBjb250ZW50 IGNoYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0MTc5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbCk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9jaGFy YWN0ZXJEYXRhTW9kaWZpZWQpOgorICAgICAgICBVcGRhdGUgTm9kZSAiVmFsdWUiIGRldGFpbHMg aWYgY2hhcmFjdGVyIGRhdGEgY2hhbmdlcy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvRE9NVHJlZVVwZGF0ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZVVwZGF0 ZXIucHJvdG90eXBlLl91cGRhdGVNb2RpZmllZE5vZGVzKToKKyAgICAgICAgVXBkYXRlIHRoZSB0 aXRsZSBvZiB0aGUgcGFyZW50LiBJZiB0aGUgcGFyZW50IGhhZCBhIHNpbmdsZSB0ZXh0IG5vZGUg Y2hpbGQKKyAgICAgICAgYW5kIG5vdyBkb2Vzbid0LCBpdCB3aWxsIG5lZWQgdG8gdXBkYXRlIGl0 cyBkaXNwbGF5LgorCisyMDE1LTAyLTE4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ3JlYXRlIFNlcGFyYXRlIE1vZGVsIGFu ZCBWaWV3IE9iamVjdHMgZm9yIFJlbW90ZU9iamVjdHMgLyBPYmplY3RQcmV2aWV3IC8gUHJvcGVy dHlEZXNjcmlwdG9yCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDE2OTYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5q cwppbmRleCA3NTljMmUwLi4yMzE3ZDQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWls c1NpZGViYXJQYW5lbC5qcwpAQCAtMjksNiArMjksNyBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZURl dGFpbHNTaWRlYmFyUGFuZWwgPSBmdW5jdGlvbigpCiAKICAgICBXZWJJbnNwZWN0b3IuZG9tVHJl ZU1hbmFnZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRE9NVHJlZU1hbmFnZXIuRXZl bnQuQXR0cmlidXRlTW9kaWZpZWQsIHRoaXMuX2F0dHJpYnV0ZXNDaGFuZ2VkLCB0aGlzKTsKICAg ICBXZWJJbnNwZWN0b3IuZG9tVHJlZU1hbmFnZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0 b3IuRE9NVHJlZU1hbmFnZXIuRXZlbnQuQXR0cmlidXRlUmVtb3ZlZCwgdGhpcy5fYXR0cmlidXRl c0NoYW5nZWQsIHRoaXMpOworICAgIFdlYkluc3BlY3Rvci5kb21UcmVlTWFuYWdlci5hZGRFdmVu dExpc3RlbmVyKFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlci5FdmVudC5DaGFyYWN0ZXJEYXRh TW9kaWZpZWQsIHRoaXMuX2NoYXJhY3RlckRhdGFNb2RpZmllZCwgdGhpcyk7CiAKICAgICB0aGlz LmVsZW1lbnQuY2xhc3NMaXN0LmFkZChXZWJJbnNwZWN0b3IuRE9NTm9kZURldGFpbHNTaWRlYmFy UGFuZWwuU3R5bGVDbGFzc05hbWUpOwogCkBAIC01NDQsNiArNTQ1LDEzIEBAIFdlYkluc3BlY3Rv ci5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMu X3JlZnJlc2hBY2Nlc3NpYmlsaXR5KCk7CiAgICAgfSwKIAorICAgIF9jaGFyYWN0ZXJEYXRhTW9k aWZpZWQ6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKGV2ZW50LmRhdGEubm9k ZSAhPT0gdGhpcy5kb21Ob2RlKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB0aGlzLl9p ZGVudGl0eU5vZGVWYWx1ZVJvdy52YWx1ZSA9IHRoaXMuZG9tTm9kZS5ub2RlVmFsdWUoKTsKKyAg ICB9LAorCiAgICAgX25vZGVUeXBlRGlzcGxheU5hbWU6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAg ICAgIHN3aXRjaCAodGhpcy5kb21Ob2RlLm5vZGVUeXBlKCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVVcGRhdGVyLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZVVwZGF0ZXIu anMKaW5kZXggY2QyNTAwZi4uYWQyNjg0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZVVwZGF0ZXIuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZVVwZGF0ZXIuanMKQEAgLTEy MCw2ICsxMjAsNyBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZVVwZGF0ZXIucHJvdG90eXBlID0gewog CiAgICAgICAgICAgICB2YXIgcGFyZW50Tm9kZUl0ZW0gPSB0aGlzLl90cmVlT3V0bGluZS5maW5k VHJlZUVsZW1lbnQocGFyZW50KTsKICAgICAgICAgICAgIGlmIChwYXJlbnROb2RlSXRlbSAmJiAh cGFyZW50Tm9kZUl0ZW0uYWxyZWFkeVVwZGF0ZWRDaGlsZHJlbikgeworICAgICAgICAgICAgICAg IHBhcmVudE5vZGVJdGVtLnVwZGF0ZVRpdGxlKCk7CiAgICAgICAgICAgICAgICAgcGFyZW50Tm9k ZUl0ZW0udXBkYXRlQ2hpbGRyZW4oKTsKICAgICAgICAgICAgICAgICBwYXJlbnROb2RlSXRlbS5h bHJlYWR5VXBkYXRlZENoaWxkcmVuID0gdHJ1ZTsKICAgICAgICAgICAgICAgICB1cGRhdGVkUGFy ZW50VHJlZUVsZW1lbnRzLnB1c2gocGFyZW50Tm9kZUl0ZW0pOwo=