141771 2015-02-18 14:59:23 -0800 REGRESSION(r180279): It broke 20 tests on ARM Linux 2015-02-25 01:03:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 141332 1 ossy ossy commit-queue fpizlo ggaren gyuyoung.kim hs85.jeong mark.lam msaboff oliver ossy zherczeg oldest_to_newest 1070240 0 ossy 2015-02-18 14:59:23 -0800 20 different tests fail on ARM and Thumb2 instruction set too: jsc-layout-tests.yaml/js/script-tests/apply-varargs.js jsc-layout-tests.yaml/js/script-tests/comparison-operators.js jsc-layout-tests.yaml/js/script-tests/dfg-arguments-out-of-bounds.js jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js jsc-layout-tests.yaml/js/script-tests/function-apply-many-args.js jsc-layout-tests.yaml/js/script-tests/regress-139548.js jsc-layout-tests.yaml/js/slow-stress/script-tests/variadic-closure-call.js regress/script-tests/call-spread-apply.js regress/script-tests/call-spread-call.js regress/script-tests/deltablue-varargs.js stress/call-varargs-length-effects.js stress/construct-varargs-inline-smaller-Foo.js stress/construct-varargs-inline.js stress/construct-varargs-no-inline.js stress/get-argument-by-val-in-inlined-varargs-call-out-of-bounds.js stress/get-argument-by-val-safe-in-inlined-varargs-call-out-of-bounds.js stress/get-my-argument-by-val-creates-arguments.js stress/load-varargs-then-inlined-call-exit-in-foo.js stress/load-varargs-then-inlined-call-inlined.js stress/load-varargs-then-inlined-call.js detailed results: - https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Thumb2%20Release/builds/11347 - https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Traditional%20Release/builds/11201 ** The following JSC stress test failures have been introduced: jsc-layout-tests.yaml/js/script-tests/apply-varargs.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/comparison-operators-greater.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/comparison-operators-less.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/comparison-operators.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/dfg-arguments-out-of-bounds.js.layout jsc-layout-tests.yaml/js/script-tests/dfg-arguments-out-of-bounds.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/dfg-arguments-out-of-bounds.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/dfg-arguments-out-of-bounds.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/function-apply-many-args.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/regress-139548.js.layout jsc-layout-tests.yaml/js/script-tests/regress-139548.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/regress-139548.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/regress-139548.js.layout-no-llint jsc-layout-tests.yaml/js/slow-stress/script-tests/variadic-closure-call.js.default jsc-layout-tests.yaml/js/slow-stress/script-tests/variadic-closure-call.js.no-cjit regress/script-tests/call-spread-apply.js.always-trigger-copy-phase regress/script-tests/call-spread-apply.js.default regress/script-tests/call-spread-apply.js.dfg-eager regress/script-tests/call-spread-apply.js.dfg-eager-no-cjit-validate regress/script-tests/call-spread-apply.js.no-cjit-validate-phases regress/script-tests/call-spread-apply.js.no-llint regress/script-tests/call-spread-call.js.always-trigger-copy-phase regress/script-tests/call-spread-call.js.default regress/script-tests/call-spread-call.js.dfg-eager regress/script-tests/call-spread-call.js.dfg-eager-no-cjit-validate regress/script-tests/call-spread-call.js.no-cjit-validate-phases regress/script-tests/call-spread-call.js.no-llint regress/script-tests/deltablue-varargs.js.always-trigger-copy-phase regress/script-tests/deltablue-varargs.js.default regress/script-tests/deltablue-varargs.js.dfg-eager regress/script-tests/deltablue-varargs.js.dfg-eager-no-cjit-validate regress/script-tests/deltablue-varargs.js.no-cjit-validate-phases regress/script-tests/deltablue-varargs.js.no-llint stress/call-varargs-length-effects.js.always-trigger-copy-phase stress/call-varargs-length-effects.js.default stress/call-varargs-length-effects.js.dfg-eager stress/call-varargs-length-effects.js.dfg-eager-no-cjit-validate stress/call-varargs-length-effects.js.no-cjit-validate-phases stress/call-varargs-length-effects.js.no-llint stress/construct-varargs-inline-smaller-Foo.js.always-trigger-copy-phase stress/construct-varargs-inline-smaller-Foo.js.default stress/construct-varargs-inline-smaller-Foo.js.dfg-eager stress/construct-varargs-inline-smaller-Foo.js.dfg-eager-no-cjit-validate stress/construct-varargs-inline-smaller-Foo.js.no-cjit-validate-phases stress/construct-varargs-inline-smaller-Foo.js.no-llint stress/construct-varargs-inline.js.always-trigger-copy-phase stress/construct-varargs-inline.js.default stress/construct-varargs-inline.js.dfg-eager stress/construct-varargs-inline.js.dfg-eager-no-cjit-validate stress/construct-varargs-inline.js.no-cjit-validate-phases stress/construct-varargs-inline.js.no-llint stress/construct-varargs-no-inline.js.always-trigger-copy-phase stress/construct-varargs-no-inline.js.default stress/construct-varargs-no-inline.js.dfg-eager stress/construct-varargs-no-inline.js.dfg-eager-no-cjit-validate stress/construct-varargs-no-inline.js.no-cjit-validate-phases stress/construct-varargs-no-inline.js.no-llint stress/get-argument-by-val-in-inlined-varargs-call-out-of-bounds.js.always-trigger-copy-phase stress/get-argument-by-val-in-inlined-varargs-call-out-of-bounds.js.default stress/get-argument-by-val-in-inlined-varargs-call-out-of-bounds.js.dfg-eager stress/get-argument-by-val-in-inlined-varargs-call-out-of-bounds.js.dfg-eager-no-cjit-validate stress/get-argument-by-val-in-inlined-varargs-call-out-of-bounds.js.no-cjit-validate-phases stress/get-argument-by-val-in-inlined-varargs-call-out-of-bounds.js.no-llint stress/get-argument-by-val-safe-in-inlined-varargs-call-out-of-bounds.js.always-trigger-copy-phase stress/get-argument-by-val-safe-in-inlined-varargs-call-out-of-bounds.js.default stress/get-argument-by-val-safe-in-inlined-varargs-call-out-of-bounds.js.dfg-eager stress/get-argument-by-val-safe-in-inlined-varargs-call-out-of-bounds.js.dfg-eager-no-cjit-validate stress/get-argument-by-val-safe-in-inlined-varargs-call-out-of-bounds.js.no-cjit-validate-phases stress/get-argument-by-val-safe-in-inlined-varargs-call-out-of-bounds.js.no-llint stress/get-my-argument-by-val-creates-arguments.js.always-trigger-copy-phase stress/get-my-argument-by-val-creates-arguments.js.default stress/get-my-argument-by-val-creates-arguments.js.dfg-eager stress/get-my-argument-by-val-creates-arguments.js.dfg-eager-no-cjit-validate stress/get-my-argument-by-val-creates-arguments.js.no-cjit-validate-phases stress/get-my-argument-by-val-creates-arguments.js.no-llint stress/load-varargs-then-inlined-call-exit-in-foo.js.always-trigger-copy-phase stress/load-varargs-then-inlined-call-exit-in-foo.js.default stress/load-varargs-then-inlined-call-exit-in-foo.js.dfg-eager stress/load-varargs-then-inlined-call-exit-in-foo.js.dfg-eager-no-cjit-validate stress/load-varargs-then-inlined-call-exit-in-foo.js.no-cjit-validate-phases stress/load-varargs-then-inlined-call-exit-in-foo.js.no-llint stress/load-varargs-then-inlined-call-inlined.js.always-trigger-copy-phase stress/load-varargs-then-inlined-call-inlined.js.default stress/load-varargs-then-inlined-call-inlined.js.dfg-eager stress/load-varargs-then-inlined-call-inlined.js.dfg-eager-no-cjit-validate stress/load-varargs-then-inlined-call-inlined.js.no-cjit-validate-phases stress/load-varargs-then-inlined-call-inlined.js.no-llint stress/load-varargs-then-inlined-call.js.always-trigger-copy-phase stress/load-varargs-then-inlined-call.js.default stress/load-varargs-then-inlined-call.js.dfg-eager stress/load-varargs-then-inlined-call.js.dfg-eager-no-cjit-validate stress/load-varargs-then-inlined-call.js.no-cjit-validate-phases stress/load-varargs-then-inlined-call.js.no-llint Results for JSC stress tests: 94 failures found. 1070242 1 fpizlo 2015-02-18 15:13:14 -0800 I wonder if this is because of EABI. Those new callOperation() overflows may need to be tweaked to respect EABI's treatment of 64-bit values. 1070361 2 ossy 2015-02-18 23:37:10 -0800 (In reply to comment #1) > I wonder if this is because of EABI. Those new callOperation() overflows > may need to be tweaked to respect EABI's treatment of 64-bit values. Many thanks for the hint, I chekced the new call functions, it seems the problem is exactly this. I'll prepare the fix soon. 1070368 3 246885 ossy 2015-02-19 00:51:50 -0800 Created attachment 246885 Patch fixed, tested, all tests pass now 1070369 4 zherczeg 2015-02-19 01:45:32 -0800 Lgtm. 1070407 5 246885 commit-queue 2015-02-19 07:46:22 -0800 Comment on attachment 246885 Patch Clearing flags on attachment: 246885 Committed r180345: <http://trac.webkit.org/changeset/180345> 1070408 6 commit-queue 2015-02-19 07:46:25 -0800 All reviewed patches have been landed. Closing bug. 1072008 7 ossy 2015-02-25 01:03:09 -0800 *** Bug 141954 has been marked as a duplicate of this bug. *** 246885 2015-02-19 00:51:50 -0800 2015-02-19 07:46:22 -0800 Patch bug-141771-20150219005140.patch text/plain 2341 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl NWEwNGY0ZGE4MDgyMDIxYTcxMWZkZDgzYmUzMzY3Y2MyNTEzOWYyLi40YWM0ZTg5ZWYzYjgxOGNh YjA4Y2Q4MDIxZDg4NGE4MDlhMTcyMzM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0wMi0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4MDI3OSk6IEl0IGJyb2tlIDIwIHRlc3RzIG9u IEFSTSBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQxNzcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuaDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxh dGl2ZUpJVDo6Y2FsbE9wZXJhdGlvbik6IEFsaWduIDY0LWJpdCB2YWx1ZXMgdG8gcmVzcGVjdCBB Uk0gRUFCSS4KKwogMjAxNS0wMi0xOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgQnl0ZWNvZGVHZW5lcmF0b3IncyBudW1iZXJNYXAsIGl0 IGlzIGRlYWQgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT cGVjdWxhdGl2ZUpJVC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2 ZUpJVC5oCmluZGV4IDg2YzgzNmQxMmE3NjA1NmNhM2RiY2M5Yzg5MzdlZjVjY2I5NTEyZjkuLmJm ZTZhZTMzM2Q5NTU4Y2E4NTQ0MzZiOTlmMDcxYTcxOTkzZGRiM2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKQEAgLTE3NzAsNyArMTc3MCw3IEBA IHB1YmxpYzoKIAogICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oWl9KSVRPcGVy YXRpb25fRUpaWiBvcGVyYXRpb24sIEdQUlJlZyByZXN1bHQsIEdQUlJlZyBhcmcxVGFnLCBHUFJS ZWcgYXJnMVBheWxvYWQsIHVuc2lnbmVkIGFyZzIsIHVuc2lnbmVkIGFyZzMpCiAgICAgewotICAg ICAgICBtX2ppdC5zZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMVBheWxvYWQsIGFyZzFU YWcsIFRydXN0ZWRJbW0zMihhcmcyKSwgVHJ1c3RlZEltbTMyKGFyZzMpKTsKKyAgICAgICAgbV9q aXQuc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKEVBQklfMzJCSVRfRFVNTVlfQVJHICBhcmcx UGF5bG9hZCwgYXJnMVRhZywgVHJ1c3RlZEltbTMyKGFyZzIpLCBUcnVzdGVkSW1tMzIoYXJnMykp OwogICAgICAgICByZXR1cm4gYXBwZW5kQ2FsbFdpdGhFeGNlcHRpb25DaGVja1NldFJlc3VsdChv cGVyYXRpb24sIHJlc3VsdCk7CiAgICAgfQogICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVy YXRpb24oRl9KSVRPcGVyYXRpb25fRUZKWlogb3BlcmF0aW9uLCBHUFJSZWcgcmVzdWx0LCBHUFJS ZWcgYXJnMSwgR1BSUmVnIGFyZzJUYWcsIEdQUlJlZyBhcmcyUGF5bG9hZCwgdW5zaWduZWQgYXJn MywgR1BSUmVnIGFyZzQpCkBAIC0xNzgwLDcgKzE3ODAsNyBAQCBwdWJsaWM6CiAgICAgfQogICAg IEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oWl9KSVRPcGVyYXRpb25fRUpaIG9wZXJh dGlvbiwgR1BSUmVnIHJlc3VsdCwgR1BSUmVnIGFyZzFUYWcsIEdQUlJlZyBhcmcxUGF5bG9hZCwg dW5zaWduZWQgYXJnMikKICAgICB7Ci0gICAgICAgIG1faml0LnNldHVwQXJndW1lbnRzV2l0aEV4 ZWNTdGF0ZShhcmcxUGF5bG9hZCwgYXJnMVRhZywgVHJ1c3RlZEltbTMyKGFyZzIpKTsKKyAgICAg ICAgbV9qaXQuc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKEVBQklfMzJCSVRfRFVNTVlfQVJH IGFyZzFQYXlsb2FkLCBhcmcxVGFnLCBUcnVzdGVkSW1tMzIoYXJnMikpOwogICAgICAgICByZXR1 cm4gYXBwZW5kQ2FsbFdpdGhFeGNlcHRpb25DaGVja1NldFJlc3VsdChvcGVyYXRpb24sIHJlc3Vs dCk7CiAgICAgfQogICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oVl9KSVRPcGVy YXRpb25fRVpKWlpaIG9wZXJhdGlvbiwgdW5zaWduZWQgYXJnMSwgR1BSUmVnIGFyZzJUYWcsIEdQ UlJlZyBhcmcyUGF5bG9hZCwgdW5zaWduZWQgYXJnMywgR1BSUmVnIGFyZzQsIHVuc2lnbmVkIGFy ZzUpCg==