141765 2015-02-18 12:44:33 -0800 [Win] CFData leak in CDMSessionAVFoundationCF 2015-02-18 16:20:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck bfulgham bfulgham eric.carlson webkit-bug-importer oldest_to_newest 1070198 0 joepeck 2015-02-18 12:44:33 -0800 * SUMMARY Possible CFData leak in CDMSessionAVFoundationCF. This looks like a leak to me: RetainPtr<CFDataRef> keyRequest = AVCFAssetResourceLoadingRequestCreateStreamingContentKeyRequestDataForApp(...); The naming of the method implies "Create" so I would expect an adoptCF() into the RetainPtr. 1070225 1 bfulgham 2015-02-18 14:10:39 -0800 (In reply to comment #0) > * SUMMARY > Possible CFData leak in CDMSessionAVFoundationCF. > > This looks like a leak to me: > > RetainPtr<CFDataRef> keyRequest = > AVCFAssetResourceLoadingRequestCreateStreamingContentKeyRequestDataForApp(... > ); > > The naming of the method implies "Create" so I would expect an adoptCF() > into the RetainPtr. I agree! 1070226 2 webkit-bug-importer 2015-02-18 14:11:30 -0800 <rdar://problem/19880286> 1070233 3 246849 bfulgham 2015-02-18 14:36:37 -0800 Created attachment 246849 Patch 1070244 4 246849 joepeck 2015-02-18 15:20:46 -0800 Comment on attachment 246849 Patch r=me! Thanks. 1070267 5 bfulgham 2015-02-18 16:20:23 -0800 Committed r180324: <http://trac.webkit.org/changeset/180324> 246849 2015-02-18 14:36:37 -0800 2015-02-18 15:20:46 -0800 Patch bug-141765-20150218144458.patch text/plain 1788 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDI5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTE4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIENGRGF0YSBsZWFr IGluIENETVNlc3Npb25BVkZvdW5kYXRpb25DRgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNzY1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNDE3 NjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2YvQ0RNU2Vzc2lvbkFWRm91bmRhdGlvbkNG LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNETVNlc3Npb25BVkZvdW5kYXRpb25DRjo6Z2VuZXJh dGVLZXlSZXF1ZXN0KTogdXNlICdhZG9wdENGJworICAgICAgICBzbyB3ZSBkb24ndCBkb3VibGUt aW5jcmVtZW50IHRoZSByZXRhaW4gY291bnQuCisKIDIwMTUtMDItMTggIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgTG9jYWxpemVkU3RyaW5n c01hYy5jcHAgdG8gTG9jYWxpemVkU3RyaW5nc0NvY29hLm1tCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2YvQ0RNU2Vzc2lvbkFWRm91bmRhdGlv bkNGLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vY2YvQ0RNU2Vzc2lvbkFWRm91bmRhdGlvbkNGLmNwcAkocmV2aXNpb24gMTgw MjkyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL2Nm L0NETVNlc3Npb25BVkZvdW5kYXRpb25DRi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3LDcgKzc3 LDcgQEAgUGFzc1JlZlB0cjxVaW50OEFycmF5PiBDRE1TZXNzaW9uQVZGb3VuZAogICAgIENGRGF0 YUFwcGVuZEJ5dGVzKGFzc2V0SUQuZ2V0KCksIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVUludDgq Pihhc3NldFN0ci5kYXRhKCkpLCBhc3NldFN0ci5sZW5ndGgoKSk7CiAKICAgICBDRkVycm9yUmVm IGNmRXJyb3IgPSBudWxscHRyOwotICAgIFJldGFpblB0cjxDRkRhdGFSZWY+IGtleVJlcXVlc3Qg PSBBVkNGQXNzZXRSZXNvdXJjZUxvYWRpbmdSZXF1ZXN0Q3JlYXRlU3RyZWFtaW5nQ29udGVudEtl eVJlcXVlc3REYXRhRm9yQXBwKG1fcmVxdWVzdC5nZXQoKSwgY2VydGlmaWNhdGVEYXRhLmdldCgp LCBhc3NldElELmdldCgpLCBudWxscHRyLCAmY2ZFcnJvcik7CisgICAgUmV0YWluUHRyPENGRGF0 YVJlZj4ga2V5UmVxdWVzdCA9IGFkb3B0Q0YoQVZDRkFzc2V0UmVzb3VyY2VMb2FkaW5nUmVxdWVz dENyZWF0ZVN0cmVhbWluZ0NvbnRlbnRLZXlSZXF1ZXN0RGF0YUZvckFwcChtX3JlcXVlc3QuZ2V0 KCksIGNlcnRpZmljYXRlRGF0YS5nZXQoKSwgYXNzZXRJRC5nZXQoKSwgbnVsbHB0ciwgJmNmRXJy b3IpKTsKIAogICAgIGlmICgha2V5UmVxdWVzdCkgewogICAgICAgICBSZXRhaW5QdHI8Q0ZEaWN0 aW9uYXJ5UmVmPiB1c2VySW5mbzsK