141758 2015-02-18 09:21:35 -0800 Finding an option in a select element shouldn't be reset when the user types a space 2023-06-16 09:48:02 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified OS X 10.10 NEW InRadar P2 Normal --- 1 adele webkit-unassigned adele ahmad.saleem792 akeerthi ap bfulgham hyatt jonlee kandalkar.abhijeet58 rniwa spam-webkit oldest_to_newest 1070125 0 246820 adele 2015-02-18 09:21:35 -0800 Created attachment 246820 Test case Finding an option in a select element shouldn't be reset when the user types a space. Steps to reproduce: 1) Load the attached test case 2) Hit tab twice to focus the select element 3) Type "United S" When you hit the space, the search string is reset, and when you next type "S", "Spain" is selected. I expect "United States" to be selected. Firefox behaves correctly, Chrome matches our behavior. 1070128 1 adele 2015-02-18 09:33:12 -0800 rdar://problem/19875341 1071125 2 adele 2015-02-22 21:12:09 -0800 WebKit considers the event to be handled once the popup opens. I played around with trying to call typeAheadFind before opening the menu, but that doesn't really help. The searching WebKit does in the select element before the menu opens is separate from any searching that happens after the menu is open (which I think is handled by AppKit). So even if WebKit's search string includes the space, it doesn't help because the AppKit menu doesn't know anything about the characters that were typed before the menu was opened. So I think the challenge here is to find a way to pass this info along. 1082201 3 kandalkar.abhijeet58 2015-04-02 03:03:59 -0700 Related chromium issue : https://code.google.com/p/chromium/issues/detail?id=473050 1899310 4 ahmad.saleem792 2022-09-18 03:27:53 -0700 I think this is added already here: https://github.com/WebKit/WebKit/blob/5a8883c75f0a425515a601a4eb8de66e88ada97d/Source/WebCore/html/HTMLSelectElement.cpp#L1213 rniwa@webkit.org - Can you confirm? Thanks! 1899407 5 rniwa 2022-09-18 18:47:52 -0700 The issue still reproduces in Safari whereas Chrome & Firefox will select "United States" upon typing "united s". The space after "united" is opening the popup instead of changing the selection to "united states". 1962131 6 ahmad.saleem792 2023-06-16 09:48:02 -0700 Potential merge - https://src.chromium.org/viewvc/blink?view=revision&revision=193280 ^ I merged locally with following changes: < In HTMLSelectElement.cpp > Line 1245: if ((keyCode == ' ' && !m_typeAhead.hasActiveSession(&keyboardEvent)) || keyCode == '\r') { in HTMLSelectElement::menuListDefaultEventHandler. _______ < In TypeAhead.h > bool hasActiveSession(KeyboardEvent*); _____ < In TypeAhead.cpp > bool TypeAhead::hasActiveSession(KeyboardEvent* event) { Seconds delta = event->timeStamp() - m_lastTypeTime; return delta <= typeAheadTimeout; } ______ This compiles but it does not fixed attached testcase. :-( 246820 2015-02-18 09:21:35 -0800 2015-02-18 09:21:35 -0800 Test case test.html text/html 159 adele PGlucHV0Pgo8c2VsZWN0PgogICAgPG9wdGlvbj5DYW5hZGE8L29wdGlvbj4KICAgIDxvcHRpb24+ U3BhaW48L29wdGlvbj4KICAgIDxvcHRpb24+VW5pdGVkIEFyYWIgRW1lcml0ZXM8L29wdGlvbj4K ICAgIDxvcHRpb24+VW5pdGVkIFN0YXRlczwvb3B0aW9uPgo8L3NlbGVjdD4K