<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>141746</bug_id>
          
          <creation_ts>2015-02-17 23:56:30 -0800</creation_ts>
          <short_desc>REGRESSION(r180235): It broke the !ENABLE(PROMISES) build</short_desc>
          <delta_ts>2015-02-18 00:58:07 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>141634</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>joepeck</cc>
    
    <cc>timothy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1070059</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-02-17 23:56:30 -0800</bug_when>
    <thetext>build log:
../../Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp: In member function &apos;JSC::JSValue Inspector::JSInjectedScriptHost::getInternalProperties(JSC::ExecState*)&apos;:
../../Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:212:9: error: &apos;JSPromise&apos; was not declared in this scope

The problem is that JSPromise type is used unconditionally,
but it is defined inside ENABLE(PROMISES) guard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070070</commentid>
    <comment_count>1</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2015-02-18 00:56:04 -0800</bug_when>
    <thetext>Oops, somehow I didn&apos;t even notice that this was behind an enable flag. I&apos;ll fix. Thanks for alerting me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1070073</commentid>
    <comment_count>2</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2015-02-18 00:58:07 -0800</bug_when>
    <thetext>Should be fixed by:
http://trac.webkit.org/changeset/180259</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>