141744 2015-02-17 21:26:48 -0800 [iOS] Fix inefficiencies in ResourceResponse::platformLazyInit() 2015-02-19 11:43:24 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez ap commit-queue darin ggaren kling koivisto mitz oldest_to_newest 1070040 0 cdumez 2015-02-17 21:26:48 -0800 Fix inefficiencies in ResourceResponse::platformLazyInit(), similarly to what was already done for Mac in <http://trac.webkit.org/changeset/174717>. 1070046 1 246801 cdumez 2015-02-17 21:38:57 -0800 Created attachment 246801 Patch 1070434 2 cdumez 2015-02-19 10:37:29 -0800 ping review? 1070441 3 246801 ap 2015-02-19 10:51:27 -0800 Comment on attachment 246801 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246801&action=review > Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:107 > - if (m_initLevel < AllFields) { > + if (m_initLevel < AllFields && initLevel == AllFields) { Whoa. Did this regress recently? 1070442 4 kling 2015-02-19 10:54:49 -0800 @Alexey: I know you have strong feelings about making changes to the iOS resource loader code at this point in time. Care to comment on this change? 1070443 5 kling 2015-02-19 10:55:25 -0800 (In reply to comment #4) > @Alexey: I know you have strong feelings about making changes to the iOS > resource loader code at this point in time. Care to comment on this change? Oh oops, this comment landed just after you commented! Thanks :-) 1070447 6 246801 cdumez 2015-02-19 10:59:52 -0800 Comment on attachment 246801 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246801&action=review >> Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:107 >> + if (m_initLevel < AllFields && initLevel == AllFields) { > > Whoa. Did this regress recently? Yes, I think this regressed in <https://trac.webkit.org/r173272>. 1070463 7 246801 commit-queue 2015-02-19 11:43:19 -0800 Comment on attachment 246801 Patch Clearing flags on attachment: 246801 Committed r180353: <http://trac.webkit.org/changeset/180353> 1070464 8 commit-queue 2015-02-19 11:43:24 -0800 All reviewed patches have been landed. Closing bug. 246801 2015-02-17 21:38:57 -0800 2015-02-19 11:43:19 -0800 Patch bug-141744-20150217213851.patch text/plain 5197 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTBiN2YyMmZlMzMwN2Nh YmRiYjkwOTEzNzkwYzY0ZjE3ZDk5ZTU1My4uODQ1ZDg4YWIyZDE4ODIyOGI1ZjFkMTIzMTkzNjY2 M2JlMGU5ODEwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE1LTAyLTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gRml4IGluZWZmaWNp ZW5jaWVzIGluIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtTGF6eUluaXQoKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNzQ0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGluZWZmaWNpZW5jaWVz IGluIGlPUydzIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtTGF6eUluaXQoKQorICAgICAgICBp bXBsZW1lbnRhdGlvbiwgc2ltaWxhcmx5IHRvIHdoYXQgd2FzIGFscmVhZHkgZG9uZSBmb3IgTWFj IGluOgorICAgICAgICA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTc0NzE3Pgor CisgICAgICAgIFRoZSBmb2xsb3dpbmcgY2hhbmdlcyB3ZXJlIG1hZGU6CisgICAgICAgIC0gQWRk IG1pc3NpbmcgImluaXRMZXZlbCA9PSBBbGxGaWVsZHMiIGNoZWNrIGJlZm9yZSBpbml0aWFsaXpp bmcKKyAgICAgICAgICB1bmNvbW1vbiBmaWVsZHMuIFRoaXMgYnVnIHdhcyBjYXVzaW5nIHVzIHRv IGluaXRpYWxpemUgdW5jb21tb24KKyAgICAgICAgICBmaWVsZHMgZXZlbiBpZiBjYWxsZWQgd2l0 aCAnQ29tbW9uRmllbGRzT25seScgaW5pdExldmVsLgorICAgICAgICAtIEJ5cGFzcyB0aGUgZmly c3QgcGFzcyBwb3B1bGF0aW5nIGNvbW1vbiBIVFRQIGhlYWRlcnMgaW4KKyAgICAgICAgICBtX2h0 dHBIZWFkZXJGaWVsZHMgaWYgdGhlIGluaXRMZXZlbCBpcyBBbGxGaWVsZHMuIElmIGNhbGxlZAor ICAgICAgICAgIHdpdGggQWxsRmllbGRzIGluaXRMZXZlbCwgd2Ugd2lsbCBlbmQgdXAgcG9wdWxh dGluZyBhbGwgSFRUUAorICAgICAgICAgIGhlYWRlcnMgbGF0ZXIgb24gc28gdGhpcyBmaXJzdCBw YXNzIGlzIHJlZHVuZGFudC4KKyAgICAgICAgLSBVc2UgQysrMTEgcmFuZ2UgbG9vcCB0byBpdGVy YXRvciBvdmVyIGNvbW1vbkhlYWRlckZpZWxkcyBhcnJheQorICAgICAgICAgIGZvciByZWFkYWJp bGl0eS4KKyAgICAgICAgLSBVc2UgQ0ZEaWN0aW9uYXJ5QXBwbHlGdW5jdGlvbigpIHRvIHBvcHVs YXRlIG1faHR0cEhlYWRlckZpZWxkcworICAgICAgICAgIGZvciB0aGUgQ0ZEaWN0aW9uYXJ5UmVm IGNvbnRhaW5pbmcgdGhlIGhlYWRlcnMgaW5zdGVhZCBvZiBjcmVhdGluZworICAgICAgICAgIGNv cGllcyBvZiBrZXlzIGFuZCB2YWx1ZXMgdXNpbmcgQ0ZEaWN0aW9uYXJ5R2V0S2V5c0FuZFZhbHVl cygpIGFuZAorICAgICAgICAgIHRoZW4gaXRlcmF0aW5nIG92ZXIgdGhvc2UuIFRoaXMgYXZvaWRz IGFsbG9jYXRpbmcgVmVjdG9ycyBmb3Iga2V5cyAvCisgICAgICAgICAgdmFsdWVzIGFuZCBhdm9p ZHMgdW5uZWNlc3NhcnkgY29weWluZy4KKworCiAyMDE1LTAyLTE3ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE4MDIyNCk6IFJlbW92 ZSB1bnVzZWQgZ2VuZXJhdGUtZXhwb3J0LWZpbGUgc2NyaXB0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5j cHAKaW5kZXggMDdlZWQ4ZGE2NGJiNThiZGI0NWY4YzNjM2IzMmY0ZTQ4ODk5ZWEzNi4uYTE5NzAy NzJkNzI2YjJiMmRkOTdhNmUxNTBiMTcyNzk0MDk5ZWE4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNlQ0ZOZXQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0 LmNwcApAQCAtNDcsNyArNDcsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBzdGF0aWMgQ0ZTdHJp bmdSZWYgY29uc3QgY29tbW9uSGVhZGVyRmllbGRzW10gPSB7CiAgICAgQ0ZTVFIoIkFnZSIpLCBD RlNUUigiQ2FjaGUtQ29udHJvbCIpLCBDRlNUUigiQ29udGVudC1UeXBlIiksIENGU1RSKCJEYXRl IiksIENGU1RSKCJFdGFnIiksIENGU1RSKCJFeHBpcmVzIiksIENGU1RSKCJMYXN0LU1vZGlmaWVk IiksIENGU1RSKCJQcmFnbWEiKQogfTsKLXN0YXRpYyBjb25zdCBpbnQgbnVtQ29tbW9uSGVhZGVy RmllbGRzID0gc2l6ZW9mKGNvbW1vbkhlYWRlckZpZWxkcykgLyBzaXplb2YoQ0ZTdHJpbmdSZWYp OwogCiBDRlVSTFJlc3BvbnNlUmVmIFJlc291cmNlUmVzcG9uc2U6OmNmVVJMUmVzcG9uc2UoKSBj b25zdAogewpAQCAtNjQsNiArNjMsMTIgQEAgQ0ZVUkxSZXNwb25zZVJlZiBSZXNvdXJjZVJlc3Bv bnNlOjpjZlVSTFJlc3BvbnNlKCkgY29uc3QKICAgICByZXR1cm4gbV9jZlJlc3BvbnNlLmdldCgp OwogfQogCitzdGF0aWMgdm9pZCBhZGRUb0hUVFBIZWFkZXJNYXAoY29uc3Qgdm9pZCoga2V5LCBj b25zdCB2b2lkKiB2YWx1ZSwgdm9pZCogY29udGV4dCkKK3sKKyAgICBIVFRQSGVhZGVyTWFwKiBo dHRwSGVhZGVyTWFwID0gKEhUVFBIZWFkZXJNYXAqKWNvbnRleHQ7CisgICAgaHR0cEhlYWRlck1h cC0+c2V0KChDRlN0cmluZ1JlZilrZXksIChDRlN0cmluZ1JlZil2YWx1ZSk7Cit9CisKIHZvaWQg UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdChJbml0TGV2ZWwgaW5pdExldmVsKQog ewogICAgIGlmIChtX2luaXRMZXZlbCA+IGluaXRMZXZlbCkKQEAgLTg3LDMwICs5MiwyNiBAQCB2 b2lkIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtTGF6eUluaXQoSW5pdExldmVsIGluaXRMZXZl bCkKICAgICAgICAgaWYgKGh0dHBSZXNwb25zZSkgewogICAgICAgICAgICAgbV9odHRwU3RhdHVz Q29kZSA9IENGSFRUUE1lc3NhZ2VHZXRSZXNwb25zZVN0YXR1c0NvZGUoaHR0cFJlc3BvbnNlKTsK ICAgICAgICAgICAgIAotICAgICAgICAgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gaGVh ZGVycyA9IGFkb3B0Q0YoQ0ZIVFRQTWVzc2FnZUNvcHlBbGxIZWFkZXJGaWVsZHMoaHR0cFJlc3Bv bnNlKSk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVt Q29tbW9uSGVhZGVyRmllbGRzOyBpKyspIHsKLSAgICAgICAgICAgICAgICBDRlN0cmluZ1JlZiB2 YWx1ZTsKLSAgICAgICAgICAgICAgICBpZiAoQ0ZEaWN0aW9uYXJ5R2V0VmFsdWVJZlByZXNlbnQo aGVhZGVycy5nZXQoKSwgY29tbW9uSGVhZGVyRmllbGRzW2ldLCAoY29uc3Qgdm9pZCAqKikmdmFs dWUpKQotICAgICAgICAgICAgICAgICAgICBtX2h0dHBIZWFkZXJGaWVsZHMuc2V0KGNvbW1vbkhl YWRlckZpZWxkc1tpXSwgdmFsdWUpOworICAgICAgICAgICAgaWYgKGluaXRMZXZlbCA8IEFsbEZp ZWxkcykgeworICAgICAgICAgICAgICAgIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IGhlYWRl cnMgPSBhZG9wdENGKENGSFRUUE1lc3NhZ2VDb3B5QWxsSGVhZGVyRmllbGRzKGh0dHBSZXNwb25z ZSkpOworICAgICAgICAgICAgICAgIGZvciAoYXV0byYgY29tbW9uSGVhZGVyIDogY29tbW9uSGVh ZGVyRmllbGRzKSB7CisgICAgICAgICAgICAgICAgICAgIENGU3RyaW5nUmVmIHZhbHVlOworICAg ICAgICAgICAgICAgICAgICBpZiAoQ0ZEaWN0aW9uYXJ5R2V0VmFsdWVJZlByZXNlbnQoaGVhZGVy cy5nZXQoKSwgY29tbW9uSGVhZGVyLCAoY29uc3Qgdm9pZCAqKikmdmFsdWUpKQorICAgICAgICAg ICAgICAgICAgICAgICAgbV9odHRwSGVhZGVyRmllbGRzLnNldChjb21tb25IZWFkZXIsIHZhbHVl KTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZQogICAg ICAgICAgICAgbV9odHRwU3RhdHVzQ29kZSA9IDA7CiAgICAgfQogCi0gICAgaWYgKG1faW5pdExl dmVsIDwgQWxsRmllbGRzKSB7CisgICAgaWYgKG1faW5pdExldmVsIDwgQWxsRmllbGRzICYmIGlu aXRMZXZlbCA9PSBBbGxGaWVsZHMpIHsKICAgICAgICAgQ0ZIVFRQTWVzc2FnZVJlZiBodHRwUmVz cG9uc2UgPSBDRlVSTFJlc3BvbnNlR2V0SFRUUFJlc3BvbnNlKG1fY2ZSZXNwb25zZS5nZXQoKSk7 CiAgICAgICAgIGlmIChodHRwUmVzcG9uc2UpIHsKICAgICAgICAgICAgIFJldGFpblB0cjxDRlN0 cmluZ1JlZj4gc3RhdHVzTGluZSA9IGFkb3B0Q0YoQ0ZIVFRQTWVzc2FnZUNvcHlSZXNwb25zZVN0 YXR1c0xpbmUoaHR0cFJlc3BvbnNlKSk7CiAgICAgICAgICAgICBtX2h0dHBTdGF0dXNUZXh0ID0g ZXh0cmFjdFJlYXNvblBocmFzZUZyb21IVFRQU3RhdHVzTGluZShzdGF0dXNMaW5lLmdldCgpKTsK IAogICAgICAgICAgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gaGVhZGVycyA9IGFkb3B0 Q0YoQ0ZIVFRQTWVzc2FnZUNvcHlBbGxIZWFkZXJGaWVsZHMoaHR0cFJlc3BvbnNlKSk7Ci0gICAg ICAgICAgICBDRkluZGV4IGhlYWRlckNvdW50ID0gQ0ZEaWN0aW9uYXJ5R2V0Q291bnQoaGVhZGVy cy5nZXQoKSk7Ci0gICAgICAgICAgICBWZWN0b3I8Y29uc3Qgdm9pZCosIDEyOD4ga2V5cyhoZWFk ZXJDb3VudCk7Ci0gICAgICAgICAgICBWZWN0b3I8Y29uc3Qgdm9pZCosIDEyOD4gdmFsdWVzKGhl YWRlckNvdW50KTsKLSAgICAgICAgICAgIENGRGljdGlvbmFyeUdldEtleXNBbmRWYWx1ZXMoaGVh ZGVycy5nZXQoKSwga2V5cy5kYXRhKCksIHZhbHVlcy5kYXRhKCkpOwotICAgICAgICAgICAgZm9y IChpbnQgaSA9IDA7IGkgPCBoZWFkZXJDb3VudDsgKytpKQotICAgICAgICAgICAgICAgIG1faHR0 cEhlYWRlckZpZWxkcy5zZXQoKENGU3RyaW5nUmVmKWtleXNbaV0sIChDRlN0cmluZ1JlZil2YWx1 ZXNbaV0pOworICAgICAgICAgICAgQ0ZEaWN0aW9uYXJ5QXBwbHlGdW5jdGlvbihoZWFkZXJzLmdl dCgpLCBhZGRUb0hUVFBIZWFkZXJNYXAsICZtX2h0dHBIZWFkZXJGaWVsZHMpOwogICAgICAgICB9 CiAgICAgfQogCg==