141721 2015-02-17 13:05:23 -0800 StackLayoutPhase should use CodeBlock::usesArguments rather than FunctionExecutable::usesArguments 2016-08-04 16:26:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo rhodovan.u-szeged oldest_to_newest 1069922 0 fpizlo 2015-02-17 13:05:23 -0800 I've seen cases where the two are out of sync. We know we can trust the CodeBlock::usesArguments because we use it everywhere else. 1069923 1 246761 fpizlo 2015-02-17 13:07:11 -0800 Created attachment 246761 the patch 1069929 2 246761 msaboff 2015-02-17 13:33:09 -0800 Comment on attachment 246761 the patch r=me 1069931 3 fpizlo 2015-02-17 13:41:55 -0800 Landed in http://trac.webkit.org/changeset/180237 1217649 4 bfulgham 2016-08-04 16:26:48 -0700 *** Bug 141246 has been marked as a duplicate of this bug. *** 246761 2015-02-17 13:07:11 -0800 2015-02-17 13:33:09 -0800 the patch blah.patch text/plain 3000 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwMjM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTAyLTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3RhY2tMYXlvdXRQaGFzZSBzaG91bGQgdXNlIENvZGVCbG9jazo6dXNlc0FyZ3VtZW50cyByYXRo ZXIgdGhhbiBGdW5jdGlvbkV4ZWN1dGFibGU6OnVzZXNBcmd1bWVudHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTcyMQorICAgICAgICByZGFyOi8v cHJvYmxlbS8xNzE5ODYzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor ICAgICAgICAKKyAgICAgICAgSSd2ZSBzZWVuIGNhc2VzIHdoZXJlIHRoZSB0d28gYXJlIG91dCBv ZiBzeW5jLiAgV2Uga25vdyB3ZSBjYW4gdHJ1c3QgdGhlIENvZGVCbG9jazo6dXNlc0FyZ3VtZW50 cyBiZWNhdXNlCisgICAgICAgIHdlIHVzZSBpdCBldmVyeXdoZXJlIGVsc2UuCisgICAgICAgIAor ICAgICAgICBObyB0ZXN0IGJlY2F1c2UgSSBjb3VsZCBuZXZlciByZXByb2R1Y2UgdGhlIGNyYXNo LgorCisgICAgICAgICogZGZnL0RGR0dyYXBoLmg6CisgICAgICAgIChKU0M6OkRGRzo6R3JhcGg6 OnVzZXNBcmd1bWVudHMpOgorICAgICAgICAqIGRmZy9ERkdTdGFja0xheW91dFBoYXNlLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpTdGFja0xheW91dFBoYXNlOjpydW4pOgorCiAyMDE1LTAyLTE2 ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogSW1wcm92ZWQgQ29uc29sZSBTdXBwb3J0IGZvciBCb3VuZCBGdW5jdGlvbnMKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmgJKHJldmlzaW9uIDE4MDIzMSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaAkod29ya2luZyBjb3B5KQpAQCAt NDA2LDYgKzQwNiwxNCBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBoYXNFeGl0U2l0ZShub2Rl LT5vcmlnaW4uc2VtYW50aWMsIGV4aXRLaW5kKTsKICAgICB9CiAgICAgCisgICAgYm9vbCB1c2Vz QXJndW1lbnRzKElubGluZUNhbGxGcmFtZSogaW5saW5lQ2FsbEZyYW1lKQorICAgIHsKKyAgICAg ICAgaWYgKCFpbmxpbmVDYWxsRnJhbWUpCisgICAgICAgICAgICByZXR1cm4gbV9wcm9maWxlZEJs b2NrLT51c2VzQXJndW1lbnRzKCk7CisgICAgICAgIAorICAgICAgICByZXR1cm4gYmFzZWxpbmVD b2RlQmxvY2tGb3JJbmxpbmVDYWxsRnJhbWUoaW5saW5lQ2FsbEZyYW1lKS0+dXNlc0FyZ3VtZW50 cygpOworICAgIH0KKyAgICAKICAgICBWaXJ0dWFsUmVnaXN0ZXIgYXJndW1lbnRzUmVnaXN0ZXJG b3IoSW5saW5lQ2FsbEZyYW1lKiBpbmxpbmVDYWxsRnJhbWUpCiAgICAgewogICAgICAgICBpZiAo IWlubGluZUNhbGxGcmFtZSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Rh Y2tMYXlvdXRQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTdGFja0xheW91dFBoYXNlLmNwcAkocmV2aXNpb24gMTgwMjMxKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTdGFja0xheW91dFBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTA2LDcgKzEwNiw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHVzZWRMb2NhbHMuc2V0KGNv ZGVCbG9jaygpLT5hY3RpdmF0aW9uUmVnaXN0ZXIoKS50b0xvY2FsKCkpOwogICAgICAgICBmb3Ig KElubGluZUNhbGxGcmFtZVNldDo6aXRlcmF0b3IgaXRlciA9IG1fZ3JhcGgubV9wbGFuLmlubGlu ZUNhbGxGcmFtZXMtPmJlZ2luKCk7ICEhaXRlcjsgKytpdGVyKSB7CiAgICAgICAgICAgICBJbmxp bmVDYWxsRnJhbWUqIGlubGluZUNhbGxGcmFtZSA9ICppdGVyOwotICAgICAgICAgICAgaWYgKCFp bmxpbmVDYWxsRnJhbWUtPmV4ZWN1dGFibGUtPnVzZXNBcmd1bWVudHMoKSkKKyAgICAgICAgICAg IGlmICghbV9ncmFwaC51c2VzQXJndW1lbnRzKGlubGluZUNhbGxGcmFtZSkpCiAgICAgICAgICAg ICAgICAgY29udGludWU7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIFZpcnR1YWxSZWdpc3Rl ciBhcmd1bWVudHNSZWdpc3RlciA9IG1fZ3JhcGguYXJndW1lbnRzUmVnaXN0ZXJGb3IoaW5saW5l Q2FsbEZyYW1lKTsKQEAgLTE3NSw3ICsxNzUsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBJbmxp bmVWYXJpYWJsZURhdGEgZGF0YSA9IG1fZ3JhcGgubV9pbmxpbmVWYXJpYWJsZURhdGFbaV07CiAg ICAgICAgICAgICBJbmxpbmVDYWxsRnJhbWUqIGlubGluZUNhbGxGcmFtZSA9IGRhdGEuaW5saW5l Q2FsbEZyYW1lOwogICAgICAgICAgICAgCi0gICAgICAgICAgICBpZiAoaW5saW5lQ2FsbEZyYW1l LT5leGVjdXRhYmxlLT51c2VzQXJndW1lbnRzKCkpIHsKKyAgICAgICAgICAgIGlmIChtX2dyYXBo LnVzZXNBcmd1bWVudHMoaW5saW5lQ2FsbEZyYW1lKSkgewogICAgICAgICAgICAgICAgIGlubGlu ZUNhbGxGcmFtZS0+YXJndW1lbnRzUmVnaXN0ZXIgPSB2aXJ0dWFsUmVnaXN0ZXJGb3JMb2NhbCgK ICAgICAgICAgICAgICAgICAgICAgYWxsb2NhdGlvblttX2dyYXBoLmFyZ3VtZW50c1JlZ2lzdGVy Rm9yKGlubGluZUNhbGxGcmFtZSkudG9Mb2NhbCgpXSk7CiAK