141705 2015-02-17 08:19:23 -0800 [GTK] Layout Test media/video-fullscreeen-only-controls.html is failing 2017-08-18 01:59:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chavarria1991 Ms2ger bugs-noreply calvaris chavarria1991 clopez commit-queue dino eric.carlson Ms2ger webkit-bug-importer oldest_to_newest 1069841 0 chavarria1991 2015-02-17 08:19:23 -0800 The media/video-fullscreeen-only-controls.html layout test is failing since r179612 (http://trac.webkit.org/179612). The diff is the following: --- /home/ch01/wk-tools/layout-test-results/media/video-fullscreeen-only-controls-expected.txt +++ /home/ch01/wk-tools/layout-test-results/media/video-fullscreeen-only-controls-actual.txt @@ -5,9 +5,9 @@ EXPECTED (video.hasAttribute('controls') == 'false') OK EXPECTED (video.controls == 'false') OK EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK -EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK -EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK -EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK -EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK +EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null'), OBSERVED 'null' FAIL +Error: InvalidAccessError: DOM Exception 15 +TypeError: null is not an object (evaluating 'document.defaultView.getComputedStyle(panel)') +TypeError: null is not an object (evaluating 'document.defaultView.getComputedStyle(panel)') END OF TEST 1339541 1 318364 Ms2ger 2017-08-17 07:26:00 -0700 Created attachment 318364 Patch 1339567 2 318364 commit-queue 2017-08-17 08:19:49 -0700 Comment on attachment 318364 Patch Rejecting attachment 318364 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 318364, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 220854 = 8e6e489dabeb4975d24b72647ea19cdd0fef400c r220856 = 0c063cae22c2455f7b6ec95789c6fdda397b0be1 r220857 = 4ce2c62a498ac2ae3bae7750af796f0d198609e8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Total errors found: 0 in 0 files Full output: http://webkit-queues.webkit.org/results/4330647 1340012 3 318486 Ms2ger 2017-08-18 01:14:07 -0700 Created attachment 318486 Patch 1340017 4 318486 commit-queue 2017-08-18 01:58:38 -0700 Comment on attachment 318486 Patch Clearing flags on attachment: 318486 Committed r220910: <http://trac.webkit.org/changeset/220910> 1340018 5 commit-queue 2017-08-18 01:58:39 -0700 All reviewed patches have been landed. Closing bug. 1340019 6 webkit-bug-importer 2017-08-18 01:59:03 -0700 <rdar://problem/33959455> 318364 2017-08-17 07:26:00 -0700 2017-08-18 01:14:04 -0700 Patch bug-141705-20170817162558.patch text/plain 2850 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTBiODJlOTk1NmM0MTk2 ODQ4YmMyZDM1NGIwNjQ2YjdiYjA1ZjA2Ny4uMzIxM2JmOTU3OGYxYmVlZjEyYTYwZWQ0NzA3MmU2 YzEzM2Q4NWYxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTE3ICBNczJn ZXIgIDxNczJnZXJAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIFNob3cgY29udHJvbHMgaWYg YSB2aWRlbyBlbGVtZW50IGlzbid0IGFsbG93ZWQgdG8gcGxheSBpbmxpbmUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE3MDUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBjb3ZlcmVkIGJ5IG1l ZGlhL3ZpZGVvLWZ1bGxzY3JlZWVuLW9ubHktY29udHJvbHMuaHRtbCBbc2ljXS4KKworICAgICAg ICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzOgorICAgICAgICAo Q29udHJvbGxlckd0ay5wcm90b3R5cGUuc2hvdWxkSGF2ZUNvbnRyb2xzKToKKwogMjAxNy0wOC0x NiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgdGhlIHN1 cHBvcnQgZm9yIG11dGF0aW5nIGNsaXBib2FyZCBkYXRhIHZpYSBEYXRhVHJhbnNmZXJJdGVtTGlz dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlh Q29udHJvbHNHdGsuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVk aWFDb250cm9sc0d0ay5qcwppbmRleCBiY2E3Nzc2YzgxMTdlZjFlMTFlMmQyYjBjYjIwN2RhMzcx MGY4MDU1Li4yZmU4YzU4OGRiMmYxMTQ4MjlkNTY4YjYzZDVkYTRjNTkzNDM4ZjJjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0 ay5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250 cm9sc0d0ay5qcwpAQCAtNTYsNiArNTYsOSBAQCBDb250cm9sbGVyR3RrLnByb3RvdHlwZSA9IHsK IAogICAgIHNob3VsZEhhdmVDb250cm9sczogZnVuY3Rpb24oKQogICAgIHsKKyAgICAgICAgaWYg KCF0aGlzLmlzQXVkaW8oKSAmJiAhdGhpcy5ob3N0LmFsbG93c0lubGluZU1lZGlhUGxheWJhY2sp CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAgICAgICByZXR1cm4gdGhpcy52aWRlby5j b250cm9scyB8fCB0aGlzLmlzRnVsbFNjcmVlbigpOwogICAgIH0sCiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlMzA4Njdi MzVlODI5ODY2Yjg3ZGU5ZmFlN2RkNmYxNWI3MzJiNTE5Li5hODViZDY5N2NiNGExYjExNjUxMzNi ODllZDE4NWE3YmIwZTBhNzczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDgtMTcgIE1z MmdlciAgPE1zMmdlckBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gU2hvdyBjb250cm9scyBp ZiBhIHZpZGVvIGVsZW1lbnQgaXNuJ3QgYWxsb3dlZCB0byBwbGF5IGlubGluZS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTcwNQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnM6IGVuYWJsZSB0ZXN0IGZvciB0aGlzIGNhc2UuCisKIDIwMTctMDgtMTYg IFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIHRoZSBzdXBw b3J0IGZvciBtdXRhdGluZyBjbGlwYm9hcmQgZGF0YSB2aWEgRGF0YVRyYW5zZmVySXRlbUxpc3QK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOTAyZDU1NDg1 NGJiOThmZGViNTE1N2IxZjJmNjNmOGZmZDU3OGZlZS4uMjUyYzA0NGI3NjczN2MzZTFmNjIyODI5 MWNiMzIyZTFlM2ViZDFkOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3Rh dGlvbnMKQEAgLTkxOSw4ICs5MTksNiBAQCB3ZWJraXQub3JnL2IvMTQxNjk5IGZhc3QvYXR0YWNo bWVudC9hdHRhY2htZW50LWRpc2FibGVkLXJlbmRlcmluZy5odG1sIFsgRmFpbHVyZQogd2Via2l0 Lm9yZy9iLzE0MTY5OSBmYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1yZW5kZXJpbmcuaHRtbCBb IEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE0MTY5OSBmYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVu dC1yZXNwZWN0cy1jc3Mtc2l6ZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5v cmcvYi8xNDE3MDUgbWVkaWEvdmlkZW8tZnVsbHNjcmVlZW4tb25seS1jb250cm9scy5odG1sIFsg RmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xNDE4MzEgc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS10 ZXh0LW5lc3RlZC10cmFuc2Zvcm1zLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi85ODY1 MyAgc3ZnL3RleHQvbGVuZ3RoQWRqdXN0LXRleHQtbWV0cmljcy5odG1sIFsgRmFpbHVyZSBdCiAK 318486 2017-08-18 01:14:07 -0700 2017-08-18 01:58:38 -0700 Patch bug-141705-20170818101406.patch text/plain 2847 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwOTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZhM2RkZTBjNmI2NmRl NzhkYTE1YWI5ZWMyMDFmMTc5MDM4MmVjMS4uMjcyNjAxNzI1NjliZWYxZjNjMWU3OWNkMTFiNTU3 Y2UyZThlMThlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTE4ICBNczJn ZXIgIDxNczJnZXJAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIFNob3cgY29udHJvbHMgaWYg YSB2aWRlbyBlbGVtZW50IGlzbid0IGFsbG93ZWQgdG8gcGxheSBpbmxpbmUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE3MDUKKworICAgICAgICBS ZXZpZXdlZCBieSBYYWJpZXIgUm9kcmlndWV6LUNhbHZhci4KKworICAgICAgICBUZXN0OiBjb3Zl cmVkIGJ5IG1lZGlhL3ZpZGVvLWZ1bGxzY3JlZWVuLW9ubHktY29udHJvbHMuaHRtbCBbc2ljXS4K KworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzOgor ICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuc2hvdWxkSGF2ZUNvbnRyb2xzKToKKwog MjAxNy0wOC0xOCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIyMDg1NC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMKaW5k ZXggYmNhNzc3NmM4MTE3ZWYxZTExZTJkMmIwY2IyMDdkYTM3MTBmODA1NS4uMmZlOGM1ODhkYjJm MTE0ODI5ZDU2OGI2M2Q1ZGE0YzU5MzQzOGYyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMKQEAgLTU2LDYg KzU2LDkgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAKICAgICBzaG91bGRIYXZlQ29u dHJvbHM6IGZ1bmN0aW9uKCkKICAgICB7CisgICAgICAgIGlmICghdGhpcy5pc0F1ZGlvKCkgJiYg IXRoaXMuaG9zdC5hbGxvd3NJbmxpbmVNZWRpYVBsYXliYWNrKQorICAgICAgICAgICAgcmV0dXJu IHRydWU7CisKICAgICAgICAgcmV0dXJuIHRoaXMudmlkZW8uY29udHJvbHMgfHwgdGhpcy5pc0Z1 bGxTY3JlZW4oKTsKICAgICB9LAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjdhZTJiY2VhMmYzZWE4MDI3OTE5OGQ5YTJh YWIyZmQ3OWViY2IzOS4uY2VmZTBjYmFlN2M4MjlkMWU5NGY1MzhlMzk4MjdiMGZkZTM4ZjE3ZSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA4LTE4ICBNczJnZXIgIDxNczJnZXJAZ21haWwu Y29tPgorCisgICAgICAgIFtHVEtdIFNob3cgY29udHJvbHMgaWYgYSB2aWRlbyBlbGVtZW50IGlz bid0IGFsbG93ZWQgdG8gcGxheSBpbmxpbmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE3MDUKKworICAgICAgICBSZXZpZXdlZCBieSBYYWJpZXIg Um9kcmlndWV6LUNhbHZhci4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zOiBlbmFibGUgdGVzdCBmb3IgdGhpcyBjYXNlLgorCiAyMDE3LTA4LTE3ICBXZW5zb24gSHNp ZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtJbnB1dCBFdmVudHNdIFJl bmFtZSBpbnB1dFR5cGUgImZvcm1hdEZvcmVDb2xvciIgdG8gImZvcm1hdEZvbnRDb2xvciIKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMjIyZWZiY2NhMDNk NjhiNTBkNGQ1YWY4ZWVhNjYwNGRhYjc0YzY4Mi4uYTE2NjZkZjIzNDI5OGRkM2JjOGZiNDk5Y2Nl Y2IwZGEyYjk4ZjdjNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlv bnMKQEAgLTkxOSw4ICs5MTksNiBAQCB3ZWJraXQub3JnL2IvMTQxNjk5IGZhc3QvYXR0YWNobWVu dC9hdHRhY2htZW50LWRpc2FibGVkLXJlbmRlcmluZy5odG1sIFsgRmFpbHVyZQogd2Via2l0Lm9y Zy9iLzE0MTY5OSBmYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1yZW5kZXJpbmcuaHRtbCBbIEZh aWx1cmUgXQogd2Via2l0Lm9yZy9iLzE0MTY5OSBmYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1y ZXNwZWN0cy1jc3Mtc2l6ZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcv Yi8xNDE3MDUgbWVkaWEvdmlkZW8tZnVsbHNjcmVlZW4tb25seS1jb250cm9scy5odG1sIFsgRmFp bHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xNDE4MzEgc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS10ZXh0 LW5lc3RlZC10cmFuc2Zvcm1zLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi85ODY1MyAg c3ZnL3RleHQvbGVuZ3RoQWRqdXN0LXRleHQtbWV0cmljcy5odG1sIFsgRmFpbHVyZSBdCiAK