141699 2015-02-17 05:23:24 -0800 [GTK] Layout Tests for experimental <attachment> element are failing since added 2021-10-29 17:50:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chavarria1991 crzwdjk aboya bugs-noreply chavarria1991 clopez crzwdjk lmoura mcatanzaro sam thorton webkit-bug-importer zan oldest_to_newest 1069820 0 chavarria1991 2015-02-17 05:23:24 -0800 The fast/attachment/attachment-disabled-rendering.html and fast/attachment/attachment-rendering.html layout tests are failing since they were added on r180193 (https://trac.webkit.org/changeset/180193). The diffs are the following: * fast/attachment/attachment-disabled-rendering.html --- /home/ch01/wk-tools/layout-test-results/fast/attachment/attachment-disabled-rendering-expected.txt +++ /home/ch01/wk-tools/layout-test-results/fast/attachment/attachment-disabled-rendering-actual.txt @@ -3,9 +3,9 @@ layer at (0,0) size 800x600 RenderBlock {HTML} at (0,0) size 800x600 RenderBody {BODY} at (8,8) size 784x576 - RenderBlock {P} at (0,0) size 784x18 - RenderText {#text} at (0,0) size 766x18 - text run at (0,0) width 766: "This tests that attachments don't have a custom renderer when they are disabled. This test must be run in the test runner." - RenderBlock (anonymous) at (0,34) size 784x0 + RenderBlock {P} at (0,0) size 784x17 + RenderText {#text} at (0,0) size 750x17 + text run at (0,0) width 750: "This tests that attachments don't have a custom renderer when they are disabled. This test must be run in the test runner." + RenderBlock (anonymous) at (0,33) size 784x0 RenderInline {ATTACHMENT} at (0,0) size 0x0 RenderText {#text} at (0,0) size 0x0 * fast/attachment/attachment-rendering.html --- /home/ch01/wk-tools/layout-test-results/fast/attachment/attachment-rendering-expected.txt +++ /home/ch01/wk-tools/layout-test-results/fast/attachment/attachment-rendering-actual.txt @@ -2,10 +2,10 @@ RenderView at (0,0) size 800x600 layer at (0,0) size 800x600 RenderBlock {HTML} at (0,0) size 800x600 - RenderBody {BODY} at (8,8) size 784x584 - RenderBlock {P} at (0,0) size 784x18 - RenderText {#text} at (0,0) size 326x18 - text run at (0,0) width 326: "This tests that attachments have a custom renderer." - RenderBlock (anonymous) at (0,34) size 784x200 - RenderAttachment {ATTACHMENT} at (0,0) size 200x200 + RenderBody {BODY} at (8,8) size 784x576 + RenderBlock {P} at (0,0) size 784x17 + RenderText {#text} at (0,0) size 318x17 + text run at (0,0) width 318: "This tests that attachments have a custom renderer." + RenderBlock (anonymous) at (0,33) size 784x0 + RenderInline {ATTACHMENT} at (0,0) size 0x0 RenderText {#text} at (0,0) size 0x0 1790742 1 crzwdjk 2021-09-06 11:00:20 -0700 For what it's worth, the tests all fail because the attachment element is not enabled on GTK. 1790782 2 thorton 2021-09-06 14:25:03 -0700 FWIW I would expect Gtk to skip all of fast/attachment; it's not a web-exposed feature nor one that I imagine you need? 1790801 3 crzwdjk 2021-09-06 16:00:47 -0700 *** Bug 177534 has been marked as a duplicate of this bug. *** 1790803 4 crzwdjk 2021-09-06 16:01:12 -0700 *** Bug 142268 has been marked as a duplicate of this bug. *** 1790805 5 crzwdjk 2021-09-06 16:01:35 -0700 *** Bug 142269 has been marked as a duplicate of this bug. *** 1790807 6 crzwdjk 2021-09-06 16:01:53 -0700 *** Bug 191402 has been marked as a duplicate of this bug. *** 1790809 7 crzwdjk 2021-09-06 16:02:23 -0700 *** Bug 212199 has been marked as a duplicate of this bug. *** 1790811 8 crzwdjk 2021-09-06 16:03:42 -0700 *** Bug 194009 has been marked as a duplicate of this bug. *** 1790976 9 mcatanzaro 2021-09-07 06:34:37 -0700 (In reply to Tim Horton from comment #2) > FWIW I would expect Gtk to skip all of fast/attachment; it's not a > web-exposed feature nor one that I imagine you need? So... what is HTML attachment element? I'm curious that we have an HTML element that is not web-exposed? Is it something private for Mac applications only? 1791117 10 thorton 2021-09-07 10:59:18 -0700 (In reply to Michael Catanzaro from comment #9) > (In reply to Tim Horton from comment #2) > > FWIW I would expect Gtk to skip all of fast/attachment; it's not a > > web-exposed feature nor one that I imagine you need? > > So... what is HTML attachment element? I'm curious that we have an HTML > element that is not web-exposed? > > Is it something private for Mac applications only? For apps (both iOS and macOS), yes; it represents a 'file' in the contenteditable area in Mail. 1791211 11 mcatanzaro 2021-09-07 14:00:51 -0700 It should probably be skipped in the global expectations then, and unskipped in Cocoa port expectations, so that every port doesn't have to skip it separately. 1791215 12 thorton 2021-09-07 14:08:26 -0700 I agree! (and am surprised it's not already that way) 1791283 13 sam 2021-09-07 17:16:29 -0700 (In reply to Tim Horton from comment #12) > I agree! (and am surprised it's not already that way) (I think we really should consider proposing <attachment> for actual web usage, perhaps under a different name, at some point. It seems like it could have its uses). 1791284 14 thorton 2021-09-07 17:24:02 -0700 Likely! Could be useful for mail/notes/etc. web apps. I think it would need a significantly expanded JS interface, though; the way it shook out requires a lot of interaction to happen through the native API, sadly. 1791293 15 sam 2021-09-07 18:17:54 -0700 Not shocked, just disappointed. 1810339 16 442887 crzwdjk 2021-10-29 17:41:43 -0700 Created attachment 442887 [fast-cq] Patch 1810344 17 crzwdjk 2021-10-29 17:43:17 -0700 For now I would like to just mark the tests as skipped on GLIB and close this bug. If and when the attachment element gets on track to standardization, we can open another bug for its implementation on glib platforms. 1810348 18 ews-feeder 2021-10-29 17:49:01 -0700 Committed r285066 (243708@main): <https://commits.webkit.org/243708@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442887. 1810350 19 webkit-bug-importer 2021-10-29 17:50:21 -0700 <rdar://problem/84829919> 442887 2021-10-29 17:41:43 -0700 2021-10-29 17:49:03 -0700 [fast-cq] Patch bug-141699-20211029204142.patch text/plain 4072 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MDM1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjYxMDBjODNhMTZlZmE2MzMzYWZj NmZlNzM2ZjQzODdmMzY5MDIzYS4uYTViY2RlNTBjOTZkNjFkNmEwMjEzN2JhOWY3OWRmNmNkMDY5 NWNlZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTI5ICBBcmNhZHkgR29sZG1pbnRz LU9ybG92ICA8YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIExheW91dCBU ZXN0cyBmb3IgZXhwZXJpbWVudGFsIDxhdHRhY2htZW50PiBlbGVtZW50IGFyZSBmYWlsaW5nIHNp bmNlIGFkZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDE2OTkKKworICAgICAgICBNYXJrIHRoZSB0ZXN0cyB0aGF0IHJlbHkgb24gdGhlIGF0dGFj aG1lbnQgZWxlbWVudCBhcyBza2lwcGVkIGZvcgorICAgICAgICBnbGliIHBsYXRmb3JtcywgYXMg aXQgaXMgbm90IHN0YW5kYXJkIG5vciBzdXBwb3J0ZWQgb24gdGhhdCBwbGF0Zm9ybS4KKworICAg ICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vZ2xp Yi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zOgorICAgICAgICAqIHBsYXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIxLTEw LTI5ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OIChyMjgzMjY5KSBkaXNuZXlwbHVzLmNvbSB0aW1lIHJlbWFpbmluZyBiYXIgc2hvd3Mg YW4gZXh0cmEgbGluZS9iYXIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIv VGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCA5ZDhkODVhMjQyYzJhMzg5YTNhOTFhZGU3MmNjNTI4MTU5ZTcyZTEyLi4zYWFh N2JmMDM2ZTliNzkwNDAzOTcyODdlNGEyZGJlMTQ5YjI1Njg1IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zCkBAIC0xODA4LDYgKzE4MDgsMTIgQEAgaHR0cC90 ZXN0cy93ZWJzaGFyZSBbIFNraXAgXQogIyBwcml2YXRlQ2xpY2tNZWFzdXJlbWVudCBpcyBkaXNh YmxlZCBvbiBnbGliCiBodHRwL3Rlc3RzL3ByaXZhdGVDbGlja01lYXN1cmVtZW50IFsgU2tpcCBd CiAKKyMgVGhlIGF0dGFjaG1lbnQgZWxlbWVudCBpcyBub3Qgc3RhZGFuZGFyZCBhbmQgbm90IGN1 cnJlbnRseSBzdXBwb3J0ZWQgb24gZ2xpYgorZmFzdC9hdHRhY2htZW50IFsgU2tpcCBdCitlZGl0 aW5nL3Bhc3RlYm9hcmQvY29weS1wYXN0ZS1hdHRhY2htZW50Lmh0bWwgWyBTa2lwIF0KK2VkaXRp bmcvdGV4dC1pdGVyYXRvci9iYWNrd2FyZHMtdGV4dC1pdGVyYXRvci1hdHRhY2htZW50Lmh0bWwg WyBTa2lwIF0KK2Zhc3QvY3NzL2hhcy1hdHRhY2htZW50Lmh0bWwgWyBTa2lwIF0KKwogIy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIFVOU1VQUE9SVEVEIHRlc3RzLgog Iy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOTM1NmJjYzczMTc1ODlkZjBmYTRhNzlhYzY2ZGY5Nzg0 YjFkNTRkZS4uNGU4ZDU1NTEzYmYyNzczYjZkMWEyZWNlNjk1OTc3NTUzOTdjNGFmYyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTYwNSwxNCArNjA1LDYg QEAgd2Via2l0Lm9yZy9iLzEzMTM0NyBmYXN0L3JlcGFpbnQvaGlkcGktd3JvbmctcmVwYWludC1y ZWN0LXdoZW4tcGFyZW50LWhhcy1ub25jb20KIHdlYmtpdC5vcmcvYi8xNDE0NjcgZmFzdC9tdWx0 aWNvbC9wYWdpbmF0aW9uL0xlZnRUb1JpZ2h0LXRiLWhpdHRlc3QuaHRtbCBbIEZhaWx1cmUgXQog d2Via2l0Lm9yZy9iLzE0MTQ2NyBmYXN0L211bHRpY29sL3BhZ2luYXRpb24vUmlnaHRUb0xlZnQt cmwtaGl0dGVzdC5odG1sIFsgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xNDE2OTkgZmFzdC9h dHRhY2htZW50L2F0dGFjaG1lbnQtZGlzYWJsZWQtcmVuZGVyaW5nLmh0bWwgWyBGYWlsdXJlIF0K LXdlYmtpdC5vcmcvYi8xNDE2OTkgZmFzdC9hdHRhY2htZW50L2F0dGFjaG1lbnQtcmVuZGVyaW5n Lmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNDE2OTkgZWRpdGluZy9wYXN0ZWJvYXJk L2NvcHktcGFzdGUtYXR0YWNobWVudC5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTQx Njk5IGZhc3QvYXR0YWNobWVudC9hdHRhY2htZW50LWRvbS5odG1sIFsgRmFpbHVyZSBdCi13ZWJr aXQub3JnL2IvMTQxNjk5IGZhc3QvYXR0YWNobWVudC9hdHRhY2htZW50LXJlc3BlY3RzLWNzcy1z aXplLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNDE2OTkgZmFzdC9j c3MvaGFzLWF0dGFjaG1lbnQuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE0MTY5OSBl ZGl0aW5nL3RleHQtaXRlcmF0b3IvYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYXR0YWNobWVudC5o dG1sIFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xNDE0NTggaW1wb3J0ZWQvbW96aWxsYS9z dmcvYmxlbmQtb3ZlcmxheS5zdmcgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9y Zy9iLzE0MTQ1OCBpbXBvcnRlZC9tb3ppbGxhL3N2Zy9wYXR0ZXJuLXNjYWxlLTAxYS5zdmcgWyBJ bWFnZU9ubHlGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzE0MTQ1OCBpbXBvcnRlZC9tb3pp bGxhL3N2Zy9wYXR0ZXJuLXNjYWxlLTAxYi5zdmcgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA3YThhZjM2Yzdl YWIzMjRlMmEwYjEwNTVjYmMzZWJhNWRlYjQyMjViLi5mN2U3NGIzNDlmOTU3MDY3NGMzNmRmNGI5 MTg1ZDdkZTA0NTU0ZTI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0 aW9ucwpAQCAtMTM4Nyw4ICsxMzg3LDYgQEAgd2Via2l0Lm9yZy9iLzIxMjE1NSBpbXBvcnRlZC9t b3ppbGxhL3N2Zy9zeW1ib2wtMDEuc3ZnIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKIHdlYmtpdC5v cmcvYi8yMTIxNTcgaW1wb3J0ZWQvYmxpbmsvZWRpdGluZy9leGVjQ29tbWFuZC80MTI4MDgwLTIu aHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTQxNjk5IGZhc3QvYXR0YWNobWVudC9h dHRhY2htZW50LXJlc3BlY3RzLWNzcy1zaXplLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLQog d2Via2l0Lm9yZy9iLzIxMjIwMCBmYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWlucHV0Lmh0 bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTIyMDAgZmFzdC9zcGF0aWFsLW5hdmlnYXRp b24vc25hdi10ZXh0YXJlYS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjEyMjAwIGZh c3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtdW5pdC1vdmVyZmxvdy1hbmQtc2Nyb2xsLWluLWRp cmVjdGlvbi5odG1sIFsgRmFpbHVyZSBdCg==