141679 2015-02-16 16:40:49 -0800 Update cross-frame http tests after r177774 2015-02-16 18:21:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139968 1 mmaxfield mmaxfield ap commit-queue dino jonlee simon.fraser thorton oldest_to_newest 1069666 0 mmaxfield 2015-02-16 16:40:49 -0800 Update cross-frame http tests after r177774 1069667 1 246702 mmaxfield 2015-02-16 16:41:44 -0800 Created attachment 246702 Patch 1069689 2 246702 ap 2015-02-16 17:28:42 -0800 Comment on attachment 246702 Patch I don't see how r177774 could possibly affect this. It may be worth digging deeper. That said, flakiness with spaces that correspond to iframe and object elements is somewhat common on tests, I think that it's a bug in line layout code, where it produces different results depending on whether layout happens before or after a newline after the element is parsed. As such, this is probably OK to land. 1069693 3 mmaxfield 2015-02-16 17:31:11 -0800 https://bugs.webkit.org/show_bug.cgi?id=141681 1069706 4 246702 commit-queue 2015-02-16 18:15:06 -0800 Comment on attachment 246702 Patch Rejecting attachment 246702 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 246702, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 180195 = 25e4353fede138ac39388c7aeaea2fd0986a38e3 r180197 = ade3d778dcc2af6eca1825eb7d846e2feeb6f8e7 r180200 = a9bfab5ed24fe57aa74ab2510808f9a553d95f14 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/4752338422071296 1069712 5 mmaxfield 2015-02-16 18:21:19 -0800 Committed r180202: <http://trac.webkit.org/changeset/180202> 246702 2015-02-16 16:41:44 -0800 2015-02-16 18:15:06 -0800 Patch bug-141679-20150216164139.patch text/plain 4019 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMTgwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWE3ZDc2YzM3MGRhMjYzMGJmODRh ZWE1OGNmMDExZDU1ODRmMmEyZi4uMmFlZDM4ZGUxODljYzRkYzEwY2JhNmE5NzRlOTVmMjkyOGQ0 YWJlNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTAyLTE2ICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgVXBkYXRlIGNyb3NzLWZyYW1lIGh0 dHAgdGVzdHMgYWZ0ZXIgcjE3Nzc3NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQxNjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU2ltcGx5IGEgc3BhY2luZyBjaGFuZ2UKKworICAgICAgICAqIGh0dHAv dGVzdHMvc2VjdXJpdHkvWEZyYW1lT3B0aW9ucy94LWZyYW1lLW9wdGlvbnMtZGVueS1tdWx0aXBs ZS1jbGllbnRzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Ny b3NzLWZyYW1lLWFjY2Vzcy1jYWxsYmFjay1leHBsaWNpdC1kb21haW4tQUxMT1ctZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCisyMDE1LTAy LTE2ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKICAgICAgICAg VXBkYXRlIGZhc3QvZG9tL3tFbGVtZW50LFJhbmdlfS9nZXRDbGllbnRSZWN0cy5odG1sIGFmdGVy IHIxNzc3NzQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0MTY2NQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L1hG cmFtZU9wdGlvbnMveC1mcmFtZS1vcHRpb25zLWRlbnktbXVsdGlwbGUtY2xpZW50cy1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L1hGcmFtZU9wdGlvbnMveC1m cmFtZS1vcHRpb25zLWRlbnktbXVsdGlwbGUtY2xpZW50cy1leHBlY3RlZC50eHQKaW5kZXggNTcz ZjcyMDc5ZWM2YzAwODQwZGMwZjUyMDY2ZDdjOWJlZDE1Mjg3OC4uZmIxZWFhYmM4NWEzYjhjMzUy YjRkNWY5ZDhiZWM3MmU2YWNiYWZjZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zZWN1cml0eS9YRnJhbWVPcHRpb25zL3gtZnJhbWUtb3B0aW9ucy1kZW55LW11bHRpcGxlLWNs aWVudHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkv WEZyYW1lT3B0aW9ucy94LWZyYW1lLW9wdGlvbnMtZGVueS1tdWx0aXBsZS1jbGllbnRzLWV4cGVj dGVkLnR4dApAQCAtMSwzICsxLDMgQEAKIENPTlNPTEUgTUVTU0FHRTogUmVmdXNlZCB0byBkaXNw bGF5ICdodHRwOi8vMTI3LjAuMC4xOjgwMDAvc2VjdXJpdHkvWEZyYW1lT3B0aW9ucy9yZXNvdXJj ZXMveC1mcmFtZS1vcHRpb25zLWRlbnkuY2dpJyBpbiBhIGZyYW1lIGJlY2F1c2UgaXQgc2V0ICdY LUZyYW1lLU9wdGlvbnMnIHRvICdkZW55Jy4KIEFMRVJUOiBQQVNTOiBvbmxvYWQgZmlyZWQuCi1U ZXN0IHRoYXQgdHdvIG1haW4gcmVzb3VyY2VzIHBvaW50aW5nIHRvIHRoZSBzYW1lIHVybCB0aGF0 IGFyZSBjYW5jZWxlZCB3aXRoaW4gZGlkUmVjZWl2ZVJlc3BvbnNlKCkgZG9uJ3QgY2F1c2UgdXMg dG8gY3Jhc2guICAKK1Rlc3QgdGhhdCB0d28gbWFpbiByZXNvdXJjZXMgcG9pbnRpbmcgdG8gdGhl IHNhbWUgdXJsIHRoYXQgYXJlIGNhbmNlbGVkIHdpdGhpbiBkaWRSZWNlaXZlUmVzcG9uc2UoKSBk b24ndCBjYXVzZSB1cyB0byBjcmFzaC4gICAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLWNhbGxiYWNrLWV4cGxpY2l0LWRvbWFp bi1BTExPVy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Ny b3NzLWZyYW1lLWFjY2Vzcy1jYWxsYmFjay1leHBsaWNpdC1kb21haW4tQUxMT1ctZXhwZWN0ZWQu dHh0CmluZGV4IDM2ODUyMTllOWE5YWNlMGU3YTg4Y2QxNmM4NGE0MGE2MWIzMTk2MDEuLjNmOTY2 NmVmOWNkMWE1NzU1YjdkNTQ3NGVkNjViOTE2NzE5MDNlOGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLWNhbGxiYWNrLWV4cGxp Y2l0LWRvbWFpbi1BTExPVy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtY2FsbGJhY2stZXhwbGljaXQtZG9tYWluLUFM TE9XLWV4cGVjdGVkLnR4dApAQCAtMSw0ICsxLDQgQEAKLVRoZSBjaGlsZCBmcmFtZSB3aWxsIGdl dCBhIGZ1bmN0aW9uIGZyb20gdGhlIHBhcmVudCBmcmFtZSwgc2V0IHRoZSBkb2N1bWVudC5kb21h aW4gcHJvcGVydHkgYW5kIHRoZW4gdHJ5IHRvIHVzZSB0aGUgZnVuY3Rpb24uIFRoZSBmdW5jdGlv biBzaG91bGQgc3RpbGwgYmUgYWJsZSB0byBhY2Nlc3MgcGFyZW50IGZyYW1lIHByb3BlcnRpZXMu ICAKK1RoZSBjaGlsZCBmcmFtZSB3aWxsIGdldCBhIGZ1bmN0aW9uIGZyb20gdGhlIHBhcmVudCBm cmFtZSwgc2V0IHRoZSBkb2N1bWVudC5kb21haW4gcHJvcGVydHkgYW5kIHRoZW4gdHJ5IHRvIHVz ZSB0aGUgZnVuY3Rpb24uIFRoZSBmdW5jdGlvbiBzaG91bGQgc3RpbGwgYmUgYWJsZSB0byBhY2Nl c3MgcGFyZW50IGZyYW1lIHByb3BlcnRpZXMuIAogCiBQQVNTOiBjYW5HZXQoJ3dpbmRvdy5sb2Nh dGlvbi5ocmVmJykgc2hvdWxkIGJlICd0cnVlJyBhbmQgaXMuCiBQQVNTOiB3aW5kb3cudGhpc0lz VG9wRnJhbWUgc2hvdWxkIGJlICd0cnVlJyBhbmQgaXMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGY3ZWIxM2Y5ZTM3ZjljNDNmNjBiODc2MzI5NGE1ZGUy YTc2OTY5NmUuLjFmOTdiYWJhMDhjZDYwYTVlNjlkYzUwMzEzNWM5M2UzMzkyOTM4YjQgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMjcwLDggKzEyNzAs NiBAQCB3ZWJraXQub3JnL2IvMTM5OTY4IGZhc3QvcmVnaW9ucy9jc3NvbS9nZXQtcmVnaW9ucy1i eS1jb250ZW50LWhvcml6LWJ0Lmh0bWwgWyBGYQogd2Via2l0Lm9yZy9iLzEzOTk2OCBmYXN0L3Jl Z2lvbnMvY3Nzb20vZ2V0LXJlZ2lvbnMtYnktY29udGVudC1ob3Jpei10Yi5odG1sIFsgRmFpbHVy ZSBdCiB3ZWJraXQub3JnL2IvMTM5OTY4IGZhc3QvdGV4dC9kZWNvbXBvc2VkLWFmdGVyLXN0YWNr ZWQtZGlhY3JpdGljcy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTM5OTY4IGZhc3Qv dGV4dC9nbHlwaC1yZW9yZGVyaW5nLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xMzk5 NjggaHR0cC90ZXN0cy9zZWN1cml0eS9YRnJhbWVPcHRpb25zL3gtZnJhbWUtb3B0aW9ucy1kZW55 LW11bHRpcGxlLWNsaWVudHMuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzEzOTk2OCBo dHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1jYWxsYmFjay1leHBsaWNpdC1k b21haW4tQUxMT1cuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEzOTk2OCBhY2Nlc3Np YmlsaXR5L3RhYmxlLWNlbGxzLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMzk5Njgg ZmFzdC9mb3Jtcy9jdXJzb3ItYXQtZWRpdGFibGUtY29udGVudC1ib3VuZGFyeS5odG1sIFsgRmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvMTM5OTY4IGZhc3QvZm9ybXMvdGV4dC1jb250cm9sLWludHJp bnNpYy13aWR0aHMuaHRtbCBbIEZhaWx1cmUgXQo=