141672 2015-02-16 15:42:26 -0800 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack 2015-02-25 16:30:28 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dburkart mark.lam ap commit-queue dburkart ddkilzer ggaren webkit-bug-importer oldest_to_newest 1069631 0 dburkart 2015-02-16 15:42:26 -0800 From Geoff: Since JSC::MachineThreads::tryCopyOtherThreadStack reads another thread's stack. We should use one of the ASan annotations to make ASan ignore this function or treat it in a more lax way. 1069632 1 dburkart 2015-02-16 15:42:39 -0800 <rdar://problem/19828843> 1069634 2 webkit-bug-importer 2015-02-16 15:43:09 -0800 <rdar://problem/19853304> 1069635 3 dburkart 2015-02-16 15:46:34 -0800 <rdar://problem/19828843> 1069672 4 246705 dburkart 2015-02-16 16:59:09 -0800 Created attachment 246705 Ignore JSC::MachineThreads::tryCopyOtherThreadStack 1069849 5 246705 ddkilzer 2015-02-17 09:23:03 -0800 Comment on attachment 246705 Ignore JSC::MachineThreads::tryCopyOtherThreadStack r=me 1069873 6 246705 commit-queue 2015-02-17 10:06:36 -0800 Comment on attachment 246705 Ignore JSC::MachineThreads::tryCopyOtherThreadStack Clearing flags on attachment: 246705 Committed r180227: <http://trac.webkit.org/changeset/180227> 1069874 7 commit-queue 2015-02-17 10:06:40 -0800 All reviewed patches have been landed. Closing bug. 1070197 8 ap 2015-02-18 12:40:20 -0800 This fixes run-webkit-tests --threaded 1071966 9 ap 2015-02-24 22:01:47 -0800 Geoff, did this actually fix the issue? Looking at bug 141990 comment 10, ASan can still crash under this function, because the violation happens in memcpy, not in this function. 1072188 10 ap 2015-02-25 16:27:01 -0800 Mark Lam replaced this fix with a different one in <https://trac.webkit.org/r180649>. We now hit this code path on worker tests too, and this fix was ineffective. 1072189 11 247361 mark.lam 2015-02-25 16:28:50 -0800 Created attachment 247361 Patch with updated fix This patch was reviewed and r+'ed offline by Alexey. 1072190 12 mark.lam 2015-02-25 16:30:28 -0800 The fix is landed in r180649: <http://trac.webkit.org/r180649>. 246705 2015-02-16 16:59:09 -0800 2015-02-25 16:28:50 -0800 Ignore JSC::MachineThreads::tryCopyOtherThreadStack bug_141672.patch text/plain 1073 dburkart SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MDE4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE1LTAyLTE2ICBEYW5hIEJ1cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+ CisKKyAgICAgICAgQVNhbiBkb2VzIG5vdCBsaWtlIEpTQzo6TWFjaGluZVRocmVhZHM6OnRyeUNv cHlPdGhlclRocmVhZFN0YWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDE2NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGFzYW4vd2Via2l0LWFzYW4taWdub3JlLnR4dDoKKwogMjAxNS0wMi0xNiAg VGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhl IE1pbmlCcm93c2VyIGJ1aWxkIHdpdGggbmV3ZXIgY2xhbmcKSW5kZXg6IFRvb2xzL2FzYW4vd2Vi a2l0LWFzYW4taWdub3JlLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9hc2FuL3dlYmtpdC1hc2Fu LWlnbm9yZS50eHQJKHJldmlzaW9uIDE4MDE4OSkKKysrIFRvb2xzL2FzYW4vd2Via2l0LWFzYW4t aWdub3JlLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNCwzICs0LDQgQEAgZnVuOipERkcqcHJlcGFy ZU9TUkVudHJ5KgogIyBGSVhNRSAocmRhcjovL3Byb2JsZW0vMTkzNzkyMTQpOiBSZWdpc3Rlcjo6 anNWYWx1ZSgpIG9ubHkgbmVlZHMgdG8gYmUgYmxhY2tsaXN0ZWQgd2hlbgogIyBjYWxsZWQgZnJv bSBwcmVwYXJlT1NSRW50cnkoKSwgYnV0IHRoZXJlIGlzIGN1cnJlbnRseSBubyB3YXkgdG8gZXhw cmVzcyB0aGlzIGluIGEgYmxhY2tsaXN0LgogZnVuOipKU0MqUmVnaXN0ZXIqanNWYWx1ZSoKK2Z1 bjoqSlNDKk1hY2hpbmVUaHJlYWRzKnRyeUNvcHlPdGhlclRocmVhZFN0YWNrKgo= 247361 2015-02-25 16:28:50 -0800 2015-02-25 16:28:50 -0800 Patch with updated fix bug-141672.patch text/plain 3647 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwNjQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwNjQ5KQpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTAyLTI1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAg ICBBU2FuIGRvZXMgbm90IGxpa2UgSlNDOjpNYWNoaW5lVGhyZWFkczo6dHJ5Q29weU90aGVyVGhy ZWFkU3RhY2suCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDE2NzI+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICBBU2FuIGRvZXMg bm90IGxpa2UgdGhlIGZhY3QgdGhhdCB3ZSBtZW1jcHkgdGhlIHN0YWNrIGZvciBHQyBzY2Fucy4g IFNvLAorICAgICAgICB3ZSdyZSB3b3JraW5nIGFyb3VuZCB0aGlzIGJ5IHVzaW5nIG91ciBvd24g bWVtY3B5IChhc2FuVW5zYWZlTWVtY3B5KQorICAgICAgICBpbXBsZW1lbnRhdGlvbiB0aGF0IHdl IGNhbiB0ZWxsIEFTYW4gdG8gaWdub3JlLgorCisgICAgICAgICogaGVhcC9NYWNoaW5lU3RhY2tN YXJrZXIuY3BwOgorICAgICAgICAoSlNDOjphc2FuVW5zYWZlTWVtY3B5KToKKwogMjAxNS0wMi0y NSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBDb2Rl QmxvY2sgY3Jhc2hlcyB3aGVuIGR1bXBpbmcgb3BfcHVzaF9uYW1lX3Njb3BlCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYWNoaW5lU3RhY2tNYXJrZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hY2hpbmVTdGFja01hcmtlci5jcHAJKHJl dmlzaW9uIDE4MDY0OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hY2hpbmVTdGFj a01hcmtlci5jcHAJKHJldmlzaW9uIDE4MDY0OSkKQEAgLTQxMCw2ICs0MTAsMjYgQEAKICAgICBy ZXR1cm4gc3RkOjptYWtlX3BhaXIoYmVnaW4sIHN0YXRpY19jYXN0PGNoYXIqPihlbmQpIC0gc3Rh dGljX2Nhc3Q8Y2hhcio+KGJlZ2luKSk7CiB9CiAKKyNpZiBBU0FOX0VOQUJMRUQKK3ZvaWQgYXNh blVuc2FmZU1lbWNweSh2b2lkKiBkc3QsIGNvbnN0IHZvaWQqIHNyYywgc2l6ZV90KTsKK3ZvaWQg YXNhblVuc2FmZU1lbWNweSh2b2lkKiBkc3QsIGNvbnN0IHZvaWQqIHNyYywgc2l6ZV90IHNpemUp Cit7CisgICAgc2l6ZV90IGRzdEFzU2l6ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8c2l6ZV90Pihkc3Qp OworICAgIHNpemVfdCBzcmNBc1NpemUgPSByZWludGVycHJldF9jYXN0PHNpemVfdD4oc3JjKTsK KyAgICBSRUxFQVNFX0FTU0VSVChkc3RBc1NpemUgPT0gV1RGOjpyb3VuZFVwVG9NdWx0aXBsZU9m PHNpemVvZihpbnRwdHJfdCk+KGRzdEFzU2l6ZSkpOworICAgIFJFTEVBU0VfQVNTRVJUKHNyY0Fz U2l6ZSA9PSBXVEY6OnJvdW5kVXBUb011bHRpcGxlT2Y8c2l6ZW9mKGludHB0cl90KT4oc3JjQXNT aXplKSk7CisgICAgUkVMRUFTRV9BU1NFUlQoc2l6ZSA9PSBXVEY6OnJvdW5kVXBUb011bHRpcGxl T2Y8c2l6ZW9mKGludHB0cl90KT4oc2l6ZSkpOworCisgICAgaW50cHRyX3QqIGRzdFB0ciA9IHJl aW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3QqPihkc3QpOworICAgIGNvbnN0IGludHB0cl90KiBzcmNQ dHIgPSByZWludGVycHJldF9jYXN0PGNvbnN0IGludHB0cl90Kj4oc3JjKTsKKyAgICBzaXplIC89 IHNpemVvZihpbnRwdHJfdCk7CisgICAgd2hpbGUgKHNpemUtLSkKKyAgICAgICAgKmRzdFB0cisr ID0gKnNyY1B0cisrOworfQorICAgIAorI2RlZmluZSBtZW1jcHkgYXNhblVuc2FmZU1lbWNweQor I2VuZGlmCisKIC8vIFRoaXMgZnVuY3Rpb24gbXVzdCBub3QgY2FsbCBtYWxsb2MoKSwgZnJlZSgp LCBvciBhbnkgb3RoZXIgZnVuY3Rpb24gdGhhdCBtaWdodAogLy8gYWNxdWlyZSBhIGxvY2suIFNp bmNlICd0aHJlYWQnIGlzIHN1c3BlbmRlZCwgdHJ5aW5nIHRvIGFjcXVpcmUgYSBsb2NrCiAvLyB3 aWxsIGRlYWRsb2NrIGlmICd0aHJlYWQnIGhvbGRzIHRoYXQgbG9jay4KSW5kZXg6IFRvb2xzL2Fz YW4vd2Via2l0LWFzYW4taWdub3JlLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9hc2FuL3dlYmtp dC1hc2FuLWlnbm9yZS50eHQJKHJldmlzaW9uIDE4MDY0OCkKKysrIFRvb2xzL2FzYW4vd2Via2l0 LWFzYW4taWdub3JlLnR4dAkocmV2aXNpb24gMTgwNjQ5KQpAQCAtNCw0ICs0LDQgQEAKICMgRklY TUUgKHJkYXI6Ly9wcm9ibGVtLzE5Mzc5MjE0KTogUmVnaXN0ZXI6OmpzVmFsdWUoKSBvbmx5IG5l ZWRzIHRvIGJlIGJsYWNrbGlzdGVkIHdoZW4KICMgY2FsbGVkIGZyb20gcHJlcGFyZU9TUkVudHJ5 KCksIGJ1dCB0aGVyZSBpcyBjdXJyZW50bHkgbm8gd2F5IHRvIGV4cHJlc3MgdGhpcyBpbiBhIGJs YWNrbGlzdC4KIGZ1bjoqSlNDKlJlZ2lzdGVyKmpzVmFsdWUqCi1mdW46KkpTQypNYWNoaW5lVGhy ZWFkcyp0cnlDb3B5T3RoZXJUaHJlYWRTdGFjayoKK2Z1bjoqYXNhblVuc2FmZU1lbWNweSoKSW5k ZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlz aW9uIDE4MDY0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwNjQ5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTAyLTI1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBBU2FuIGRvZXMgbm90IGxpa2UgSlNDOjpNYWNoaW5lVGhyZWFkczo6dHJ5Q29weU90 aGVyVGhyZWFkU3RhY2suCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDE2NzI+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICBBU2Fu IGRvZXMgbm90IGxpa2UgdGhlIGZhY3QgdGhhdCB3ZSBtZW1jcHkgdGhlIHN0YWNrIGZvciBHQyBz Y2Fucy4gIFNvLAorICAgICAgICB3ZSdyZSB3b3JraW5nIGFyb3VuZCB0aGlzIGJ5IHVzaW5nIG91 ciBvd24gbWVtY3B5IChhc2FuVW5zYWZlTWVtY3B5KQorICAgICAgICBpbXBsZW1lbnRhdGlvbiB0 aGF0IHdlIGNhbiB0ZWxsIEFTYW4gdG8gaWdub3JlLgorCisgICAgICAgIEFsc28gcmVtb3ZlZCB0 aGUgcHJldmlvdXMgYWRkZWQgZGlyZWN0aXZlIHRvIGlnbm9yZSAqdHJ5Q29weU90aGVyVGhyZWFk U3RhY2sqCisgICAgICAgIHdoaWNoIGlzbid0IGVmZmVjdGl2ZSBmb3Igd29ya2luZyBhcm91bmQg dGhpcyBpc3N1ZS4gCisKKyAgICAgICAgKiBhc2FuL3dlYmtpdC1hc2FuLWlnbm9yZS50eHQ6CisK IDIwMTUtMDItMjUgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgQ29kZUJsb2NrIGNyYXNoZXMgd2hlbiBkdW1waW5nIG9wX3B1c2hfbmFtZV9zY29wZQo=