141669 2015-02-16 15:20:23 -0800 REGRESSION (r176459): Process suspension cleanup timer sometimes never stops 2015-02-16 15:24:30 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton webkit-unassigned andersca commit-queue simon.fraser oldest_to_newest 1069620 0 246688 thorton 2015-02-16 15:20:23 -0800 Created attachment 246688 patch r176459 accidentally removed the code to stop the cleanup timer in the case where we successfully finish marking layers volatile, causing the timer to continue running once the process comes back from a suspended state. 1069621 1 246688 simon.fraser 2015-02-16 15:21:33 -0800 Comment on attachment 246688 patch Testable? 1069622 2 commit-queue 2015-02-16 15:22:14 -0800 Attachment 246688 did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1069623 3 thorton 2015-02-16 15:22:47 -0800 I don't think we have any infrastructure for testing process suspension (nor would I have any idea how to test that a timer that has negligible functional impact *isn't* firing). 1069625 4 thorton 2015-02-16 15:24:30 -0800 http://trac.webkit.org/changeset/180180 246688 2015-02-16 15:20:23 -0800 2015-02-16 15:21:33 -0800 patch timer.diff text/plain 1412 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiOGVlZThjLi5kYjJmOTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTUtMDItMTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjE3NjQ1OSk6IFByb2Nlc3Mgc3VzcGVuc2lvbiBjbGVhbnVw IHRpbWVyIHNvbWV0aW1lcyBuZXZlciBzdG9wcworICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChP T1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNz OjptYXJrQWxsTGF5ZXJzVm9sYXRpbGVJZlBvc3NpYmxlKToKKyAgICAgICAgcjE3NjQ1OSBhY2Np ZGVudGFsbHkgcmVtb3ZlZCB0aGUgY29kZSB0byBzdG9wIHRoZSBjbGVhbnVwIHRpbWVyCisgICAg ICAgIGluIHRoZSBjYXNlIHdoZXJlIHdlIHN1Y2Nlc3NmdWxseSBmaW5pc2ggbWFya2luZyBsYXll cnMgdm9sYXRpbGUsCisgICAgICAgIGNhdXNpbmcgdGhlIHRpbWVyIHRvIGNvbnRpbnVlIHJ1bm5p bmcgb25jZSB0aGUgcHJvY2VzcyBjb21lcyBiYWNrCisgICAgICAgIGZyb20gYSBzdXNwZW5kZWQg c3RhdGUuCisKIDIwMTUtMDItMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgbnVsbGFiaWxpdHkgcXVhbGlmaWVycyB0byBhbGwgQVBJIGhlYWRl cnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IGMzYzkxM2Yu LjhhNDQyM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vz cy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcApAQCAt MTE5Niw2ICsxMTk2LDcgQEAgYm9vbCBXZWJQcm9jZXNzOjptYXJrQWxsTGF5ZXJzVm9sYXRpbGVJ ZlBvc3NpYmxlKCkKIHZvaWQgV2ViUHJvY2Vzczo6cHJvY2Vzc1N1c3BlbnNpb25DbGVhbnVwVGlt ZXJGaXJlZCgpCiB7CiAgICAgaWYgKG1hcmtBbGxMYXllcnNWb2xhdGlsZUlmUG9zc2libGUoKSkg eworICAgICAgICBtX3Byb2Nlc3NTdXNwZW5zaW9uQ2xlYW51cFRpbWVyLnN0b3AoKTsKICAgICAg ICAgcGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViUHJvY2Vzc1By b3h5OjpQcm9jZXNzUmVhZHlUb1N1c3BlbmQoKSwgMCk7CiAgICAgfQogfQo=