141663 2015-02-16 13:44:42 -0800 GC (almost) immediately when navigating under memory pressure. 2015-02-16 17:06:59 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue ggaren kling oldest_to_newest 1069558 0 kling 2015-02-16 13:44:42 -0800 When we're navigating during system memory pressure conditions, we know that the page isn't going into PageCache, so is basically guaranteed to generate lots of garbage. We should do a full GC to make sure we soften the peak memory consumption during this stage. 1069602 1 246685 kling 2015-02-16 14:42:58 -0800 Created attachment 246685 Patch 1069660 2 246685 ggaren 2015-02-16 16:29:24 -0800 Comment on attachment 246685 Patch r=me(tm) 1069678 3 246685 commit-queue 2015-02-16 17:06:55 -0800 Comment on attachment 246685 Patch Clearing flags on attachment: 246685 Committed r180192: <http://trac.webkit.org/changeset/180192> 1069679 4 commit-queue 2015-02-16 17:06:59 -0800 All reviewed patches have been landed. Closing bug. 246685 2015-02-16 14:42:58 -0800 2015-02-16 17:06:55 -0800 Patch bug-141663.diff text/plain 5836 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZjYzMDQzLi42YjUxNjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzcg QEAKKzIwMTUtMDItMTYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEdDIChhbG1vc3QpIGltbWVkaWF0ZWx5IHdoZW4gbmF2aWdhdGluZyB1bmRlciBtZW1vcnkg cHJlc3N1cmUuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDE2NjM+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgdGhlIFBhZ2VD YWNoZSBpcyBhbHJlYWR5IGRpc2FibGVkIGluIG1lbW9yeSBwcmVzc3VyZSBzaXR1YXRpb25zLAor ICAgICAgICB3ZSBrbm93IHRoYXQgZGV0YWNoaW5nIHRoZSBvbGQgd2luZG93IHNoZWxsIG9uIG5h dmlnYXRpb24gaXMgYmFzaWNhbGx5CisgICAgICAgIGd1YXJhbnRlZWQgdG8gZ2VuZXJhdGUgYSBi dW5jaCBvZiBnYXJiYWdlLCB3ZSBjYW4gc29mdGVuIHRoZSBtZW1vcnkKKyAgICAgICAgcGVhayBh IGJpdCBieSBkb2luZyBhIEdDIHJpZ2h0IGF3YXkgaW5zdGVhZCBvZiBzY2hlZHVsaW5nIG9uZSBm b3Igc29vbih0bSkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R0NDb250cm9sbGVyOjpHQ0NvbnRyb2xsZXIpOgorICAgICAgICAo V2ViQ29yZTo6R0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdFNvb24pOgorICAgICAgICAoV2Vi Q29yZTo6R0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdE9uTmV4dFJ1bkxvb3ApOgorICAgICAg ICAoV2ViQ29yZTo6R0NDb250cm9sbGVyOjpnY1RpbWVyRmlyZWQpOgorICAgICAgICAqIGJpbmRp bmdzL2pzL0dDQ29udHJvbGxlci5oOgorCisgICAgICAgICAgICBBZGQgYSBHQ0NvbnRyb2xsZXI6 OmdhcmJhZ2VDb2xsZWN0T25OZXh0UnVuTG9vcCgpIGNvbXBsZW1lbnQgdG8gdGhlCisgICAgICAg ICAgICAic29vbiIgYW5kICJub3ciIG9wdGlvbnMuIFRoZXJlIHdhcyBhbHJlYWR5IGEgemVybyB0 aW1lciBpbiBoZXJlIGZvcgorICAgICAgICAgICAgbm9uLUNGIGJ1aWxkcywgc28gSSBqdXN0IHVz ZWQgdGhhdCBzYW1lIHRpbWVyIHRvIGltcGxlbWVudCB0aGlzCisgICAgICAgICAgICBhbmQgaGF2 ZSB0aGUgbm9uLUNGIGNvZGUgcGF0aCBjYWxsIGdhcmJhZ2VDb2xsZWN0T25OZXh0UnVuTG9vcCgp LgorCisgICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjb2xsZWN0R2FyYmFnZUFmdGVyV2luZG93U2hlbGxEZXN0cnVjdGlvbik6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250cm9sbGVyOjp+U2NyaXB0Q29udHJvbGxlcik6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250cm9sbGVyOjpjbGVhcldpbmRvd1NoZWxsKToKKwor ICAgICAgICAgICAgVW5kZXIgc3lzdGVtIG1lbW9yeSBwcmVzc3VyZSBjb25kaXRpb25zLCBzY2hl ZHVsZSBhIGZ1bGwgR0Mgb24gbmV4dAorICAgICAgICAgICAgcnVubG9vcCBpdGVyYXRpb24gaW5z dGVhZCBvZiBqdXN0IGFza2luZyBmb3IgaXQgdG8gaGFwcGVuIHNvb24uCisgICAgICAgICAgICBX ZSBkbyBpdCBvbiBuZXh0IHJ1bmxvb3AgdG8gZW5zdXJlIHRoYXQgdGhlcmUncyBubyBwb2ludGVy IHRvIHRoZQorICAgICAgICAgICAgd2luZG93IG9iamVjdCBvbiB0aGUgc3RhY2suCisKIDIwMTUt MDItMTMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5kZXJM aXN0SXRlbSByZXNldHMgaXRzIG1hcmtlcidzIHN0eWxlIG9uIHN0eWxlIGNoYW5nZSBldmVuIGlm IHRoZSBkaWZmIGlzIFN0eWxlRGlmZmVyZW5jZUVxdWFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvR0NDb250cm9sbGVyLmNwcAppbmRleCA3ZWY2ODc0Li45NTUyOTRmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAKQEAgLTUwLDkgKzUwLDcgQEAg R0NDb250cm9sbGVyJiBnY0NvbnRyb2xsZXIoKQogfQogCiBHQ0NvbnRyb2xsZXI6OkdDQ29udHJv bGxlcigpCi0jaWYgIVVTRShDRikKICAgICA6IG1fR0NUaW1lcigqdGhpcywgJkdDQ29udHJvbGxl cjo6Z2NUaW1lckZpcmVkKQotI2VuZGlmCiB7CiB9CiAKQEAgLTY3LDE3ICs2NSwyMCBAQCB2b2lk IEdDQ29udHJvbGxlcjo6Z2FyYmFnZUNvbGxlY3RTb29uKCkKICAgICBKU0xvY2tIb2xkZXIgbG9j ayhKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKSk7CiAgICAgSlNET01XaW5kb3c6OmNvbW1vblZNKCku aGVhcC5yZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaCgpOwogI2Vsc2UKKyAgICBnYXJiYWdlQ29s bGVjdE9uTmV4dFJ1bkxvb3AoKTsKKyNlbmRpZgorfQorCit2b2lkIEdDQ29udHJvbGxlcjo6Z2Fy YmFnZUNvbGxlY3RPbk5leHRSdW5Mb29wKCkKK3sKICAgICBpZiAoIW1fR0NUaW1lci5pc0FjdGl2 ZSgpKQogICAgICAgICBtX0dDVGltZXIuc3RhcnRPbmVTaG90KDApOwotI2VuZGlmCiB9CiAKLSNp ZiAhVVNFKENGKQogdm9pZCBHQ0NvbnRyb2xsZXI6OmdjVGltZXJGaXJlZCgpCiB7CiAgICAgY29s bGVjdChudWxscHRyKTsKIH0KLSNlbmRpZgogCiB2b2lkIEdDQ29udHJvbGxlcjo6Z2FyYmFnZUNv bGxlY3ROb3coKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0ND b250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuaApp bmRleCBlZWJlMTA3Li4zMTM2NmMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9HQ0NvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0Nv bnRyb2xsZXIuaApAQCAtMjYsMTIgKzI2LDkgQEAKICNpZm5kZWYgR0NDb250cm9sbGVyX2gKICNk ZWZpbmUgR0NDb250cm9sbGVyX2gKIAotI2lmIFVTRShDRikKICNpbmNsdWRlIDx3dGYvRmFzdE1h bGxvYy5oPgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgotI2Vsc2UKICNpbmNsdWRlICJU aW1lci5oIgotI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNDIsNiArMzksNyBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgcHVibGljOgogICAgICAgICBXRUJDT1JFX0VYUE9S VCB2b2lkIGdhcmJhZ2VDb2xsZWN0U29vbigpOwogICAgICAgICBXRUJDT1JFX0VYUE9SVCB2b2lk IGdhcmJhZ2VDb2xsZWN0Tm93KCk7IC8vIEl0J3MgYmV0dGVyIHRvIGNhbGwgZ2FyYmFnZUNvbGxl Y3RTb29uLCB1bmxlc3MgeW91IGhhdmUgYSBzcGVjaWZpYyByZWFzb24gbm90IHRvLgorICAgICAg ICB2b2lkIGdhcmJhZ2VDb2xsZWN0T25OZXh0UnVuTG9vcCgpOwogCiAgICAgICAgIFdFQkNPUkVf RVhQT1JUIHZvaWQgZ2FyYmFnZUNvbGxlY3RPbkFsdGVybmF0ZVRocmVhZEZvckRlYnVnZ2luZyhi b29sIHdhaXRVbnRpbERvbmUpOyAvLyBVc2VkIGZvciBzdHJlc3MgdGVzdGluZy4KICAgICAgICAg V0VCQ09SRV9FWFBPUlQgdm9pZCByZWxlYXNlRXhlY3V0YWJsZU1lbW9yeSgpOwpAQCAtNTEsMTAg KzQ5LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHByaXZhdGU6CiAgICAgICAgIEdDQ29u dHJvbGxlcigpOyAvLyBVc2UgZ2NDb250cm9sbGVyKCkgaW5zdGVhZAogCi0jaWYgIVVTRShDRikK ICAgICAgICAgdm9pZCBnY1RpbWVyRmlyZWQoKTsKICAgICAgICAgVGltZXIgbV9HQ1RpbWVyOwot I2VuZGlmCiAgICAgfTsKIAogICAgIC8vIEZ1bmN0aW9uIHRvIG9idGFpbiB0aGUgZ2xvYmFsIEdD IGNvbnRyb2xsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3Jp cHRDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRy b2xsZXIuY3BwCmluZGV4IGViYjVjN2UuLjU5YjI5MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCkBAIC0zNSw2ICszNSw3IEBACiAjaW5j bHVkZSAiSlNEb2N1bWVudC5oIgogI2luY2x1ZGUgIkpTTWFpblRocmVhZEV4ZWNTdGF0ZS5oIgog I2luY2x1ZGUgIk1haW5GcmFtZS5oIgorI2luY2x1ZGUgIk1lbW9yeVByZXNzdXJlSGFuZGxlci5o IgogI2luY2x1ZGUgIk5QX2pzb2JqZWN0LmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUg IlBhZ2VDb25zb2xlQ2xpZW50LmgiCkBAIC02MCw2ICs2MSwxOCBAQCB1c2luZyBuYW1lc3BhY2Ug SlNDOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK3N0YXRpYyB2b2lkIGNvbGxlY3RHYXJiYWdl QWZ0ZXJXaW5kb3dTaGVsbERlc3RydWN0aW9uKCkKK3sKKyAgICAvLyBNYWtlIHN1cmUgdG8gR0Mg RXh0cmEgU29vbih0bSkgZHVyaW5nIG1lbW9yeSBwcmVzc3VyZSBjb25kaXRpb25zCisgICAgLy8g dG8gc29mdGVuIGhpZ2ggcGVha3Mgb2YgbWVtb3J5IHVzYWdlIGR1cmluZyBuYXZpZ2F0aW9uLgor ICAgIGlmIChtZW1vcnlQcmVzc3VyZUhhbmRsZXIoKS5pc1VuZGVyTWVtb3J5UHJlc3N1cmUoKSkg eworICAgICAgICAvLyBOT1RFOiBXZSBkbyB0aGUgY29sbGVjdGlvbiBvbiBuZXh0IHJ1bmxvb3Ag dG8gZW5zdXJlIHRoYXQgdGhlcmUncyBubyBwb2ludGVyCisgICAgICAgIC8vICAgICAgIHRvIHRo ZSB3aW5kb3cgb2JqZWN0IG9uIHRoZSBzdGFjay4KKyAgICAgICAgZ2NDb250cm9sbGVyKCkuZ2Fy YmFnZUNvbGxlY3RPbk5leHRSdW5Mb29wKCk7CisgICAgfSBlbHNlCisgICAgICAgIGdjQ29udHJv bGxlcigpLmdhcmJhZ2VDb2xsZWN0U29vbigpOworfQorCiB2b2lkIFNjcmlwdENvbnRyb2xsZXI6 OmluaXRpYWxpemVUaHJlYWRpbmcoKQogewogI2lmICFQTEFURk9STShJT1MpCkBAIC05OCw3ICsx MTEsNyBAQCBTY3JpcHRDb250cm9sbGVyOjp+U2NyaXB0Q29udHJvbGxlcigpCiAgICAgICAgICAg ICBpdGVyLT52YWx1ZS0+d2luZG93KCktPnNldENvbnNvbGVDbGllbnQobnVsbHB0cik7CiAgICAg ICAgICAgICBkZXN0cm95V2luZG93U2hlbGwoKml0ZXItPmtleSk7CiAgICAgICAgIH0KLSAgICAg ICAgZ2NDb250cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3RTb29uKCk7CisgICAgICAgIGNvbGxlY3RH YXJiYWdlQWZ0ZXJXaW5kb3dTaGVsbERlc3RydWN0aW9uKCk7CiAgICAgfQogfQogCkBAIC0yMjcs NyArMjQwLDcgQEAgdm9pZCBTY3JpcHRDb250cm9sbGVyOjpjbGVhcldpbmRvd1NoZWxsKERPTVdp bmRvdyogbmV3RE9NV2luZG93LCBib29sIGdvaW5nSW50b1AKICAgICAvLyBJdCdzIGxpa2VseSB0 aGF0IHJlc2V0dGluZyBvdXIgd2luZG93cyBjcmVhdGVkIGEgbG90IG9mIGdhcmJhZ2UsIHVubGVz cwogICAgIC8vIGl0IHdlbnQgaW4gYSBiYWNrL2ZvcndhcmQgY2FjaGUuCiAgICAgaWYgKCFnb2lu Z0ludG9QYWdlQ2FjaGUpCi0gICAgICAgIGdjQ29udHJvbGxlcigpLmdhcmJhZ2VDb2xsZWN0U29v bigpOworICAgICAgICBjb2xsZWN0R2FyYmFnZUFmdGVyV2luZG93U2hlbGxEZXN0cnVjdGlvbigp OwogfQogCiBKU0RPTVdpbmRvd1NoZWxsKiBTY3JpcHRDb250cm9sbGVyOjppbml0U2NyaXB0KERP TVdyYXBwZXJXb3JsZCYgd29ybGQpCg==